vscode-json-languageservice 5.3.7 → 5.3.10

package/lib/esm/parser/jsonParser.js

@@ -455,10 +455,11 @@ function validate(n, schema, validationResult, matchingSchemas, context) {
             validationResult.enumValues = [schema.const];
         }
         let deprecationMessage = schema.deprecationMessage;
-        if ((deprecationMessage || schema.deprecated) && node.parent) {
+        if (deprecationMessage || schema.deprecated) {
             deprecationMessage = deprecationMessage || l10n.t('Value is deprecated');
+            let targetNode = node.parent?.type === 'property' ? node.parent : node;
             validationResult.problems.push({
-                location: { offset: node.parent.offset, length: node.parent.length },
+                location: { offset: targetNode.offset, length: targetNode.length },
                 severity: DiagnosticSeverity.Warning,
                 message: deprecationMessage,
                 code: ErrorCode.Deprecated
@@ -727,10 +728,18 @@ function validate(n, schema, validationResult, matchingSchemas, context) {
         }
         if (schema.uniqueItems === true) {
             const values = getNodeValue(node);
-            const duplicates = values.some((value, index) => {
-                return index !== values.lastIndexOf(value);
-            });
-            if (duplicates) {
+            function hasDuplicates() {
+                for (let i = 0; i < values.length - 1; i++) {
+                    const value = values[i];
+                    for (let j = i + 1; j < values.length; j++) {
+                        if (equals(value, values[j])) {
+                            return true;
+                        }
+                    }
+                }
+                return false;
+            }
+            if (hasDuplicates()) {
                 validationResult.problems.push({
                     location: { offset: node.offset, length: node.length },
                     message: l10n.t('Array has duplicate items.')

package/lib/esm/services/jsonSchemaService.js

@@ -263,6 +263,9 @@ export class JSONSchemaService {
             const errorMessage = l10n.t('Unable to load schema from \'{0}\'. No schema request service available', toDisplayString(url));
             return this.promise.resolve(new UnresolvedSchema({}, [errorMessage]));
         }
+        if (url.startsWith('http://json-schema.org/')) {
+            url = 'https' + url.substring(4); // always access json-schema.org with https. See https://github.com/microsoft/vscode/issues/195189
+        }
         return this.requestService(url).then(content => {
             if (!content) {
                 const errorMessage = l10n.t('Unable to load schema from \'{0}\': No content.', toDisplayString(url));

package/lib/esm/utils/sort.js

@@ -190,15 +190,17 @@ function findJsoncPropertyTree(formattedDocument) {
             case 2 /* SyntaxKind.CloseBraceToken */: {
                 endLineNumber = scanner.getTokenStartLine();
                 currentContainerStack.pop();
-                // If we are not inside of an empty object and current property end line number has not yet been defined, define it
-                if (lastNonTriviaNonCommentToken !== 1 /* SyntaxKind.OpenBraceToken */
-                    && currentProperty.endLineNumber === undefined) {
-                    currentProperty.endLineNumber = endLineNumber - 1;
-                    // The current property is also the last property
-                    currentProperty.lastProperty = true;
-                    // The last property of an object is associated with the line and index of where to add the comma, in case after sorting, it is no longer the last property
-                    currentProperty.lineWhereToAddComma = lineOfLastNonTriviaNonCommentToken;
-                    currentProperty.indexWhereToAddComa = endIndexOfLastNonTriviaNonCommentToken;
+                // If we are not inside of an empty object
+                if (lastNonTriviaNonCommentToken !== 1 /* SyntaxKind.OpenBraceToken */) {
+                    // If current property end line number has not yet been defined, define it
+                    if (currentProperty.endLineNumber === undefined) {
+                        currentProperty.endLineNumber = endLineNumber - 1;
+                        // The current property is also the last property
+                        currentProperty.lastProperty = true;
+                        // The last property of an object is associated with the line and index of where to add the comma, in case after sorting, it is no longer the last property
+                        currentProperty.lineWhereToAddComma = lineOfLastNonTriviaNonCommentToken;
+                        currentProperty.indexWhereToAddComa = endIndexOfLastNonTriviaNonCommentToken;
+                    }
                     lastProperty = currentProperty;
                     currentProperty = currentProperty ? currentProperty.parent : undefined;
                     currentTree = currentProperty;

package/lib/umd/parser/jsonParser.js

@@ -482,10 +482,11 @@
                 validationResult.enumValues = [schema.const];
             }
             let deprecationMessage = schema.deprecationMessage;
-            if ((deprecationMessage || schema.deprecated) && node.parent) {
+            if (deprecationMessage || schema.deprecated) {
                 deprecationMessage = deprecationMessage || l10n.t('Value is deprecated');
+                let targetNode = node.parent?.type === 'property' ? node.parent : node;
                 validationResult.problems.push({
-                    location: { offset: node.parent.offset, length: node.parent.length },
+                    location: { offset: targetNode.offset, length: targetNode.length },
                     severity: jsonLanguageTypes_1.DiagnosticSeverity.Warning,
                     message: deprecationMessage,
                     code: jsonLanguageTypes_1.ErrorCode.Deprecated
@@ -754,10 +755,18 @@
             }
             if (schema.uniqueItems === true) {
                 const values = getNodeValue(node);
-                const duplicates = values.some((value, index) => {
-                    return index !== values.lastIndexOf(value);
-                });
-                if (duplicates) {
+                function hasDuplicates() {
+                    for (let i = 0; i < values.length - 1; i++) {
+                        const value = values[i];
+                        for (let j = i + 1; j < values.length; j++) {
+                            if ((0, objects_1.equals)(value, values[j])) {
+                                return true;
+                            }
+                        }
+                    }
+                    return false;
+                }
+                if (hasDuplicates()) {
                     validationResult.problems.push({
                         location: { offset: node.offset, length: node.length },
                         message: l10n.t('Array has duplicate items.')

package/lib/umd/services/jsonSchemaService.js

@@ -277,6 +277,9 @@
                 const errorMessage = l10n.t('Unable to load schema from \'{0}\'. No schema request service available', toDisplayString(url));
                 return this.promise.resolve(new UnresolvedSchema({}, [errorMessage]));
             }
+            if (url.startsWith('http://json-schema.org/')) {
+                url = 'https' + url.substring(4); // always access json-schema.org with https. See https://github.com/microsoft/vscode/issues/195189
+            }
             return this.requestService(url).then(content => {
                 if (!content) {
                     const errorMessage = l10n.t('Unable to load schema from \'{0}\': No content.', toDisplayString(url));

package/lib/umd/utils/sort.js

@@ -203,15 +203,17 @@
                 case 2 /* SyntaxKind.CloseBraceToken */: {
                     endLineNumber = scanner.getTokenStartLine();
                     currentContainerStack.pop();
-                    // If we are not inside of an empty object and current property end line number has not yet been defined, define it
-                    if (lastNonTriviaNonCommentToken !== 1 /* SyntaxKind.OpenBraceToken */
-                        && currentProperty.endLineNumber === undefined) {
-                        currentProperty.endLineNumber = endLineNumber - 1;
-                        // The current property is also the last property
-                        currentProperty.lastProperty = true;
-                        // The last property of an object is associated with the line and index of where to add the comma, in case after sorting, it is no longer the last property
-                        currentProperty.lineWhereToAddComma = lineOfLastNonTriviaNonCommentToken;
-                        currentProperty.indexWhereToAddComa = endIndexOfLastNonTriviaNonCommentToken;
+                    // If we are not inside of an empty object
+                    if (lastNonTriviaNonCommentToken !== 1 /* SyntaxKind.OpenBraceToken */) {
+                        // If current property end line number has not yet been defined, define it
+                        if (currentProperty.endLineNumber === undefined) {
+                            currentProperty.endLineNumber = endLineNumber - 1;
+                            // The current property is also the last property
+                            currentProperty.lastProperty = true;
+                            // The last property of an object is associated with the line and index of where to add the comma, in case after sorting, it is no longer the last property
+                            currentProperty.lineWhereToAddComma = lineOfLastNonTriviaNonCommentToken;
+                            currentProperty.indexWhereToAddComa = endIndexOfLastNonTriviaNonCommentToken;
+                        }
                         lastProperty = currentProperty;
                         currentProperty = currentProperty ? currentProperty.parent : undefined;
                         currentTree = currentProperty;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vscode-json-languageservice",
-  "version": "5.3.7",
+  "version": "5.3.10",
   "description": "Language service for JSON",
   "main": "./lib/umd/jsonLanguageService.js",
   "typings": "./lib/umd/jsonLanguageService",
@@ -15,22 +15,22 @@
     "url": "https://github.com/Microsoft/vscode-json-languageservice"
   },
   "devDependencies": {
-    "@types/mocha": "^10.0.2",
+    "@types/mocha": "^10.0.6",
     "@types/node": "16.x",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
-    "eslint": "^8.51.0",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
+    "eslint": "^8.57.0",
     "json-schema-test-suite": "https://github.com/json-schema-org/JSON-Schema-Test-Suite.git#69acf52990b004240839ae19b4bec8fb01d50876",
-    "mocha": "^10.2.0",
+    "mocha": "^10.3.0",
     "rimraf": "^5.0.5",
-    "typescript": "^5.2.2"
+    "typescript": "^5.3.3"
   },
   "dependencies": {
-    "jsonc-parser": "^3.2.0",
+    "jsonc-parser": "^3.2.1",
     "vscode-languageserver-textdocument": "^1.0.11",
     "vscode-languageserver-types": "^3.17.5",
     "vscode-uri": "^3.0.8",
-    "@vscode/l10n": "^0.0.16"
+    "@vscode/l10n": "^0.0.18"
   },
   "scripts": {
     "prepack": "npm run clean && npm run compile-esm && npm run test && npm run remove-sourcemap-refs",