vouchington-tooling 0.85.1 → 0.85.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (75) hide show
  1. package/dist/cli/commands/final-review.d.mts +8 -0
  2. package/dist/cli/commands/final-review.mjs +70 -0
  3. package/dist/cli/index.mjs +2 -0
  4. package/dist/cli/parse-forwarded-commands.d.mts +1 -1
  5. package/dist/cli/parse-forwarded-commands.mjs +1 -0
  6. package/dist/cli/parse.d.mts +3 -0
  7. package/dist/cli/usage-text-final-review.d.mts +2 -0
  8. package/dist/cli/usage-text-final-review.mjs +22 -0
  9. package/dist/cli/usage-text-policy.d.mts +2 -2
  10. package/dist/cli/usage-text-policy.mjs +3 -2
  11. package/dist/cli/usage-text.d.mts +1 -1
  12. package/dist/final-review/benchmark/cases.d.mts +23 -0
  13. package/dist/final-review/benchmark/cases.mjs +89 -0
  14. package/dist/final-review/benchmark/cli.d.mts +12 -0
  15. package/dist/final-review/benchmark/cli.mjs +144 -0
  16. package/dist/final-review/benchmark/judge-all.d.mts +32 -0
  17. package/dist/final-review/benchmark/judge-all.mjs +50 -0
  18. package/dist/final-review/benchmark/judge.d.mts +18 -0
  19. package/dist/final-review/benchmark/judge.mjs +86 -0
  20. package/dist/final-review/benchmark/runner.d.mts +60 -0
  21. package/dist/final-review/benchmark/runner.mjs +85 -0
  22. package/dist/final-review/benchmark/score.d.mts +33 -0
  23. package/dist/final-review/benchmark/score.mjs +84 -0
  24. package/dist/final-review/benchmark/snapshot.d.mts +20 -0
  25. package/dist/final-review/benchmark/snapshot.mjs +107 -0
  26. package/dist/final-review/benchmark/verifier-check.d.mts +21 -0
  27. package/dist/final-review/benchmark/verifier-check.mjs +93 -0
  28. package/dist/final-review/benchmark/verifier-cli.d.mts +6 -0
  29. package/dist/final-review/benchmark/verifier-cli.mjs +141 -0
  30. package/dist/final-review/benchmark/verifier-grade.d.mts +42 -0
  31. package/dist/final-review/benchmark/verifier-grade.mjs +76 -0
  32. package/dist/final-review/benchmark/verifier-input.d.mts +21 -0
  33. package/dist/final-review/benchmark/verifier-input.mjs +47 -0
  34. package/dist/final-review/benchmark/verifier-run.d.mts +23 -0
  35. package/dist/final-review/benchmark/verifier-run.mjs +108 -0
  36. package/dist/final-review/benchmark/verifier-score.d.mts +39 -0
  37. package/dist/final-review/benchmark/verifier-score.mjs +70 -0
  38. package/dist/final-review/build.d.mts +21 -0
  39. package/dist/final-review/build.mjs +91 -0
  40. package/dist/final-review/diff-files.d.mts +16 -0
  41. package/dist/final-review/diff-files.mjs +44 -0
  42. package/dist/final-review/finding.d.mts +32 -0
  43. package/dist/final-review/finding.mjs +101 -0
  44. package/dist/final-review/github.d.mts +21 -0
  45. package/dist/final-review/github.mjs +105 -0
  46. package/dist/final-review/index.d.mts +11 -0
  47. package/dist/final-review/index.mjs +6 -0
  48. package/dist/final-review/numbered-diff.d.mts +9 -0
  49. package/dist/final-review/numbered-diff.mjs +52 -0
  50. package/dist/final-review/post.d.mts +33 -0
  51. package/dist/final-review/post.mjs +63 -0
  52. package/dist/final-review/render.d.mts +17 -0
  53. package/dist/final-review/render.mjs +81 -0
  54. package/dist/gh-cli/exec.mjs +3 -1
  55. package/dist/gha-review-payload/index.d.mts +1 -1
  56. package/dist/gha-review-payload/index.mjs +1 -1
  57. package/dist/gha-review-payload/remap.d.mts +3 -1
  58. package/dist/gha-review-payload/remap.mjs +3 -2
  59. package/package.json +4 -4
  60. package/scripts/__pycache__/run_bounded_process.cpython-314.pyc +0 -0
  61. package/skills/bounded-iteration/SKILL.md +29 -14
  62. package/skills/final-review/SKILL.md +95 -0
  63. package/skills/final-review/references/dispatch.md +40 -0
  64. package/skills/final-review/references/orchestrator.md +39 -0
  65. package/skills/final-review/references/pillars/_contract.md +61 -0
  66. package/skills/final-review/references/pillars/blast-radius.md +33 -0
  67. package/skills/final-review/references/pillars/congruence.md +25 -0
  68. package/skills/final-review/references/pillars/correctness.md +52 -0
  69. package/skills/final-review/references/pillars/design.md +30 -0
  70. package/skills/final-review/references/pillars/history.md +26 -0
  71. package/skills/final-review/references/pillars/rules.md +34 -0
  72. package/skills/final-review/references/pillars/security.md +28 -0
  73. package/skills/final-review/references/verifier.md +62 -0
  74. package/skills/manifest.json +34 -28
  75. package/skills/postgres-node-performance-tuning/references/performance-patterns.md +5 -1
@@ -0,0 +1,26 @@
1
+ # Pillar: history
2
+
3
+ You are the history reviewer. Follow [the pillar contract](_contract.md). This pillar runs only
4
+ when [dispatch](../dispatch.md) finds reverts or fix-ups on the changed files.
5
+
6
+ ## Scope
7
+
8
+ - Earlier reverts, hotfixes, and follow-up fixes that touched the same files or symbols
9
+ (`git log --follow` at the base ref, and the pull requests behind those commits).
10
+ - Whether this change reintroduces an approach that was reverted, undoes a deliberate fix, or
11
+ repeats a pattern a previous incident report or issue warned against.
12
+
13
+ ## Not in scope
14
+
15
+ Anything that does not have a concrete precedent in history.
16
+
17
+ ## Blocking bar
18
+
19
+ The change reintroduces behavior that was reverted or fixed, and the pull request does not
20
+ explain what is different now. Link the earlier commit or pull request. A loosely similar
21
+ precedent is `medium` at most.
22
+
23
+ ## Method
24
+
25
+ Cite the precedent (commit SHA or pull request number) in every finding. Never report history
26
+ that only shows normal iteration.
@@ -0,0 +1,34 @@
1
+ # Pillar: rules and hygiene
2
+
3
+ You are the rules reviewer. Follow [the pillar contract](_contract.md).
4
+
5
+ ## Scope
6
+
7
+ - Every applicable `AGENTS.md` (and `CLAUDE.md` adapters) from the repository root down to each
8
+ changed file, read from the **base** ref, never from the pull request head. A pull request can
9
+ edit its own rules; if it does, review the rule change itself as a finding target, but judge the
10
+ rest of the diff by the base rules.
11
+ - Repository-local skills (`.agents/skills/**`, `.claude/skills/**`) from the base ref, and the
12
+ shared vouchington-tooling skills (the `vouchington-workflow`, `vouchington-testing`, and
13
+ `vouchington-database` plugins) whose descriptions match the change.
14
+ - [Review](../../../agent-workflow/references/review.md) criteria from agent-workflow.
15
+ - Hygiene: unrelated changes mixed in, a pull request that should be a stack, stale or missing
16
+ docs and changelog entries the repository requires, the wrong semver level for a published
17
+ package, dependency policy (latest or LTS version, pinned Actions with version comments,
18
+ license policy), and file-length caps.
19
+
20
+ ## Not in scope
21
+
22
+ Logic bugs (correctness), approach and simplicity (design), consumer breakage (blast-radius),
23
+ vulnerabilities (security), and whether the description matches the code (congruence).
24
+
25
+ ## Blocking bar
26
+
27
+ A rule the repository states as mandatory (must, never, always, required, or enforced by CI) is
28
+ broken and the pull request does not explain an exception. Name the rule's file and quote it
29
+ briefly. Style preferences and "should" guidance are `medium` or `low`.
30
+
31
+ ## Method
32
+
33
+ List the rule sources you read first (path and ref), then check each changed file against them.
34
+ Cite the rule in every finding body.
@@ -0,0 +1,28 @@
1
+ # Pillar: security
2
+
3
+ You are the security reviewer. Follow [the pillar contract](_contract.md). This pillar runs only
4
+ when [dispatch](../dispatch.md) finds a security trigger.
5
+
6
+ ## Scope
7
+
8
+ Authentication and authorization, injection (SQL, shell, path, template), untrusted input
9
+ parsing, secrets handling and logging, cryptography, SSRF and open redirects, unsafe
10
+ deserialization, GitHub Actions trust boundaries (`pull_request_target`, untrusted checkout,
11
+ `${{ }}` interpolation into `run`, token permissions, unpinned actions), and supply chain (new
12
+ dependencies, install scripts, typosquats).
13
+
14
+ ## Built-in reviewer
15
+
16
+ If the host provides a built-in security review command (for example Claude Code's
17
+ `/security-review`) and it can target the pull request head, run it and fold in its confirmed
18
+ findings. Otherwise review directly.
19
+
20
+ ## Not in scope
21
+
22
+ General bugs, rules, design, and consumer breakage, unless the issue is exploitable.
23
+
24
+ ## Blocking bar
25
+
26
+ An attacker-controlled input reaches a sensitive sink, or a secret or credential can leak. State
27
+ the source, the sink, and the path between them. Defense-in-depth suggestions are `medium` or
28
+ `low`.
@@ -0,0 +1,62 @@
1
+ # Verifier
2
+
3
+ The verifier runs on the strongest model tier after every dispatched pillar returns. It is the
4
+ only step that writes the review.
5
+
6
+ ## Steps
7
+
8
+ 1. **Congruence.** Perform the [congruence pillar](pillars/congruence.md) yourself.
9
+ 2. **Verify each finding** against the code at the reviewed head: open the cited lines and their
10
+ callers. Mark it confirmed, re-rated (wrong severity for the pillar's blocking bar, in either
11
+ direction: raise an under-rated finding as readily as you lower an over-rated one), or
12
+ rejected (not true, out of scope, or speculative). Drop rejected findings; never post a
13
+ finding you could not confirm in the code. Check `RIGHT` locations against the head file and
14
+ `LEFT` locations against the base side of the numbered diff (deleted code is not in the head).
15
+ If the cited line does not hold the code the finding describes, correct `line` and `startLine`
16
+ to the lines on the same side that do (pillars sometimes cite diff offsets), or drop the
17
+ location. Read the cited ranges with an offset and limit, and grep the diff and large files
18
+ instead of reading them whole, so a large pull request fits in context.
19
+ 3. **Deduplicate** across pillars: the same path, an overlapping line range, and the same claim
20
+ become one finding that keeps the strongest severity and the clearest body.
21
+ 4. **Re-review** (low effort): for each previous finding, decide fixed, still present, or no
22
+ longer applicable. Keep only the still-present ones (once) and the new ones. Resolve the
23
+ review threads of fixed findings
24
+ (`gh api graphql -f query='mutation { resolveReviewThread(input: {threadId: "<id>"}) { thread { id } } }'`).
25
+ 5. **Summarize** in two to four sentences a human can act on: what the change does, whether it
26
+ achieves its intent, and the one or two things that matter most.
27
+
28
+ ## Severity
29
+
30
+ Severity follows the [pillar contract](pillars/_contract.md) and the blocking bar of the finding's
31
+ pillar.
32
+
33
+ ## Verdict
34
+
35
+ The verdict is derived from the findings: any `blocking` finding gives Request Changes, any `high`
36
+ finding gives Comment, and anything else gives Approve. Do not choose it separately. To change
37
+ the verdict, change a finding's severity, and justify that in its body.
38
+
39
+ ## Output
40
+
41
+ Write the input file for `vouchington final-review post`:
42
+
43
+ ```json
44
+ {
45
+ "effort": "high",
46
+ "summary": "Two to four sentences.",
47
+ "skipped": [{ "pillar": "security", "reason": "No security trigger paths changed." }],
48
+ "findings": [
49
+ {
50
+ "pillar": "correctness",
51
+ "severity": "blocking",
52
+ "title": "...",
53
+ "body": "...",
54
+ "path": "...",
55
+ "line": 1
56
+ }
57
+ ]
58
+ }
59
+ ```
60
+
61
+ Then preview it with `--dry-run`, read the rendered reviews, and post it. The tool refuses when
62
+ the head moved since the review started. In that case, start a re-review of the new head.
@@ -4,7 +4,7 @@
4
4
  {
5
5
  "name": "agent-workflow",
6
6
  "plugin": "vouchington-workflow",
7
- "pluginVersion": "0.15.0",
7
+ "pluginVersion": "0.16.0",
8
8
  "path": "agent-workflow/SKILL.md",
9
9
  "prerequisites": [
10
10
  "blackboard",
@@ -24,19 +24,19 @@
24
24
  {
25
25
  "name": "blackboard",
26
26
  "plugin": "vouchington-workflow",
27
- "pluginVersion": "0.15.0",
27
+ "pluginVersion": "0.16.0",
28
28
  "path": "blackboard/SKILL.md"
29
29
  },
30
30
  {
31
31
  "name": "bounded-iteration",
32
32
  "plugin": "vouchington-database",
33
- "pluginVersion": "0.9.0",
33
+ "pluginVersion": "0.10.0",
34
34
  "path": "bounded-iteration/SKILL.md"
35
35
  },
36
36
  {
37
37
  "name": "dependabot",
38
38
  "plugin": "vouchington-workflow",
39
- "pluginVersion": "0.15.0",
39
+ "pluginVersion": "0.16.0",
40
40
  "path": "dependabot/SKILL.md",
41
41
  "prerequisites": ["github-actions-checklist"]
42
42
  },
@@ -47,35 +47,41 @@
47
47
  "path": "dotnet-test-authoring/SKILL.md",
48
48
  "prerequisites": ["test-authoring"]
49
49
  },
50
+ {
51
+ "name": "final-review",
52
+ "plugin": "vouchington-workflow",
53
+ "pluginVersion": "0.16.0",
54
+ "path": "final-review/SKILL.md"
55
+ },
50
56
  {
51
57
  "name": "git-commit-checklist",
52
58
  "plugin": "vouchington-workflow",
53
- "pluginVersion": "0.15.0",
59
+ "pluginVersion": "0.16.0",
54
60
  "path": "git-commit-checklist/SKILL.md"
55
61
  },
56
62
  {
57
63
  "name": "github-actions-authoring",
58
64
  "plugin": "vouchington-workflow",
59
- "pluginVersion": "0.15.0",
65
+ "pluginVersion": "0.16.0",
60
66
  "path": "github-actions-authoring/SKILL.md",
61
67
  "prerequisites": ["github-actions-checklist"]
62
68
  },
63
69
  {
64
70
  "name": "github-actions-checklist",
65
71
  "plugin": "vouchington-workflow",
66
- "pluginVersion": "0.15.0",
72
+ "pluginVersion": "0.16.0",
67
73
  "path": "github-actions-checklist/SKILL.md"
68
74
  },
69
75
  {
70
76
  "name": "github-issue",
71
77
  "plugin": "vouchington-workflow",
72
- "pluginVersion": "0.15.0",
78
+ "pluginVersion": "0.16.0",
73
79
  "path": "github-issue/SKILL.md"
74
80
  },
75
81
  {
76
82
  "name": "glide-mq",
77
83
  "plugin": "vouchington-database",
78
- "pluginVersion": "0.9.0",
84
+ "pluginVersion": "0.10.0",
79
85
  "path": "glide-mq/SKILL.md"
80
86
  },
81
87
  {
@@ -88,26 +94,26 @@
88
94
  {
89
95
  "name": "npm-publishing",
90
96
  "plugin": "vouchington-workflow",
91
- "pluginVersion": "0.15.0",
97
+ "pluginVersion": "0.16.0",
92
98
  "path": "npm-publishing/SKILL.md"
93
99
  },
94
100
  {
95
101
  "name": "organize-github-issues",
96
102
  "plugin": "vouchington-workflow",
97
- "pluginVersion": "0.15.0",
103
+ "pluginVersion": "0.16.0",
98
104
  "path": "organize-github-issues/SKILL.md",
99
105
  "prerequisites": ["github-issue"]
100
106
  },
101
107
  {
102
108
  "name": "package-json-checklist",
103
109
  "plugin": "vouchington-workflow",
104
- "pluginVersion": "0.15.0",
110
+ "pluginVersion": "0.16.0",
105
111
  "path": "package-json-checklist/SKILL.md"
106
112
  },
107
113
  {
108
114
  "name": "planning",
109
115
  "plugin": "vouchington-workflow",
110
- "pluginVersion": "0.15.0",
116
+ "pluginVersion": "0.16.0",
111
117
  "path": "planning/SKILL.md",
112
118
  "prerequisites": ["github-issue"]
113
119
  },
@@ -121,78 +127,78 @@
121
127
  {
122
128
  "name": "postgres-node-performance-tuning",
123
129
  "plugin": "vouchington-database",
124
- "pluginVersion": "0.9.0",
130
+ "pluginVersion": "0.10.0",
125
131
  "path": "postgres-node-performance-tuning/SKILL.md"
126
132
  },
127
133
  {
128
134
  "name": "postgres-partitioning-uuid-v7",
129
135
  "plugin": "vouchington-database",
130
- "pluginVersion": "0.9.0",
136
+ "pluginVersion": "0.10.0",
131
137
  "path": "postgres-partitioning-uuid-v7/SKILL.md"
132
138
  },
133
139
  {
134
140
  "name": "postgres-schema-design",
135
141
  "plugin": "vouchington-database",
136
- "pluginVersion": "0.9.0",
142
+ "pluginVersion": "0.10.0",
137
143
  "path": "postgres-schema-design/SKILL.md"
138
144
  },
139
145
  {
140
146
  "name": "pr-description",
141
147
  "plugin": "vouchington-workflow",
142
- "pluginVersion": "0.15.0",
148
+ "pluginVersion": "0.16.0",
143
149
  "path": "pr-description/SKILL.md"
144
150
  },
145
151
  {
146
152
  "name": "ready-and-shepherd",
147
153
  "plugin": "vouchington-workflow",
148
- "pluginVersion": "0.15.0",
154
+ "pluginVersion": "0.16.0",
149
155
  "path": "ready-and-shepherd/SKILL.md",
150
156
  "prerequisites": ["stacked-prs"]
151
157
  },
152
158
  {
153
159
  "name": "retrospective",
154
160
  "plugin": "vouchington-workflow",
155
- "pluginVersion": "0.15.0",
161
+ "pluginVersion": "0.16.0",
156
162
  "path": "retrospective/SKILL.md"
157
163
  },
158
164
  {
159
165
  "name": "retrospective-distill",
160
166
  "plugin": "vouchington-workflow",
161
- "pluginVersion": "0.15.0",
167
+ "pluginVersion": "0.16.0",
162
168
  "path": "retrospective-distill/SKILL.md",
163
169
  "prerequisites": ["github-issue"]
164
170
  },
165
171
  {
166
172
  "name": "review-ci-logs",
167
173
  "plugin": "vouchington-workflow",
168
- "pluginVersion": "0.15.0",
174
+ "pluginVersion": "0.16.0",
169
175
  "path": "review-ci-logs/SKILL.md",
170
176
  "prerequisites": ["github-actions-checklist", "pr-description"]
171
177
  },
172
178
  {
173
179
  "name": "review-github-issue-taxonomy",
174
180
  "plugin": "vouchington-workflow",
175
- "pluginVersion": "0.15.0",
181
+ "pluginVersion": "0.16.0",
176
182
  "path": "review-github-issue-taxonomy/SKILL.md",
177
183
  "prerequisites": ["github-issue"]
178
184
  },
179
185
  {
180
186
  "name": "revisit-followups",
181
187
  "plugin": "vouchington-workflow",
182
- "pluginVersion": "0.15.0",
188
+ "pluginVersion": "0.16.0",
183
189
  "path": "revisit-followups/SKILL.md",
184
190
  "prerequisites": ["github-issue"]
185
191
  },
186
192
  {
187
193
  "name": "stacked-prs",
188
194
  "plugin": "vouchington-workflow",
189
- "pluginVersion": "0.15.0",
195
+ "pluginVersion": "0.16.0",
190
196
  "path": "stacked-prs/SKILL.md"
191
197
  },
192
198
  {
193
199
  "name": "static-analysis-checklist",
194
200
  "plugin": "vouchington-workflow",
195
- "pluginVersion": "0.15.0",
201
+ "pluginVersion": "0.16.0",
196
202
  "path": "static-analysis-checklist/SKILL.md",
197
203
  "prerequisites": ["github-actions-checklist"]
198
204
  },
@@ -219,14 +225,14 @@
219
225
  {
220
226
  "name": "triage-loop",
221
227
  "plugin": "vouchington-workflow",
222
- "pluginVersion": "0.15.0",
228
+ "pluginVersion": "0.16.0",
223
229
  "path": "triage-loop/SKILL.md",
224
230
  "prerequisites": ["ready-and-shepherd", "github-issue"]
225
231
  },
226
232
  {
227
233
  "name": "triage-prs",
228
234
  "plugin": "vouchington-workflow",
229
- "pluginVersion": "0.15.0",
235
+ "pluginVersion": "0.16.0",
230
236
  "path": "triage-prs/SKILL.md",
231
237
  "prerequisites": [
232
238
  "pr-description",
@@ -240,7 +246,7 @@
240
246
  {
241
247
  "name": "triage-sweep",
242
248
  "plugin": "vouchington-workflow",
243
- "pluginVersion": "0.15.0",
249
+ "pluginVersion": "0.16.0",
244
250
  "path": "triage-sweep/SKILL.md",
245
251
  "prerequisites": [
246
252
  "triage-loop",
@@ -28,7 +28,11 @@ Read and return tables with explicit columns: no `SELECT *`, `alias.*`, or `RETU
28
28
  A view may use `*` when its reviewed column list is the reader contract.
29
29
 
30
30
  Use keyset pagination, never `OFFSET`. An optimizer fence is a `MATERIALIZED` CTE, not
31
- `OFFSET 0`. Constrain a partitioned table's partition key, or document the reason for a
31
+ `OFFSET 0`. The fence keeps the outer query's filters and ordering away from the CTE's indexes.
32
+ The outer query still reads CTE rows on demand and can stop at its `LIMIT`, but when its filters
33
+ reject most CTE rows, or it sorts, aggregates or hash-joins them, it reads every row up to the CTE's own
34
+ `LIMIT`. Use a `MATERIALIZED` CTE only when it holds the final `LIMIT`, or for a small
35
+ viewer-scoped set. Never use it as a candidate pool before the page `LIMIT`. Constrain a partitioned table's partition key, or document the reason for a
32
36
  cross-partition query. Choose the partition key from dominant access patterns; a hot reader
33
37
  of `RANGE (id)` needs an id or time bound.
34
38