vouchington-tooling 0.14.0 → 0.15.1

package/README.md

@@ -93,6 +93,9 @@ ancestor of `HEAD`. `gitleaks-directory-scan` builds and scans isolated staged-i
 nonignored-working-tree mirrors with an explicit config; `--directory` selects the repository root.
 `ast-grep-examples` runs native `ast-grep test`, then validates each scoped rule's `files:` and
 `ignores:` examples with project `languageGlobs` replay from its root `--config`.
+The shipped pack maps `**/*.ts`, `**/*.mts`, `**/*.cts`, and `**/*.tsx` to `Tsx` so one rule
+covers script and JSX surfaces. Consumers must use the same `languageGlobs` and `language: Tsx`;
+do not add `-tsx` companion YAML. Angle-bracket type assertions (`<T>value`) are not valid TSX.
 `compareAstGrepCompanions` compares recursive `<name>.yml`/`.yaml` and `<name>-tsx` companion
 rules across every YAML field, returns stable JSON-pointer differences, and rejects unsafe or
 ambiguous rule paths. The supplied rule path and every ancestor must be physical directories; YAML

package/ast-grep/rules/backend-no-test-file-imports.yml

@@ -1,5 +1,5 @@
 id: backend-no-test-file-imports
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Do not import backend test files from backend Vitest files; move shared helpers to test-helpers or a support module.'
 files:

package/ast-grep/rules/no-dynamic-import-in-vitest-config.yml

@@ -1,5 +1,5 @@
 id: no-dynamic-import-in-vitest-config
-language: TypeScript
+language: Tsx
 severity: error
 message: >-
   vitest config files must use static imports — dynamic import() prevents

package/ast-grep/rules/no-dynamic-server-components.yml

@@ -2,17 +2,17 @@
 # It cannot verify the import source — it matches by function name.
 # If you have other functions named `dynamic` or `nextDynamic`, add a suppression comment.
 id: no-dynamic-server-components
-language: TypeScript
+language: Tsx
 severity: error
 message: "dynamic()/nextDynamic() may wrap a server component — ensure the target has 'use client'"
-# NOTE: ast-grep maps `.tsx` to language `Tsx`, not `TypeScript`. This rule
-# only scans `.ts` files; see no-dynamic-server-components-tsx.yml for the
-# companion rule that covers `.tsx` files.
 files:
-  - 'web/**/*.ts'
+  - web/**/*.ts
+  - web/**/*.tsx
 ignores:
   - '**/*.test.ts'
   - '**/*.spec.ts'
+  - '**/*.test.tsx'
+  - '**/*.spec.tsx'
 rule:
   any:
     - pattern: '$FN(() => import($PATH))'
@@ -69,3 +69,39 @@ examples:
   - code: "const Comp = lazy(() => import('./my-component'))"
     isValid: true
     file: 'web/app/page.ts'
+  - code: const Comp = dynamic(() => import('./my-component'))
+    isValid: false
+    file: web/app/page.tsx
+  - code: const Comp = dynamic(() => import(`./my-component`))
+    isValid: false
+    file: web/app/page.tsx
+  - code: const Comp = dynamic(() => import('../components/comp'))
+    isValid: false
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./add-tag-form').then(m => ({ default: m.AddTagForm })))"
+    isValid: false
+    file: web/app/page.tsx
+  - code: const Comp = nextDynamic(() => import('./my-component'))
+    isValid: false
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./c'), { loading: () => null })"
+    isValid: false
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./c'), { not_ssr: false })"
+    isValid: false
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./c'), { ssr: falsey })"
+    isValid: false
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./c'), { ssr: false })"
+    isValid: true
+    file: web/app/page.tsx
+  - code: 'const Comp = dynamic(() => import("./c"), { "ssr": false })'
+    isValid: true
+    file: web/app/page.tsx
+  - code: "const Comp = dynamic(() => import('./c'), { 'ssr': false })"
+    isValid: true
+    file: web/app/page.tsx
+  - code: const Comp = lazy(() => import('./my-component'))
+    isValid: true
+    file: web/app/page.tsx

package/ast-grep/rules/no-enable-indexscan-off.yml

@@ -1,8 +1,5 @@
-# NOTE: ast-grep maps `.tsx` to language `Tsx`, not `TypeScript`. This rule
-# only scans `.ts/.mts/.cts` files; see no-enable-indexscan-off-tsx.yml for
-# the companion rule that covers `.tsx` files.
 id: no-enable-indexscan-off
-language: TypeScript
+language: Tsx
 severity: error
 message: >-
   Do not use `enable_indexscan = off` — it disables index scans repo-wide within the transaction
@@ -39,3 +36,19 @@ examples:
       const note = 'see applyFilteredVectorScan'
     isValid: true
     file: 'backend/src/vector-scan.mts'
+  - code: |-
+      import sql from 'sql-template-strings'
+      export const query = sql`SET LOCAL enable_indexscan = off`
+    isValid: false
+    file: web/lib/__tests__/example.tsx
+  - code: |-
+      import sql from 'sql-template-strings'
+      export const query = sql`SET LOCAL enable_indexscan TO off`
+    isValid: false
+    file: web/lib/__tests__/example.tsx
+  - code: |-
+      export function Example() {
+        return <div>hnsw.iterative_scan = strict_order</div>
+      }
+    isValid: true
+    file: web/components/example.tsx

package/ast-grep/rules/no-exports-in-tests-folder.yml

@@ -1,17 +1,16 @@
 # NOTE: `__tests__` directories must contain tests only. Shared helpers, registries,
 # fixtures, and other imported support modules belong in a nearby `test-helpers/`
 # directory so test roots stay easy to scan.
-# NOTE: ast-grep maps `.tsx` to language `Tsx`, not `TypeScript`. This rule
-# only scans `.ts/.mts/.cts` files; see no-exports-in-tests-folder-tsx.yml for
-# the companion rule that covers `.tsx` files.
+
 id: no-exports-in-tests-folder
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Do not export from files under __tests__; move shared test support to a test-helpers directory.'
 files:
   - '**/__tests__/**/*.ts'
   - '**/__tests__/**/*.mts'
   - '**/__tests__/**/*.cts'
+  - '**/__tests__/**/*.tsx'
 rule:
   all:
     - kind: export_statement
@@ -41,3 +40,27 @@ examples:
   - code: 'export {}'
     isValid: true
     file: 'backend/services/example/__tests__/global-script.test.mts'
+  - code: |
+      export function renderThing() {
+        return <div />
+      }
+    isValid: false
+    file: web/components/example/__tests__/comment-tree-test-helpers.tsx
+  - code: export type RenderThing = () => JSX.Element
+    isValid: false
+    file: web/components/__tests__/render-helpers.tsx
+  - code: |
+      it('renders shell exports', () => {
+        expect(`export NEXT_PORT=3901`).toContain('export')
+      })
+    isValid: true
+    file: web/components/example/__tests__/comment-tree.test.tsx
+  - code: |
+      function renderThing() {
+        return <div />
+      }
+    isValid: true
+    file: web/components/example/__tests__/comment-tree.test.tsx
+  - code: export {}
+    isValid: true
+    file: web/components/example/__tests__/global-jsx.test.tsx

package/ast-grep/rules/no-object-assign-new-error.yml

@@ -1,5 +1,5 @@
 id: no-object-assign-new-error
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Use http-errors/http-assert or an explicit typed error helper instead of Object.assign(new Error(...))'
 files:

package/ast-grep/rules/no-runner-temp-nullish.yml

@@ -1,5 +1,5 @@
 id: no-runner-temp-nullish
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Use logical OR for RUNNER_TEMP temp roots so an empty string falls back safely.'
 files:

package/ast-grep/rules/no-self-comparison-assertion.yml

@@ -1,5 +1,5 @@
 id: no-self-comparison-assertion
-language: TypeScript
+language: Tsx
 severity: error
 message: 'This compares an expression against itself (e.g. expect(result.id).toBe(result.id)). ast-grep metavariables enforce identical text, so both sides read the same value the same way; nearly every real occurrence of this shape is a copy-paste bug where the second operand should have been an independently derived expected value. Compare against that instead, or a fixture-provided value the code under test did not produce. (Two syntactic shapes are exempted because they cannot be tautological by construction: an expression containing a call anywhere in it, e.g. expect(f(a)).toBe(f(a)) or expect((await load()).id).toBe((await load()).id), is a fresh invocation on each side and legitimately tests that the call is deterministic/pure; and a postfix/prefix increment or decrement, e.g. expect(index++).toBe(index++), advances state between the two reads. A getter or other stateful property access is NOT exempted -- ast-grep cannot see whether a given `.foo` is a plain field or a getter with side effects, and every real violation this rule has caught in this repo is a plain field, so this stays flagged by design; if you are deliberately asserting that such an accessor is stable across two reads, add an `ast-grep-ignore: no-self-comparison-assertion` comment with that rationale instead of weakening this rule.)'
 files:
@@ -9,6 +9,8 @@ files:
   - '**/*.spec.ts'
   - '**/*.spec.mts'
   - '**/*.spec.cts'
+  - '**/*.test.tsx'
+  - '**/*.spec.tsx'
 rule:
   pattern: 'expect($X).toBe($X)'
 constraints:
@@ -51,3 +53,21 @@ examples:
   - code: 'expect(index++).toBe(index++)'
     isValid: true
     file: 'backend/services/example/__tests__/items.test.mts'
+  - code: expect(item.id).toBe(item.id)
+    isValid: false
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect(item.id).toBe(expectedId)
+    isValid: true
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect(formatItemLabel(item)).toBe(formatItemLabel(item))
+    isValid: true
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect((await loadItem()).id).toBe((await loadItem()).id)
+    isValid: true
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect(item.id).toBe(item.id)
+    isValid: true
+    file: web/components/example/add-to-list-menu-item.tsx
+  - code: expect(index++).toBe(index++)
+    isValid: true
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx

package/ast-grep/rules/no-sql-offset.yml

@@ -1,5 +1,5 @@
 id: no-sql-offset
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Do not use SQL OFFSET in backend sql templates; use cursor pagination, LIMIT + 1, COUNT, EXISTS, or ROW_NUMBER() instead'
 files:

package/ast-grep/rules/no-sync-throw-assert-on-async-enqueue.yml

@@ -1,5 +1,5 @@
 id: no-sync-throw-assert-on-async-enqueue
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Best-effort syntactic heuristic (not type-aware): this wraps a synchronous throw-assertion around a call that looks like a Promise-returning enqueue call. expect(() => fn()).not.toThrow() and .toThrow() only observe a synchronous throw and never see an async rejection, so this gives false confidence in the async contract. Await the call and assert on its resolved value instead, e.g. expect(await enqueueFoo()).toBeUndefined() or await expect(enqueueFoo()).resolves.toBeDefined().'
 files:

package/ast-grep/rules/no-tautological-literal-assertion.yml

@@ -1,5 +1,5 @@
 id: no-tautological-literal-assertion
-language: TypeScript
+language: Tsx
 severity: error
 message: 'This asserts a literal against an identical literal (e.g. expect(true).toBe(true)), which can never fail and provides zero real coverage of the code under test. Assert on the actual value the code under test produced instead -- for example expect(await run()).not.toBeNull(), or a specific value or shape derived from calling the function being tested.'
 files:
@@ -9,6 +9,8 @@ files:
   - '**/*.spec.ts'
   - '**/*.spec.mts'
   - '**/*.spec.cts'
+  - '**/*.test.tsx'
+  - '**/*.spec.tsx'
 rule:
   pattern: 'expect($LIT).toBe($LIT)'
 constraints:
@@ -36,3 +38,15 @@ examples:
   - code: 'expect(true).toBe(true)'
     isValid: true
     file: 'backend/services/example/get-trending-posts.mts'
+  - code: expect(true).toBe(true)
+    isValid: false
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect('placeholder').toBe('placeholder')
+    isValid: false
+    file: web/components/example/__tests__/source-list-item.interactions.mock.test.tsx
+  - code: expect(screen.getByRole("button")).toBeInTheDocument()
+    isValid: true
+    file: web/components/example/__tests__/add-to-list-menu-item.mock.test.tsx
+  - code: expect(true).toBe(true)
+    isValid: true
+    file: web/components/example/add-to-list-menu-item.tsx

package/ast-grep/rules/no-test-max-lines-disable.yml

@@ -1,11 +1,9 @@
 # NOTE: This rule flags eslint/oxlint disable directives that suppress max-lines
 # (or all rules) inside test files. Test files must stay within their line limit;
 # split the test or extract reusable helpers instead.
-# NOTE: ast-grep maps `.tsx` to language `Tsx`, not `TypeScript`. This rule
-# only scans `.ts/.mts/.cts` files; see no-test-max-lines-disable-tsx.yml for
-# the companion rule that covers `.tsx` files.
+
 id: no-test-max-lines-disable
-language: TypeScript
+language: Tsx
 severity: error
 message: 'Test files must not disable max-lines or all lint rules; split the test or extract reusable helpers instead.'
 files:
@@ -18,6 +16,9 @@ files:
   - '**/__tests__/**/*.ts'
   - '**/__tests__/**/*.mts'
   - '**/__tests__/**/*.cts'
+  - '**/*.test.tsx'
+  - '**/*.spec.tsx'
+  - '**/__tests__/**/*.tsx'
 rule:
   kind: comment
   any:
@@ -51,3 +52,24 @@ examples:
   - code: '// oxlint-disable no-console -- split because of max-lines'
     isValid: true
     file: 'backend/services/users.test.ts'
+  - code: // oxlint-disable max-lines
+    isValid: false
+    file: web/components/__tests__/foo.test.tsx
+  - code: // eslint-disable
+    isValid: false
+    file: web/components/__tests__/foo.test.tsx
+  - code: // oxlint-disable vitest/expect-expect
+    isValid: true
+    file: web/components/__tests__/foo.test.tsx
+  - code: // oxlint-disable no-console
+    isValid: true
+    file: web/components/__tests__/foo.spec.tsx
+  - code: // eslint-disable max-lines-per-function
+    isValid: true
+    file: web/components/__tests__/foo.test.tsx
+  - code: // eslint-disable eslint/max-lines-per-function
+    isValid: true
+    file: web/components/__tests__/foo.test.tsx
+  - code: // oxlint-disable no-console -- split because of max-lines
+    isValid: true
+    file: web/components/__tests__/foo.test.tsx