vouchington-tooling 0.13.4 → 0.14.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "vouchington-tooling",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.14.0",
|
|
4
4
|
"description": "Vouchington CLI and extractable tooling libraries.",
|
|
5
5
|
"homepage": "https://github.com/vouchington/vouchington-tooling/tree/main/packages/vouchington-tooling#readme",
|
|
6
6
|
"bugs": {
|
|
@@ -22,9 +22,12 @@ branching, review, and release policy.
|
|
|
22
22
|
checks with a concrete reason.
|
|
23
23
|
6. Review the diff for accidental files, secrets, generated output, broken documentation links,
|
|
24
24
|
and assumptions that belong in local instructions instead.
|
|
25
|
+
7. When feedback arrives on an open change, give every surfaced item a disposition and drive it to
|
|
26
|
+
closure before hand-off; do not leave items unaddressed or silently absorb or defer them.
|
|
25
27
|
|
|
26
28
|
For portable implementation and review checks, read [implementation](references/implementation.md),
|
|
27
|
-
[review](references/review.md),
|
|
29
|
+
[review](references/review.md), [review response](references/review-response.md), and
|
|
30
|
+
[evidence sweep](references/evidence-sweep.md). The older
|
|
28
31
|
[implementation and review](references/implementation-and-review.md) remains a compact overview.
|
|
29
32
|
Local instructions remain authoritative for commands, commits, review systems, and release policy.
|
|
30
33
|
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
# Review response
|
|
2
|
+
|
|
3
|
+
Applies when responding to feedback on an open change — a human reviewer, an automated reviewer, or
|
|
4
|
+
a shepherding tool that surfaces both. This is the response side of [review](review.md); its closing
|
|
5
|
+
line, to record unresolved risk as an explicit decision or follow-up and never as an unnoticed gap,
|
|
6
|
+
is what the ladder below operationalizes.
|
|
7
|
+
|
|
8
|
+
Give every surfaced item exactly one disposition before its resolution runs, recorded where the
|
|
9
|
+
review conversation lives. Invalid — wrong, already satisfied by the current diff, or out of an
|
|
10
|
+
already-settled scope — gets a reason and closes with no code change and no follow-up. Blocking —
|
|
11
|
+
correctness, security, data safety, or a gap against a linked requirement — gets fixed, pushed, and
|
|
12
|
+
confirmed on the change's head commit before closing; closing first can leave an unfixed commit
|
|
13
|
+
behind a closed conversation. Non-blocking gets folded into an already-planned push when the fix is
|
|
14
|
+
cheap and low-risk, and otherwise gets recorded as a follow-up only when leaving it undone would
|
|
15
|
+
change behavior, structure, or risk: reuse or extend an existing follow-up before opening a new one,
|
|
16
|
+
and group related items from the same round into one. A correct item that clears none of those bars
|
|
17
|
+
— a style preference, a restatement, polish the change is fine without — is declined with a reason
|
|
18
|
+
and no follow-up; that is the expected outcome for a minor suggestion, not a lapse. Escalate — work
|
|
19
|
+
the change cannot absorb as feedback, such as a large architectural or ownership change — is
|
|
20
|
+
recorded where decisions are tracked and reported for direction rather than implemented or silently
|
|
21
|
+
downgraded to a follow-up.
|
|
22
|
+
|
|
23
|
+
Read every outstanding item before editing and drain the round locally; the cost of iterating is the
|
|
24
|
+
push, not the commit, because a push re-runs checks and re-triggers automated reviewers. Declining a
|
|
25
|
+
round without pushing is what lets it converge instead of regenerating the same suggestions on every
|
|
26
|
+
cycle. By hand-off, every item carries a disposition and reaches closure — an escalation through its
|
|
27
|
+
decision record rather than an open conversation — except where the review surface itself withholds
|
|
28
|
+
the capability to close an item; say so and leave it rather than forcing a resolution it never
|
|
29
|
+
authorized.
|
|
30
|
+
|
|
31
|
+
This skill supplies no review system, resolution mechanism, issue tracker, label, or severity
|
|
32
|
+
vocabulary; a consumer wrapper owns those.
|