volleyballsimtypes 0.0.485 → 0.0.486

package/dist/cjs/src/service/team/sub-config-convert.js

@@ -23,12 +23,17 @@ function fatigueCondition(band) {
 function convertLegacySetSubConfig(raw) {
     if (!isRecord(raw))
         return raw;
-    // Derive the mode for the oldest (pre-mode) generation; a unified shape has none of these keys.
+    // Derive the mode for the oldest (pre-mode) generation; a unified shape has none of these keys. Test the
+    // isPinchServer VALUE, not key presence: the sim read path (transformToObject) spreads `isPinchServer:
+    // d.isPinchServer` onto every row, so a unified row carries an `isPinchServer: undefined` key. `'isPinchServer'
+    // in raw` would then misread that unified row as a legacy FATIGUE sub and overwrite its real conditions /
+    // pinchServer flag. A genuine legacy isPinchServer-era row always has a boolean flag (true handled above), so
+    // the only remaining legacy case is an explicit `=== false`.
     const mode = raw.mode ?? (raw.isPinchServer === true
         ? 'PINCH'
         : raw.fatigueBand === 'NEVER'
             ? 'NEVER'
-            : raw.fatigueBand != null || 'isPinchServer' in raw ? 'FATIGUE' : null);
+            : raw.fatigueBand != null || raw.isPinchServer === false ? 'FATIGUE' : null);
     if (mode == null)
         return raw;
     const { mode: _m, fatigueBand, isPinchServer: _p, ...rest } = raw;

package/dist/cjs/src/service/team/sub-config-convert.test.js

@@ -12,6 +12,25 @@ const sub_config_convert_1 = require("./sub-config-convert");
         const unified = { bench: 'X', conditions: [{ type: pinch_condition_1.PinchConditionType.ASAP }], pinchServer: true };
         (0, globals_1.expect)((0, sub_config_convert_1.convertLegacySetSubConfig)(unified)).toBe(unified);
     });
+    (0, globals_1.it)('keeps a unified pinch server intact when a caller injects isPinchServer: undefined (sim read path)', () => {
+        // The sim read path (transformToObject) spreads `isPinchServer: d.isPinchServer` onto every row, so a
+        // unified row arrives carrying an `isPinchServer: undefined` key. Detecting the legacy shape by key
+        // PRESENCE misread it as a FATIGUE sub and wiped its real conditions + pinchServer flag; the value check
+        // (=== false) keeps the unified shape. Regression for the "pinch server never serves" prod bug.
+        const out = (0, sub_config_convert_1.convertLegacySetSubConfig)({
+            bench: 'X',
+            conditions: [{ type: pinch_condition_1.PinchConditionType.AFTER_ROTATIONS, rotations: 1 }],
+            conditionLogic: 'ANY',
+            pinchServer: true,
+            subBackMode: 'FATIGUE',
+            isPinchServer: undefined,
+            mode: undefined,
+            fatigueBand: undefined
+        });
+        (0, globals_1.expect)(out.pinchServer).toBe(true);
+        (0, globals_1.expect)(out.conditions).toEqual([{ type: pinch_condition_1.PinchConditionType.AFTER_ROTATIONS, rotations: 1 }]);
+        (0, globals_1.expect)(out.conditionLogic).toBe('ANY');
+    });
     (0, globals_1.it)('converts mode NEVER to an explicit empty condition list, dropping every other field', () => {
         (0, globals_1.expect)((0, sub_config_convert_1.convertLegacySetSubConfig)({ mode: 'NEVER', bench: 'X' })).toEqual({ conditions: [] });
     });

package/dist/esm/src/service/team/sub-config-convert.js

@@ -17,12 +17,17 @@ function fatigueCondition(band) {
 export function convertLegacySetSubConfig(raw) {
     if (!isRecord(raw))
         return raw;
-    // Derive the mode for the oldest (pre-mode) generation; a unified shape has none of these keys.
+    // Derive the mode for the oldest (pre-mode) generation; a unified shape has none of these keys. Test the
+    // isPinchServer VALUE, not key presence: the sim read path (transformToObject) spreads `isPinchServer:
+    // d.isPinchServer` onto every row, so a unified row carries an `isPinchServer: undefined` key. `'isPinchServer'
+    // in raw` would then misread that unified row as a legacy FATIGUE sub and overwrite its real conditions /
+    // pinchServer flag. A genuine legacy isPinchServer-era row always has a boolean flag (true handled above), so
+    // the only remaining legacy case is an explicit `=== false`.
     const mode = raw.mode ?? (raw.isPinchServer === true
         ? 'PINCH'
         : raw.fatigueBand === 'NEVER'
             ? 'NEVER'
-            : raw.fatigueBand != null || 'isPinchServer' in raw ? 'FATIGUE' : null);
+            : raw.fatigueBand != null || raw.isPinchServer === false ? 'FATIGUE' : null);
     if (mode == null)
         return raw;
     const { mode: _m, fatigueBand, isPinchServer: _p, ...rest } = raw;

package/dist/esm/src/service/team/sub-config-convert.test.js

@@ -10,6 +10,25 @@ describe('convertLegacySetSubConfig', () => {
         const unified = { bench: 'X', conditions: [{ type: PinchConditionType.ASAP }], pinchServer: true };
         expect(convertLegacySetSubConfig(unified)).toBe(unified);
     });
+    it('keeps a unified pinch server intact when a caller injects isPinchServer: undefined (sim read path)', () => {
+        // The sim read path (transformToObject) spreads `isPinchServer: d.isPinchServer` onto every row, so a
+        // unified row arrives carrying an `isPinchServer: undefined` key. Detecting the legacy shape by key
+        // PRESENCE misread it as a FATIGUE sub and wiped its real conditions + pinchServer flag; the value check
+        // (=== false) keeps the unified shape. Regression for the "pinch server never serves" prod bug.
+        const out = convertLegacySetSubConfig({
+            bench: 'X',
+            conditions: [{ type: PinchConditionType.AFTER_ROTATIONS, rotations: 1 }],
+            conditionLogic: 'ANY',
+            pinchServer: true,
+            subBackMode: 'FATIGUE',
+            isPinchServer: undefined,
+            mode: undefined,
+            fatigueBand: undefined
+        });
+        expect(out.pinchServer).toBe(true);
+        expect(out.conditions).toEqual([{ type: PinchConditionType.AFTER_ROTATIONS, rotations: 1 }]);
+        expect(out.conditionLogic).toBe('ANY');
+    });
     it('converts mode NEVER to an explicit empty condition list, dropping every other field', () => {
         expect(convertLegacySetSubConfig({ mode: 'NEVER', bench: 'X' })).toEqual({ conditions: [] });
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "volleyballsimtypes",
-  "version": "0.0.485",
+  "version": "0.0.486",
   "description": "vbsim types",
   "main": "./dist/cjs/src/index.js",
   "module": "./dist/esm/src/index.js",