vizcraft 1.3.0 → 1.3.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # vizcraft
 
+## 1.3.1
+
+### Patch Changes
+
+- [`086ef9e`](https://github.com/ChipiKaf/vizcraft/commit/086ef9e7b5d505cbb03f955e8d24297fb60a6b3e) Thanks [@ChipiKaf](https://github.com/ChipiKaf)! - The fix prevents commit() from using a stale cached runtimePatchCtx (which could reference detached DOM elements) by always recreating it after \_renderSceneToDOM, and removes the redundant strokeDasharray write from patchRuntime so that base style is owned by a single write path.
+
 ## 1.3.0
 
 ### Minor Changes

package/dist/builder.js

@@ -654,14 +654,13 @@ class VizBuilderImpl {
         // The reconciliation correctly re-uses existing SVG elements, inserts new ones, and deletes missing ones.
         const scene = this.build();
         this._renderSceneToDOM(scene, container);
-        // Apply runtime overrides (if any)
-        let ctx = runtimePatchCtxBySvg.get(svg);
-        if (!ctx) {
-            ctx = createRuntimePatchCtx(svg, {
-                edgePathResolver: this._edgePathResolver,
-            });
-            runtimePatchCtxBySvg.set(svg, ctx);
-        }
+        // Apply runtime overrides (if any).
+        // Always recreate the context after _renderSceneToDOM so patchRuntime
+        // never references stale / detached elements (fixes #81).
+        const ctx = createRuntimePatchCtx(svg, {
+            edgePathResolver: this._edgePathResolver,
+        });
+        runtimePatchCtxBySvg.set(svg, ctx);
         patchRuntime(scene, ctx);
     }
     /**

package/dist/runtimePatcher.js

@@ -511,19 +511,9 @@ export function patchRuntime(scene, ctx) {
                 shape.removeAttribute('opacity');
             }
         }
-        // Stroke-dasharray: apply resolved value to shape.
-        if (node.style?.strokeDasharray !== undefined) {
-            const resolved = resolveDasharray(node.style.strokeDasharray);
-            if (resolved) {
-                shape.setAttribute('stroke-dasharray', resolved);
-            }
-            else {
-                shape.removeAttribute('stroke-dasharray');
-            }
-        }
-        else {
-            shape.removeAttribute('stroke-dasharray');
-        }
+        // NOTE: strokeDasharray is a static base style — written exclusively by
+        // _renderSceneToDOM via setSvgAttributes.  patchRuntime must NOT duplicate
+        // that write to avoid the stale-context overwrite described in #81.
         if (node.style?.shadow) {
             const fid = ensureShadowFilter(ctx.svg, node.style.shadow);
             shape.setAttribute('filter', `url(#${fid})`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vizcraft",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "A fluent, type-safe SVG scene builder for composing nodes, edges, animations, and overlays with incremental DOM updates and no framework dependency.",
   "keywords": [
     "visualization",