visualproof 0.2.0 → 0.4.0

package/dist/shared/collab.js

@@ -93,8 +93,11 @@ export function artNameId(kind, s) {
  *  presence carries, in bytes of their JSON: a heartbeat is at most 16 KB (server/main.ts), and the
  *  rest of where a reader is has room beside them. Names by selection are kept as what differs from
  *  As shown, so that a few names hidden or added are a few names carried. */
-export const ART_NAMES_BYTES = 4500;
+export const ART_NAMES_BYTES = 4000;
 export const ART_TARGETS_BYTES = 2500;
+/** the names a recipe's rule chose (ArtworkLook `ruledNames`): a rule names a few clusters. The four
+ *  lists full, with the longest title and line, leave a heartbeat room (test/sharesnap.test.ts) */
+export const ART_RULED_BYTES = 1000;
 /** What `x` adds to a list's JSON: itself, quoted, and a comma. */
 const jsonBytes = (x) => new TextEncoder().encode(JSON.stringify(x)).length + 1;
 /** A list of names as given, checked: strings, each once, none empty or longer than a name is (1,000
@@ -148,12 +151,14 @@ export function cleanArtwork(v) {
     // say them, and the key marks as the targets drew them before (with their stars, unless As any)
     const namesFrom = o.namesFrom === "none" ? "none" : "board";
     const hiddenNames = cleanNames(o.hiddenNames, ART_NAMES_BYTES, isArtNameId), shownNames = cleanNames(o.shownNames, ART_NAMES_BYTES, isArtNameId);
+    // the names a recipe's rule chose, said since later that night: none where a page does not say them
+    const ruledNames = cleanNames(o.ruledNames, ART_RULED_BYTES, isArtNameId);
     const shownTargets = cleanNames(o.shownTargets, ART_TARGETS_BYTES);
     const keys = typeof o.keys === "boolean" ? o.keys : targets !== "plain";
     // the style and the title, said since that night: as the board, the project's own; the foot's
     // size, said since later that night: the first
     const style = one(ART_STYLES, o.style) ?? "board";
-    return { w, h, scheme, theme, background, labels, namesFrom, hiddenNames, shownNames, edges, notes: o.notes, targets, shownTargets, keys, selection: o.selection, source: o.source === true, style, title: cleanTitle(o.title), subtitle: cleanTitle(o.subtitle), titleSize: cleanTitleSize(o.titleSize), footSize: cleanFootSize(o.footSize), border: o.border === true, region: [...r] };
+    return { w, h, scheme, theme, background, labels, namesFrom, hiddenNames, shownNames, ruledNames, edges, notes: o.notes, targets, shownTargets, keys, selection: o.selection, source: o.source === true, style, title: cleanTitle(o.title), subtitle: cleanTitle(o.subtitle), titleSize: cleanTitleSize(o.titleSize), footSize: cleanFootSize(o.footSize), border: o.border === true, region: [...r] };
 }
 /** The legend's schemes (CanvasSpec, "Colour schemes"). */
 export const SCHEMES = ["kind", "status"];

package/dist/shared/declfind.js

@@ -0,0 +1,95 @@
+// A declaration by the name someone gives (the agents' API, server/agent.ts; the artwork command,
+// server/artcmd.ts): the graph's own name; else the declaration a name it folds is folded into — a
+// declaration Lean generated from a command, or a constructor, recursor, field, equation lemma of
+// one — else, where none is, the names likely meant.
+import { search } from "./search.js";
+/** the last components of names Lean generates beside a declaration (extractor/Extract.lean,
+ *  `generatedSuffixes`, and the like) */
+export const GENERATED_LAST = /^(?:rec|recOn|casesOn|noConfusion|noConfusionType|ctorElim|ctorElimType|below|brecOn|binductionOn|ibelow|ctorIdx|toCtorIdx|ofNat|ofNat_ctorIdx|sizeOf_spec|injEq|inj|eq_def|induct|mutual_induct|fun_cases|induct_unfolding|ext_iff|congr_simp|mk|elim|(?:eq|match|proof)_\d+|_.*)$/;
+/** The edit distance between two short strings, or `most + 1` once it is more than `most`. */
+export function editDistance(a, b, most) {
+    if (Math.abs(a.length - b.length) > most)
+        return most + 1;
+    let prev = Array.from({ length: b.length + 1 }, (_, j) => j);
+    for (let i = 1; i <= a.length; i++) {
+        const row = [i];
+        let best = i;
+        for (let j = 1; j <= b.length; j++) {
+            row[j] = Math.min(prev[j] + 1, row[j - 1] + 1, prev[j - 1] + (a[i - 1] === b[j - 1] ? 0 : 1));
+            best = Math.min(best, row[j]);
+        }
+        if (best > most)
+            return most + 1;
+        prev = row;
+    }
+    return Math.min(prev[b.length], most + 1);
+}
+/** The declaration a name the graph has no node for is folded into: a declaration Lean generated
+ *  from a command (ViewNode.also), or a constructor, recursor, field, equation lemma… of a
+ *  declaration or of one so generated, which is a name one component below it. A name one
+ *  component below a declaration that is a typo or two away from a declaration beside it is
+ *  taken for that typo, not for something folded, unless its last component is one Lean
+ *  generates. */
+export function foldedAt(g, name) {
+    const direct = g.foldedInto.get(name);
+    if (direct !== undefined)
+        return direct;
+    const dot = name.lastIndexOf(".");
+    if (dot <= 0)
+        return undefined;
+    const head = name.slice(0, dot), last = name.slice(dot + 1);
+    const at = g.byName.get(head) ?? g.foldedInto.get(head);
+    if (at === undefined || !last)
+        return undefined;
+    if (!GENERATED_LAST.test(last)) {
+        const most = last.length < 5 ? 1 : 2;
+        const near = (n) => n.length > head.length + 1 && n.startsWith(head + ".") && !n.includes(".", head.length + 1) && editDistance(n.slice(head.length + 1).toLowerCase(), last.toLowerCase(), most) <= most;
+        for (const n of g.nodes)
+            if (near(n.name))
+                return undefined;
+        for (const n of g.foldedInto.keys())
+            if (near(n))
+                return undefined;
+    }
+    return at;
+}
+/** Up to five names like `name`: the same name in another case; then the same last component,
+ *  or one a typo or two away, in the same namespace first; then what the search finds. */
+export function guessNames(g, index, name) {
+    const dot = name.lastIndexOf(".");
+    const last = name.slice(dot + 1).toLowerCase();
+    const ns = dot < 0 ? "" : name.slice(0, dot);
+    const scored = new Map();
+    const offer = (n, score) => {
+        if ((scored.get(n) ?? Infinity) > score)
+            scored.set(n, score);
+    };
+    const lower = name.toLowerCase();
+    const most = last.length < 5 ? 1 : 2;
+    // the graph's declarations, and the names Lean generated from a command that they fold
+    for (const name of [...g.nodes.map((n) => n.name), ...g.foldedInto.keys()]) {
+        if (name.toLowerCase() === lower)
+            offer(name, -1);
+        const k = name.lastIndexOf(".");
+        const d = editDistance(name.slice(k + 1).toLowerCase(), last, most);
+        if (d <= most)
+            offer(name, 2 * d + (name.slice(0, Math.max(0, k)) === ns ? 0 : 1));
+    }
+    let rank = 0;
+    for (const q of [name.slice(dot + 1), name.replace(/\./g, " ")]) {
+        if (q.trim().length < 2)
+            continue;
+        const f = search(index, q);
+        for (const h of [...f.hits.name, ...f.hits.statement].slice(0, 10))
+            offer(g.nodes[h.i].name, 10 + rank++);
+    }
+    return [...scored]
+        .sort((a, b) => a[1] - b[1] || a[0].length - b[0].length || (a[0] < b[0] ? -1 : 1))
+        .slice(0, 5)
+        .map(([n]) => n);
+}
+/** The declaration `name` names, its own or the one it is folded into; undefined where none is. */
+export function declAt(g, name) {
+    const n = name.trim();
+    return g.byName.get(n) ?? foldedAt(g, n);
+}

package/dist/shared/lostfound.js

@@ -64,6 +64,7 @@ export function lostEntries(d, views, has, known = (n) => n.includes("."), pinWh
                 kind: "opinion",
                 name,
                 ...who(o),
+                ...(o.recordedBy ? { recordedBy: o.recordedBy } : {}),
                 verdict: o.verdict,
                 ...(o.comment ? { comment: o.comment } : {}),
                 ...(was.length ? { aliases: was.map((n) => lostKey.opinion(name, n, o.at)) } : {}),

package/dist/shared/pastgraph.js

@@ -21,12 +21,12 @@ export const PAST_GHOST = 1;
 export const PAST_CHANGED = 4;
 /** renamed since: shown under its name then */
 export const PAST_RENAMED = 8;
-/** The git source of a past build: the project's source, the build's own commit; none where the
- *  build's commit is not known, or only guessed. */
-function gitThen(now, commit) {
+/** The git commit of a past build; none where it is not known, or only guessed. Its source is the
+ *  project's, which the page has now (web/src/main.ts, GET /api/git). */
+function gitThen(commit) {
     if (!commit || commit.guessed)
         return { git: undefined };
-    return { git: { source: now?.source ?? null, commit: commit.hash, branch: commit.branch, ...(commit.dirty ? { dirty: true } : {}) } };
+    return { git: { source: null, commit: commit.hash, branch: commit.branch, ...(commit.dirty ? { dirty: true } : {}) } };
 }
 /** The past graph of snapshot `snap` (its declarations and its edges, as /graph's parts give them),
  *  marked by `diff` (from it to the latest), with the project's description of `now`. */
@@ -40,8 +40,8 @@ export function pastGraph(snap, edges, now, diff) {
     const meta = {
         schema: 1,
         layoutVersion: now.meta.layoutVersion,
-        // the commit of that build, where it is known; the source is the project's now
-        project: { ...now.meta.project, extractedAt: snap.snapshot.at, ...gitThen(now.meta.project.git, snap.snapshot.commit) },
+        // the commit of that build, where it is known
+        project: { ...now.meta.project, extractedAt: snap.snapshot.at, ...gitThen(snap.snapshot.commit) },
         modules: snap.modules.map((m) => ({ name: m.name, file: null, imports: m.imports })),
         nodes,
         projectCount: P,

package/dist/shared/review.js

@@ -40,6 +40,7 @@
 // Declarations are keyed by name, and a name can be anything Lean allows: `toString`,
 // `constructor`, even `__proto__`. Every object keyed by names here has no prototype (`byName`),
 // is read with Object.hasOwn, and is never spread or assigned into a plain object.
+import { validName } from "./collab.js";
 import { applyLibrary, invalidLibrary, isLibraryOp, libraryEventOf, libraryFromJson, libraryNoChange, readLibraryEvent, renamePerson } from "./library.js";
 import { applyMove, moveIsIdle, readMove } from "./moves.js";
 export const DEFAULT_TRUSTED = ["Batteries", "Init", "Lean", "Mathlib", "Std"];
@@ -102,6 +103,19 @@ export function invalid(r) {
         return "agent";
     if (o.person !== undefined && (!validPersonId(o.person) || o.agent))
         return "person";
+    // an opinion recorded for someone else (ReviewSpec decision 8): a person's, for another person
+    if (o.for !== undefined || o.forPerson !== undefined) {
+        if (o.op !== "opinion")
+            return "only an opinion is recorded for someone else";
+        if (o.agent)
+            return "an agent records for no one";
+        if (typeof o.for !== "string" || !validName(o.for.trim()))
+            return "for";
+        if (o.forPerson !== undefined && !validPersonId(o.forPerson))
+            return "forPerson";
+        if (o.for.trim() === o.by.trim() || (o.forPerson !== undefined && o.forPerson === o.person))
+            return "an opinion of one's own is recorded as one's own";
+    }
     switch (o.op) {
         case "opinion":
             if (o.verdict !== "approve" && o.verdict !== "comment")
@@ -153,6 +167,12 @@ export function eventOf(d, r, toolchain, now) {
     switch (r.op) {
         case "opinion": {
             const e = { op: "opinion", name: r.name, by, ...person, verdict: r.verdict, at: now, toolchain };
+            // recorded for someone else (ReviewSpec decision 8)
+            if (r.for?.trim()) {
+                e.for = r.for.trim();
+                if (r.forPerson)
+                    e.forPerson = r.forPerson;
+            }
             if (r.comment?.trim())
                 e.comment = r.comment.trim();
             if (r.agent)
@@ -160,7 +180,7 @@ export function eventOf(d, r, toolchain, now) {
             // the text matters only to an opinion that can go stale, one bound to a version
             if (r.hash) {
                 e.hash = r.hash;
-                const was = (Object.hasOwn(d.opinions, r.name) ? d.opinions[r.name] : []).findLast((p) => author(p) === author(e));
+                const was = (Object.hasOwn(d.opinions, r.name) ? d.opinions[r.name] : []).findLast((p) => author(p) === voice(e));
                 const same = was?.hash === r.hash ? judgedOn(d, r.name, was) : null;
                 if (r.text !== undefined && !(same?.of === "source" && same.text === r.text))
                     e.text = r.text;
@@ -212,8 +232,8 @@ export function applyEvent(d, e) {
         case "name":
             return;
         case "opinion": {
-            const { op: _op, name, ...o } = e;
-            (Object.hasOwn(d.opinions, name) ? d.opinions[name] : (d.opinions[name] = [])).push(o);
+            const { op: _op, name, for: forName, forPerson, ...o } = e;
+            (Object.hasOwn(d.opinions, name) ? d.opinions[name] : (d.opinions[name] = [])).push(forName === undefined ? o : recordedFor(d, o, forName, forPerson));
             return;
         }
         case "target":
@@ -256,15 +276,27 @@ function named(d, id, name) {
     if (p?.name === name)
         return;
     if (!p) {
-        d.people[id] = { name, was: [] };
+        // first seen after opinions were recorded for them (decision 8): those show under this name,
+        // the names they were written under kept, so that a quote of one still finds it
+        const was = new Set();
+        for (const ops of Object.values(d.opinions))
+            for (const o of ops)
+                if (o.person === id && o.by !== name) {
+                    was.add(o.by);
+                    o.by = name;
+                }
+        d.people[id] = { name, was: [...was] };
         return;
     }
     p.was = [...p.was.filter((n) => n !== p.name && n !== name), p.name];
     p.name = name;
     for (const ops of Object.values(d.opinions))
-        for (const o of ops)
+        for (const o of ops) {
             if (o.person === id)
                 o.by = name;
+            if (o.recordedBy?.person === id)
+                o.recordedBy.by = name;
+        }
     for (const t of Object.values(d.targets))
         if (t.person === id)
             t.by = name;
@@ -351,6 +383,20 @@ export function readEvent(raw, agentLog, personLog = null) {
             }
             if (e.text !== undefined && e.statement !== undefined)
                 return "a text and a statement";
+            // recorded for someone else (ReviewSpec decision 8): a person's line, for another person
+            if (o.for !== undefined || o.forPerson !== undefined) {
+                if (agentLog)
+                    return "an agent's opinion recorded for someone else";
+                if (typeof o.for !== "string" || !validName(o.for))
+                    return "for";
+                if (o.forPerson !== undefined && !validPersonId(o.forPerson))
+                    return "forPerson";
+                if (o.for === by || (o.forPerson !== undefined && o.forPerson === personLog))
+                    return "an opinion recorded for its own writer";
+                e.for = o.for;
+                if (o.forPerson !== undefined)
+                    e.forPerson = o.forPerson;
+            }
             if (agentLog)
                 e.agent = true;
             return e;
@@ -503,6 +549,17 @@ export function problemsText(ps) {
 function author(o) {
     return o.person ? `link ${o.person}` : (o.agent ? "agent " : "person ") + o.by;
 }
+/** Whose an opinion line is: theirs it was recorded for (ReviewSpec decision 8), else its writer's. */
+function voice(e) {
+    return e.for === undefined ? author(e) : author({ by: e.for, verdict: e.verdict, at: e.at, ...(e.forPerson ? { person: e.forPerson } : {}) });
+}
+/** An opinion recorded for someone else (ReviewSpec decision 8), as the review holds it: theirs —
+ *  under their latest name where they are invited — saying who recorded it. */
+function recordedFor(d, o, forName, forPerson) {
+    const { by, person, ...rest } = o;
+    const name = forPerson && Object.hasOwn(d.people, forPerson) ? d.people[forPerson].name : forName;
+    return { ...rest, by: name, ...(forPerson ? { person: forPerson } : {}), recordedBy: { by, ...(person ? { person } : {}) } };
+}
 /** Each author's latest opinion on a declaration, people's or agents': a new one replaces their
  *  earlier one. */
 function latest(d, name, agents) {

package/dist/shared/timeline.js

@@ -15,6 +15,11 @@ import { SITE_BODY, SITE_STMT } from "./graph.js";
 import { byName } from "./review.js";
 /** at most this many names are listed in one event; the counts stay exact */
 export const NAMES_LISTED = 100;
+/** An event as a read-only reader and an agent are told it (UpdateSpec decision 11): a version set
+ *  aside without why (what this machine and its servers said of it). */
+export function withoutReasons(e) {
+    return e.kind === "tool" && e.setAside ? { ...e, setAside: { version: e.setAside.version } } : e;
+}
 /** The graph as the TCB needs it: names, content hashes, statement and body edges. */
 export class TcbIndex {
     names;