virtual-code-owners 9.0.0 → 9.1.1

package/README.md

@@ -210,9 +210,8 @@ user/team names but doesn't verify their existence in the project.
   (unless they're in a _section_ that has default owners `[sales related] @ch/sales`
   in which case the rule inherits the default owners of that section)
 - valid sections headings comply with the syntax described over at [GitLab](https://docs.gitlab.com/ee/user/project/codeowners/reference.html#sections)
-  > different from GitLab's syntax the line `[bla @group` is not interpreted
-  > as a rule, but as an erroneous section heading. This behaviour might change
-  > to be the same as GitLab's in future releases without a major version bump.
+  > same as GitLab's syntax the line `[bla @group` is interpreted
+  > as a rule, and not as an erroneous section heading.
 
 ### Does virtual-code-owners support GitLab style sections?
 

package/dist/utensils.js

@@ -5,3 +5,24 @@ export function isEmailIshUsername(pUsername) {
 		pUsername.includes("@")
 	);
 }
+export function bracketsMatch(pString) {
+	const lStringWithoutComment = stripComment(pString);
+	let lBalanceCounter = 0;
+	for (const lChar of lStringWithoutComment) {
+		if (lChar === "[") {
+			lBalanceCounter++;
+		} else if (lChar === "]") {
+			lBalanceCounter--;
+		}
+		if (lBalanceCounter < 0) {
+			return false;
+		}
+	}
+	return lBalanceCounter === 0;
+}
+function stripComment(pString) {
+	const lCommentStartPosition = pString.indexOf("#");
+	return lCommentStartPosition === -1
+		? pString
+		: pString.slice(0, lCommentStartPosition);
+}

package/dist/version.js

@@ -1 +1 @@
-export const VERSION = "9.0.0";
+export const VERSION = "9.1.1";

package/dist/virtual-code-owners/parse.js

@@ -1,4 +1,4 @@
-import { isEmailIshUsername } from "../utensils.js";
+import { bracketsMatch, isEmailIshUsername } from "../utensils.js";
 let STATE = {
 	currentSection: "",
 	inheritedUsers: [],
@@ -25,7 +25,10 @@ function parseLine(pUntreatedLine, pTeamMap, pLineNo) {
 	if (lTrimmedLine === "") {
 		return { type: "empty", line: pLineNo, raw: pUntreatedLine };
 	}
-	if (lTrimmedLine.startsWith("[") || lTrimmedLine.startsWith("^[")) {
+	if (
+		(lTrimmedLine.startsWith("[") || lTrimmedLine.startsWith("^[")) &&
+		bracketsMatch(lTrimmedLine)
+	) {
 		return parseSection(pUntreatedLine, pLineNo, pTeamMap);
 	}
 	return parseRule(pUntreatedLine, pLineNo, pTeamMap);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "virtual-code-owners",
-	"version": "9.0.0",
+	"version": "9.1.1",
 	"description": "CODEOWNERS with teams for teams that can't use GitHub teams",
 	"type": "module",
 	"bin": {
@@ -26,7 +26,7 @@
 		"url": "https://github.com/sverweij/virtual-code-owners/issues"
 	},
 	"dependencies": {
-		"yaml": "^2.8.1"
+		"yaml": "2.8.1"
 	},
 	"engines": {
 		"node": "^20.12||^22||>=24"