virtual-code-owners 8.2.7 → 9.1.0

package/README.md

@@ -210,9 +210,8 @@ user/team names but doesn't verify their existence in the project.
   (unless they're in a _section_ that has default owners `[sales related] @ch/sales`
   in which case the rule inherits the default owners of that section)
 - valid sections headings comply with the syntax described over at [GitLab](https://docs.gitlab.com/ee/user/project/codeowners/reference.html#sections)
-  > different from GitLab's syntax the line `[bla @group` is not interpreted
-  > as a rule, but as an erroneous section heading. This behaviour might change
-  > to be the same as GitLab's in future releases without a major version bump.
+  > same as GitLab's syntax the line `[bla @group` is interpreted
+  > as a rule, and not as an erroneous section heading.
 
 ### Does virtual-code-owners support GitLab style sections?
 

package/dist/team-map/read.js

@@ -1,6 +1,7 @@
 import { readFileSync } from "node:fs";
 import { parse as parseYaml } from "yaml";
 import { EOL } from "node:os";
+const MAX_TEAM_NAME_LENGTH = 80;
 export default function readTeamMap(pVirtualTeamsFileName) {
 	const lVirtualTeamsAsAString = readFileSync(pVirtualTeamsFileName, {
 		encoding: "utf-8",
@@ -45,14 +46,20 @@ function validateTeamMap(pCandidateTeamMap) {
 }
 function validateTeamName(pTeamNameCandidate) {
 	if (typeof pTeamNameCandidate !== "string") {
-		return [false, "not a string"];
+		return [false, `${pTeamNameCandidate} (is not a string)`];
 	}
 	if (pTeamNameCandidate === "") {
-		return [false, "'' (empty string)"];
+		return [false, "'' (is an empty string)"];
 	}
 	if (pTeamNameCandidate.includes(" ")) {
 		return [false, `'${pTeamNameCandidate}' (contains spaces)`];
 	}
+	if (pTeamNameCandidate.length > MAX_TEAM_NAME_LENGTH) {
+		return [
+			false,
+			`'${pTeamNameCandidate}' (is too long - keep it <= ${MAX_TEAM_NAME_LENGTH} characters)`,
+		];
+	}
 	return [true];
 }
 function validateTeam(pCandidateTeam, pTeamName) {

package/dist/version.js

@@ -1 +1 @@
-export const VERSION = "8.2.7";
+export const VERSION = "9.1.0";

package/dist/virtual-code-owners/parse.js

@@ -25,7 +25,10 @@ function parseLine(pUntreatedLine, pTeamMap, pLineNo) {
 	if (lTrimmedLine === "") {
 		return { type: "empty", line: pLineNo, raw: pUntreatedLine };
 	}
-	if (lTrimmedLine.startsWith("[") || lTrimmedLine.startsWith("^[")) {
+	if (
+		(lTrimmedLine.startsWith("[") || lTrimmedLine.startsWith("^[")) &&
+		lTrimmedLine.includes("]")
+	) {
 		return parseSection(pUntreatedLine, pLineNo, pTeamMap);
 	}
 	return parseRule(pUntreatedLine, pLineNo, pTeamMap);
@@ -107,7 +110,7 @@ function getUserNameType(pUserName, pBareName, pTeamMap) {
 		return "e-mail-address";
 	}
 	if (pUserName.startsWith("@")) {
-		if (pTeamMap.hasOwnProperty(pBareName)) {
+		if (Object.hasOwn(pTeamMap, pBareName)) {
 			return "virtual-team-name";
 		}
 		return "other-user-or-team";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "virtual-code-owners",
-	"version": "8.2.7",
+	"version": "9.1.0",
 	"description": "CODEOWNERS with teams for teams that can't use GitHub teams",
 	"type": "module",
 	"bin": {
@@ -26,10 +26,10 @@
 		"url": "https://github.com/sverweij/virtual-code-owners/issues"
 	},
 	"dependencies": {
-		"yaml": "^2.8.0"
+		"yaml": "^2.8.1"
 	},
 	"engines": {
-		"node": "^18.11.0||>=20.0.0"
+		"node": "^20.12||^22||>=24"
 	},
 	"scripts": {
 		"test": "echo for test, build and static analysis scripts: see the github repository"