virtua 0.48.1 → 0.48.3

package/lib/solid/index.jsx

@@ -807,26 +807,11 @@ const createScroller = (store, isHorizontal) => {
         }
     });
     return {
-        $observe(viewport) {
+        $observe(_, viewport) {
             viewportElement = viewport;
-            const clean = store.$subscribe(UPDATE_SIZE_EVENT, () => {
-                const viewportSize = store.$getViewportSize();
-                if (viewportSize) {
-                    const prev = viewport[scrollOffsetKey];
-                    // Detect overflowed direction after the initial viewport measurement
-                    const dummy = getCurrentDocument(viewport).createElement("div");
-                    dummy.style.cssText = `visibility:hidden;min-${isHorizontal ? "width" : "height"}:${
-                    // Set larger value than the viewportSize to force overflow. And the value must take subpixels into account.
-                    viewportSize + 9}px`;
-                    viewport.appendChild(dummy);
-                    viewport[scrollOffsetKey] = 1;
-                    // It can be positive under some specific situations even if negative mode, so we use `<` for now.
-                    isNegative = viewport[scrollOffsetKey] < 1;
-                    viewport.removeChild(dummy);
-                    viewport[scrollOffsetKey] = prev;
-                    clean();
-                }
-            });
+            if (isHorizontal) {
+                isNegative = getComputedStyle(viewport).direction === "rtl";
+            }
             scrollObserver = createScrollObserver(store, viewport, isHorizontal, () => normalizeScrollOffset(viewport[scrollOffsetKey], isNegative), (jump, shift, isMomentumScrolling) => {
                 // If we update scroll position while touching on iOS, the position will be reverted.
                 // However iOS WebKit fires touch events only once at the beginning of momentum scrolling.
@@ -1021,9 +1006,9 @@ const createGridScroller = (rowStore, colStore) => {
     const rowScroller = createScroller(rowStore, false);
     const colScroller = createScroller(colStore, true);
     return {
-        $observe(viewportElement) {
-            rowScroller.$observe(viewportElement);
-            colScroller.$observe(viewportElement);
+        $observe(container, viewport) {
+            rowScroller.$observe(container, viewport);
+            colScroller.$observe(container, viewport);
         },
         $dispose() {
             rowScroller.$dispose();
@@ -1388,9 +1373,10 @@ const Virtualizer = (props) => {
                 scrollBy: scroller.$scrollBy,
             });
         }
-        const scrollable = props.scrollRef || containerRef.parentElement;
+        const container = containerRef;
+        const scrollable = props.scrollRef || container.parentElement;
         resizer.$observeRoot(scrollable);
-        scroller.$observe(scrollable);
+        scroller.$observe(container, scrollable);
         onCleanup(() => {
             if (props.ref) {
                 props.ref();
@@ -1415,7 +1401,6 @@ const Virtualizer = (props) => {
                 store.$update(ACTION_ITEMS_LENGTH_CHANGE, [count, props.shift]);
             }
         });
-        const pushKey = !horizontal && isNegative() ? "unshift" : "push";
         const items = [];
         const indexes = [];
         if (props.keepMounted) {
@@ -1424,14 +1409,14 @@ const Virtualizer = (props) => {
                 mounted.add(i);
             }
             sort([...mounted]).forEach((index) => {
-                items[pushKey](props.data[index]);
-                indexes[pushKey](index);
+                items.push(props.data[index]);
+                indexes.push(index);
             });
         }
         else {
             for (let [i, j] = range(); i <= j; i++) {
-                items[pushKey](props.data[i]);
-                indexes[pushKey](i);
+                items.push(props.data[i]);
+                indexes.push(i);
             }
         }
         return { _items: items, _indexes: indexes };
@@ -1580,10 +1565,9 @@ const WindowVirtualizer = (props) => {
                 store.$update(ACTION_ITEMS_LENGTH_CHANGE, [count, props.shift]);
             }
         });
-        const pushKey = !horizontal && isNegative() ? "unshift" : "push";
         const items = [];
         for (let [i, j] = range(); i <= j; i++) {
-            items[pushKey](props.data[i]);
+            items.push(props.data[i]);
         }
         return items;
     });