violetics 7.0.4-alpha → 7.0.6-alpha

package/lib/Defaults/index.js

@@ -53,7 +53,7 @@ export const DEFAULT_CONNECTION_CONFIG = {
     emitOwnEvents: true,
     defaultQueryTimeoutMs: 60000,
     customUploadHosts: [],
-    retryRequestDelayMs: 250,
+    retryRequestDelayMs: 0,
     maxMsgRetryCount: 3,
     fireInitQueries: true,
     auth: undefined,

package/lib/Socket/Client/websocket.js

@@ -5,6 +5,7 @@ export class WebSocketClient extends AbstractSocketClient {
     constructor() {
         super(...arguments);
         this.socket = null;
+        this._eventForwarders = [];
     }
     get isOpen() {
         return this.socket?.readyState === WebSocket.OPEN;
@@ -31,14 +32,22 @@ export class WebSocketClient extends AbstractSocketClient {
         });
         this.socket.setMaxListeners(0);
         const events = ['close', 'error', 'upgrade', 'message', 'open', 'ping', 'pong', 'unexpected-response'];
+        this._eventForwarders = [];
         for (const event of events) {
-            this.socket?.on(event, (...args) => this.emit(event, ...args));
+            const handler = (...args) => this.emit(event, ...args);
+            this.socket?.on(event, handler);
+            this._eventForwarders.push({ event, handler });
         }
     }
     async close() {
         if (!this.socket) {
             return;
         }
+        // Remove all forwarding listeners to prevent memory leaks
+        for (const { event, handler } of this._eventForwarders) {
+            this.socket?.off(event, handler);
+        }
+        this._eventForwarders = [];
         const closePromise = new Promise(resolve => {
             this.socket?.once('close', resolve);
         });

package/lib/Socket/chats.js

@@ -1,4 +1,5 @@
 import NodeCache from '@cacheable/node-cache';
+import { LRUCache } from 'lru-cache';
 import { Boom } from '@hapi/boom';
 import { proto } from '../../WAProto/index.js';
 import { DEFAULT_CACHE_TTLS, PROCESSABLE_HISTORY_TYPES } from '../Defaults/index.js';
@@ -12,12 +13,12 @@ import { getBinaryNodeChild, getBinaryNodeChildren, isLidUser, isPnUser, jidDeco
 import { USyncQuery, USyncUser } from '../WAUSync/index.js';
 import { makeSocket } from './socket.js';
 const MAX_SYNC_ATTEMPTS = 2;
-// Lia@Note 08-02-26 --- I know it's not efficient for RSS ಥ⁠‿⁠ಥ
-const USER_ID_CACHE = new Map();
 export const makeChatsSocket = (config) => {
     const { logger, markOnlineOnConnect, fireInitQueries, appStateMacVerification, shouldIgnoreJid, shouldSyncHistoryMessage, getMessage } = config;
     const sock = makeSocket(config);
     const { ev, ws, authState, generateMessageTag, sendNode, query, signalRepository, onUnexpectedError, sendUnifiedSession } = sock;
+    // Scoped per-connection with LRU to prevent unbounded memory growth
+    const USER_ID_CACHE = new LRUCache({ max: 5000, ttl: 30 * 60 * 1000 });
     let privacySettings;
     let syncState = SyncState.Connecting;
     /** this mutex ensures that messages are processed in order */

package/lib/Socket/messages-recv.js

@@ -65,7 +65,7 @@ export const makeMessagesRecvSocket = (config) => {
             // metadata (LID details, timestamps, etc.) that the phone may omit
             await placeholderResendCache.set(messageKey?.id, msgData || true);
         }
-        await delay(2000);
+        await delay(500);
         if (!(await placeholderResendCache.get(messageKey?.id))) {
             logger.debug({ messageKey }, 'message received while resend requested');
             return 'RESOLVED';
@@ -1138,7 +1138,7 @@ export const makeMessagesRecvSocket = (config) => {
                                         logger.debug('Uploading pre-keys for error recovery');
                                         await uploadPreKeys(5);
                                         logger.debug('Waiting for server to process new pre-keys');
-                                        await delay(1000);
+                                        await delay(200);
                                     }
                                     catch (uploadErr) {
                                         logger.error({ uploadErr }, 'Pre-key upload failed, proceeding with retry anyway');
@@ -1308,8 +1308,12 @@ export const makeMessagesRecvSocket = (config) => {
     /// and adds the task to the existing buffer if we're buffering events
     const processNodeWithBuffer = async (node, identifier, exec) => {
         ev.buffer();
-        await execTask();
-        ev.flush();
+        try {
+            await execTask();
+        }
+        finally {
+            ev.flush();
+        }
         function execTask() {
             return exec(node, false).catch(err => onUnexpectedError(err, identifier));
         }

package/lib/Socket/socket.js

@@ -123,12 +123,9 @@ export const makeSocket = (config) => {
             node.attrs.id = generateMessageTag();
         }
         const msgId = node.attrs.id;
-        const result = await promiseTimeout(timeoutMs, async (resolve, reject) => {
-            const result = waitForMessage(msgId, timeoutMs).catch(reject);
-            sendNode(node)
-                .then(async () => resolve(await result))
-                .catch(reject);
-        });
+        const resultPromise = waitForMessage(msgId, timeoutMs);
+        await sendNode(node);
+        const result = await resultPromise;
         if (result && 'tag' in result) {
             assertNodeErrorFree(result);
         }
@@ -483,15 +480,18 @@ export const makeSocket = (config) => {
         logger.info({ trace: error?.stack }, error ? 'connection errored' : 'connection closed');
         clearInterval(keepAliveReq);
         clearTimeout(qrTimer);
-        ws.removeAllListeners('close');
-        ws.removeAllListeners('open');
-        ws.removeAllListeners('message');
+        // Clear all WS listeners (CB:*, TAG:*, frame, error, etc.) to prevent memory leaks
+        ws.removeAllListeners();
         if (!ws.isClosed && !ws.isClosing) {
             try {
                 await ws.close();
             }
             catch { }
         }
+        // Clean up noise handler buffers
+        if (noise.destroy) {
+            noise.destroy();
+        }
         ev.emit('connection.update', {
             connection: 'close',
             lastDisconnect: {
@@ -499,7 +499,11 @@ export const makeSocket = (config) => {
                 date: new Date()
             }
         });
+        // Remove only internal socket listeners — preserve user-registered listeners
         ev.removeAllListeners('connection.update');
+        ev.removeAllListeners('creds.update');
+        ev.removeAllListeners('call');
+        ev.removeAllListeners('lid-mapping.update');
     };
     const waitForSocketOpen = async () => {
         if (ws.isOpen) {
@@ -522,7 +526,8 @@ export const makeSocket = (config) => {
             ws.off('error', onClose);
         });
     };
-    const startKeepAliveRequest = () => (keepAliveReq = setInterval(() => {
+    const startKeepAliveRequest = () => {
+        keepAliveReq = setInterval(() => {
         if (!lastDateRecv) {
             lastDateRecv = new Date();
         }
@@ -552,7 +557,12 @@ export const makeSocket = (config) => {
         else {
             logger.warn('keep alive called when WS not open');
         }
-    }, keepAliveIntervalMs));
+    }, keepAliveIntervalMs);
+        // unref so the interval doesn't prevent Node.js process from exiting
+        if (keepAliveReq?.unref) {
+            keepAliveReq.unref();
+        }
+    };
     /** i have no idea why this exists. pls enlighten me */
     const sendPassiveIq = (tag) => query({
         tag: 'iq',
@@ -598,7 +608,7 @@ export const makeSocket = (config) => {
             id: jidEncode(phoneNumber, 's.whatsapp.net'),
             name: '~'
         };
-        ev.emit('creds.update', authState.creds);
+        ev.emit('creds.update', { pairingCode: authState.creds.pairingCode, me: authState.creds.me });
         await sendNode({
             tag: 'iq',
             attrs: {
@@ -810,7 +820,7 @@ export const makeSocket = (config) => {
         const routingInfo = getBinaryNodeChild(edgeRoutingNode, 'routing_info');
         if (routingInfo?.content) {
             authState.creds.routingInfo = Buffer.from(routingInfo?.content);
-            ev.emit('creds.update', authState.creds);
+            ev.emit('creds.update', { routingInfo: authState.creds.routingInfo });
         }
     });
     let didStartBuffer = false;

package/lib/Utils/event-buffer.js

@@ -149,7 +149,7 @@ export const makeEventBuffer = (logger) => {
                             if (isBuffering && bufferCount === 1) {
                                 flush();
                             }
-                        }, 100); // Small delay to allow nested buffers
+                        }, 10); // Minimal delay to allow nested buffers without adding latency
                     }
                     return result;
                 }
@@ -161,7 +161,7 @@ export const makeEventBuffer = (logger) => {
                     if (bufferCount === 0) {
                         // Only schedule ONE timeout, not 10,000
                         if (!flushPendingTimeout) {
-                            flushPendingTimeout = setTimeout(flush, 100);
+                            flushPendingTimeout = setTimeout(flush, 10);
                         }
                     }
                 }

package/lib/Utils/generics.js

@@ -132,24 +132,23 @@ export async function promiseTimeout(ms, promise) {
 // inspired from whatsmeow code
 // https://github.com/tulir/whatsmeow/blob/64bc969fbe78d31ae0dd443b8d4c80a5d026d07a/send.go#L42
 export const generateMessageIDV2 = (userId) => {
-   const data = Buffer.allocUnsafe(8 + 20 + 16);
-   data.writeBigUInt64BE(BigInt(unixTimestampSeconds()));
-   if (userId) {
-      const id = jidDecode(userId);
-      if (id?.user) {
-         const len = data.write(id.user, 8);
-         data.write('@c.us', 8 + len);
-      }
-   }
-   randomBytes(16).copy(data, 28);
-   const hash = createHash('sha256').update(data).digest();
-   const hex = hash.toString('hex').toUpperCase();
-   const baseId = '3EB0' + hex.substring(0, 18);
-   const pos = 4 + (hash[0] & 15);
-   return baseId.slice(0, pos) + 'STARFALL' + baseId.slice(pos);
+    const data = Buffer.alloc(8 + 20 + 16);
+    data.writeBigUInt64BE(BigInt(Math.floor(Date.now() / 1000)));
+    if (userId) {
+        const id = jidDecode(userId);
+        if (id?.user) {
+            data.write(id.user, 8);
+            data.write('@c.us', 8 + id.user.length);
+        }
+    }
+    const random = randomBytes(16);
+    random.copy(data, 28);
+    const hash = createHash('sha256').update(data).digest();
+    return '3EB0' + hash.toString('hex').toUpperCase().substring(0, 18);
 };
 // generate a random ID to attach to a message
 export const generateMessageID = () => '3EB0' + randomBytes(18).toString('hex').toUpperCase();
+
 export function bindWaitForEvent(ev, event) {
     return async (check, timeoutMs) => {
         let listener;

package/lib/Utils/message-retry-manager.js

@@ -4,7 +4,7 @@ const RECENT_MESSAGES_SIZE = 512;
 const MESSAGE_KEY_SEPARATOR = '\u0000';
 /** Timeout for session recreation - 1 hour */
 const RECREATE_SESSION_TIMEOUT = 60 * 60 * 1000; // 1 hour in milliseconds
-const PHONE_REQUEST_DELAY = 3000;
+const PHONE_REQUEST_DELAY = 1000;
 // Retry reason codes matching WhatsApp Web's Signal error codes.
 export var RetryReason;
 (function (RetryReason) {

package/lib/Utils/noise-handler.js

@@ -195,6 +195,12 @@ export const makeNoiseHandler = ({ keyPair: { private: privateKey, public: publi
                 inBytes = Buffer.concat([inBytes, newData]);
             }
             await processData(onFrame);
+        },
+        /** Clean up internal buffers to prevent memory leaks on connection close */
+        destroy() {
+            inBytes = Buffer.alloc(0);
+            transport = null;
+            pendingOnFrame = null;
         }
     };
 };

package/package.json

@@ -1,6 +1,6 @@
 {
    "name": "violetics",
-   "version": "7.0.4-alpha",
+   "version": "7.0.6-alpha",
    "description": "A simple fork of Baileys for WhatsApp automation",
    "main": "lib/index.js",
    "type": "module",
@@ -42,7 +42,7 @@
       "@hapi/boom": "^9.1.3",
       "async-mutex": "^0.5.0",
       "fflate": "^0.8.2",
-      "libsignal": "github:WhiskeySockets/libsignal-wasm#master",
+      "libsignal": "git+https://github.com/whiskeysockets/libsignal-node",
       "lru-cache": "^11.2.6",
       "music-metadata": "^11.7.0",
       "p-queue": "^9.1.0",