vinta-ai-workflows 0.7.0-alpha24 → 0.7.0-alpha25

package/CHANGELOG.md

@@ -393,6 +393,26 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ### Fixed
 
+- **`open-pr.sh` posts inline comments on macOS and reports why a comment
+  failed.** Four bugs in the `open-pr-from-context` script, all seen while
+  publishing a stacked plan from a Mac:
+  - Trimming trailing blank lines from `# Title`, `# Description` and
+    `# Comments` used a GNU-only `sed` idiom. BSD `sed` fails on it with
+    "unused label" and trims nothing. A portable `awk` helper does it now.
+  - A comment with lowercase `side: right` got "422 Validation Failed" from
+    GitHub, so failures looked random across files. The script now converts
+    `side` to upper case and falls back to `RIGHT` for any other value. The
+    `prs-context-comments` schema still only allows `LEFT` / `RIGHT`.
+  - The `gh api` call threw away its stderr, so a run of failed comments
+    gave no reason. The CLI's error now prints on one line above each
+    `FAILED` line, and the comment still counts toward exit `1`. The
+    `glab api` call for GitLab had the same problem and gets the same fix.
+  - Adding entries to an existing `## Publish log` section passed several
+    lines through `awk -v`, which BSD `awk` rejects ("newline in string").
+    The entries go through the environment now.
+
+  Projects that patched their own copy can re-sync with `vinta-sync-ai-tools`.
+
 - **`check-ai-models` no longer mistakes sibling models for snapshots of a
   cited id.** The id matcher used substring matching, so `claude-sonnet-5`
   matched `claude-sonnet-5-5` (hiding the newer Sonnet and Opus releases).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vinta-ai-workflows",
-  "version": "0.7.0-alpha24",
+  "version": "0.7.0-alpha25",
   "description": "Bootstrap AI tooling (AGENTS.md, skills, sub-agents) across Claude Code, Codex, Cursor, and VS Code + GitHub Copilot.",
   "type": "module",
   "bin": {

package/schemas/prs-context-comments.v1.schema.json

@@ -25,7 +25,7 @@
         "minimum": 1
       },
       "side": {
-        "description": "Which side of the diff the comment attaches to. `RIGHT` = post-change (default). `LEFT` = pre-change (rare; for comments on removed code).",
+        "description": "Which side of the diff the comment attaches to. `RIGHT` = post-change (default). `LEFT` = pre-change (rare; for comments on removed code). Write it in upper case. `open-pr.sh` also accepts lower case and sends `RIGHT` for any other value, but that is only tolerance in the script: this schema still rejects anything other than `LEFT` / `RIGHT`.",
         "type": "string",
         "enum": ["LEFT", "RIGHT"],
         "default": "RIGHT"

package/skills/vinta-derive-skills/resources/foundation-skills/open-pr-from-context/SKILL.md

@@ -47,7 +47,7 @@ Pass through whatever the user explicitly asked for; otherwise no flags.
 Read the script's stdout + exit code:
 
 - **Exit 0** — PR opened (or pre-existing detected); all comments posted. File rewritten to `status: published` + `pr_url`. Surface the URL to the user; you're done.
-- **Exit 1** — PR opened, but one or more inline comments failed. The script's stderr lists which `(file:line)` failed. Forward the failures verbatim. Most common cause: a force-push between branch push and now invalidated the line position — re-run after pushing.
+- **Exit 1** — PR opened, but one or more inline comments failed. The script's stderr lists which `(file:line)` failed, each one after a `gh error:` / `glab error:` line that holds the API's message (for example `422 Validation Failed`). Forward both verbatim. Most common cause: a force-push between branch push and now invalidated the line position — re-run after pushing.
 - **Exit 2** — Hard failure (file invalid, branch not pushed, CLI missing/unauthed, missing dependency). Forward the script's error message; do **not** improvise (don't push the branch, don't install CLIs, don't auth on the user's behalf).
 
 ## Inputs the script expects

package/skills/vinta-derive-skills/resources/foundation-skills/open-pr-from-context/scripts/open-pr.sh

@@ -97,6 +97,19 @@ if [[ "$STATUS" == "published" && -n "$PR_URL" && "$PR_URL" != "null" ]]; then
   exit 0
 fi
 
+# awk, not sed: BSD sed (macOS) can't parse the GNU idiom for this
+# (`:a;...;ba`) — it reports "unused label" and trims nothing.
+trim_trailing_blank_lines() {
+  awk '
+    { lines[NR] = $0 }
+    END {
+      last = 0
+      for (i = 1; i <= NR; i++) if (lines[i] ~ /[^[:space:]]/) last = i
+      for (i = 1; i <= last; i++) print lines[i]
+    }
+  '
+}
+
 # Body sections — split on `^# ` H1 headings.
 extract_section() {
   local heading="$1"
@@ -104,7 +117,7 @@ extract_section() {
     $0 ~ h { in_sec = 1; next }
     /^# / && in_sec { in_sec = 0 }
     in_sec { print }
-  ' | sed -e ':a;/./,$!d;/^$/{$d;ba;}'   # trim trailing blank lines
+  ' | trim_trailing_blank_lines
 }
 
 TITLE=$(extract_section "Title" | sed -e '/./,$!d')
@@ -237,6 +250,10 @@ FAILURES=0
 
 post_comment_gh() {
   local file="$1" start="$2" end="$3" side="$4" body="$5"
+  # The API only takes upper case; the schema says LEFT/RIGHT, but tolerate
+  # hand-written `side: right` rather than 422 on every comment.
+  side=$(printf '%s' "${side:-RIGHT}" | tr '[:lower:]' '[:upper:]')
+  [[ "$side" == "LEFT" || "$side" == "RIGHT" ]] || side="RIGHT"
   local repo commit
   repo=$(gh repo view --json nameWithOwner -q .nameWithOwner)
   commit=$(git rev-parse "origin/$BRANCH")
@@ -248,12 +265,16 @@ post_comment_gh() {
     -f "commit_id=$commit"
     -f "path=$file"
     -F "line=${end:-$start}"
-    -f "side=${side:-RIGHT}"
+    -f "side=$side"
   )
   if [[ -n "$end" && "$end" != "$start" && "$end" != "null" ]]; then
-    args+=( -F "start_line=$start" -f "start_side=${side:-RIGHT}" )
+    args+=( -F "start_line=$start" -f "start_side=$side" )
+  fi
+  local err
+  if ! err=$(gh "${args[@]}" 2>&1 >/dev/null); then
+    printf '    gh error: %s\n' "${err//$'\n'/ }" >&2
+    return 1
   fi
-  gh "${args[@]}" >/dev/null 2>&1
 }
 
 post_comment_glab() {
@@ -264,7 +285,8 @@ post_comment_glab() {
   base_sha=$(echo "$refs" | jq -r '.base_sha')
   head_sha=$(echo "$refs" | jq -r '.head_sha')
   start_sha=$(echo "$refs" | jq -r '.start_sha')
-  glab api --method POST \
+  local err
+  if ! err=$(glab api --method POST \
     "projects/:id/merge_requests/$PR_NUMBER/discussions" \
     -f "body=$body" \
     -f "position[base_sha]=$base_sha" \
@@ -273,7 +295,10 @@ post_comment_glab() {
     -f "position[position_type]=text" \
     -f "position[new_path]=$file" \
     -f "position[new_line]=${end:-$start}" \
-    >/dev/null 2>&1
+    2>&1 >/dev/null); then
+    printf '    glab error: %s\n' "${err//$'\n'/ }" >&2
+    return 1
+  fi
 }
 
 if [[ "$COMMENT_COUNT" -eq 0 ]]; then
@@ -329,7 +354,9 @@ if [[ $DRY_RUN -eq 0 ]]; then
 
   # If body already has a publish log, append entries to it; else add new section.
   if echo "$BODY" | grep -q '^## Publish log'; then
-    NEW_BODY=$(echo "$BODY" | awk -v entries="$(printf '%s\n' "${PUBLISH_LOG[@]}" | sed 's/^/- /')" '
+    # Entries go through the environment: BSD awk rejects a newline in a -v value.
+    NEW_BODY=$(echo "$BODY" | PUBLISH_ENTRIES="$(printf '%s\n' "${PUBLISH_LOG[@]}" | sed 's/^/- /')" awk '
+      BEGIN { entries = ENVIRON["PUBLISH_ENTRIES"] }
       /^## Publish log/ { in_log = 1; print; next }
       /^## / && in_log { in_log = 0; print entries; print; next }
       { print }

package/skills/vinta-derive-skills/resources/plan-execution/partials/pr-context.md

@@ -54,7 +54,7 @@ Two project-level signals decide the actual behavior:
    The script opens the PR (or detects an existing one), posts each inline comment, rewrites the file's frontmatter to `status: published` + populated `pr_url`, appends a publish log. Exit codes:
 
    - `0` — PR up, all comments (if any) posted. Capture `pr_url` for the user update.
-   - `1` — PR up, ≥1 comment failed. Surface the failed `(file:line)` list to the user; continue to the tracking step.
+   - `1` — PR up, ≥1 comment failed. Surface the failed `(file:line)` list to the user, with the `gh error:` / `glab error:` line the script printed above each one; continue to the tracking step.
    - `2` — Hard failure (deps missing, branch not pushed, CLI unauthed, file invalid). Surface the script's stderr; treat the phase as having no PR. The file stays `status: pending` so the user can re-run after fixing the gap.
 
    When policy = "branches only": **don't run the script.** File stays `status: pending`.