vinta-ai-workflows 0.7.0-alpha2 → 0.7.0-alpha21
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +1704 -3
- package/README.md +16 -0
- package/package.json +11 -9
- package/schemas/README.md +9 -2
- package/schemas/intervention.v1.schema.json +170 -0
- package/schemas/postmortem.v1.schema.json +268 -3
- package/schemas/prs-context-frontmatter.v1.schema.json +18 -7
- package/schemas/vinta-ai-workflows-config.v1.schema.json +12 -0
- package/schemas/workflow.v1.schema.json +388 -24
- package/skills/vinta-analyze-codebase/SKILL.md +1 -0
- package/skills/vinta-bootstrap-ai-tools/SKILL.md +18 -2
- package/skills/vinta-derive-skills/SKILL.md +5 -0
- package/skills/vinta-derive-skills/resources/foundation-skills/open-pr-from-context/scripts/open-pr.sh +0 -0
- package/skills/vinta-derive-skills/resources/foundation-skills/plan-feature/SKILL.md +100 -50
- package/skills/vinta-derive-skills/resources/foundation-skills/plan-feature/resources/ai-models.yaml +9 -10
- package/skills/vinta-derive-skills/resources/foundation-skills/prepare-worktree/SKILL.md +10 -2
- package/skills/vinta-derive-skills/resources/foundation-skills/prepare-worktree/scripts/claude-worktree-write-guard.py +0 -0
- package/skills/vinta-derive-skills/resources/foundation-skills/prepare-worktree/scripts/gen-claude-sandbox-settings.sh +0 -0
- package/skills/vinta-derive-skills/resources/foundation-skills/prepare-worktree/scripts/gen-compose-worktree-override.sh +0 -0
- package/skills/vinta-derive-skills/resources/foundation-skills/prepare-worktree/scripts/sandbox-run.sh +0 -0
- package/skills/vinta-derive-skills/resources/plan-execution/README.md +11 -0
- package/skills/vinta-derive-skills/resources/plan-execution/partials/commit-strategy/stacked.md +18 -0
- package/skills/vinta-derive-skills/resources/plan-execution/partials/dispatched-agent.md +31 -0
- package/skills/vinta-derive-skills/resources/plan-execution/partials/implementer-prompt.md +2 -0
- package/skills/vinta-derive-skills/resources/plan-execution/partials/parallel-lanes.md +10 -3
- package/skills/vinta-derive-skills/resources/plan-execution/partials/pr-context.md +3 -1
- package/skills/vinta-derive-skills/resources/plan-execution/shell/amend-plan-template.md +3 -0
- package/skills/vinta-derive-skills/resources/plan-execution/shell/implement-phase-template.md +3 -0
- package/skills/vinta-derive-skills/resources/plan-execution/shell/implement-plan-template.md +7 -3
- package/skills/vinta-derive-skills/resources/plan-execution/shell/integrate-phase-template.md +2 -1
- package/skills/vinta-derive-skills/resources/plan-execution/shell/review-phase-template.md +3 -0
- package/skills/vinta-derive-skills/resources/prs-context-template.md +5 -4
- package/skills/vinta-install-ai-tools-setup/SKILL.md +28 -1
- package/skills/vinta-install-ai-tools-setup/resources/setup-ai-tools.mjs +0 -0
- package/skills/vinta-sync-ai-tools/SKILL.md +2 -1
- package/skills/vinta-update-project-skills/SKILL.md +1 -0
package/CHANGELOG.md
CHANGED
|
@@ -7,11 +7,556 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
7
7
|
|
|
8
8
|
## [0.7.0] — YYYY-MM-DD
|
|
9
9
|
|
|
10
|
+
<!-- pre-release: 0.7.0-alpha20 on 2026-09-24 -->
|
|
11
|
+
<!-- pre-release: 0.7.0-alpha19 on 2026-09-19 -->
|
|
12
|
+
<!-- pre-release: 0.7.0-alpha18 on 2026-09-17 -->
|
|
13
|
+
<!-- pre-release: 0.7.0-alpha17 on 2026-09-17 -->
|
|
14
|
+
<!-- pre-release: 0.7.0-alpha16 on 2026-09-16 -->
|
|
15
|
+
<!-- pre-release: 0.7.0-alpha15 on 2026-09-16 -->
|
|
16
|
+
<!-- pre-release: 0.7.0-alpha14 on 2026-09-16 -->
|
|
17
|
+
<!-- pre-release: 0.7.0-alpha13 on 2026-09-16 -->
|
|
18
|
+
<!-- pre-release: 0.7.0-alpha12 on 2026-09-15 -->
|
|
19
|
+
<!-- pre-release: 0.7.0-alpha11 on 2026-09-15 -->
|
|
20
|
+
<!-- pre-release: 0.7.0-alpha10 on 2026-09-15 -->
|
|
21
|
+
<!-- pre-release: 0.7.0-alpha9 on 2026-09-14 -->
|
|
22
|
+
<!-- pre-release: 0.7.0-alpha8 on 2026-09-14 -->
|
|
23
|
+
<!-- pre-release: 0.7.0-alpha7 on 2026-09-14 -->
|
|
24
|
+
<!-- pre-release: 0.7.0-alpha6 on 2026-09-13 -->
|
|
25
|
+
<!-- pre-release: 0.7.0-alpha5 on 2026-09-13 -->
|
|
26
|
+
<!-- pre-release: 0.7.0-alpha4 on 2026-09-13 -->
|
|
27
|
+
<!-- pre-release: 0.7.0-alpha3 on 2026-09-12 -->
|
|
10
28
|
<!-- pre-release: 0.7.0-alpha2 on 2026-09-12 -->
|
|
11
29
|
<!-- pre-release: 0.7.0-alpha1 on 2026-09-11 -->
|
|
12
30
|
|
|
13
31
|
### Added
|
|
14
32
|
|
|
33
|
+
- **PR Review Canvas integration (`integrations.pr-review-canvas`).** The
|
|
34
|
+
bootstrap now offers [PR Review Canvas](https://github.com/vintasoftware/pr-review-canvas)
|
|
35
|
+
as its first *integration*: an external tool that installs its own skill.
|
|
36
|
+
Nothing from it is bundled here. A new optional top-level `integrations`
|
|
37
|
+
object in `vinta-ai-workflows-config.v1.schema.json` records the opt-in
|
|
38
|
+
(`enabled` / `disabled`). It is additive, so no schema major bump. The
|
|
39
|
+
question is interview group D.2. It is asked only when `code_host` is
|
|
40
|
+
GitHub or GitLab and `pr_creation` is `agents-create`.
|
|
41
|
+
When it is enabled:
|
|
42
|
+
- `vinta-install-ai-tools-setup` step 7b runs
|
|
43
|
+
`pr-review install-skill --claude-dir ai-tools/skills --codex-dir ai-tools/skills`.
|
|
44
|
+
It writes one tool-owned copy that every vendor symlink reaches, then
|
|
45
|
+
runs `pr-review doctor`. The CLI is never auto-installed; the step prints
|
|
46
|
+
`npm install -g @vintasoftware/pr-review-canvas` instead.
|
|
47
|
+
- The `integrate-phase` PR step runs `/pr-review-canvas <n>` after
|
|
48
|
+
`open-pr.sh` publishes. This is a runtime gate in `partials/pr-context.md`,
|
|
49
|
+
so enabling the integration later needs no re-derive.
|
|
50
|
+
- `plan-feature` adds an `after_pr` `review-canvas` chore to the maestro
|
|
51
|
+
workflow it writes.
|
|
52
|
+
|
|
53
|
+
`vinta-analyze-codebase`, `vinta-derive-skills` and
|
|
54
|
+
`vinta-update-project-skills` treat an integration-owned skill (marker
|
|
55
|
+
`.pr-review-install`) as the tool's and never diff or edit it. Refresh it
|
|
56
|
+
with `pr-review upgrade`. `vinta-sync-ai-tools` offers the integration to
|
|
57
|
+
existing projects as an `opt-in-offer`.
|
|
58
|
+
- **Maestro: System One classifiers (SPEC §17).** A run can now consult a
|
|
59
|
+
fast classifier: one that answers yes/no or scores a fixed set of labels.
|
|
60
|
+
Three things use it.
|
|
61
|
+
- **Configuration.** `run`, `serve` and `doctor` take
|
|
62
|
+
`--system-one <config.json>`. The file lives on the operator's machine and
|
|
63
|
+
is never part of the plan. It names the classifier adapter: `http` (POST,
|
|
64
|
+
bearer key read from the env var you name) or `command` (a local process,
|
|
65
|
+
JSON on stdin and stdout). Out-of-tree adapters register through
|
|
66
|
+
`registerSystemOneAdapter`. The file also turns on the built-in judges.
|
|
67
|
+
This is the only API key the package uses; LLM harnesses still run on your
|
|
68
|
+
logged-in CLIs.
|
|
69
|
+
- **Judge gates.** A workflow gate can be
|
|
70
|
+
`{ "judge": { "question" | "question_ref", "labels", "fail_on",
|
|
71
|
+
"threshold", "on_unavailable" } }` instead of `{ "cmd": … }`. It asks the
|
|
72
|
+
plan's question about the lane's diff and reports exit 0 or 1, so
|
|
73
|
+
pipelines, the fix loop and the fixer prompt are unchanged. A judge gate
|
|
74
|
+
can only fail a phase, never pass one that a command gate failed. Agents
|
|
75
|
+
are not told to run judge gates. Without `--system-one`, a judge gate
|
|
76
|
+
falls back to its `on_unavailable` setting (`pass` by default).
|
|
77
|
+
`schemas/workflow.v1.schema.json` is regenerated (`gates` values are now
|
|
78
|
+
`anyOf` command | judge). The change is additive: existing gates are
|
|
79
|
+
unchanged.
|
|
80
|
+
- **Gate triage** (`judges.gate_triage`). When a command gate fails, the
|
|
81
|
+
classifier reads the end of its log. If it calls the failure flaky or
|
|
82
|
+
environmental, the gate is rerun once before a fixer is spent. The result
|
|
83
|
+
is exposed as `gate.triage`.
|
|
84
|
+
- **`--permission judged`** (claude-code only). Agents run without vendor
|
|
85
|
+
prompts. A `PreToolUse` hook asks the classifier about each judged tool
|
|
86
|
+
call (default `Bash`) through a new `POST /api/runs/:runId/permission`
|
|
87
|
+
endpoint. It fails closed at every step. It needs `judges.permission` in
|
|
88
|
+
the config. `doctor` refuses it for codex or opencode phases. This is a
|
|
89
|
+
speed trade-off, not a sandbox.
|
|
90
|
+
|
|
91
|
+
Every judgement is journalled as `system_one_judged`, with labels and
|
|
92
|
+
scores only, never the diff, log or command. With a hosted classifier,
|
|
93
|
+
diffs, gate logs and shell commands leave the machine. Use the `command`
|
|
94
|
+
adapter with a local model where that is not acceptable.
|
|
95
|
+
- **Maestro: chores that run after the PR opens (`when: "after_pr"`).** A
|
|
96
|
+
chore can now declare `when`. The default, `before_gate`, keeps today's
|
|
97
|
+
`polish` timing. `after_pr` runs the chore at the end of `standard-phase`'s
|
|
98
|
+
`integrate` state, after `open_pr`, for work about the PR rather than the
|
|
99
|
+
diff, such as a review canvas. `open_pr` now states `pr.opened` / `pr.url` /
|
|
100
|
+
`pr.number` as facts, so a guard can read them, and the `pr` root joins the
|
|
101
|
+
guard context. An `after_pr` chore's prompt names the PR and forbids
|
|
102
|
+
editing, committing or pushing. It is skipped when no PR opened. The
|
|
103
|
+
validator refuses `after_pr` with `on_failure: "fail"`, because the phase is
|
|
104
|
+
already merged. `run_chore` takes a `when` param. Custom pipelines that
|
|
105
|
+
call it without one keep running the `before_gate` chores.
|
|
106
|
+
`schemas/workflow.v1.schema.json` is regenerated, and the change is
|
|
107
|
+
additive.
|
|
108
|
+
- **Maestro: the node view links the phase's PR.** `GET
|
|
109
|
+
/api/runs/:runId/nodes/:nodeId` now carries `pullRequest` (`opened`, `url`,
|
|
110
|
+
`number`, `reason`), read from the latest `node_pr` event. The **Changes**
|
|
111
|
+
card shows `#<n>` as a link, or says why no PR opened (`gh` missing or
|
|
112
|
+
failed). Only an `https://` URL becomes a link. The link carries
|
|
113
|
+
`rel="noreferrer noopener"` because the page URL holds the daemon token.
|
|
114
|
+
- **The node view shows what a phase changed, and the whole diff on request.**
|
|
115
|
+
The *Diff* panel used to print `git diff base...branch` for the operator to
|
|
116
|
+
paste into a terminal. It is now a *Changes* card: how many files changed
|
|
117
|
+
and how many lines were added and removed, then each file — up to ten, the
|
|
118
|
+
rest as a count — with its status mark (`A`, `M`, `D`, `R`, `?` for a file
|
|
119
|
+
not yet added to git), its own `+N −M`, and a five-block bar that compares
|
|
120
|
+
the files to each other at a glance. *View full diff* opens a new route,
|
|
121
|
+
`#/runs/<run>/nodes/<node>/changes`, that renders the unified diff with
|
|
122
|
+
syntax highlighting (shiki, GitHub light and dark following the theme),
|
|
123
|
+
old and new line numbers, hunk headers with their function context, a
|
|
124
|
+
sticky file list that scrolls to each file, and a fold on any file past 400
|
|
125
|
+
changed lines. Within a removed line and the added line it pairs with, the
|
|
126
|
+
words that differ are marked, so a flipped operator or a renamed variable
|
|
127
|
+
reads at a glance; a line rewritten rather than edited keeps the row colour
|
|
128
|
+
alone. *Unified* or *Split* — the old file beside the new — is a toggle in
|
|
129
|
+
the header, remembered per browser. The daemon serves it from a new endpoint,
|
|
130
|
+
`GET /api/runs/:runId/nodes/:nodeId/changes`, answered by the git unit: from
|
|
131
|
+
the lane's **working tree** while the lane still holds the phase's branch —
|
|
132
|
+
so an agent's uncommitted edits and untracked files are visible while it is
|
|
133
|
+
working — and from the branch itself once the lane has moved on. The card
|
|
134
|
+
polls the counts on the node view's cadence and never the patch; the diff
|
|
135
|
+
view reads the patch once, and again on a button or when the run moves. A
|
|
136
|
+
patch over 2 MiB is cut at a file boundary and says so; the per-file counts
|
|
137
|
+
are complete whatever its size. A daemon older than this browser gets the
|
|
138
|
+
reference — branch, base, lane — as before. (`vinta-ai-maestro`)
|
|
139
|
+
|
|
140
|
+
- **The transcript reads like the harnesses do.** An agent's prose is
|
|
141
|
+
rendered as the markdown it is — headings, lists, inline code and fenced
|
|
142
|
+
blocks, the blocks highlighted like the diff — instead of as its asterisks;
|
|
143
|
+
raw HTML in it stays text. Tool calls are a verb and a target on one line —
|
|
144
|
+
`Read` and a path, `Shell` and a command, `Edit` and a path with `+N −M`
|
|
145
|
+
beside it — whatever the harness named the tool (`Bash`, `bash`,
|
|
146
|
+
`command_execution` and an MCP server's `read_file` all read as what they
|
|
147
|
+
are), with the result's verdict as a dot at the end of the row because the
|
|
148
|
+
result now sits under the call it answers. Open, an edit is a diff of its
|
|
149
|
+
two sides, a write is the file, a shell call is the command and what it
|
|
150
|
+
printed, a failed one with a red edge. A stretch of consecutive reads,
|
|
151
|
+
searches and listings is one row — *Explored · 3 reads, 2 searches* — that
|
|
152
|
+
opens into the calls. The operator's own message is set apart in a tinted
|
|
153
|
+
block. The transcript panel also takes the height the window leaves it
|
|
154
|
+
rather than a fixed 480px. (`vinta-ai-maestro`)
|
|
155
|
+
|
|
156
|
+
- **A plan's PRs now reach `main`.** Phase PRs alone did not: a phase with
|
|
157
|
+
several dependencies targets its `integ-<id>` branch, and nothing ever
|
|
158
|
+
targeted that branch, so every PR stacked above it was stuck. Conflict
|
|
159
|
+
resolutions from wave merges were on no phase branch at all. maestro and the
|
|
160
|
+
stacked-branches `implement-plan` now open two more kinds of PR:
|
|
161
|
+
- an **integration PR** per `integ-<id>` branch, into `base_branch`, opened
|
|
162
|
+
by that phase just before its own PR;
|
|
163
|
+
- a **plan PR** from the final wave branch into `base_branch`, opened once
|
|
164
|
+
the last wave merges. Its body lists every phase and integration PR in an
|
|
165
|
+
order that merges, and the two ways to land the plan: merge it alone, or
|
|
166
|
+
merge the listed PRs in order and this one last.
|
|
167
|
+
|
|
168
|
+
maestro also pushes every wave branch, journals the new PRs (`node_pr` gains
|
|
169
|
+
`kind`, and a new `run_pr` event), and treats `gh`'s "a pull request already
|
|
170
|
+
exists" as opened, with that PR's URL, so a retry no longer reports a failure.
|
|
171
|
+
`prs-context-frontmatter.v1` gains an optional `kind`
|
|
172
|
+
(`phase` | `integration` | `plan`); `phase_id` and `phase_title` are no
|
|
173
|
+
longer required for `kind: plan`.
|
|
174
|
+
- **The schemas are checked.** `npm run validate-schemas` (and `npm test`)
|
|
175
|
+
compiles every schema under `schemas/` with Ajv in strict Draft 2020-12 mode
|
|
176
|
+
and checks the fixtures in `tests/schema-fixtures/`: `valid/` must pass,
|
|
177
|
+
`invalid/` must fail. Source-side only — `ajv` and `ajv-formats` are root
|
|
178
|
+
devDependencies, and nothing new ships.
|
|
179
|
+
- **The plan graph is readable, and says where you are in it.** The canvas
|
|
180
|
+
`vinta-ai-maestro`'s run view and workflow editor share (`vinta-dag-editor`)
|
|
181
|
+
was a strip of six-pixel cards: a five-wave plan was framed into a 380px box
|
|
182
|
+
at half scale, every dependency label was a bordered box truncated to "the
|
|
183
|
+
BookmarkFolder…" piled on the line it labelled, edges had no direction, and
|
|
184
|
+
nothing changed when a node was picked. Redrawn: edges carry arrowheads and
|
|
185
|
+
the ones touching the selected or hovered node are pulled forward while the
|
|
186
|
+
rest recede; cards show a status dot and label (running pulses; failed and
|
|
187
|
+
awaiting-human tint the whole card) and clamp a long name to two lines;
|
|
188
|
+
labels are quiet pills in the gap between waves and spread apart when two
|
|
189
|
+
share one; the zoom and fit controls are icons with tooltips; an empty canvas
|
|
190
|
+
says so. **Long text is reachable three ways:** an instant tooltip on hover
|
|
191
|
+
or keyboard focus for a clamped name or truncated artifact, a label that
|
|
192
|
+
grows to its full text when hovered or selected, and a details strip under
|
|
193
|
+
the canvas — in the run view too — printing the selected node's name and
|
|
194
|
+
status or the selected dependency as a sentence. Keyboard: `+`/`−`/`0` zoom
|
|
195
|
+
and fit, Enter on the selected node opens it. Double-clicking a node in the
|
|
196
|
+
run view opens its node view (`vinta-dag-node-activate`).
|
|
197
|
+
- **Dependencies are drawn by dragging.** Drag from a node's handle onto
|
|
198
|
+
another node; a dashed preview follows the pointer, the source is ringed, and
|
|
199
|
+
every card says whether it would take the drop — a cycle, a duplicate, or the
|
|
200
|
+
source itself is dimmed and refused before the gesture is spent. Click-then-
|
|
201
|
+
pick and the `e` key still work. A refused dependency now says which rule it
|
|
202
|
+
broke (`vinta-dag-refuse`), and the editor shows that where the gesture
|
|
203
|
+
happened instead of nothing.
|
|
204
|
+
|
|
205
|
+
### Changed
|
|
206
|
+
|
|
207
|
+
- **The canvas no longer swallows the page's scroll.** A bare wheel over the
|
|
208
|
+
graph used to zoom it and block the page from scrolling; it now scrolls the
|
|
209
|
+
page, and zoom is ⌘ or Ctrl + scroll (which is also how a trackpad pinch
|
|
210
|
+
arrives), the buttons, or the keys. Dragging the canvas shows a grab cursor
|
|
211
|
+
and never selects text. The host box follows the window's height instead of
|
|
212
|
+
being fixed at 380px.
|
|
213
|
+
|
|
214
|
+
### Fixed
|
|
215
|
+
|
|
216
|
+
- **The editor's canvas inspector no longer offers fields it then discards.**
|
|
217
|
+
Its Status and Wave fields were folded back into the workflow and silently
|
|
218
|
+
dropped — status is run state and wave is computed from dependencies — and
|
|
219
|
+
Name duplicated the field in the panel beside the graph. They are hidden in
|
|
220
|
+
the editor through the parts the component now exposes, leaving the
|
|
221
|
+
inspector the one thing only it can do: a dependency's artifact and the
|
|
222
|
+
delete actions.
|
|
223
|
+
- **Picking a dependency after a node no longer loses it on the next frame.**
|
|
224
|
+
The host reported an edge selection as "no node", pushed that back into the
|
|
225
|
+
canvas, and cleared the edge the moment it was picked; the edge's inspector
|
|
226
|
+
flashed and vanished. A cleared node selection now leaves an edge selection
|
|
227
|
+
alone.
|
|
228
|
+
- **Pressing on the canvas's toolbar or inspector no longer pans the graph.**
|
|
229
|
+
- **A timed-out gate says whether it hung or was slow.** A `gate_result` with
|
|
230
|
+
`status: timed_out` used to carry only the status, so a run with nine
|
|
231
|
+
timeouts could not say whether any of them was a stuck suite or a host too
|
|
232
|
+
busy to finish one. It now carries `timeout`: `quiet_ms` (how long the gate
|
|
233
|
+
had gone without writing anything when it was killed), `output_bytes`, and
|
|
234
|
+
the host's `load_1m` beside `cpus`. `quiet_ms` near the timeout is a gate
|
|
235
|
+
waiting on something; a small one with `load_1m` well above `cpus` is
|
|
236
|
+
contention. Numbers only, as before: nothing the gate printed reaches the
|
|
237
|
+
row. The monitor's brief points at the new field. Older rows have no
|
|
238
|
+
`timeout`.
|
|
239
|
+
|
|
240
|
+
- **Gate durations are now kept, not just displayed.** Every `gate_result` has
|
|
241
|
+
carried the runner's own `duration_ms` since gates were journalled, and
|
|
242
|
+
nothing read it back: the figure went to a live panel and was afterwards
|
|
243
|
+
reachable only by hand-parsing event payloads, so the one measurement that
|
|
244
|
+
answers "is the suite why this run took an hour" could not be asked of a
|
|
245
|
+
finished run. `analyzeRun` now rolls it up per gate — runs, cache hits,
|
|
246
|
+
summed runtime, the slowest single run, verdicts by kind — and each phase's
|
|
247
|
+
time split carries `gateRunMs` beside `gatePoolQueueMs`, so a run says how
|
|
248
|
+
much of its working time was the gate queue and how much was the gate. The
|
|
249
|
+
post-mortem carries the same as a `gate_costs` finding, which is what makes
|
|
250
|
+
it durable: `plan-feature` reads these artifacts when sizing the next plan,
|
|
251
|
+
and a gate pool's capacity and `max_parallel_lanes` are one decision made
|
|
252
|
+
with half the numbers. Cache hits are counted and their time kept in its own
|
|
253
|
+
`cache_saved_ms` column — a hit's duration is what the gate cost when it last
|
|
254
|
+
ran, and adding it to the runtime would report time the run specifically did
|
|
255
|
+
not spend. A verdict written before the runner measured itself is counted and
|
|
256
|
+
its milliseconds are not: both reports emit a `gate_durations_unrecorded` gap
|
|
257
|
+
naming the gates, because a gate reported as free is the number a planner
|
|
258
|
+
would act on hardest.
|
|
259
|
+
|
|
260
|
+
- **Phases can run chores: declared agent turns that change the diff rather than
|
|
261
|
+
judge it.** A gate is a shell command that says pass or fail; a chore is an
|
|
262
|
+
agent asked to do something to the work — rewrite the comments this phase
|
|
263
|
+
wrote, add the changelog entry, extract the strings that need translating. It
|
|
264
|
+
runs on the implementer's own session, so the agent that wrote the diff is the
|
|
265
|
+
one asked to act on it. Declare them in `chores.<id>` (a `prompt` or a
|
|
266
|
+
`prompt_ref` into the plan, plus an optional `skill` the prompt names) and
|
|
267
|
+
pick them with `defaults.chores` for the run or `nodes[].chores` for one
|
|
268
|
+
phase — a node's list replaces the default rather than adding to it, so `[]`
|
|
269
|
+
opts a phase out. In `standard-phase` they run in a new `polish` state,
|
|
270
|
+
between a passing review and the gate: a chore edits the tree, so running it
|
|
271
|
+
later would merge a diff the gates never ran against, and running it earlier
|
|
272
|
+
would have the fixer rewrite what it just did. A chore that fails, or that the
|
|
273
|
+
harness had no capacity for, is journalled and the phase continues to its
|
|
274
|
+
gates — `on_failure: "fail"` is for one the phase is not correct without.
|
|
275
|
+
|
|
276
|
+
- **The post-mortem now reports what the schedule cost.** Two findings, both
|
|
277
|
+
derived from events the journal already carried. `critical_path` is the
|
|
278
|
+
dependency chain that decided the wall clock — each phase's span, the total,
|
|
279
|
+
and its share of elapsed — because every phase *off* that chain could be made
|
|
280
|
+
instant without moving the run, and nothing said which phases those were.
|
|
281
|
+
`idle_capacity` reports the width the graph actually reached against the lanes
|
|
282
|
+
it asked for: a plan declaring three lanes that never runs more than two
|
|
283
|
+
phases at once pays for a third worktree, a third forked database and a third
|
|
284
|
+
desk, and gets none of them back. Run against a real fourteen-hour build, the
|
|
285
|
+
two say its critical path was **99% of elapsed time** — six phases, effectively
|
|
286
|
+
serial — with peak concurrency 2 against 3 lanes and **55% of lane time idle**.
|
|
287
|
+
`plan-feature` already reads these artifacts before drawing the next set of
|
|
288
|
+
dependency lines; until now neither depth nor width was in them. A
|
|
289
|
+
`blocking_cause_unrecorded` gap ships alongside, because the chain is what the
|
|
290
|
+
*graph* forced and a phase can also wait on a busy lane or an unanswered
|
|
291
|
+
question — which the journal cannot currently tell apart.
|
|
292
|
+
|
|
293
|
+
- **`--retry-after <15m>`: an unanswered failure question eventually answers
|
|
294
|
+
itself.** An observed fourteen-hour run spent 4h07m — 29% of its wall clock —
|
|
295
|
+
parked on "This phase failed. Try it again?" with nobody at the keyboard; the
|
|
296
|
+
answer, when it came, was `retry`, and it worked. Unset by default, so a run
|
|
297
|
+
behaves exactly as it did. Accepts minutes bare or a unit (`15`, `15m`, `90s`,
|
|
298
|
+
`2h`) on both `run` and `serve`. It is deliberately unbounded and fires again
|
|
299
|
+
on each new question: a version capped by `--retries` would stall at the cap
|
|
300
|
+
and idle for the rest of the night, which is the failure it exists for. Every
|
|
301
|
+
firing is a full phase attempt, so the interval is the throttle. It reaches
|
|
302
|
+
the failure question and nothing else — a plan's own `await_human` gate asked
|
|
303
|
+
for a person, and both park through the same code, so answering those would be
|
|
304
|
+
the orchestrator overruling the plan. An unattended answer is journalled with
|
|
305
|
+
`unattended: true`, because "a human said try again" and "nobody was here" are
|
|
306
|
+
the same answer with very different meanings.
|
|
307
|
+
|
|
308
|
+
- **The daemon now has a log of its own, and a Logs view to read it in.**
|
|
309
|
+
Transcripts said what the agents did; nothing said what the *daemon* did, so
|
|
310
|
+
"the run stopped and I don't know why" had no evidence behind it at all.
|
|
311
|
+
`.vinta-ai-maestro/logs/daemon.ndjson` now records what the process bound,
|
|
312
|
+
every HTTP request and socket upgrade it refused and why, every start request
|
|
313
|
+
that produced no run, every scheduler dispatch and node transition, and every
|
|
314
|
+
deadlock — on one clock, so a node failure can be read beside the refusal
|
|
315
|
+
thirty seconds before it. `GET /api/logs` serves it as a tail or a follow,
|
|
316
|
+
with filters for level, run, node and a substring of any event or field; the
|
|
317
|
+
UI's new **Logs** section follows the tail until you scroll up. The file
|
|
318
|
+
rotates at 8 MiB and keeps five rotations, so it is bounded whatever the
|
|
319
|
+
daemon's uptime, and `purge` leaves it alone for the same reason it leaves
|
|
320
|
+
`flow.db` alone — it holds no repository contents, and it is the record of the
|
|
321
|
+
failure somebody is about to ask about.
|
|
322
|
+
|
|
323
|
+
- **A crash is no longer silent.** An exception escaping a node's own handling
|
|
324
|
+
used to become an unhandled rejection on a promise the scheduler does not
|
|
325
|
+
hold, and an unhandled rejection ends the process: hours of agent turns and a
|
|
326
|
+
real amount of money, gone with no journal row, no transcript entry and
|
|
327
|
+
nothing on disk saying why — because the thing that would have said it was the
|
|
328
|
+
thing that died. Three changes. A node that throws is now **contained** by the
|
|
329
|
+
rule §6 already states for failures: it fails, its transitive dependents
|
|
330
|
+
block, and everything independent of it keeps going. A crash that is still
|
|
331
|
+
fatal is **recorded first** — `daemon.uncaught_exception` /
|
|
332
|
+
`daemon.unhandled_rejection`, with the error's kind, its stack frames and the
|
|
333
|
+
ids of every run in flight. And the in-flight runs are **journalled as ended**
|
|
334
|
+
before the process goes, so `run --resume <run-id>` picks them up instead of
|
|
335
|
+
finding a row that says `running` for ever. `serve` and `run` both take
|
|
336
|
+
`--log-level`, `--log-stderr` and `--log-detail`.
|
|
337
|
+
|
|
338
|
+
- **The log is identifiers only, enforced rather than asked for — plus the one
|
|
339
|
+
field that is deliberately prose.** A log is called from anywhere, and "please
|
|
340
|
+
do not log repository contents" is a hope rather than a control. So a field
|
|
341
|
+
may only hold a string, a number, a boolean or null — an object is dropped,
|
|
342
|
+
never stringified, which is the way a diff or a file read becomes a log line —
|
|
343
|
+
identifier values are capped at 200 characters, field names that are secrets
|
|
344
|
+
by their name are redacted, and the daemon's token is registered at boot so
|
|
345
|
+
any value containing it is written `<redacted>`.
|
|
346
|
+
|
|
347
|
+
The exception is an error's **`message`**, which every failure record carries
|
|
348
|
+
beside its kind, capped at 2000 characters and redacted like anything else. It
|
|
349
|
+
is the default because `.vinta-ai-maestro/runs/` already holds every agent
|
|
350
|
+
transcript and gate log *verbatim*, in the same gitignored store and under the
|
|
351
|
+
same `purge` — an error message is a rounding error against a directory that
|
|
352
|
+
is already a copy of the repository, and excluding it cost the one string that
|
|
353
|
+
most often explains a failure. `--log-detail kind` narrows to the kind and the
|
|
354
|
+
stack frames for a checkout under a stricter obligation than this store's own.
|
|
355
|
+
- **A run that is dragging can now tune itself, within bounds somebody wrote
|
|
356
|
+
down.** A run can be mis-*configured* rather than broken — every phase doing
|
|
357
|
+
what it was asked, every gate reporting honestly, and the whole thing paying
|
|
358
|
+
for a test database it rebuilds on every gate run in every lane. Nobody needs
|
|
359
|
+
waking for that, and the post-mortem found it out an afternoon too late to
|
|
360
|
+
help. Now a watchdog wakes the run's monitor when a phase passes an hour or a
|
|
361
|
+
gate's uncached cost passes thirty minutes, the monitor reads the gate logs
|
|
362
|
+
and the durations, and it answers with a **proposal** that the daemon
|
|
363
|
+
validates and applies through the existing amend path. `--no-intervene` turns
|
|
364
|
+
it off.
|
|
365
|
+
|
|
366
|
+
It proposes; it never writes. Its authority is four verbs — a gate's command,
|
|
367
|
+
a gate's timeout, a phase's fix budget, a phase's model — and the line they
|
|
368
|
+
draw is that it may change **how** the run executes and never **what** it
|
|
369
|
+
builds. There is no way to express a change to a dependency, a phase brief, a
|
|
370
|
+
touch list, the base branch, or the set of phases: not refused at runtime,
|
|
371
|
+
unrepresentable.
|
|
372
|
+
|
|
373
|
+
The one field that can do real damage is a gate's command, because
|
|
374
|
+
`--reuse-db` and `-k not_slow` are the same edit to the same string, and a
|
|
375
|
+
gate narrowed wrongly goes green and looks like success in every log there
|
|
376
|
+
is. So a command may only be changed when the gate itself declares
|
|
377
|
+
`tuning.allowed_flags` — a list a person wrote in the committed plan, under
|
|
378
|
+
review, before the run started — and the proposed command must be the current
|
|
379
|
+
one's argv tokens, in order, plus additions from that list. A gate that
|
|
380
|
+
declares no `tuning` block is not tunable, which is the default.
|
|
381
|
+
|
|
382
|
+
A run gets three of these in its life, at most one per gate and per phase.
|
|
383
|
+
What it changed is journalled as identifiers; why it changed it is the
|
|
384
|
+
monitor's prose and goes in `runs/<run-id>/interventions.jsonl` beside the
|
|
385
|
+
run, including every attempt that was refused — an agent trying to do
|
|
386
|
+
something it may not do, with nobody in the room, is the record most worth
|
|
387
|
+
keeping. See `packages/vinta-ai-maestro/docs/monitor-intervention.md`.
|
|
388
|
+
|
|
389
|
+
- **`plan-feature` is told what the newer post-mortem findings mean.** The
|
|
390
|
+
skill documents each finding and what to *do* about it, and three had been
|
|
391
|
+
added to the artifact without reaching it: `gate_costs`, `critical_path` and
|
|
392
|
+
`idle_capacity`. A finding a planning agent cannot interpret is a finding
|
|
393
|
+
that changes no plan, which is the whole return on emitting it — and the
|
|
394
|
+
three are among the most actionable there are. `gate_costs` sizes the gate
|
|
395
|
+
pool capacities a plan declares, and separates a slow suite from a fix loop
|
|
396
|
+
re-paying for the same one. `critical_path` is the chain to re-draw the graph
|
|
397
|
+
against: shortening a phase that is not on it changes nothing, so a plan that
|
|
398
|
+
parallelises harder without touching that chain buys nothing at all.
|
|
399
|
+
`idle_capacity` says the graph never got as wide as the lanes it asked for,
|
|
400
|
+
which is a fact about the plan rather than about the machine. Each now has a
|
|
401
|
+
row beside the findings that already had one.
|
|
402
|
+
|
|
403
|
+
- **The post-mortem says what a run changed about itself, and whether it
|
|
404
|
+
helped.** `postmortem.v1` gains an `interventions[]` finding: one entry per
|
|
405
|
+
amendment the run made to itself, with the effect on the thing it changed. A
|
|
406
|
+
gate is scored against its own uncached durations either side of the
|
|
407
|
+
amendment — mean before, mean after, `cheaper` / `dearer` / `unchanged`
|
|
408
|
+
outside a ten-per-cent band. Cached hits are excluded, because a hit reports
|
|
409
|
+
the duration of the run that filled the cache and would drag the mean toward
|
|
410
|
+
whichever side of the boundary that run fell on.
|
|
411
|
+
|
|
412
|
+
It is a comparison and not a claim of cause, and the schema says so: a gate
|
|
413
|
+
that got cheaper did so while phases were finishing and caches warming. It is
|
|
414
|
+
worth carrying anyway, because without it an autonomous editor is one nobody
|
|
415
|
+
can tell is making runs worse — and because `plan-feature` now reads it, so a
|
|
416
|
+
project whose `unit` gate wants `--reuse-db` pays to find that out once
|
|
417
|
+
instead of every run.
|
|
418
|
+
|
|
419
|
+
A phase-level change (a fix budget, a model) is reported `unmeasured` rather
|
|
420
|
+
than estimated: a phase runs once, so there is no before to compare an after
|
|
421
|
+
against, and the only candidate baseline is a different phase doing different
|
|
422
|
+
work. An operator's amendment is not scored at all — a person deciding
|
|
423
|
+
something is not the run choosing it.
|
|
424
|
+
|
|
425
|
+
- **`schemas/intervention.v1.schema.json`** — the document the monitor answers
|
|
426
|
+
with, generated from `src/intervention/intervention.ts` the way the workflow
|
|
427
|
+
and post-mortem schemas are generated from theirs. It is the odd one in
|
|
428
|
+
`schemas/`: it validates something a *model* writes rather than a skill or a
|
|
429
|
+
person, and it is the boundary deciding what an unattended run may change
|
|
430
|
+
about itself.
|
|
431
|
+
|
|
432
|
+
- **A run no longer dies with the terminal that started it.** `vinta-ai-maestro
|
|
433
|
+
serve` accepts `POST /api/runs`, so a run can be submitted to a daemon that
|
|
434
|
+
was already listening and belongs to that daemon rather than to the shell that
|
|
435
|
+
asked for it; the request answers with the run id as soon as the run is
|
|
436
|
+
registered, not when it finishes. Previously `run` was the only way to start a
|
|
437
|
+
run and it hosted its own daemon, so closing the window killed the scheduler
|
|
438
|
+
and every agent under it — and left the journal claiming `running` for ever,
|
|
439
|
+
with nothing able to tell that row apart from a run still in flight.
|
|
440
|
+
|
|
441
|
+
- **`vinta-ai-maestro run --resume <run-id>` picks an interrupted run back up.**
|
|
442
|
+
Phases already `done` stay done and are not dispatched again, their lane
|
|
443
|
+
worktrees are adopted rather than re-provisioned — so whatever an agent had
|
|
444
|
+
written and not committed is still there — and a phase that was mid-turn when
|
|
445
|
+
the process died runs again from the top of its pipeline, because the turn it
|
|
446
|
+
was in belonged to a process that is gone. The plan comes from the run's
|
|
447
|
+
frozen snapshot, never from the document it was written from, so editing that
|
|
448
|
+
file in the meantime cannot switch plans under a run already under way. A new
|
|
449
|
+
`run_resumed` event records each hand-over; it is deliberately not a second
|
|
450
|
+
`run_started`, which would have moved the run's `started_at` to whenever it
|
|
451
|
+
was last picked up and made every duration short by the length of the outage.
|
|
452
|
+
|
|
453
|
+
- **`vinta-ai-maestro gate <gate-id>` runs a declared gate from inside an agent
|
|
454
|
+
turn.** A phase used to run its full gate suite five or six times a round —
|
|
455
|
+
implementer, reviewer, fixer, reviewer again, then the authoritative `gate`
|
|
456
|
+
node — and only the last of those consulted the gate cache or the resource
|
|
457
|
+
pool. Agents now ask the daemon for a gate by id: the result is cached on the
|
|
458
|
+
same `(gate id, lane tree hash)` key the `gate` node reads, the gate's
|
|
459
|
+
resources are held by the daemon rather than by whichever agent remembered to
|
|
460
|
+
wrap the command, and the id resolves to the plan's own command so a scoped
|
|
461
|
+
approximation cannot be reported as the gate. Each run is journalled as a
|
|
462
|
+
`gate_result` event and a `gate_run` transcript entry under the GATE band,
|
|
463
|
+
whoever asked for it.
|
|
464
|
+
|
|
465
|
+
- **A project declares what makes a lane runnable.** `project.env_files` copies
|
|
466
|
+
ignored configuration into each worktree, `project.setup_cmd` runs an
|
|
467
|
+
idempotent setup hook on provisioning and recycle, and the fixed
|
|
468
|
+
`project.commands` vocabulary tells implementers, reviewers and fixers the
|
|
469
|
+
project's real lint, typecheck, test and migration entry points.
|
|
470
|
+
|
|
471
|
+
- **Compose-backed lanes are isolated past `COMPOSE_PROJECT_NAME`.** The daemon
|
|
472
|
+
now generates an out-of-tree Compose override per lane, strips fixed host
|
|
473
|
+
ports, re-pins fixed and external volumes, and carries the complete lane
|
|
474
|
+
environment into agent and takeover processes as well as gates. Explicitly
|
|
475
|
+
published services receive probed per-lane ports recorded in the teardown
|
|
476
|
+
summary.
|
|
477
|
+
|
|
478
|
+
- **Shared services get one namespace per lane.** `project.services` models a
|
|
479
|
+
fixed index or lane-derived name inside one Redis, RabbitMQ, object-storage,
|
|
480
|
+
or similar server, with project-owned create/reset commands and capacity
|
|
481
|
+
validation before provisioning creates templates or worktrees.
|
|
482
|
+
|
|
483
|
+
- **Agents can take the semaphore a workflow declares.**
|
|
484
|
+
`vinta-ai-maestro with <resource> -- <cmd>` waits on the run's existing
|
|
485
|
+
`ResourcePools`, runs the heavy inner-loop command, and releases on exit.
|
|
486
|
+
Renewable leases expire when their client disappears, are visible in the
|
|
487
|
+
live journal, and are surfaced in implementer, reviewer and fixer prompts.
|
|
488
|
+
|
|
489
|
+
- **A failed phase retries itself, and then asks.** `--on-failure` defaults to
|
|
490
|
+
`retry`: one cold re-attempt (`--retries <n>`, 0–5), and then the node parks
|
|
491
|
+
on a question — retry, retry with another member of the crew, or stop. The
|
|
492
|
+
failures this system produces are overwhelmingly environmental and are gone by
|
|
493
|
+
the second attempt; the ones that survive it are the ones worth a person.
|
|
494
|
+
`ask` skips the automatic attempt. `stop` is the old behaviour and remains the
|
|
495
|
+
right choice for CI, because everything else eventually **waits**.
|
|
496
|
+
|
|
497
|
+
A failure that survives its retries says so: the reason carries
|
|
498
|
+
`(after N attempts)`, which no event otherwise records.
|
|
499
|
+
|
|
500
|
+
- **A failed phase can be retried by hand.** A **Retry phase** button, and
|
|
501
|
+
`POST /api/runs/:runId/nodes/:nodeId/retry`. It returns the node to the ready
|
|
502
|
+
set and unblocks the subtree its failure blocked — a phase that died of
|
|
503
|
+
something environmental holds up work that was never broken. It needs the run
|
|
504
|
+
to still be in flight, which with the new default it usually is; a run that
|
|
505
|
+
has genuinely ended is re-run, not retried, and says so rather than doing
|
|
506
|
+
nothing.
|
|
507
|
+
|
|
508
|
+
- **The monitor can go and look.** It was given a digest and nothing else, and
|
|
509
|
+
read exactly as thin as that sounds — it could say a phase had failed and
|
|
510
|
+
never say what the phase had written. It is briefed as a technical project
|
|
511
|
+
manager now, with the map: the plan document, each phase's brief, each lane's
|
|
512
|
+
worktree path, each branch and its base, and where the journal and transcripts
|
|
513
|
+
live. It has a shell and its working directory is the repository, so it can
|
|
514
|
+
read the diff before drawing a conclusion. The digest stays as the index —
|
|
515
|
+
bounded, cheap, enough to know which phase is worth a closer look.
|
|
516
|
+
|
|
517
|
+
- **The monitor conversation is kept.** It lived in component state, so a reload
|
|
518
|
+
threw away every question and every answer — a worse record than the run it
|
|
519
|
+
describes. It is written to the transcript store under a reserved node id and
|
|
520
|
+
read back on load, so it outlives the tab, the daemon and the run.
|
|
521
|
+
|
|
522
|
+
- **Panels expand.** Anything holding content that is only nominally
|
|
523
|
+
summarisable — an agent's transcript, a gate log, the monitor conversation,
|
|
524
|
+
the steering box — takes the full container width and about a screen of
|
|
525
|
+
height on demand. The height travels as a CSS variable, because the element
|
|
526
|
+
that has to grow is a scroller several components below the panel.
|
|
527
|
+
|
|
528
|
+
- **A run has a spokesperson you can ask.** `serve` grows a **Monitor** panel on
|
|
529
|
+
the run view: one agent that reads the journal and answers in prose — what is
|
|
530
|
+
blocked, why a phase failed, what it would take to move on. It runs on the
|
|
531
|
+
dearest tier on the crew, because it is read by a person deciding what to do
|
|
532
|
+
about a failing run, and it is asked a handful of times rather than hundreds.
|
|
533
|
+
|
|
534
|
+
Three things it deliberately is not.
|
|
535
|
+
|
|
536
|
+
**It is not in the permission path.** The obvious thought, once an agent has
|
|
537
|
+
been refused something, is to put a smarter agent in front of the refusals —
|
|
538
|
+
but a phase makes hundreds of tool calls (one node in one real run made 179)
|
|
539
|
+
and a model turn before each is latency and cost spent on questions like "may
|
|
540
|
+
I run ruff", which should never have been questions. Permissions are settled
|
|
541
|
+
structurally, once per spawn, for free.
|
|
542
|
+
|
|
543
|
+
**It does not read the transcripts.** Piping every agent's output into a
|
|
544
|
+
second agent would make the monitor the most expensive thing in the run and
|
|
545
|
+
tie its cost to the work rather than to the questions. It reads a bounded
|
|
546
|
+
digest — statuses, failure reasons, pending questions, the last few refusals
|
|
547
|
+
with their sentences, one trimmed last word per phase — so a one-hour run and
|
|
548
|
+
a one-day run cost about the same to ask about.
|
|
549
|
+
|
|
550
|
+
**It has no authority.** It can explain a §9.1 pause; it cannot answer one.
|
|
551
|
+
An agent that could quietly approve its colleagues' work would turn a
|
|
552
|
+
checkpoint into a formality, and the checkpoint is the point.
|
|
553
|
+
|
|
554
|
+
It answers about **finished runs too**, which is when "why did this fail" is
|
|
555
|
+
usually asked, and it needs no lane: it writes nothing.
|
|
556
|
+
|
|
557
|
+
- **`serve` reads `--permission`.** The flag has been accepted and ignored since
|
|
558
|
+
it existed. It decides how the monitor is spawned, so it is read now.
|
|
559
|
+
|
|
15
560
|
- **A plan staffs a team, instead of picking a model per phase.** Choosing a tier
|
|
16
561
|
phase by phase answers "what runs this one" ten times and never adds it up, so the
|
|
17
562
|
two questions that decide what a feature costs go unasked: how many agents does
|
|
@@ -79,10 +624,33 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
79
624
|
claimed per review turn rather than per phase — it has one session ledger and
|
|
80
625
|
two concurrent reviews would collide over it — so one reviewer on a three-lane
|
|
81
626
|
plan is a queue at the review step and not a serialised run.
|
|
627
|
+
- **"Cheapest qualified" has one exception, and it is about sessions.** A
|
|
628
|
+
member who already holds a session this phase would genuinely resume takes
|
|
629
|
+
it ahead of a cheaper member who would have to start cold — even when they
|
|
630
|
+
are more senior than the phase needs, and even when the member the plan
|
|
631
|
+
named is free. What it buys is the context a cold session spends its first
|
|
632
|
+
turn rebuilding; what it costs is the dearer model for that phase, which is
|
|
633
|
+
the smaller of the two bills. **The tier floor is untouched**: warmth
|
|
634
|
+
reorders the members who already qualify and never widens them, so a warm
|
|
635
|
+
junior still cannot take a Tier 3 phase.
|
|
636
|
+
- **Only when a session is genuinely already up.** "Warm" means the scheduler
|
|
637
|
+
asked its own session-reuse rules and got a yes — same pinned lane, same
|
|
638
|
+
harness, under the turn ceiling, not poisoned by a failed phase. A member
|
|
639
|
+
who has merely run before is not warm, because a promotion bought on a
|
|
640
|
+
resume that is then refused pays the senior's rate *and* cold-starts
|
|
641
|
+
anyway. With nobody warm, staffing is exactly what it was: a session is
|
|
642
|
+
being opened either way, and the plan's own level wins.
|
|
643
|
+
- An operator who picks the member by hand on a retry gets that member. A
|
|
644
|
+
saving nobody asked for does not overrule an explicit answer.
|
|
82
645
|
- The run view reports who actually worked against who the plan said would.
|
|
83
646
|
`substituted` is the figure to read beside a cost that overran: every
|
|
84
647
|
substitution ran at or above the budgeted tier, so a run can be entirely green
|
|
85
|
-
and still have been staffed dearer than planned.
|
|
648
|
+
and still have been staffed dearer than planned. The phases promoted to reuse
|
|
649
|
+
a warm session are counted **within** that figure and reported apart from it —
|
|
650
|
+
a peer covering for a busy member costs what the plan budgeted, while a warm
|
|
651
|
+
promotion is the scheduler deliberately trading model rate against cold
|
|
652
|
+
starts, and folded together a run that promoted everything to the top tier
|
|
653
|
+
would read as an ordinary busy wave.
|
|
86
654
|
|
|
87
655
|
- **`implement-plan` runs independent phases in parallel.** The plan now carries a
|
|
88
656
|
dependency graph and the conductor schedules against it: a phase starts as soon as
|
|
@@ -177,8 +745,258 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
177
745
|
**generated** from a zod source rather than hand-written — see
|
|
178
746
|
[`schemas/README.md`](schemas/README.md).
|
|
179
747
|
|
|
748
|
+
- **The monitor keeps thinking when you look away, and thinks out loud.**
|
|
749
|
+
Asking used to be one long HTTP request that produced the whole answer inside
|
|
750
|
+
it, which made the turn's lifetime the browser's connection: switching view,
|
|
751
|
+
reloading or letting a laptop sleep killed the monitor mid-thought and left a
|
|
752
|
+
question with no answer and no record that one had been attempted. The daemon
|
|
753
|
+
owns the turn now — `POST` answers `202`, and the monitor journals each
|
|
754
|
+
thought and each sentence as it produces them, so the conversation is
|
|
755
|
+
readable while it is being written and by any tab that opens it. The panel
|
|
756
|
+
renders through the same rows a phase's transcript uses, which is what the
|
|
757
|
+
API always claimed and the UI never did.
|
|
758
|
+
|
|
759
|
+
- **A phase's transcript says which agent wrote each line, and holds the gates.**
|
|
760
|
+
Every spawn on a node appends to one file whatever its role, so a phase that
|
|
761
|
+
took two fix rounds held five agents' output in one undifferentiated stream —
|
|
762
|
+
the role was in scope at the append and simply not written down. Each line now
|
|
763
|
+
carries the role and the session slot that produced it, the view bands the
|
|
764
|
+
list where one agent stops and the next starts, and gate runs are entries in
|
|
765
|
+
it rather than only in a log beside it. The operator's own steering stays the
|
|
766
|
+
operator's (§7), even though the adapter echoes it back on the agent's event
|
|
767
|
+
stream. Transcripts written before this render exactly as they did, with no
|
|
768
|
+
bands. The band stays pinned to the top of the scroller while its own run of
|
|
769
|
+
rows goes past, so the agent you are reading is named without scrolling back
|
|
770
|
+
to where it started — in the phase transcript and in the monitor conversation
|
|
771
|
+
alike.
|
|
772
|
+
|
|
180
773
|
### Changed
|
|
181
774
|
|
|
775
|
+
- **maestro's review/fix loop is now the thermo-nuclear review loop.** The
|
|
776
|
+
shipped `standard-phase` changes for every run that uses it:
|
|
777
|
+
- **The reviewer** keeps its session across rounds. It is held to a shipped
|
|
778
|
+
Review Standard (evidence bar, priority order, approval bar), or to the
|
|
779
|
+
project's `REVIEW.md`, which replaces that standard when the lane has one.
|
|
780
|
+
`VERDICT: pass` is now an explicit approval. A re-review gets the fixer's
|
|
781
|
+
report, every finding already rejected or settled, and the pass-two rules.
|
|
782
|
+
- **The orchestrator checks that a review turn changed nothing.** If `HEAD`
|
|
783
|
+
or a tracked file moved, the node stops and asks whether to keep the edits
|
|
784
|
+
or stop the phase.
|
|
785
|
+
- **The fixer** (the implementer continuing its session) verifies each
|
|
786
|
+
finding before acting on it and rejects unsupported ones with
|
|
787
|
+
counter-evidence. It sends scope decisions to the operator instead of
|
|
788
|
+
making them: unreachable scenarios, defensive checks, requirements
|
|
789
|
+
ambiguities, destructive operations. The new `consult` state asks about the
|
|
790
|
+
whole batch at once and does not count as a fix round.
|
|
791
|
+
- **The review ledger.** Rejections and the operator's answers are kept in
|
|
792
|
+
`runs/<run-id>/nodes/<node-id>/review-ledger.jsonl` and shown to every
|
|
793
|
+
later review and fix.
|
|
794
|
+
- **The budget.** `max_fix_rounds` now defaults to **4** (was 2). Running out
|
|
795
|
+
asks `continue` / `stop` instead of failing the phase.
|
|
796
|
+
- **Unattended runs.** Under `--retry-after`, a scope question nobody answers
|
|
797
|
+
takes each item's default, and an exhausted budget nobody answers takes
|
|
798
|
+
`stop`, which fails into `--on-failure` as before. Without `--retry-after`
|
|
799
|
+
both questions wait for a person.
|
|
800
|
+
- **The reviewer's model.** An unstaffed review runs on the new optional
|
|
801
|
+
`defaults.reviewer_model`, then the harness's top tier (`opus` on
|
|
802
|
+
claude-code), then the phase's model.
|
|
803
|
+
- **New pieces.** `await_human` gains an optional `unattended_answer`, and
|
|
804
|
+
there are two new effects, `record_decision` and `grant_fix_rounds`; the
|
|
805
|
+
schema stays at `workflow.v1`.
|
|
806
|
+
- **Migration.** A workflow that pins `max_fix_rounds` keeps its number but
|
|
807
|
+
now gets asked at the end of it. One that ships its own `standard-phase`
|
|
808
|
+
shadows the built-in and is unaffected. The skills-path review partials
|
|
809
|
+
are not updated yet (SPEC §16.6). See
|
|
810
|
+
[SPEC §16](packages/vinta-ai-maestro/SPEC.md#16-the-review-loop).
|
|
811
|
+
|
|
812
|
+
- **maestro starts one session at a time per harness, and remembers the
|
|
813
|
+
account's limit.** Sessions used to boot simultaneously up to the harness
|
|
814
|
+
ceiling, and N Claude Code CLIs starting together contend for the same local
|
|
815
|
+
config and OAuth token: a probe against 2.1.274 measured time to `init`
|
|
816
|
+
rising from 1.2 s with two simultaneous starts to 4.8 s with sixteen, against
|
|
817
|
+
a flat 0.7 s when each waited for the previous one. A spawn now waits until
|
|
818
|
+
the one ahead of it has a session or a refusal, so a refusal also parks every
|
|
819
|
+
queued spawn before it spends one. The ceiling AIMD discovers after a
|
|
820
|
+
`concurrency` or `rate_limit` refusal is kept per harness in `flow.db` and a
|
|
821
|
+
run started within six hours opens at it instead of re-learning the limit by
|
|
822
|
+
being refused; clean spawns still probe back up to the configured value, and
|
|
823
|
+
the hint is dropped once the ceiling recovers or goes stale. When a harness
|
|
824
|
+
is throttled, the freed slot goes to the node with the longest chain of work
|
|
825
|
+
still in front of it rather than to whichever queued first.
|
|
826
|
+
|
|
827
|
+
- **Updated the OpenAI and Anthropic models to their latest version.**
|
|
828
|
+
|
|
829
|
+
- **Updated the generated skills to have `disable-model-invocation: true` set.**
|
|
830
|
+
|
|
831
|
+
- **An expanded panel reads in a centred column.** Full page used to mean
|
|
832
|
+
full width too, so on a large monitor a transcript or gate log ran in lines
|
|
833
|
+
too long to follow. The overlay still covers the window; its header and
|
|
834
|
+
content now sit in a centred column capped at `max-w-6xl`.
|
|
835
|
+
|
|
836
|
+
- **The node view reads like a chat.** The transcript now sits above the
|
|
837
|
+
steering box instead of below it, so the conversation comes first and the
|
|
838
|
+
box you answer it in is under its newest turn. A terminal opened by *Take
|
|
839
|
+
over* still appears under the steering box.
|
|
840
|
+
|
|
841
|
+
- **`--retry-after` backs off when attempts fail faster than it.** An
|
|
842
|
+
unanswered failure question used to answer itself on a flat interval
|
|
843
|
+
forever, so a phase whose attempts died within seconds was retried every
|
|
844
|
+
fifteen minutes for hours, against the same failure, at the price of a cold
|
|
845
|
+
lane each time. Each attempt that fails in less time than the interval now
|
|
846
|
+
doubles the next wait, up to 8× (15m becomes 2h); one attempt that runs at
|
|
847
|
+
least the interval long puts it back. It still never stops on its own: a
|
|
848
|
+
run whose cause goes away overnight is moving again before morning. The
|
|
849
|
+
`node.unattended_retry` log line reports the actual wait and the streak.
|
|
850
|
+
|
|
851
|
+
- **Notifications have an inbox, and are heard from every view.** The UI's
|
|
852
|
+
notifications used to be a row of banners in the top bar, shown only when
|
|
853
|
+
browser notifications were refused. They piled up there and could be read
|
|
854
|
+
only one at a time, by dismissing whichever was in front. Every notification
|
|
855
|
+
now lands in an inbox behind a bell with an unread count: newest first,
|
|
856
|
+
filterable by unread and by still-waiting pauses, marked read one at a time
|
|
857
|
+
or all at once, dismissed singly or cleared. A pause that gets answered stays
|
|
858
|
+
listed and says *Answered*. The inbox is kept in `localStorage` and shared by
|
|
859
|
+
every tab, so a reload no longer loses it. It stores what a notification
|
|
860
|
+
body already carries — a run id, a node id, a reason and the journal's
|
|
861
|
+
timestamp — and no question text, output or diff. Browser notifications also
|
|
862
|
+
reach the operator more often now. They used to fire only for the run open
|
|
863
|
+
on screen; the UI now follows every running run in the background, and a run
|
|
864
|
+
view takes over that run's stream instead of opening a second one. They also
|
|
865
|
+
depended on a permission prompt raised by the first pause, which Firefox and
|
|
866
|
+
Safari ignore when no click raised it, so on those browsers they could never
|
|
867
|
+
turn on. An *Enable notifications* button now sits in the top bar until the
|
|
868
|
+
browser has been asked (and in the inbox too), and confirms with one test
|
|
869
|
+
notification. It also says why the channel is off
|
|
870
|
+
when it is: blocked in the browser's site settings, or served over plain
|
|
871
|
+
HTTP on a remote `--host`, which browsers do not allow notifications from.
|
|
872
|
+
The reminder interval moved into the inbox.
|
|
873
|
+
|
|
874
|
+
- **The run view's Nodes table names a lane by what distinguishes it.**
|
|
875
|
+
Every lane in a run is named `${runId}-...`, so the column spelled them in
|
|
876
|
+
full as `2026-09-11-graphql-aggregations-mubou9ar-crew-3-tier4` on every
|
|
877
|
+
row, phase after phase — the same forty characters of prefix repeated down
|
|
878
|
+
the table, wide enough to push the whole table into a horizontal scroll for
|
|
879
|
+
the sake of a string that was identical everywhere it appeared. The cell now
|
|
880
|
+
shows the tail that actually differs (`crew-3-tier4`, `lane-2`, `integ`) and
|
|
881
|
+
keeps the full name in its `title`, because that is what the worktree
|
|
882
|
+
directory and the branch are called. The phase description beside the node
|
|
883
|
+
id is bounded and wraps for the same reason — table cells are
|
|
884
|
+
`whitespace-nowrap`, so one long phase name was setting the width of the
|
|
885
|
+
whole table.
|
|
886
|
+
|
|
887
|
+
- **A dispatched phase agent does the work itself, instead of spawning an
|
|
888
|
+
implementer under it.** claude-code sessions run by the orchestrator were
|
|
889
|
+
handing their phase to a sub-agent and reporting its summary back, and the
|
|
890
|
+
pull was not laziness — `implement-phase` ships into the same repositories,
|
|
891
|
+
its description matches "you are implementing P3 of plan X", and its content
|
|
892
|
+
is "spawn exactly one implementer subagent". So a session was loading a
|
|
893
|
+
conductor skill on its own and correctly following it, one level below the
|
|
894
|
+
conductor that had already spawned it. The cost is the whole point of session
|
|
895
|
+
reuse: a sub-agent's reading of the codebase ends with the sub-agent, so the
|
|
896
|
+
warm session that every cross-phase turn greets with "everything you learned
|
|
897
|
+
still holds" was left holding a paragraph, and each phase paid a cold agent's
|
|
898
|
+
first turn again. Both halves are now closed. Every `vinta-ai-maestro` role
|
|
899
|
+
prompt (implementer, reviewer, fixer, chore — cold and continued) carries a
|
|
900
|
+
no-delegation section that names those skills and says what delegating costs,
|
|
901
|
+
and the plan-execution unit grows a `dispatched-agent` partial: a guard at the
|
|
902
|
+
top of all four conductors refusing entry to an agent that was itself handed
|
|
903
|
+
one phase, plus the same rule inside every composed implementer prompt.
|
|
904
|
+
|
|
905
|
+
- **The node view's gate panel is a list of verdicts you can open, not a stack
|
|
906
|
+
of scrolling boxes.** Every gate used to render its whole log at once, each
|
|
907
|
+
in its own fixed-height box with its own scrollbar — so three gates in a
|
|
908
|
+
third of a grid row was a column of letterbox slots, and a wheel gesture
|
|
909
|
+
over one of them was swallowed by that box instead of scrolling the page.
|
|
910
|
+
Gates are now an accordion: one row per gate, only one open at a time, and
|
|
911
|
+
the open log has no scroller of its own (it is tail-truncated at 64 KiB
|
|
912
|
+
already, and long lines wrap the way the diff panel's do). The panel opens
|
|
913
|
+
on the gate a human question points at, or on the first that is not passing.
|
|
914
|
+
|
|
915
|
+
- **Each gate row says what happened and what it cost.** The verdict —
|
|
916
|
+
`running`, `passed`, `failed`, `timed out` — is on the wire now, so a phase
|
|
917
|
+
whose lint gate passed and whose unit gate failed reads as that instead of
|
|
918
|
+
as two identical rows; previously the UI could only name the single gate
|
|
919
|
+
§9.1's question happened to point at, because `NodeDetail` carried an id and
|
|
920
|
+
a log and nothing else. A running gate shows a clock counting from the
|
|
921
|
+
daemon's own start time, so a tab opened halfway through a slow suite shows
|
|
922
|
+
the true elapsed figure rather than starting from zero; a finished one shows
|
|
923
|
+
the runner's measurement of its latest attempt, with `cached` where the
|
|
924
|
+
cache served the verdict and a `×N` count where the gate has run more than
|
|
925
|
+
once.
|
|
926
|
+
|
|
927
|
+
- **Crew members are named after their tier, not after a seniority.** A roster
|
|
928
|
+
reads `tier1`, `tier2-1`, `tier2-2`, `tier4` and `reviewer` where it used to
|
|
929
|
+
read `junior`, `mid-1`, `mid-2` and `senior`. Nothing about the data model
|
|
930
|
+
moved — `tier` was already the 1-4 number the orchestrator staffs on, and it
|
|
931
|
+
is still the only thing compared when one member covers for another. What
|
|
932
|
+
changed is that the label beside it now says the same thing, instead of
|
|
933
|
+
offering a second vocabulary that could drift from it and that reads as a
|
|
934
|
+
ranking of people rather than of difficulty. Workflows using the old ids keep
|
|
935
|
+
running: the ids are free-form and nothing resolves them by name.
|
|
936
|
+
|
|
937
|
+
- **`plan-feature` emits its workflow with the plan's date prefix.** The
|
|
938
|
+
executable sibling is now
|
|
939
|
+
`ai-plans/YYYY-MM-DD-<feature-kebab>.workflow.json` — previously it carried
|
|
940
|
+
no date, which sorted it away from the `YYYY-MM-DD-FEATURE_NAME_PLAN.md` and
|
|
941
|
+
`_SPEC.md` it belongs to, so the one file you want with the plan open was the
|
|
942
|
+
one you had to go looking for. A feature's three files now land adjacent. The
|
|
943
|
+
case difference between them is not an oversight: the markdown convention is
|
|
944
|
+
`UPPERCASE_WITH_UNDERSCORES` and a workflow's filename stem *is* its `id`,
|
|
945
|
+
which the schema requires to be lowercase kebab-case, so the date prefix is
|
|
946
|
+
the only part the three can share. Existing dateless workflows are unaffected
|
|
947
|
+
— this is the emitter's convention, not a schema rule.
|
|
948
|
+
- **A gate's command can be retuned while the phase that runs it is still
|
|
949
|
+
running.** §9's amend refused any change reaching a node in flight, which is
|
|
950
|
+
exactly the node anyone is looking at when a run is dragging: a `unit` gate
|
|
951
|
+
missing `--reuse-db` could not be fixed until the run it was costing hours
|
|
952
|
+
had finished. The refusal now reads a narrower set. A node's harness, model,
|
|
953
|
+
pipeline, body and base are each read at a moment that has already passed, so
|
|
954
|
+
changing them is refused as before; a gate's *command* is resolved per gate
|
|
955
|
+
run by every reader of it, so a running phase simply runs the new command at
|
|
956
|
+
its next gate. Nothing downstream is blocked either, because a command moves
|
|
957
|
+
no branch's base. Changing **which** gates a node declares is still refused
|
|
958
|
+
mid-flight — a phase that gained a gate would finish without ever running it —
|
|
959
|
+
so that now counts as part of the phase body.
|
|
960
|
+
|
|
961
|
+
- **A gate result is cached against the command that produced it.** The key was
|
|
962
|
+
`(gate id, tree hash)`, on the assumption that a gate id names a command.
|
|
963
|
+
Amending a live run makes that false, and an unchanged tree would have been
|
|
964
|
+
served the old command's verdict. The command is now part of the key, hashed
|
|
965
|
+
rather than stored — a command line is repository content. A cache database
|
|
966
|
+
written before this is dropped when it is opened: its rows cannot say which
|
|
967
|
+
command produced them, and one re-run per stale entry is the price a lost row
|
|
968
|
+
already costs.
|
|
969
|
+
|
|
970
|
+
- **A session cannot inherit a machine's decision to stop compacting.** All
|
|
971
|
+
three harnesses compact automatically when their context fills — there was
|
|
972
|
+
never a flag to turn on — but each honours an environment variable that turns
|
|
973
|
+
it off, and an agent spawned on a machine carrying one would run a long phase
|
|
974
|
+
straight into a wall it was supposed to be able to survive. Those variables
|
|
975
|
+
are now stripped from every child the daemon spawns, and claude-code's own
|
|
976
|
+
setting is reasserted in the per-lane file beside its permission rules. The
|
|
977
|
+
window itself is left alone: an operator who narrowed theirs compacts earlier,
|
|
978
|
+
which is not the failure this guards against. A harness that compacts declares
|
|
979
|
+
it, and a compaction the harness reports is a transcript row like any other.
|
|
980
|
+
|
|
981
|
+
One consequence worth knowing: `max_session_turns` used to be a proxy for "this
|
|
982
|
+
session is nearing a context window it will die on". That death no longer
|
|
983
|
+
happens, so the ceiling now guards a different thing — a session whose memory
|
|
984
|
+
was replaced by a summary of itself, and which answers just as confidently.
|
|
985
|
+
|
|
986
|
+
- **Agent prompts name gates by id rather than printing their commands.** The
|
|
987
|
+
implementer's step 4 was descriptive — "Outer gate… These run against your
|
|
988
|
+
lane:" followed by the gate commands — and implementers were observed reading
|
|
989
|
+
it as a note about what would run later, finishing the scoped inner loop and
|
|
990
|
+
never running a gate at all. It is imperative now, and every role that runs a
|
|
991
|
+
gate (implementer, reviewer, fixer, and the continuation of each) is pointed
|
|
992
|
+
at `vinta-ai-maestro gate <id>`. The fixer prompts no longer say to re-run the
|
|
993
|
+
gates "until they are green", which contradicted the commit protocol directly
|
|
994
|
+
below them and left fixers running out the turn with the work uncommitted;
|
|
995
|
+
they now say to commit and report FAILURE when a gate cannot be turned green.
|
|
996
|
+
Implementers and fixers report which gates they ran and what each returned —
|
|
997
|
+
a record for the reviewer to check against, explicitly not a licence for the
|
|
998
|
+
reviewer to skip running them itself.
|
|
999
|
+
|
|
182
1000
|
- **Phase branches base on their dependencies, not on the previous phase.** A phase
|
|
183
1001
|
with no dependencies cuts from the default branch; one with a single dependency
|
|
184
1002
|
cuts from that phase's branch; one with several cuts from a
|
|
@@ -215,8 +1033,893 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
215
1033
|
`plan/{plan-id}/lane-{phase-id}` branches, merged `--no-ff` into the single plan
|
|
216
1034
|
branch at each wave boundary, so the unit commits survive.
|
|
217
1035
|
|
|
1036
|
+
- **`project.prepare_cmd`, for the shared servers a run depends on.** A project
|
|
1037
|
+
whose databases are `delivery: external` and whose services point at one Redis
|
|
1038
|
+
has no long-lived containers of its own — the shape these fields recommend —
|
|
1039
|
+
and that makes some *other* stack a hard dependency of every run. Nothing in
|
|
1040
|
+
the package could bring it up. `setup_cmd` looks like the place and is not: it
|
|
1041
|
+
runs per lane, long after the template database was created on a server that
|
|
1042
|
+
had to be up for `createdb` to work at all.
|
|
1043
|
+
|
|
1044
|
+
It runs in the repository root **before anything else a run does** — before
|
|
1045
|
+
the preflight, before the templates, before the first worktree — and again
|
|
1046
|
+
before every lane recycle, so a server that dies mid-run is restored at the
|
|
1047
|
+
next hand-off rather than failing every phase after it. Failure aborts with
|
|
1048
|
+
the exit code and a bounded stderr tail, and says what the failure means
|
|
1049
|
+
rather than only that a command exited. It must be idempotent, and `--wait`
|
|
1050
|
+
is only as good as the `healthcheck` a service declares: without one, compose
|
|
1051
|
+
returns as soon as the container starts and `createdb` races the server.
|
|
1052
|
+
|
|
1053
|
+
- **A merge conflict goes to the most senior member who wrote one of its
|
|
1054
|
+
sides.** The conflict fixer was staffed from `defaults` and ignored the roster
|
|
1055
|
+
entirely, so on a tiered crew a collision between two Tier 4 phases was handed
|
|
1056
|
+
to a default-tier agent that had read neither of them — the hardest merge in
|
|
1057
|
+
the run going to the least contextualised agent available, and resolved by
|
|
1058
|
+
guessing which side looked more finished.
|
|
1059
|
+
|
|
1060
|
+
`Integrator` already knows which nodes own the contested paths, and `node_crew`
|
|
1061
|
+
already records who took each one; this is the join. Highest tier among them
|
|
1062
|
+
wins, on that member's own `model` and `harness`, and a tier tie breaks on
|
|
1063
|
+
member id the way roster substitution breaks its own. An unstaffed workflow
|
|
1064
|
+
still resolves through `defaults`, unchanged, and so does a conflict whose
|
|
1065
|
+
nodes cannot be resolved to a member.
|
|
1066
|
+
|
|
1067
|
+
What is carried is the member's **capability, not their session**. A phase's
|
|
1068
|
+
session ran in that phase's lane; the fixer runs in the integration worktree,
|
|
1069
|
+
where the files in dispute are half-merged and unlike anything that session
|
|
1070
|
+
saw — resuming there would give the agent confident, false memories of exactly
|
|
1071
|
+
the files it is merging. The prompt tells the fixer which side is its own, and
|
|
1072
|
+
in the same breath that it is a fresh session and must read rather than
|
|
1073
|
+
recall.
|
|
1074
|
+
|
|
218
1075
|
### Fixed
|
|
219
1076
|
|
|
1077
|
+
- **maestro asks you to log in instead of failing on a logged-out harness.**
|
|
1078
|
+
A CLI that was not logged in (or whose token was rejected) was `fatal`: the
|
|
1079
|
+
node failed and its whole subtree blocked. It now parks in `awaiting_human`
|
|
1080
|
+
on a "not logged in" question answered with `logged in` or `stop`, holding
|
|
1081
|
+
its lane. Nothing answers it for you — no automatic or unattended retry,
|
|
1082
|
+
regardless of `onFailure` — and one `logged in` resumes every node that
|
|
1083
|
+
harness refused. Adapters report it as the new `unauthenticated` refusal
|
|
1084
|
+
kind (Claude Code, Codex and opencode).
|
|
1085
|
+
- **maestro no longer fails a node on an organization spend cap.** Claude
|
|
1086
|
+
Code's `billing_error` "spend limit reached (daily; resets …)", the
|
|
1087
|
+
`org_spend_cap_reached` overage reason and "usage credit limit reached"
|
|
1088
|
+
matched no refusal pattern and were classified `fatal`, failing the node and
|
|
1089
|
+
blocking its subtree. They are now `quota` waits, and the stated
|
|
1090
|
+
`resets YYYY-MM-DD HH:MM UTC` time is honored as the wake time.
|
|
1091
|
+
|
|
1092
|
+
- **A failed Claude Code turn no longer reads as `claude-code result:
|
|
1093
|
+
success`.** When the CLI ends a turn with `is_error: true` beside
|
|
1094
|
+
`subtype: "success"` (how a plan limit arrives, for one), the recorded
|
|
1095
|
+
error printed the subtype and said "success" — 189 times in one observed
|
|
1096
|
+
run. It now reads `claude-code result: is_error`. Other subtypes
|
|
1097
|
+
(`error_max_turns`, …) are unchanged.
|
|
1098
|
+
|
|
1099
|
+
- **The monitor's conversation was mostly unformatted JSON.** Not its answers —
|
|
1100
|
+
its *watchdog's*. An intervention turn must reply with one document matching
|
|
1101
|
+
`intervention.v1.schema.json`, which is what makes the monitor's authority
|
|
1102
|
+
over a live run a closed set of verbs rather than an editor over
|
|
1103
|
+
`workflow.json`; and that turn is journalled into the conversation a person
|
|
1104
|
+
reads, because a run that retuned itself should say so where somebody is
|
|
1105
|
+
already looking. Both of those are right. Rendering the document verbatim was
|
|
1106
|
+
not, and the summary paragraph the operator wanted arrived a thousand
|
|
1107
|
+
characters into one unwrapped line of braces. A proposal now renders as what
|
|
1108
|
+
it says: the summary, then one line per proposed change with its evidence
|
|
1109
|
+
under it, and a tone dot only when something was actually proposed — a turn
|
|
1110
|
+
that looked and changed nothing is the expected outcome and should not shout.
|
|
1111
|
+
The verb table is keyed on the daemon's own union, so a fifth verb fails the
|
|
1112
|
+
UI build rather than shipping as a bare identifier. The journal still holds
|
|
1113
|
+
the bytes the model wrote — only the row changed, so conversations already on
|
|
1114
|
+
disk read as well as new ones. Any other whole-JSON answer is at least
|
|
1115
|
+
indented.
|
|
1116
|
+
|
|
1117
|
+
- **The monitor's conversation opened at its oldest entry and never scrolled.**
|
|
1118
|
+
It followed the newest row *only while a turn was running*, on the reasoning
|
|
1119
|
+
that the list is short and the operator is watching the answer they just
|
|
1120
|
+
asked for. Neither half held: the conversation is the journal's, so it holds
|
|
1121
|
+
every question ever asked about the run plus every proposal the run's own
|
|
1122
|
+
watchdog made with nobody asking anything — a hundred entries is ordinary.
|
|
1123
|
+
Opening the panel therefore put the reader at the oldest of them. It now
|
|
1124
|
+
follows the way a phase's transcript does: stuck to the newest row, letting
|
|
1125
|
+
go the moment the reader scrolls up to read, with a "Jump to latest" as the
|
|
1126
|
+
way back. That rule is one module now rather than a well-tested copy in the
|
|
1127
|
+
transcript and none in the monitor, which is how the panel came to be missing
|
|
1128
|
+
three of its parts — including the one that survives a panel being expanded
|
|
1129
|
+
to full page, where the portal hands the view a brand new list scrolled to
|
|
1130
|
+
the top.
|
|
1131
|
+
|
|
1132
|
+
- **Hitting the plan's session or weekly limit failed the node instead of
|
|
1133
|
+
waiting for the window to end.** `claude-code`'s refusal table recognised
|
|
1134
|
+
"usage limit reached" and nothing else, and the classifier's default is
|
|
1135
|
+
`fatal` — correctly, since an unrecognised failure must not become an
|
|
1136
|
+
unbounded wait. But the CLI announces a plan window in its own words:
|
|
1137
|
+
"You've hit your session limit", "Session limit reached · resets 3am",
|
|
1138
|
+
"5-hour limit reached", "You've reached your weekly limit". None of those
|
|
1139
|
+
contain "usage limit", so every one of them fell past the table to `fatal`,
|
|
1140
|
+
which fails the node and blocks its whole dependent subtree — for a window
|
|
1141
|
+
that ends by itself in a few hours. The machinery to do the right thing was
|
|
1142
|
+
already there and simply never reached: a `quota` refusal parks the harness,
|
|
1143
|
+
not the node, so every later node joins one wait instead of discovering the
|
|
1144
|
+
limit for itself; the wake time is journalled and survives a daemon restart;
|
|
1145
|
+
and the AIMD ceiling is left alone, because a plan window says nothing about
|
|
1146
|
+
how many agents may run at once. Those wordings are now `quota`. The new row
|
|
1147
|
+
sits *below* `concurrency` and `rate_limit` so that "concurrent session limit
|
|
1148
|
+
reached" keeps the kind that halves the ceiling, and "approaching session
|
|
1149
|
+
limit" — a warning from a harness that is still working — matches nothing.
|
|
1150
|
+
|
|
1151
|
+
- **A window that closed *under* a running turn was an ordinary turn failure.**
|
|
1152
|
+
§6.1 is written about a spawn, because that is where a vendor usually says
|
|
1153
|
+
"not right now" — and everything that follows from it, parking the harness so
|
|
1154
|
+
every later node joins one wait, journalling the wake time so a daemon
|
|
1155
|
+
restart does not forget it, leaving the AIMD ceiling alone for a window that
|
|
1156
|
+
says nothing about concurrency, hung off `admit`. So the other arrival of the
|
|
1157
|
+
same fact had none of it: a plan window that closes while an agent is twenty
|
|
1158
|
+
minutes into a phase ends the turn, and the node then burnt its retries
|
|
1159
|
+
against a closed window and failed, blocking its whole dependent subtree —
|
|
1160
|
+
the exact outcome §6.1 exists to prevent, reached by the one path that did not
|
|
1161
|
+
go through admission control. A session now reports a `TurnRefusal`, and the
|
|
1162
|
+
caller answers it with the `CapacityRetry` a refused spawn raises: the lane
|
|
1163
|
+
goes back, the harness parks until the stated reset, and the node re-drives
|
|
1164
|
+
when the window opens.
|
|
1165
|
+
|
|
1166
|
+
Each adapter reads it where its own failure prose is, which is not where its
|
|
1167
|
+
events are: `claude-code`'s terminal `result` frame carries the sentence in
|
|
1168
|
+
the `result` string that `mapResult` deliberately drops (it is agent output,
|
|
1169
|
+
§11), `codex` states a failure as prose on three different frames, and
|
|
1170
|
+
`opencode`'s `session.error` carries it under `data`, which `#errorName`
|
|
1171
|
+
refuses to put in an event. All three read that prose, match it against the
|
|
1172
|
+
table they already had, and drop it — what reaches the caller is a kind, a
|
|
1173
|
+
fixed reason token and a reset time, and what reaches the transcript is one
|
|
1174
|
+
token-only line so the record says why the turn stopped. The stderr-and-exit
|
|
1175
|
+
shape of the same event is read too, from the diagnostics buffer that is the
|
|
1176
|
+
only place that sentence exists.
|
|
1177
|
+
|
|
1178
|
+
The re-drive is a full one, and that is deliberate: the session the turn was
|
|
1179
|
+
using is gone, and resuming from a memory of files a recycle has removed is
|
|
1180
|
+
worse than redoing the work. Nothing is destroyed by it — `recycle` sets
|
|
1181
|
+
aside whatever the turn left uncommitted as a WIP ref first. What it costs is
|
|
1182
|
+
the turn. What it used to cost was the node.
|
|
1183
|
+
|
|
1184
|
+
- **A stated reset time was only read when it was an hour on the same day.**
|
|
1185
|
+
`parseRetryAfter` prefers a reset the vendor reported over a guessed backoff,
|
|
1186
|
+
and its wall-clock pattern wanted `am`/`pm` immediately after "reset", so
|
|
1187
|
+
"resets at 15:00", "resets tomorrow at 2am" and the weekly window's "resets
|
|
1188
|
+
on Monday at 12am" all reported nothing — falling back to the five-minute
|
|
1189
|
+
re-probe interval, which across a week-long window is two thousand spawns to
|
|
1190
|
+
discover what the first sentence said. It now reads 24-hour times, `today`,
|
|
1191
|
+
`tomorrow` and a named weekday (the next occurrence of it, which is today
|
|
1192
|
+
only while the hour is still ahead). A reset named by date, "resets Nov 3 at
|
|
1193
|
+
9am", still reports nothing on purpose: a month with no year is a guess, and
|
|
1194
|
+
the re-probe is a better answer than a wait that is wrong by a year. So are
|
|
1195
|
+
"reset 3", "resets at 25:00" and "resets at 13pm" — an hour with neither
|
|
1196
|
+
minutes nor a meridiem is as likely to be a version or a retry count, and
|
|
1197
|
+
everything this function returns becomes a wait.
|
|
1198
|
+
|
|
1199
|
+
- **`run --resume` could not provision a pool at all on a project that
|
|
1200
|
+
disables hooks.** `#configureHooks` enables `extensions.worktreeConfig`
|
|
1201
|
+
before it can set `core.hooksPath --worktree`, and that first key is
|
|
1202
|
+
repository-wide: the write lands in the shared `.git/config`, which git takes
|
|
1203
|
+
`.git/config.lock` to edit. Called once per lane out of the provisioning
|
|
1204
|
+
`Promise.all`, the lanes collided on that lock — `could not lock config file
|
|
1205
|
+
…: File exists`. A fresh provision never showed it, because `worktree add`
|
|
1206
|
+
goes through the pool's serialized git turn and staggered the lanes apart by
|
|
1207
|
+
the time they reached the shared write; `adopt` skips `worktree add`, so every
|
|
1208
|
+
lane arrived in the same tick and **every** resume of a `hooks: false` project
|
|
1209
|
+
failed, reproducibly, before a single phase was scheduled. The extension now
|
|
1210
|
+
goes through the same serialized turn. The `--worktree` write stays parallel:
|
|
1211
|
+
it lands in `.git/worktrees/<name>/config.worktree`, one file per lane.
|
|
1212
|
+
|
|
1213
|
+
- **A provision failure that was not one of three enumerated kinds said nothing
|
|
1214
|
+
about itself.** `refusal` detailed `DiskProbeError`, `LaneSetupError` and
|
|
1215
|
+
`LaneEnvFileError`; everything else — including the lock collision above and
|
|
1216
|
+
`LaneAdoptError`, the one error a resume is most likely to hit — collapsed to
|
|
1217
|
+
"could not provision the lane pool under …", and the daemon log recorded that
|
|
1218
|
+
same sentence as `run.provision_failed`'s `reason` with no `error` field and
|
|
1219
|
+
no stack. So the run that could not start left behind no record of why, in
|
|
1220
|
+
either place an operator looks. The exclusion was a §11 reading
|
|
1221
|
+
`LaneSetupError` had already revised for this exact reason: §11 keeps
|
|
1222
|
+
repository *contents* out of the record — diffs, file bodies, gate output —
|
|
1223
|
+
and an error's own complaint about a lock file or a ref is not that. An
|
|
1224
|
+
unenumerated error's message is now carried, capped at 500 characters and run
|
|
1225
|
+
through the log's redaction set; `LaneAdoptError` speaks for itself like the
|
|
1226
|
+
other lane errors; and the failure is logged with its kind and stack frames.
|
|
1227
|
+
|
|
1228
|
+
- **`doctor` reported the resumed run's own lanes as leftovers blocking it, and
|
|
1229
|
+
offered to destroy them.** The held-branch check fails a run whose phase
|
|
1230
|
+
branches are checked out in another worktree, which is right for a fresh run
|
|
1231
|
+
and exactly wrong for a resume: the integrator puts a lane on
|
|
1232
|
+
`plan/<id>/phase-<n>` for the duration of a phase, so a run killed mid-phase
|
|
1233
|
+
— the kill a resume is *for* — leaves its own lanes holding precisely those
|
|
1234
|
+
branches. Every `run --resume` therefore refused preflight with one failure
|
|
1235
|
+
per phase in flight, each remedied by `git worktree remove --force <lane>`,
|
|
1236
|
+
which deletes the uncommitted work the resume existed to adopt. The check now
|
|
1237
|
+
takes the run being resumed and excludes lanes belonging to it, identified by
|
|
1238
|
+
reading the lane root and asking each worktree which branch it holds — never
|
|
1239
|
+
by comparing git's printed paths with this process's, the platform trap
|
|
1240
|
+
`reap` and `LanePool` both document. `doctor` takes `--resume <run-id>` to ask
|
|
1241
|
+
the same question before a resume, and a lane of *another* run still fails.
|
|
1242
|
+
|
|
1243
|
+
- **`vinta-ai-maestro gate` gave up on the slowest gate after five minutes and
|
|
1244
|
+
called it a daemon it could not reach.** The command awaited one `fetch`, on
|
|
1245
|
+
the stated reasoning that a gate is slow for reasons the client cannot shorten
|
|
1246
|
+
and so the client should simply wait — while its own comment claimed it
|
|
1247
|
+
imposed no deadline of its own. It imposed 300 seconds, because that is where
|
|
1248
|
+
Node's `fetch` abandons a response whose headers have not arrived, and a gate
|
|
1249
|
+
that queues for a capacity-1 semaphore and then runs a test suite is routinely
|
|
1250
|
+
slower. In a measured fourteen-hour run this fired **33 times, every one of
|
|
1251
|
+
them on the `unit` gate and none on any other** — a perfect correlation with
|
|
1252
|
+
duration, not a flaky daemon. The gates were running fine and cached green
|
|
1253
|
+
results minutes later; only the answer was lost. Told a transport lie about
|
|
1254
|
+
work in progress, agents wrote polling loops around a command documented as
|
|
1255
|
+
needing none: in one phase, **24 of 108 shell turns were pure waiting, six of
|
|
1256
|
+
them burning a full ten-minute ceiling — 60 minutes, 31% of that phase.** The
|
|
1257
|
+
wait is a `202` hop loop now, which is what `with` already does, having found
|
|
1258
|
+
the same bug the same way and fixed it first.
|
|
1259
|
+
|
|
1260
|
+
- **A gate command cut short by the harness started the suite over.** An agent
|
|
1261
|
+
harness caps how long one command may run, and a gate may exceed any such cap
|
|
1262
|
+
— a plan declaring `timeout_s: 2400` is asking for forty minutes against a
|
|
1263
|
+
ten-minute budget. So being killed partway is the *ordinary* ending, and what
|
|
1264
|
+
an agent does next is run the command again. That used to start a second full
|
|
1265
|
+
suite beside the first, queued behind the very semaphore its own predecessor
|
|
1266
|
+
was still holding. The daemon now keys a running gate on `(phase, gate id)`
|
|
1267
|
+
and the re-invocation attaches to it, which makes re-running the command the
|
|
1268
|
+
correct move rather than a wasteful one — worth having, because it is the move
|
|
1269
|
+
an agent makes anyway. There is no token to carry, deliberately: a client that
|
|
1270
|
+
was killed has nothing in hand, and needing something would defeat the point.
|
|
1271
|
+
|
|
1272
|
+
- **A pipeline that could not progress was journalled as the word "Error".** The
|
|
1273
|
+
interpreter composes an id-safe reason for exactly this case — which state it
|
|
1274
|
+
could not leave, and which trigger failed to match — and the scheduler threw
|
|
1275
|
+
it as a bare `Error`. `failureReason` reports an unrecognised error by its
|
|
1276
|
+
name, so the sentence was discarded at the one moment it was worth keeping.
|
|
1277
|
+
It is a `PipelineStuckError` now, carrying the state, and the reason survives
|
|
1278
|
+
into the journal. The same shape as the non-zero git exit, fixed the same way.
|
|
1279
|
+
|
|
1280
|
+
- **A pull request said nothing but the plan anchor.** The daemon opened PRs
|
|
1281
|
+
with `title: node.name` and `body: node.prompt_ref` — one line, a link to a
|
|
1282
|
+
heading. It had no idea the `prs-context` mechanism existed: there was not a
|
|
1283
|
+
single reference to it in the package, so the rich path the skills use
|
|
1284
|
+
(`open-pr-from-context`, the project's own PR template, inline review
|
|
1285
|
+
comments) was never reached from a run. `open_pr` now reads the phase's
|
|
1286
|
+
`.vinta-ai-workflows/prs-context/<plan>/phase-<node>.md` when the agent wrote
|
|
1287
|
+
one, and the implementer is asked to write it — the 5–15 line summary it
|
|
1288
|
+
already produces, put where a human will read it instead of only the
|
|
1289
|
+
transcript. With no context file the body is composed from the run's own
|
|
1290
|
+
record: the brief, what the phase is based on and why that is not the default
|
|
1291
|
+
branch, its declared surface, its gates, how many attempts it took, and any
|
|
1292
|
+
merge conflicts an agent resolved on the way in — which nobody reviews.
|
|
1293
|
+
|
|
1294
|
+
- **A phase with two dependencies could never open a pull request.** Its base is
|
|
1295
|
+
an `integ-<id>` branch and `git_push` pushes only the node's own branch, so
|
|
1296
|
+
`gh` was asked to open against a ref the forge had never seen. It refused, the
|
|
1297
|
+
refusal was discarded, and the phase completed with no PR and nothing saying
|
|
1298
|
+
so — in one observed run, the single node with two dependencies was the single
|
|
1299
|
+
node with no PR. The integration base is pushed before the PR is opened, and
|
|
1300
|
+
every outcome is journalled as `node_pr`, so a PR that did not open is now as
|
|
1301
|
+
visible as one that did.
|
|
1302
|
+
|
|
1303
|
+
- **A conflict resolution was never gated.** `IntegratorOptions.verify` has
|
|
1304
|
+
existed as long as the conflict loop, documented as "a resolution that does
|
|
1305
|
+
not build is not a resolution", and nothing ever supplied it. Six merges in
|
|
1306
|
+
one run were resolved by an agent and went straight in — ungated — to become
|
|
1307
|
+
the base the next phase built on, while the phases either side were gated to
|
|
1308
|
+
the hilt. The union of the conflicting nodes' declared gates now runs in the
|
|
1309
|
+
integration worktree, with that worktree's environment, and a red gate spends
|
|
1310
|
+
a fix round instead of shipping.
|
|
1311
|
+
|
|
1312
|
+
- **A conflict fixer that committed its own resolution failed the phase.** An
|
|
1313
|
+
agent told to resolve a merge conflict reaches for the sequence a person
|
|
1314
|
+
would — abort, merge again, resolve, commit — and the orchestrator then
|
|
1315
|
+
committed unconditionally on top of it. Against an already-committed
|
|
1316
|
+
resolution `git add --all` is a no-op that exits 0 and `git commit --no-edit`
|
|
1317
|
+
exits 1 with "nothing to commit", which is a throw. A successful resolution
|
|
1318
|
+
was reported as a failed phase, deterministically, on **every wave after a
|
|
1319
|
+
parallel one**: a multi-dependency node is the only thing that merges here,
|
|
1320
|
+
and two sibling phases both creating one file is the common case rather than
|
|
1321
|
+
the rare one. The phase died before its branch was cut, so it left no
|
|
1322
|
+
transcript, no gate log and no branch — only a resolved merge commit sitting
|
|
1323
|
+
in the integration worktree. The commit is now conditional on there being
|
|
1324
|
+
something to commit, and a fixer that discarded the merge instead of resolving
|
|
1325
|
+
it is refused rather than recorded as integrated.
|
|
1326
|
+
|
|
1327
|
+
- **The conflict fixer's turn is in the transcript now.** Its event stream was
|
|
1328
|
+
drained and every event dropped — an unread stream never ends — so the one
|
|
1329
|
+
agent turn in a run nobody could watch live was also the one nobody could read
|
|
1330
|
+
afterwards: a resolved merge, a row saying it took two rounds, and no record of
|
|
1331
|
+
what was decided. It lands in the incoming phase's own transcript, beside the
|
|
1332
|
+
implementer and reviewer turns that produced the branches being merged, under
|
|
1333
|
+
a `conflict-fixer` role that keeps it distinguishable from the review fixer —
|
|
1334
|
+
a different job, in a different worktree, on a different thing. The UI has had
|
|
1335
|
+
a band for that role since transcripts learned to name their authors; it had
|
|
1336
|
+
simply never been given one to draw.
|
|
1337
|
+
|
|
1338
|
+
- **`PlanDefectError` is now `UnresolvedConflictError`.** The old name made a
|
|
1339
|
+
judgement the orchestrator is not entitled to make. Two same-wave phases
|
|
1340
|
+
touching one file is not a broken plan — the plan's file-overlap analysis is a
|
|
1341
|
+
guess made before a line was written, and the fixer exists because of it. What
|
|
1342
|
+
reaching that error means is narrower: *this* conflict outlasted its rounds and
|
|
1343
|
+
needs a person. The message says so, and now leads with finishing the merge by
|
|
1344
|
+
hand in the integration worktree — which, since a prepared base is reused,
|
|
1345
|
+
survives into the retry — rather than with re-cutting the plan.
|
|
1346
|
+
|
|
1347
|
+
- **A conflict was resolved again on every retry, and recorded nowhere.**
|
|
1348
|
+
Conflicts are an ordinary outcome — the plan's file-overlap analysis is a
|
|
1349
|
+
guess and two sibling phases legitimately edit one file — but `prepareBase`
|
|
1350
|
+
reset and re-merged its `integ-<id>` branch unconditionally, so each retry
|
|
1351
|
+
spawned a fresh fixer agent to redo work already done, and discarded any
|
|
1352
|
+
resolution a person had finished by hand in that worktree. One observed run
|
|
1353
|
+
paid for the same resolution three times. A base that already integrates every
|
|
1354
|
+
dependency's current tip is now kept; one built before a dependency moved is
|
|
1355
|
+
still rebuilt, because reuse is about reachability of the tips rather than
|
|
1356
|
+
about the branch existing. Every settled conflict is also journalled as a
|
|
1357
|
+
`node_conflict` event naming both participants, the paths and the rounds it
|
|
1358
|
+
took — previously a wave conflict reached only the post-mortem and a *base*
|
|
1359
|
+
conflict was discarded entirely, so a phase could sit in `running` for minutes
|
|
1360
|
+
while an agent merged in a worktree nobody could see.
|
|
1361
|
+
|
|
1362
|
+
- **A failed attempt now says why, wherever it goes next.** The reason was
|
|
1363
|
+
computed at the failure site and handed to the path that gives up — which the
|
|
1364
|
+
default `onFailure: retry` does not take: it retries automatically, then parks
|
|
1365
|
+
on "This phase failed. Try it again?". Both paths dropped the reason, and
|
|
1366
|
+
`#offerRetry` carried a comment asserting the opposite. A phase that failed
|
|
1367
|
+
three times before any agent ran was undiagnosable after the fact, and the
|
|
1368
|
+
only offered action was to repeat it. Every attempt now writes a `node_error`
|
|
1369
|
+
event carrying its reason and attempt number, and a `node.attempt_failed`
|
|
1370
|
+
record to the daemon log.
|
|
1371
|
+
|
|
1372
|
+
- **A git command that exited non-zero was persisted as the word "Error".**
|
|
1373
|
+
`failureReason` reports an unrecognised error by its name plus a *string*
|
|
1374
|
+
`code`, and an `execFile` rejection carries `name: 'Error'` with a *numeric*
|
|
1375
|
+
one — so the most common real failure in this package said nothing at all.
|
|
1376
|
+
Git failures now carry their subcommand and exit status (`git commit exited
|
|
1377
|
+
1`), which is a command name and an exit code rather than anything §11 keeps
|
|
1378
|
+
out of the journal.
|
|
1379
|
+
|
|
1380
|
+
- **The conflict fixer ran without its worktree's environment.** It was the one
|
|
1381
|
+
agent spawn not given `AgentTask.env`, whose own docstring records this exact
|
|
1382
|
+
bug class. With the daemon's bare environment its `docker compose` resolved to
|
|
1383
|
+
a project named after the directory rather than the isolated one, ignored the
|
|
1384
|
+
`compose.publish: []` override that rides in `COMPOSE_FILE`, and published the
|
|
1385
|
+
project's fixed ports on the host — colliding with the developer's own stack
|
|
1386
|
+
and outliving the run.
|
|
1387
|
+
|
|
1388
|
+
- **"Retry with <member>" offered the member that had just failed.** The menu
|
|
1389
|
+
excluded the member the *plan* named, but a substitution means the member that
|
|
1390
|
+
actually ran is someone else — so a phase declared for one tier and covered by
|
|
1391
|
+
a higher one offered that higher one as its escalation, and a third of the
|
|
1392
|
+
menu did nothing distinguishable from plain retry.
|
|
1393
|
+
- **An amended workflow now reaches the integrator too, and a wave merge is
|
|
1394
|
+
pinned to the membership it was decided with.** Fixing the executor without
|
|
1395
|
+
fixing the integrator is what made this reachable: `#lastOfWave` decides a
|
|
1396
|
+
wave is complete by counting the executor's node set and `mergeWave` decided
|
|
1397
|
+
what to merge by reading the integrator's, so while both were stale they
|
|
1398
|
+
agreed with each other and nothing showed. One fresh and one stale is a wave
|
|
1399
|
+
whose merge silently omits the branch of a phase that ran.
|
|
1400
|
+
|
|
1401
|
+
The case that gets there is a phase nobody depends on. An amendment is
|
|
1402
|
+
refused while a node it *blocks* is in flight, and such a phase blocks
|
|
1403
|
+
nothing, so it lands freely beside the wave-mates it will be merged with.
|
|
1404
|
+
|
|
1405
|
+
A wave's membership is now computed once, synchronously, by the code that
|
|
1406
|
+
decides the wave is complete, and handed to the merge — a wave merge runs
|
|
1407
|
+
behind the integration worktree's queue and an amendment can land in between,
|
|
1408
|
+
so a merge that re-derived its own membership would merge a phase that never
|
|
1409
|
+
ran. §9's rebase goes through that same queue now, since "the nodes this
|
|
1410
|
+
amendment blocks are idle" says nothing about whether another wave's merge is
|
|
1411
|
+
writing in that directory.
|
|
1412
|
+
|
|
1413
|
+
- **An amended workflow now reaches the code that runs the gate.** `adopt`
|
|
1414
|
+
replaced the scheduler's copy of the run's definition and nothing else, while
|
|
1415
|
+
the effect executor and the agent-gate broker each held the snapshot they were
|
|
1416
|
+
constructed with — and the command a gate actually runs is read from the
|
|
1417
|
+
executor's. So an operator who edited a gate command mid-run moved the
|
|
1418
|
+
snapshot, the journal and the pool reservations, watched the amendment be
|
|
1419
|
+
accepted, and went on getting the old command. All three take the amendment
|
|
1420
|
+
now, fanned out from one place, host side before the scheduler so that no
|
|
1421
|
+
phase is dispatched against a definition half the system has not seen yet.
|
|
1422
|
+
|
|
1423
|
+
- **Closing a terminal on a run now records the interruption.** `run` and
|
|
1424
|
+
`serve` handle SIGHUP as well as SIGINT and SIGTERM — SIGHUP is what a
|
|
1425
|
+
terminal sends when its window closes, and with no handler Node's default was
|
|
1426
|
+
to die on the spot, running no teardown and writing no `run_ended`. Both
|
|
1427
|
+
commands now mark their live runs interrupted before exiting and print the
|
|
1428
|
+
`--resume` line for each, so a closed window leaves something recoverable
|
|
1429
|
+
instead of a row nothing will ever move again.
|
|
1430
|
+
|
|
1431
|
+
- **A member's reviews were counted as phases they took.** `node_crew` is
|
|
1432
|
+
written for both seats — the reviewer's claim carries `role: 'reviewer'`, the
|
|
1433
|
+
implementer's omits it — and the staffing rollup read neither, so every phase
|
|
1434
|
+
a member reviewed was folded into the count of phases they implemented. On any
|
|
1435
|
+
run with reviewers that inflated the number the rollup exists to put beside
|
|
1436
|
+
the plan's estimate, and inflated `asPlanned`, which the run view divides by.
|
|
1437
|
+
The two seats are counted apart now rather than one of them dropped: a review
|
|
1438
|
+
is real work by a real member, and a member who only reviewed is neither a
|
|
1439
|
+
phase-taker nor idle.
|
|
1440
|
+
|
|
1441
|
+
- **An agent taking a lease left the resource panel showing the one before it.**
|
|
1442
|
+
The scheduler's own gate-pool transitions are journalled as `gate_pool`
|
|
1443
|
+
events, so the browser re-reads the snapshot when one lands. An agent's lease,
|
|
1444
|
+
taken through `vinta-ai-maestro with`, was only a row in the `leases` table —
|
|
1445
|
+
correct in the daemon's projection and announced to nobody. A projection
|
|
1446
|
+
nobody is told changed is a projection nobody sees change, so the panel showed
|
|
1447
|
+
whatever holders it had last time some unrelated event happened to arrive, and
|
|
1448
|
+
the waits it was stalest about were the agent ones, which are the long ones.
|
|
1449
|
+
The broker now journals `agent_lease` on both edges. A renewal writes nothing:
|
|
1450
|
+
it is a heartbeat on a lease already reported, and journalling it would bury
|
|
1451
|
+
the two rows that are transitions under a liveness log.
|
|
1452
|
+
|
|
1453
|
+
- **An agent waiting for a semaphore could be overtaken without bound.** A
|
|
1454
|
+
`vinta-ai-maestro with` wait is served in fifteen-second hops so no client
|
|
1455
|
+
timeout has an opinion about it, and each hop used to abort the underlying
|
|
1456
|
+
`pools.acquire`. Aborting leaves the pool queue, and the next POST re-entered
|
|
1457
|
+
it — at the tail, behind every waiter that had arrived in the meantime. Since
|
|
1458
|
+
a gate run holds a capacity-1 semaphore for minutes, an agent lost that race
|
|
1459
|
+
on hop after hop while the scheduler's own in-process waiters, which never
|
|
1460
|
+
leave the queue, did not. The pool's aging rule could not help: aging reserves
|
|
1461
|
+
against waiters *behind* the aged one, and the waiters that overtook it are in
|
|
1462
|
+
front of it. A `202` now carries a `waitToken` naming the wait, the client
|
|
1463
|
+
sends it back, and the daemon keeps the one queue entry — one arrival time,
|
|
1464
|
+
one place in line — across the whole wait. A parked wait whose client stops
|
|
1465
|
+
hopping is reaped after a minute, releasing the slot if one was granted to it
|
|
1466
|
+
while nobody was watching.
|
|
1467
|
+
|
|
1468
|
+
- **The monitor's conversation could never be written on Windows.** It is kept
|
|
1469
|
+
under a reserved node id that becomes a directory, and that id was
|
|
1470
|
+
`monitor:conversation` — a colon, chosen because no phase id may contain one,
|
|
1471
|
+
and the drive separator on Windows. `mkdir` failed with `ENOENT`, so every
|
|
1472
|
+
question threw on its first append and the endpoint reported the monitor
|
|
1473
|
+
unavailable. A colon is legal in a macOS or Linux filename, which is why no
|
|
1474
|
+
machine the feature was built on ever saw it. The id is now
|
|
1475
|
+
`_monitor-conversation`: still unrepresentable as a phase id, and legal
|
|
1476
|
+
everywhere. Conversations recorded under the old id are not migrated.
|
|
1477
|
+
|
|
1478
|
+
- **An implementer was told both to commit and never to commit.** The prompt
|
|
1479
|
+
carried "never commit while a gate is red" beside "the turn is not complete
|
|
1480
|
+
until `git status --porcelain` is empty of your work" — a contradiction
|
|
1481
|
+
whenever the gate could not be turned green inside the turn, which is most of
|
|
1482
|
+
why fix rounds exist. Agents obeyed the `never`, and the reviewer one node
|
|
1483
|
+
later raised the BLOCKER it is told to raise for uncommitted work, spending a
|
|
1484
|
+
fix round re-implementing code that was already on disk. A red gate now
|
|
1485
|
+
changes the report and never the decision to commit: commit, and report
|
|
1486
|
+
FAILURE saying what is still red.
|
|
1487
|
+
|
|
1488
|
+
The reviewer's side was a false BLOCKER independently of that. Any unclean
|
|
1489
|
+
tree was a finding, and a lane's tree is never clean — the pool copies
|
|
1490
|
+
configuration in, links dependency trees, and the gates leave build output
|
|
1491
|
+
behind, none of which the implementer is allowed to stage. It is scoped to
|
|
1492
|
+
the failure it was written for now: work that is in the tree and missing from
|
|
1493
|
+
the diff.
|
|
1494
|
+
- **A live transcript stops following at entry sixty.** The effect that kept the
|
|
1495
|
+
box on the newest row was keyed on how many rows were *shown*, which is
|
|
1496
|
+
`min(entries, window)` — so it stopped changing the moment a transcript
|
|
1497
|
+
outgrew one window, and the following died silently and permanently, including
|
|
1498
|
+
after the operator scrolled back to the bottom to ask for it. Which is roughly
|
|
1499
|
+
minute two of any real phase. It follows on the entry count now, growing the
|
|
1500
|
+
window keeps the reader on the row they were reading instead of teleporting
|
|
1501
|
+
them, and a **Jump to latest** button says so out loud rather than leaving a
|
|
1502
|
+
60px band at the bottom of a scroller as the only way back in.
|
|
1503
|
+
|
|
1504
|
+
- **The transcript spends its space on the noisiest rows.** An agent's answer,
|
|
1505
|
+
its private reasoning and four hundred characters of tool-call JSON all
|
|
1506
|
+
rendered as the same two lines at the same weight. Thinking is now small and
|
|
1507
|
+
quiet, and a streamed thought is one row rather than the dozen events it
|
|
1508
|
+
arrived as; tool calls and their results fold to the argument that says what
|
|
1509
|
+
they did — a command, a path — and open individually or a whole kind at a time
|
|
1510
|
+
from the panel header. Prose is untouched and never folds.
|
|
1511
|
+
|
|
1512
|
+
- **A panel's expand control did nothing on the node view.** It expanded by
|
|
1513
|
+
taking `col-span-full`, which on the run view bought a strip a third wider and
|
|
1514
|
+
on the node view matched nothing at all — those panels sit in a flex column,
|
|
1515
|
+
not a grid, so the only thing the button changed was the height of the
|
|
1516
|
+
scroller inside it. It now opens the panel over the whole page through a
|
|
1517
|
+
portal, so no scrolling ancestor can clip it, with Escape to leave and the
|
|
1518
|
+
page behind it held still. A transcript that was following stays on its newest
|
|
1519
|
+
row across the change.
|
|
1520
|
+
|
|
1521
|
+
- **`doctor` checks that the shared servers answer.** It verified that binaries
|
|
1522
|
+
existed and disk fitted, and never looked at a `server_url` — so a project
|
|
1523
|
+
whose Postgres lives in another checkout's compose stack passed the preflight
|
|
1524
|
+
with that stack down and died on the first `createdb`, before a worktree
|
|
1525
|
+
existed. Each external database's server and each service URL is now probed
|
|
1526
|
+
with a TCP connect, and a failure names the address that did not answer. A
|
|
1527
|
+
compose-delivered database is deliberately not probed: the lane starts it.
|
|
1528
|
+
|
|
1529
|
+
The order matters as much as the check. `prepare_cmd` runs *before* the
|
|
1530
|
+
preflight, so the check reports the world that hook just made rather than the
|
|
1531
|
+
one in front of it.
|
|
1532
|
+
|
|
1533
|
+
- **A service's `create_cmd` runs with the lane's environment.** `reset_cmd`
|
|
1534
|
+
always had it and `create_cmd` did not, so a `create_cmd` that reached for
|
|
1535
|
+
`docker compose` ran against the lane's own compose file with no project name
|
|
1536
|
+
and no override — booting a stack on the project's fixed host ports, which is
|
|
1537
|
+
the collision the override exists to prevent, caused by the step that sets a
|
|
1538
|
+
lane up.
|
|
1539
|
+
|
|
1540
|
+
- **`vinta-ai-maestro with` waits for the lock instead of giving up on it.** Its
|
|
1541
|
+
usage said it blocked until the resource was granted, and it did — for about
|
|
1542
|
+
five minutes, which is where Node's own `fetch` stops waiting for a response.
|
|
1543
|
+
A test suite behind a capacity-1 semaphore beats that regularly. What the
|
|
1544
|
+
agent saw was "could not reach the lease daemon", and what agents did with
|
|
1545
|
+
that, repeatedly, was run the command without a lease: exactly the stampede
|
|
1546
|
+
the pool exists to prevent, arrived at by an agent behaving reasonably.
|
|
1547
|
+
|
|
1548
|
+
The wait is the client's now. The daemon answers `202 still queued` within
|
|
1549
|
+
seconds and **leaves its own queue behind it**, so nothing is granted to a
|
|
1550
|
+
request that has gone away; the client loops until it is granted, saying so
|
|
1551
|
+
once and then occasionally, so a transcript shows a wait rather than a
|
|
1552
|
+
silence. Only answers that waiting cannot change — a resource this run does
|
|
1553
|
+
not declare, a run that is no longer live — end it.
|
|
1554
|
+
|
|
1555
|
+
And when it does end that way, the refusal says what not to do about it.
|
|
1556
|
+
"The resource lease was not granted" is an error with no alternative in it;
|
|
1557
|
+
the rule against working around it now travels with the message rather than
|
|
1558
|
+
sitting only in a prompt the agent read twenty minutes earlier. The prompt
|
|
1559
|
+
says it too, including that waiting is the expected outcome and not a failure.
|
|
1560
|
+
|
|
1561
|
+
- **A retry gets a fresh fix budget.** `fix_rounds` was set to 0 when a node was
|
|
1562
|
+
created and never again, so a phase that spent its whole budget on attempt 1
|
|
1563
|
+
began attempt 2 already exhausted — one review, one fix, and the exhaustion
|
|
1564
|
+
transition fired straight back. Seen with `max_fix_rounds: 4`: the retry got a
|
|
1565
|
+
single round before the operator was asked again, forty seconds of work
|
|
1566
|
+
standing in for four rounds of it. A retry that inherits the reason the last
|
|
1567
|
+
attempt ran out is not a retry. It resets wherever a node is re-driven from
|
|
1568
|
+
its pipeline's initial state — a capacity refusal, an automatic retry, the
|
|
1569
|
+
operator's answer, the `retry` verb — which is one place rather than four.
|
|
1570
|
+
|
|
1571
|
+
- **The last fix is reviewed rather than failed unread.** `standard-phase`
|
|
1572
|
+
checked the budget on the way *out* of `fix`, so the final fixer's work went
|
|
1573
|
+
straight to `failed` with nothing looking at it. Two phases in one run ended
|
|
1574
|
+
on a fixer reporting "all gates green, committed, tree clean" and were failed
|
|
1575
|
+
anyway. The check now sits in front of the fixer, on both doors into it: every
|
|
1576
|
+
fixer that runs is reviewed, and the review after the last one can still pass
|
|
1577
|
+
the phase. Guarding only the review side left a red gate under a passing
|
|
1578
|
+
reviewer looping forever, which is the other half of the same change.
|
|
1579
|
+
|
|
1580
|
+
`max_fix_rounds` still means the number of fixers a phase may spend. `0` now
|
|
1581
|
+
means none, where before it let one run and failed the phase regardless.
|
|
1582
|
+
|
|
1583
|
+
- **Agents are told not to background their work.** An implementer started five
|
|
1584
|
+
commands with `run_in_background: true` and closed its turn with "I'll wait for
|
|
1585
|
+
the test result notification before continuing to the outer gate". There is no
|
|
1586
|
+
notification: a headless session ends when the turn ends and whatever it
|
|
1587
|
+
backgrounded is killed with it. Three sessions ended with no report and no
|
|
1588
|
+
commit, and the reviewer failed each for uncommitted work — true, and not the
|
|
1589
|
+
cause. Nothing had said so, and believing a tool that offers backgrounding will
|
|
1590
|
+
still be there afterwards is not unreasonable.
|
|
1591
|
+
|
|
1592
|
+
- **The reviewer runs the gates instead of taking their word for it.** The prompt
|
|
1593
|
+
asked it to confirm the outer gate was green, which an agent can do by reading
|
|
1594
|
+
the implementer's report — one reused reviewer session reached a verdict in
|
|
1595
|
+
under four minutes without running the project's tests at all. It is now asked
|
|
1596
|
+
to run them, to say what they returned, and to treat being unable to run them
|
|
1597
|
+
as a finding. Re-review rounds are asked again, because a session that
|
|
1598
|
+
remembers running them last round is remembering a different tree.
|
|
1599
|
+
|
|
1600
|
+
- **A retried phase keeps the commits the attempt before it made.** A failed
|
|
1601
|
+
phase re-enters its pipeline at the initial state, which runs `git_branch`
|
|
1602
|
+
again — and `checkout -B` moves an existing branch unconditionally, so attempt
|
|
1603
|
+
2 began by resetting attempt 1's work to base. The files left the worktree,
|
|
1604
|
+
the next reviewer correctly reported "phase not implemented at all", and the
|
|
1605
|
+
fix budget burned re-implementing from nothing until the operator was asked. A
|
|
1606
|
+
phase that produced real commits was guaranteed to lose them.
|
|
1607
|
+
|
|
1608
|
+
"Cold" was always meant to describe the agent's *session*, not its branch —
|
|
1609
|
+
and the default policy targets environmental failures, which is exactly when
|
|
1610
|
+
the previous attempt's code is worth keeping. A resumed branch is checked out,
|
|
1611
|
+
never rebased onto a base that moved: a conflict there would fail the retry
|
|
1612
|
+
during its setup, before the agent that might resolve it has run. A branch
|
|
1613
|
+
that committed nothing is still moved up. Whether this is a second attempt is
|
|
1614
|
+
read from the journal rather than from the ref, because a phase branch's name
|
|
1615
|
+
carries the plan id and not the run id — an identically named branch left by
|
|
1616
|
+
an earlier run must still be cut fresh. `node_assigned` now records
|
|
1617
|
+
`previous_head`, so a reset that does happen is visible in the run rather than
|
|
1618
|
+
only in a reflog.
|
|
1619
|
+
|
|
1620
|
+
- **A phase is judged on commits, and the prompts finally say so.** An
|
|
1621
|
+
implementer ran four sessions, reported `SUCCESS` with a green inner loop, and
|
|
1622
|
+
never ran `git commit`: its deliverables were untracked files. The reviewer
|
|
1623
|
+
reads the committed diff, so it saw an empty one and reported "not implemented
|
|
1624
|
+
at all"; the fixer re-implemented, also without committing; the rounds ran out
|
|
1625
|
+
and the lane was recycled over the files. Every instruction that agent had was
|
|
1626
|
+
*about* committing — "never commit while a gate is red" — and none of them
|
|
1627
|
+
said it had to.
|
|
1628
|
+
|
|
1629
|
+
Implementers and fixers, cold and continued, are now told that the phase is
|
|
1630
|
+
reviewed and merged from commits on its branch, that an uncommitted file does
|
|
1631
|
+
not exist as far as the run is concerned, and that the turn is not over until
|
|
1632
|
+
`git status --porcelain` is empty of their work — staged by explicit path,
|
|
1633
|
+
never `git add -A`, because a lane holds local files that are not theirs to
|
|
1634
|
+
commit. The reviewer reads the working tree as well as the diff: a full tree
|
|
1635
|
+
with an empty diff is a real failure and is *not* "not implemented", and the
|
|
1636
|
+
difference decides whether the fixer writes the code again or simply commits
|
|
1637
|
+
it.
|
|
1638
|
+
|
|
1639
|
+
- **A recycled lane no longer deletes work nobody committed.** Both recycle
|
|
1640
|
+
paths throw the working tree away. The tree is now committed first — with
|
|
1641
|
+
plumbing, and **off the branch**, under `refs/vinta-ai-maestro/wip/`. On the
|
|
1642
|
+
branch was the first implementation, and it was wrong: a lane's dirty tree
|
|
1643
|
+
holds gate artifacts as often as deliverables, and a phase branch is the base
|
|
1644
|
+
of its dependents, so one gate's scratch file reached the next phase and
|
|
1645
|
+
failed a gate for a reason nothing in that phase caused. Nothing merges,
|
|
1646
|
+
nothing reaches a dependent, and one `git restore --source <ref>` gets a file
|
|
1647
|
+
back. Where the rescue itself fails, the recycle refuses and names the paths.
|
|
1648
|
+
|
|
1649
|
+
The retry question says how much is at stake: commits are kept, and *N*
|
|
1650
|
+
uncommitted files in the lane will be set aside.
|
|
1651
|
+
|
|
1652
|
+
- **`project.hooks: skip`.** Committing is not optional any more, and a
|
|
1653
|
+
`language: system` pre-commit chain reads a never-committed-in worktree as a
|
|
1654
|
+
fresh machine — one project's hooks built a 510 MB virtualenv before allowing
|
|
1655
|
+
a first commit, per lane, after four attempts and a two-minute timeout. Set
|
|
1656
|
+
per worktree, so the operator's own checkout keeps its hooks, and opt-in,
|
|
1657
|
+
because hooks are usually there for a reason.
|
|
1658
|
+
|
|
1659
|
+
- **`doctor` knows when a project needs docker compose.** It assembled its
|
|
1660
|
+
options without a `project`, so `needsCompose` was handed `undefined` on every
|
|
1661
|
+
invocation and reported "not required by this project" for a
|
|
1662
|
+
compose-delivered database — and `run`'s own preflight did the same. A check
|
|
1663
|
+
nothing can reach is worse than an absent one: it reads as a pass.
|
|
1664
|
+
|
|
1665
|
+
- **A failing `setup_cmd` says why.** It carried a lane name and nothing else,
|
|
1666
|
+
so the operator saw "could not provision the lane pool under …" and had to
|
|
1667
|
+
replay the command by hand with the lane environment rebuilt to find a missing
|
|
1668
|
+
settings module. It carries the exit code and a bounded stderr tail now — the
|
|
1669
|
+
same class of thing as a harness refusal's own explanation, which this package
|
|
1670
|
+
already decided to carry after an afternoon lost to the same silence.
|
|
1671
|
+
|
|
1672
|
+
- **A lane the executor was not given is refused, not guessed.** It fell back to
|
|
1673
|
+
the right directory with an *empty environment* — a gate running against the
|
|
1674
|
+
wrong compose project and no forked connection string, with nothing anywhere
|
|
1675
|
+
saying a lane was missing.
|
|
1676
|
+
|
|
1677
|
+
- **The monitor reads, and does not run.** Its shell has no lane environment, so
|
|
1678
|
+
the project's own commands run from it contend with the lanes instead of
|
|
1679
|
+
observing them. One reported "the final gate fails on a port conflict" when no
|
|
1680
|
+
gate had run at all, and the operator believed it. Gate results come from the
|
|
1681
|
+
journal and the gate logs.
|
|
1682
|
+
|
|
1683
|
+
- **`serve --host 0.0.0.0` prints a URL another machine can open.** Binding
|
|
1684
|
+
every interface made the server report the wildcard back, so the line printed
|
|
1685
|
+
for the operator to open — and share — was `http://0.0.0.0:<port>`, which
|
|
1686
|
+
resolves for nobody. The bind is unchanged; the printed host is now this
|
|
1687
|
+
machine's LAN address. The daemon still warns, because the token in that URL
|
|
1688
|
+
is the only thing between the run and anyone who can reach the port.
|
|
1689
|
+
|
|
1690
|
+
- **An agent can run a shell command.** `auto` mapped to the vendor's
|
|
1691
|
+
`acceptEdits`, which accepts file *edits* and nothing else — a shell command
|
|
1692
|
+
still goes to a permission prompt, and in `-p` there is nobody to answer one.
|
|
1693
|
+
A run of eight phases died of it: the agents wrote their code and were then
|
|
1694
|
+
refused `ruff`, `pytest`, `git add` and `docker compose`, **69 denials across
|
|
1695
|
+
two lanes**, every gate failing on work that was never allowed to be checked.
|
|
1696
|
+
`auto` now allows `Bash` in the policy file it already writes.
|
|
1697
|
+
|
|
1698
|
+
What that costs is worth stating plainly: **`Bash` was never confined to the
|
|
1699
|
+
lane.** The deny list covers the file-editing tools and a shell redirection
|
|
1700
|
+
walks through it, so allowing the shell allows commands on the machine.
|
|
1701
|
+
`auto` has always promised exactly this in words — "the agent works unattended
|
|
1702
|
+
inside its lane" — and this is the first version where the words are true.
|
|
1703
|
+
`ask` still does not allow it: that mode exists for a human at the browser,
|
|
1704
|
+
and the prompt is its purpose.
|
|
1705
|
+
|
|
1706
|
+
- **A refusal says why, in the words the harness used.** `permission_denied`
|
|
1707
|
+
carried a decision token and deliberately dropped the sentence beside it, on
|
|
1708
|
+
§11 grounds. Then a run failed with forty-five denials reading
|
|
1709
|
+
`reason: "other"`, and finding out what that meant cost an afternoon and a
|
|
1710
|
+
rebuilt reproduction — the sentence said "this Bash command contains multiple
|
|
1711
|
+
operations; the following parts require approval". §11 keeps repository
|
|
1712
|
+
*contents* out of the record; a refusal's own explanation is not contents, and
|
|
1713
|
+
the `tool_use` row above it already carries the path and the command verbatim.
|
|
1714
|
+
Withholding it protected nothing and hid the one fact worth having.
|
|
1715
|
+
|
|
1716
|
+
- **`serve` opens a run that has already finished.** The API resolved a run from
|
|
1717
|
+
the in-memory registry *and* the journal and required both, so a daemon
|
|
1718
|
+
started with nothing running listed the operator's history — the list reads
|
|
1719
|
+
the journal — and then answered 404 for every run in it, under a message
|
|
1720
|
+
saying the daemon was not running. Reads now need only the journal, which is
|
|
1721
|
+
where a run's whole record lives and which outlives the daemon by design
|
|
1722
|
+
(§5.3). Steering a finished run is still refused, with `409` rather than
|
|
1723
|
+
`404`: the run exists, and saying it does not sends the operator hunting for a
|
|
1724
|
+
typo instead of reading the status in front of them.
|
|
1725
|
+
|
|
1726
|
+
- **Four places the UI asked the operator to work around it.** The transcript
|
|
1727
|
+
opened at the *oldest* row it held, so a live agent's newest line — the one
|
|
1728
|
+
the panel was opened to read — sat below the fold and every arriving entry
|
|
1729
|
+
pushed it further down; it now opens at the newest and stays there, but only
|
|
1730
|
+
while the operator is already at the bottom, because scrolling up is reading.
|
|
1731
|
+
The `git diff` command overflowed its panel, uncopyable without selecting
|
|
1732
|
+
blind, and now wraps. The shell's bounded column went from 1280px to 1600px:
|
|
1733
|
+
1280 is a reading measure, and the Nodes table's columns are ids, lane names
|
|
1734
|
+
and branch names, none of which can be abbreviated without losing what
|
|
1735
|
+
identifies them. And the notification interval said "Remind every 5 min"
|
|
1736
|
+
without ever saying what it would remind anyone about — it repeats the
|
|
1737
|
+
notification for a phase that stopped to ask the operator something, until
|
|
1738
|
+
they answer, which is what the options say now.
|
|
1739
|
+
|
|
1740
|
+
- **A killed terminal releases its directory on Windows.** Two PTY tests failed
|
|
1741
|
+
teardown with `EBUSY: rmdir`: killing a process there is not synchronous with
|
|
1742
|
+
releasing what it held, so the conpty and its background child are gone as far
|
|
1743
|
+
as the test is concerned while the OS still has the working directory open.
|
|
1744
|
+
|
|
1745
|
+
- **A failed phase can be retried instead of ending the run.** `run` takes
|
|
1746
|
+
`--on-failure <stop|ask>`. `stop` is the default and is what every run has
|
|
1747
|
+
always done — the phase fails, its dependents block, the run finishes. `ask`
|
|
1748
|
+
parks the node on a question instead: retry, retry with another member of the
|
|
1749
|
+
crew, or stop.
|
|
1750
|
+
|
|
1751
|
+
It exists because the failures worth retrying are overwhelmingly
|
|
1752
|
+
environmental — a permission wall, a grant nobody made, a gate whose service
|
|
1753
|
+
was not up — and the only recovery was to start the whole plan again, running
|
|
1754
|
+
every phase that had already succeeded a second time. Only pass `ask` when
|
|
1755
|
+
somebody is watching: the run waits, which is exactly why it is not the
|
|
1756
|
+
default.
|
|
1757
|
+
|
|
1758
|
+
The alternatives offered are **members of the crew, not models**. A staffed
|
|
1759
|
+
run has no free-floating models in it — a phase is taken by a member, and the
|
|
1760
|
+
tier floor that decides who may take it is the assigned member's own — so a
|
|
1761
|
+
model is something the plan cannot express and nobody could be found to hold.
|
|
1762
|
+
A member below the phase's tier is never offered: an operator answering a
|
|
1763
|
+
question is not a reason to hand a phase to somebody the plan judged too
|
|
1764
|
+
junior for it.
|
|
1765
|
+
|
|
1766
|
+
The retry starts **cold**, and everything the node held goes back before it
|
|
1767
|
+
waits (§6.1) — an operator at lunch must not be holding a lane another phase
|
|
1768
|
+
could use.
|
|
1769
|
+
|
|
1770
|
+
- **A refusal nobody was asked about is now said out loud.** The adapter knew
|
|
1771
|
+
about `permission_request`, a question waiting for an answer, and nothing
|
|
1772
|
+
else. The refusal an operator actually hits is not a question: a read outside
|
|
1773
|
+
the working directory is decided by the CLI and announced as
|
|
1774
|
+
`permission_denied`, with no request to reply to. That frame was dropped at
|
|
1775
|
+
the first `switch` — no event, no journal row, no transcript line. The new
|
|
1776
|
+
`permission_denied` event carries the decision token (`workingDir`, `mode`)
|
|
1777
|
+
and never the vendor's prose, which names the file being read (§11).
|
|
1778
|
+
|
|
1779
|
+
- **A turn that ended blocked is no longer a turn that succeeded.** The CLI
|
|
1780
|
+
says `status_category: "blocked"` one frame before reporting
|
|
1781
|
+
`is_error: false`, and both are true from its side: it was asked for
|
|
1782
|
+
something it could not do and said so. Taking the second at its word is how a
|
|
1783
|
+
phase passed having written no code and then failed two steps later under
|
|
1784
|
+
another name. A session that reported an error no longer ends `ok` — which
|
|
1785
|
+
also makes a reviewer fail closed, since its verdict is read back out of a
|
|
1786
|
+
transcript whose session did not end cleanly.
|
|
1787
|
+
|
|
1788
|
+
- **An agent still could not write in its own lane.** The entry below passed
|
|
1789
|
+
claude-code `--permission-mode auto`, which matched our own vocabulary for
|
|
1790
|
+
"works unattended" and is not what the vendor means by the word: `auto` still
|
|
1791
|
+
routes a write to a permission prompt, and in `-p` there is nobody to answer
|
|
1792
|
+
one. Run against the CLI, a `Write` to the agent's *own working directory*
|
|
1793
|
+
comes back denied with no reason attached — the same dead end, wearing the
|
|
1794
|
+
word that made it look closed. `acceptEdits` is the mode under which that
|
|
1795
|
+
write succeeds, and is what `auto` now maps to. The test covering this
|
|
1796
|
+
asserted the word rather than the behaviour, so it pinned the bug in place.
|
|
1797
|
+
|
|
1798
|
+
- **A phase can read the operator's checkout.** A lane is a worktree cut from a
|
|
1799
|
+
branch, so anything uncommitted — a plan written this morning, a spec that
|
|
1800
|
+
never leaves the operator's machine — is present where they are and absent
|
|
1801
|
+
from every lane. Reaching for it was refused before the model saw a byte, with
|
|
1802
|
+
a message that reads like a prompt awaiting an answer ("Claude requested
|
|
1803
|
+
permissions to read from …, but you haven't granted it yet") when in fact
|
|
1804
|
+
nothing is asking: the CLI denies it outright, emits no permission request,
|
|
1805
|
+
and the session then ends *successfully*, having written nothing.
|
|
1806
|
+
|
|
1807
|
+
The repository root is now granted to every claude-code agent for **reading**.
|
|
1808
|
+
Granting a directory also grants writing in it, and the lane sits inside the
|
|
1809
|
+
directory being granted, so the grant is paired with a deny list that keeps
|
|
1810
|
+
the lane the only writable place under it — the operator's source and every
|
|
1811
|
+
sibling lane stay refused. That list names the *siblings* at each level down
|
|
1812
|
+
to the lane rather than the root itself, because the vendor resolves deny
|
|
1813
|
+
before allow with no carve-out: `deny: <repo>/**` plus `allow: <lane>/**`
|
|
1814
|
+
refuses the lane too. Each of those facts was established by running the CLI.
|
|
1815
|
+
|
|
1816
|
+
**This covers the file-editing tools and not `Bash`.** A shell redirection was
|
|
1817
|
+
never confined to the working directory and is not confined now; that boundary
|
|
1818
|
+
is the OS's, and the vendor's sandbox that enforces it also switches off the
|
|
1819
|
+
network a phase needs to install anything.
|
|
1820
|
+
|
|
1821
|
+
codex needed nothing: under `--approve-for-me` it already reads anywhere on
|
|
1822
|
+
disk, which was confirmed the same way.
|
|
1823
|
+
|
|
1824
|
+
- **An agent can write in its own lane.** Every adapter declared
|
|
1825
|
+
`permissionControl: true` and passed no policy at all: claude-code was spawned
|
|
1826
|
+
as `-p --output-format stream-json …` with no `--permission-mode`, and codex as
|
|
1827
|
+
`exec --json` with no sandbox and no approval flag, under a comment saying it
|
|
1828
|
+
took both on the command line. So a headless run asked before its first write,
|
|
1829
|
+
emitted a `permission_request`, rendered it in the transcript — and nothing
|
|
1830
|
+
anywhere answered. The phase failed reporting a permission system it could not
|
|
1831
|
+
see, having written nothing.
|
|
1832
|
+
|
|
1833
|
+
`run` and `serve` now take `--permission <ask|auto|full>`, defaulting to
|
|
1834
|
+
`auto`. **The operator sets it, never the workflow document**: the document is
|
|
1835
|
+
committed and shared, and a file in a repository should not be able to tell
|
|
1836
|
+
someone else's machine to run agents without approvals.
|
|
1837
|
+
|
|
1838
|
+
Both CLIs refuse combinations that looked reasonable, and both were found by
|
|
1839
|
+
running them rather than reading them: codex rejects `--sandbox` alongside
|
|
1840
|
+
`--approve-for-me`, and `codex exec resume` accepts neither — passing the
|
|
1841
|
+
fresh-spawn policy there turned a `stale_session` refusal, which the scheduler
|
|
1842
|
+
retries cold, into a `fatal` one that fails the node.
|
|
1843
|
+
|
|
1844
|
+
This reverses a documented decision. The README said the daemon passed no
|
|
1845
|
+
permission flags and that a committed `.claude/settings.json` was what made a
|
|
1846
|
+
run able to write; that is now the narrowing layer on top of a mode, not the
|
|
1847
|
+
only thing standing between an agent and a blocked lane.
|
|
1848
|
+
- **`purge --lanes --branches` clears what a failed run leaves behind.** A run's
|
|
1849
|
+
lane worktrees are not under `runs/`, so no purge ever reached them: three
|
|
1850
|
+
failed attempts at one plan left twelve worktrees, twelve summaries, and a set
|
|
1851
|
+
of `plan/<id>/phase-*` branches still checked out — which is what makes the
|
|
1852
|
+
*next* run of that plan impossible, since git refuses to check out a branch a
|
|
1853
|
+
second worktree holds.
|
|
1854
|
+
|
|
1855
|
+
One rule decides both: **never delete the only copy of work.** A phase can
|
|
1856
|
+
leave work committed on its branch or uncommitted in its worktree, and both
|
|
1857
|
+
count — so a branch carrying commits no other branch has is kept, a lane with
|
|
1858
|
+
a dirty tree is kept, and each is listed with the command to remove it by
|
|
1859
|
+
hand. Untracked files count as work: a phase that wrote three new modules and
|
|
1860
|
+
never committed them is exactly the case worth protecting.
|
|
1861
|
+
|
|
1862
|
+
Emptiness is measured as "carries no commit another branch does not already
|
|
1863
|
+
have", not as "merged into HEAD". The latter is relative to wherever the
|
|
1864
|
+
operator is standing, so on a feature branch — the checkout this is most often
|
|
1865
|
+
run from — every empty phase branch looked unmerged and nothing was ever
|
|
1866
|
+
cleaned up.
|
|
1867
|
+
|
|
1868
|
+
`--dry-run` and `--yes` work as they already did, and a worktree that will not
|
|
1869
|
+
go is named rather than counted.
|
|
1870
|
+
|
|
1871
|
+
- **`doctor` now catches, before a lane exists, the failures that used to take a
|
|
1872
|
+
run each.** Four consecutive runs of one plan failed four different ways, and
|
|
1873
|
+
every one of them was knowable at minute zero from the workflow and the repo.
|
|
1874
|
+
- **Every `prompt_ref` and `plan_context_ref` is resolved against
|
|
1875
|
+
`base_branch`**, with `git cat-file -e`, which reads the branch's tree and
|
|
1876
|
+
so cannot be satisfied by a working-tree copy — the working tree being
|
|
1877
|
+
exactly what a lane will not have. It distinguishes the three cases, because
|
|
1878
|
+
they have three different fixes: never committed, **staged but never
|
|
1879
|
+
committed** (`git add` alone does not put a file in a branch), and committed
|
|
1880
|
+
on a different branch. The last offers both routes out — merge it, or point
|
|
1881
|
+
`base_branch` at the branch that has it — since only the operator knows
|
|
1882
|
+
which they want.
|
|
1883
|
+
- **Phase branches held by another worktree** are reported with the directory
|
|
1884
|
+
to remove. Lane directories are named per run and phase branches per
|
|
1885
|
+
workflow, so a failed run leaves worktrees holding the branch names the next
|
|
1886
|
+
run will try to cut, and git refuses to check out a branch twice. Nothing
|
|
1887
|
+
cleans those up: `purge` deletes run state under `.vinta-ai-maestro/runs/`,
|
|
1888
|
+
and lane worktrees are not there. `doctor` does not delete them either — a
|
|
1889
|
+
failed lane's worktree is the only place its state survives — but it now
|
|
1890
|
+
names each one and the exact command.
|
|
1891
|
+
|
|
1892
|
+
- **A failed node records why.** `node_status` carried `{"status":"failed"}` and
|
|
1893
|
+
nothing else, so two runs failing for two unrelated reasons produced identical
|
|
1894
|
+
journal rows and the cause survived only in the operator's terminal. The
|
|
1895
|
+
reason is now persisted — **sanitized**, not raw: errors the package builds
|
|
1896
|
+
itself are identifiers by construction and are kept verbatim, and anything
|
|
1897
|
+
else is reduced to its kind, the rule `recycleStage` already followed. The
|
|
1898
|
+
journal is durable and API-served, and an exception message from a dependency
|
|
1899
|
+
is exactly how repository content gets into one. Blocked dependents record
|
|
1900
|
+
which node blocked them.
|
|
1901
|
+
|
|
1902
|
+
- **Two diagnostics that named the symptom and hid the cause.** Both came out of
|
|
1903
|
+
one real run, and neither was a wrong answer — just an unusable one.
|
|
1904
|
+
- **A phase whose plan is not committed** failed with `prompt_ref "…" names no
|
|
1905
|
+
readable file`, against a path that was spelled correctly. A lane is a fresh
|
|
1906
|
+
worktree of the base branch, so a plan sitting untracked in the operator's
|
|
1907
|
+
checkout is in the one place the run cannot look. The message now names the
|
|
1908
|
+
directory it resolved against and says why a plan is often not in it.
|
|
1909
|
+
- **A lane summary the daemon could not accept** reported `summary unreadable`
|
|
1910
|
+
and advised deleting the lane — which takes its forked databases with it,
|
|
1911
|
+
over what turned out to be two wrong fields. `doctor` now names the fields
|
|
1912
|
+
and what was expected, and offers repair before deletion. A file that does
|
|
1913
|
+
not parse at all still reports as unreadable, because there is no field to
|
|
1914
|
+
name. Neither message carries the offending *value*: a summary holds
|
|
1915
|
+
database names and connection variables, and the value that failed
|
|
1916
|
+
validation is the likeliest thing in it to be one.
|
|
1917
|
+
|
|
1918
|
+
`prepare-worktree` gained the rule that would have prevented the summary in
|
|
1919
|
+
the first place — its `|` alternatives are closed sets read by machine, `null`
|
|
1920
|
+
is how you say "none", and a strategy outside the set should be the closest
|
|
1921
|
+
one plus a `note:` rather than a fourth word.
|
|
1922
|
+
|
|
220
1923
|
- **`npx vinta-ai-maestro` now runs.** The published package pointed its `bin` at
|
|
221
1924
|
`src/cli/bin.ts` and relied on Node stripping the types at startup — which Node
|
|
222
1925
|
refuses to do anywhere under `node_modules`, unconditionally and with no flag to
|
|
@@ -654,7 +2357,6 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
654
2357
|
**Consumers**: re-sync to pick up the opt-in questions. E2E-disabled projects
|
|
655
2358
|
are unaffected (the e2e regions strip out as before).
|
|
656
2359
|
|
|
657
|
-
|
|
658
2360
|
<!-- pre-release: 0.2.0-alpha6 on 2026-07-13 -->
|
|
659
2361
|
|
|
660
2362
|
### Changed
|
|
@@ -691,7 +2393,6 @@ the project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|
|
691
2393
|
|
|
692
2394
|
### Added
|
|
693
2395
|
|
|
694
|
-
|
|
695
2396
|
- **`handoff` foundation skill — session-continuation handoff docs between
|
|
696
2397
|
agents.** Write mode captures the current task (goal, verified-vs-unverified
|
|
697
2398
|
state, decisions + rejected alternatives, landmines, single concrete next
|