vike 0.4.265 → 0.4.266-commit-e71fad0

package/dist/client/runtime-client-routing/history.d.ts

@@ -1,11 +1,28 @@
-export { pushHistoryState };
-export { replaceHistoryStateOriginal };
+export { changeUrl };
 export { onPopStateBegin };
 export { saveScrollPosition };
 export { initHistory };
+export { historyApiReplaceStateOriginal };
 export type { HistoryInfo };
 export type { ScrollPosition };
 import '../assertEnvClient.js';
+declare function changeUrl(url: string, overwriteLastHistoryEntry: boolean): void;
+declare function historyApiReplaceStateOriginal(state: unknown, url?: Parameters<typeof window.history.replaceState>[2]): void;
+declare function onPopStateBegin(): {
+    skip: true;
+    previous?: undefined;
+    current?: undefined;
+} | {
+    skip?: undefined;
+    previous: HistoryInfo;
+    current: HistoryInfo;
+};
+type ScrollPosition = {
+    x: number;
+    y: number;
+};
+declare function saveScrollPosition(scrollPosition?: ScrollPosition): void;
+declare function initHistory(): void;
 type StateEnhanced = {
     vike: {
         timestamp: number;
@@ -13,24 +30,7 @@ type StateEnhanced = {
         triggeredBy: 'user' | 'vike' | 'browser';
     };
 };
-type ScrollPosition = {
-    x: number;
-    y: number;
-};
-declare function saveScrollPosition(scrollPosition?: ScrollPosition): void;
-declare function pushHistoryState(url: string, overwriteLastHistoryEntry: boolean): void;
-declare function replaceHistoryStateOriginal(state: unknown, url?: Parameters<typeof window.history.replaceState>[2]): void;
 type HistoryInfo = {
     url: `/${string}`;
     state: StateEnhanced;
 };
-declare function onPopStateBegin(): {
-    skip: true;
-    previous?: undefined;
-    current?: undefined;
-} | {
-    skip?: undefined;
-    previous: HistoryInfo;
-    current: HistoryInfo;
-};
-declare function initHistory(): void;

package/dist/client/runtime-client-routing/history.js

@@ -1,8 +1,8 @@
-export { pushHistoryState };
-export { replaceHistoryStateOriginal };
+export { changeUrl };
 export { onPopStateBegin };
 export { saveScrollPosition };
 export { initHistory };
+export { historyApiReplaceStateOriginal };
 import { getCurrentUrl } from '../shared/getCurrentUrl.js';
 import { assert, assertUsage } from '../../utils/assert.js';
 import { getGlobalObject } from '../../utils/getGlobalObject.js';
@@ -15,49 +15,9 @@ const globalObject = getGlobalObject('history.ts', {
 });
 initHistory(); // we redundantly call initHistory() to ensure it's called early
 globalObject.previous = getHistoryInfo();
-// `window.history.state === null` when:
-// - The very first render
-// - Click on `<a href="#some-hash" />`
-// - `location.hash = 'some-hash'`
-function enhance() {
-    if (isEnhanced(window.history.state))
-        return;
-    const stateEnhanced = {
-        vike: {
-            timestamp: getTimestamp(),
-            scrollPosition: getScrollPosition(),
-            triggeredBy: 'browser',
-        },
-    };
-    replaceHistoryState(stateEnhanced);
-}
-function getState() {
-    const state = window.history.state;
-    // *Every* state added to the history needs to go through Vike.
-    // - Otherwise Vike's `popstate` listener won't work. (Because, for example, if globalObject.previous is outdated => isHashNavigation faulty => client-side navigation is wrongfully skipped.)
-    // - Therefore, we have to monkey patch history.pushState() and history.replaceState()
-    // - Therefore, we need the assert() below to ensure history.state has been enhanced by Vike
-    //   - If users stumble upon this assert() then let's make it a assertUsage()
-    assertIsEnhanced(state);
-    return state;
-}
-function getScrollPosition() {
-    const scrollPosition = { x: window.scrollX, y: window.scrollY };
-    return scrollPosition;
-}
-function getTimestamp() {
-    return new Date().getTime();
-}
-function saveScrollPosition(scrollPosition) {
-    scrollPosition || (scrollPosition = getScrollPosition());
-    // Don't overwrite history.state if it was set by a non-Vike history.pushState() call.
-    // https://github.com/vikejs/vike/issues/2801#issuecomment-3490431479
-    if (!isEnhanced(window.history.state))
+function changeUrl(url, overwriteLastHistoryEntry) {
+    if (getCurrentUrl() === url)
         return;
-    const state = getState();
-    replaceHistoryState({ ...state, vike: { ...state.vike, scrollPosition } });
-}
-function pushHistoryState(url, overwriteLastHistoryEntry) {
     if (!overwriteLastHistoryEntry) {
         const state = {
             vike: {
@@ -67,24 +27,68 @@ function pushHistoryState(url, overwriteLastHistoryEntry) {
                 triggeredBy: 'vike',
             },
         };
-        // Calling the monkey patched history.pushState() (and not the original) so that other tools (e.g. user tracking) can listen to Vike's pushState() calls.
-        // - https://github.com/vikejs/vike/issues/1582
-        window.history.pushState(state, '', url);
+        historyApiPushState(state, url);
     }
     else {
-        replaceHistoryState(getState(), url);
+        historyApiReplaceState(getState(), url);
     }
 }
-function replaceHistoryState(state, url) {
+function historyApiPushState(state, url) {
+    // Calling the monkey patched history.pushState() (not the original) so that other tools (e.g. user tracking) can listen to Vike's pushState() calls.
+    // - https://github.com/vikejs/vike/issues/1582
+    window.history.pushState(state, '', url);
+    assertIsEnhanced(window.history.state);
+}
+function historyApiReplaceState(state, url) {
     const url_ = url ?? null; // Passing `undefined` chokes older Edge versions.
     window.history.replaceState(state, '', url_);
     assertIsEnhanced(window.history.state);
 }
-function replaceHistoryStateOriginal(state, url) {
+function historyApiReplaceStateOriginal(state, url) {
     // Bypass all monkey patches.
     // - Useful, for example, to avoid other tools listening to history.replaceState() calls
     History.prototype.replaceState.bind(window.history)(state, '', url);
 }
+function onPopStateBegin() {
+    const { previous } = globalObject;
+    const isStateEnhanced = isEnhanced(window.history.state);
+    // Either:
+    // - `window.history.pushState(null, '', '/some-path')` , or
+    // - hash navigation
+    //   - Click on `<a href="#some-hash">`
+    //   - Using the `location` API (only hash navigation)
+    // See comments a the top of the ./initOnPopState.ts file.
+    const isStatePristine = window.history.state === null;
+    if (!isStateEnhanced && !isStatePristine) {
+        // Going to a history entry not created by Vike — entering another "SPA realm" => hard reload
+        // https://github.com/vikejs/vike/issues/2801#issuecomment-3490431479
+        redirectHard(getCurrentUrl());
+        return { skip: true };
+    }
+    if (!isStateEnhanced)
+        enhanceState();
+    const current = getHistoryInfo();
+    globalObject.previous = current;
+    // Let the browser handle hash navigations.
+    // - Upon hash navigation: `isHistoryStatePristine===true` (see comment above).
+    if (isStatePristine) {
+        return { skip: true };
+    }
+    return { previous, current };
+}
+function saveScrollPosition(scrollPosition) {
+    scrollPosition || (scrollPosition = getScrollPosition());
+    // Don't overwrite history.state if it was set by a non-Vike history.pushState() call.
+    // https://github.com/vikejs/vike/issues/2801#issuecomment-3490431479
+    if (!isEnhanced(window.history.state))
+        return;
+    const state = getState();
+    historyApiReplaceState({ ...state, vike: { ...state.vike, scrollPosition } });
+}
+function initHistory() {
+    monkeyPatchHistoryAPI(); // the earlier we call it the better (Vike can workaround erroneous library monkey patches if Vike is the last one in the monkey patch chain)
+    enhanceState(); // enhance very first window.history.state which is `null`
+}
 // Monkey patch:
 // - history.pushState()
 // - history.replaceState()
@@ -114,11 +118,26 @@ function monkeyPatchHistoryAPI() {
                 if (isEnhanced(window.history.state))
                     return;
                 Object.assign(state, window.history.state);
-                replaceHistoryStateOriginal(state);
+                historyApiReplaceStateOriginal(state);
             });
         };
     });
 }
+function getState() {
+    const state = window.history.state;
+    // *Every* state added to the history needs to go through Vike.
+    // - Otherwise Vike's `popstate` listener won't work. (Because, for example, if globalObject.previous is outdated => isHashNavigation faulty => client-side navigation is wrongfully skipped.)
+    // - Therefore, we have to monkey patch history.pushState() and history.replaceState()
+    // - Therefore, we need the assert() below to ensure history.state has been enhanced by Vike
+    //   - If users stumble upon this assert() then let's make it a assertUsage()
+    assertIsEnhanced(state);
+    return state;
+}
+function assertIsEnhanced(state) {
+    if (isEnhanced(state))
+        return;
+    assert(false, { state });
+}
 function isEnhanced(state) {
     if (state?.vike) {
         /* We don't use the assert() below to save client-side KBs.
@@ -135,10 +154,21 @@ function isEnhanced(state) {
     }
     return false;
 }
-function assertIsEnhanced(state) {
-    if (isEnhanced(state))
+// `window.history.state === null` when:
+// - The very first render
+// - Click on `<a href="#some-hash" />`
+// - `location.hash = 'some-hash'`
+function enhanceState() {
+    if (isEnhanced(window.history.state))
         return;
-    assert(false, { state });
+    const stateEnhanced = {
+        vike: {
+            timestamp: getTimestamp(),
+            scrollPosition: getScrollPosition(),
+            triggeredBy: 'browser',
+        },
+    };
+    historyApiReplaceState(stateEnhanced);
 }
 function getHistoryInfo() {
     return {
@@ -146,34 +176,10 @@ function getHistoryInfo() {
         state: getState(),
     };
 }
-function onPopStateBegin() {
-    const { previous } = globalObject;
-    const isStateEnhanced = isEnhanced(window.history.state);
-    // Either:
-    // - `window.history.pushState(null, '', '/some-path')` , or
-    // - hash navigation
-    //   - Click on `<a href="#some-hash">`
-    //   - Using the `location` API (only hash navigation)
-    // See comments a the top of the ./initOnPopState.ts file.
-    const isStatePristine = window.history.state === null;
-    if (!isStateEnhanced && !isStatePristine) {
-        // Going to a history entry not created by Vike — entering another "SPA realm" => hard reload
-        // https://github.com/vikejs/vike/issues/2801#issuecomment-3490431479
-        redirectHard(getCurrentUrl());
-        return { skip: true };
-    }
-    if (!isStateEnhanced)
-        enhance();
-    const current = getHistoryInfo();
-    globalObject.previous = current;
-    // Let the browser handle hash navigations.
-    // - Upon hash navigation: `isHistoryStatePristine===true` (see comment above).
-    if (isStatePristine) {
-        return { skip: true };
-    }
-    return { previous, current };
+function getScrollPosition() {
+    const scrollPosition = { x: window.scrollX, y: window.scrollY };
+    return scrollPosition;
 }
-function initHistory() {
-    monkeyPatchHistoryAPI(); // the earlier we call it the better (Vike can workaround erroneous library monkey patches if Vike is the last one in the monkey patch chain)
-    enhance(); // enhance very first window.history.state which is `null`
+function getTimestamp() {
+    return new Date().getTime();
 }

package/dist/client/runtime-client-routing/renderPageClient.js

@@ -17,7 +17,7 @@ import { createPageContextClient } from './createPageContextClient.js';
 import { addLinkPrefetchHandlers, addLinkPrefetchHandlers_unwatch, addLinkPrefetchHandlers_watch, getPageContextPrefetched, populatePageContextPrefetchCache, } from './prefetch.js';
 import { execHookOnRenderClient } from '../shared/execHookOnRenderClient.js';
 import { isErrorFetchingStaticAssets, loadPageConfigsLazyClientSide, } from '../shared/loadPageConfigsLazyClientSide.js';
-import { pushHistoryState, saveScrollPosition } from './history.js';
+import { changeUrl, saveScrollPosition } from './history.js';
 import { addNewPageContextAborted, getPageContextAddendumAbort, isAbortError, logAbort, } from '../../shared-server-client/route/abort.js';
 import { route } from '../../shared-server-client/route/index.js';
 import { isClientSideRoutable } from './isClientSideRoutable.js';
@@ -527,11 +527,6 @@ function stampFinished(urlOriginal) {
     window._vike ?? (window._vike = {});
     window._vike.fullyRenderedUrl = urlOriginal;
 }
-function changeUrl(url, overwriteLastHistoryEntry) {
-    if (getCurrentUrl() === url)
-        return;
-    pushHistoryState(url, overwriteLastHistoryEntry);
-}
 function disableClientRouting(err, log) {
     globalObject.clientRoutingIsDisabled = true;
     assert(isErrorFetchingStaticAssets(err));

package/dist/client/runtime-client-routing/setScrollPosition.js

@@ -6,7 +6,7 @@ import { assert } from '../../utils/assert.js';
 import { onPageHide } from '../../utils/onPageVisibilityChange.js';
 import { sleep } from '../../utils/sleep.js';
 import { throttle } from '../../utils/throttle.js';
-import { replaceHistoryStateOriginal, saveScrollPosition } from './history.js';
+import { historyApiReplaceStateOriginal, saveScrollPosition } from './history.js';
 import '../assertEnvClient.js';
 function setScrollPosition(scrollTarget, url) {
     if (!scrollTarget && url && hasTextFragment(url)) {
@@ -23,17 +23,18 @@ function setScrollPosition(scrollTarget, url) {
     const hash = getUrlHash();
     scrollToHashOrTop(hash);
 }
-// https://github.com/vikejs/vike/issues/2114
-// https://github.com/WICG/scroll-to-text-fragment/issues/261
+// Scroll to the DOM element the URL fragment points to, using window.locale.replace()
+// - https://github.com/vikejs/vike/issues/2114
+// - https://github.com/WICG/scroll-to-text-fragment/issues/261
 function scrollToTextFragment(url) {
     const stateOriginal = window.history.state;
-    replaceHistoryStateOriginal(null, url);
+    historyApiReplaceStateOriginal(null, url);
     // We need `history.state===null` before location.replace() so that our 'popstate' handling is correct
     assert(window.history.state === null);
     // - Chrome's location.replace() keeps the current state (`history.state===stateOriginal`)
     // - Firefox's location.replace() replaces the current state with `null` (`history.state===null`)
     window.location.replace(url);
-    replaceHistoryStateOriginal(stateOriginal, url);
+    historyApiReplaceStateOriginal(stateOriginal, url);
 }
 function hasTextFragment(url) {
     return url.includes('#') && url.includes(':~:text');

package/dist/node/vite/plugins/build/handleAssetsManifest.js

@@ -310,7 +310,8 @@ async function handleAssetsManifest_getBuildConfig(config) {
         if (config.build?.cssMinify === undefined)
             build.cssMinify = isVite8OrAbove(config) ? true : 'esbuild';
     }
-    if (config.build?.manifest === undefined)
+    assertWarning(config.build?.manifest !== false, `Setting Vite's configuration ${pc.cyan('build.manifest')} to ${pc.cyan('false')} is ignored — Vike overrides it to ${pc.cyan('true')} because Vike needs the manifest. Note that Vike removes the manifest from the client-side bundle, see ${pc.underline('https://github.com/vikejs/vike/issues/3505#issuecomment-5563748527')}`, { onlyOnce: true });
+    if (config.build?.manifest === undefined || config.build?.manifest === false)
         build.manifest = true;
     /* Already set by vike:build:pluginBuildApp
     if (config.build?.copyPublicDir === undefined) build.copyPublicDir = !isViteServerSide_viteEnvOptional(config)

package/dist/node/vite/plugins/pluginDev/logSkillHint.js

@@ -15,6 +15,7 @@ import { requireResolveOptional } from '../../../../utils/requireResolve.js';
 import { setTimeoutUnref } from '../../../../utils/setTimeoutUnref.js';
 import { isObject } from '../../../../utils/isObject.js';
 import { toPosixPath } from '../../../../utils/path.js';
+import { PROJECT_VERSION } from '../../../../utils/PROJECT_VERSION.js';
 import { unique } from '../../../../utils/unique.js';
 import { getVikeConfigInternal } from '../../shared/resolveVikeConfigInternal.js';
 import { getCacheValue, setCacheValue } from '../../shared/cache.js';
@@ -25,19 +26,19 @@ const globalObject = getGlobalObject('logSkillHint.ts', {
     alreadyChecked: false,
 });
 const docsUrl = 'https://vike.dev/ai#skill';
-const tellAgent = `by telling your agent "${pc.cyan(`Install skill ${docsUrl}`)}"`;
-const suppressHint = `set ${pc.cyan('+ai.skill')} to ${pc.cyan('false')} to suppress this log`;
-const logMissing = `Add Vike's skill for AI agents (Claude Code, Codex, Cursor, ...) ${tellAgent}, or ${suppressHint}`;
+const seeDocs = `— see ${pc.underline(docsUrl)}`;
+const suppressHint = `set ${pc.cyan('+ai.skill')} to ${pc.cyan('false')} to suppress this log.`;
+const logMissing = `Add Vike's skill for AI agents (Claude Code, Codex, Cursor, ...) ${seeDocs}, or ${suppressHint}`;
 const logOutdated = (skillFilePaths) => {
     const isPlural = skillFilePaths.length > 1;
     const files = skillFilePaths.map((f) => pc.cyan(f)).join(', ');
-    return `Your Vike skill${isPlural ? 's' : ''} ${files} ${isPlural ? "don't" : "doesn't"} match the official ${pc.cyan('vike/SKILL.md')}, update ${isPlural ? 'them' : 'it'} ${tellAgent}, or, if you maintain your own version, ${suppressHint}`;
+    return `Your Vike skill${isPlural ? 's' : ''} ${files} ${isPlural ? "don't" : "doesn't"} match the official ${pc.cyan('vike/SKILL.md')}, update ${isPlural ? 'them' : 'it'} ${seeDocs}, or, if you maintain your own version, ${suppressHint}`;
 };
 const skillName = 'vike';
 // The skill file shipped by the vike npm package: node_modules/vike/skills/vike/SKILL.md (see packages/vike/scripts/copySkill.mjs)
 const skillFilePathInsidePackage = 'skills/vike/SKILL.md';
 // Cache entry at node_modules/.vike/cache.json, see cache.ts
-// - `false` => the check didn't log anything last time => skip the check (forever, until node_modules/ is removed)
+// - `{ skip: true, version }` => the check didn't log anything last time, with that Vike version => skip the check until Vike is upgraded (the official skill file may change between Vike versions) or node_modules/ is removed
 // - Nothing is written as long as the hint is logged => the check is re-run upon every dev start
 const cacheKey = 'logSkillHint';
 // Log a hint if the user didn't install Vike's skill for AI agents (vike/SKILL.md), or if it differs from the official one — https://vike.dev/ai#skill
@@ -95,8 +96,9 @@ async function checkSkillUnsafe(userRootDir) {
     if (!getConfigValueAiSkill(vikeConfig))
         return;
     globalObject.alreadyChecked = true;
-    // The check is skipped forever once it didn't log anything (until node_modules/ is removed) — see cacheKey
-    if ((await getCacheValue(userRootDir, cacheKey)) === false)
+    // The check is skipped once it didn't log anything, until Vike is upgraded (or node_modules/ is removed) — see cacheKey
+    const cached = await getCacheValue(userRootDir, cacheKey);
+    if (isObject(cached) && cached.skip === true && cached.version === PROJECT_VERSION)
         return;
     const skillState = await getSkillState(userRootDir);
     if (skillState.state === 'missing') {
@@ -110,7 +112,7 @@ async function checkSkillUnsafe(userRootDir) {
     if (skillState.state === 'installed' ||
         skillState.state === 'not-using-ai-agents' ||
         skillState.state === 'vike-not-from-npm') {
-        await setCacheValue(userRootDir, cacheKey, false);
+        await setCacheValue(userRootDir, cacheKey, { skip: true, version: PROJECT_VERSION });
         return;
     }
     checkType(skillState);
@@ -148,7 +150,7 @@ function getConfigValueAiSkill(vikeConfig) {
     const skill = configAi.skill;
     if (skill === undefined)
         return true;
-    assertUsage(typeof skill === 'boolean', `${pc.cyan('+ai.skill')} should be a boolean, see ${pc.underline('https://vike.dev/ai#skill')}`);
+    assertUsage(typeof skill === 'boolean', `${pc.cyan('+ai.skill')} should be a boolean, see ${pc.underline(docsUrl)}`);
     return skill;
 }
 // The root directory of the user's Git repository — skills directories usually live at the repository root (e.g. monorepos).

package/dist/utils/PROJECT_VERSION.d.ts

@@ -1 +1 @@
-export declare const PROJECT_VERSION: '0.4.265';
+export declare const PROJECT_VERSION: '0.4.266-commit-e71fad0';

package/dist/utils/PROJECT_VERSION.js

@@ -1,2 +1,2 @@
 // Automatically updated by @brillout/release-me
-export const PROJECT_VERSION = '0.4.265';
+export const PROJECT_VERSION = '0.4.266-commit-e71fad0';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike",
-  "version": "0.4.265",
+  "version": "0.4.266-commit-e71fad0",
   "repository": "https://github.com/vikejs/vike",
   "exports": {
     "./server": {
@@ -137,7 +137,7 @@
     "es-module-lexer": "^1.0.0",
     "esbuild": ">=0.19.0",
     "json5": "^2.0.0",
-    "magic-string": "^1.2.3",
+    "magic-string": "^1.3.1",
     "picomatch": "^4.0.7",
     "semver": "^7.8.5",
     "sirv": "^3.0.2",