vike 0.4.233-commit-e534fd6 → 0.4.233

package/dist/cjs/node/runtime/html/injectAssets/getHtmlTags.js

@@ -165,26 +165,9 @@ async function getHtmlTags(pageContext, streamFromReactStreamingPackage, injectF
 }
 function mergeScriptEntries(pageAssets, viteDevScript) {
     const scriptEntries = pageAssets.filter((pageAsset) => pageAsset.isEntry && pageAsset.assetType === 'script');
-    let scriptEntry = `${viteDevScript}${scriptEntries.map((asset) => (0, inferHtmlTags_js_1.inferAssetTag)(asset)).join('')}`;
-    // We merge scripts to avoid the infamous HMR preamble error.
-    // - Infamous HMR preamble error:
-    //   ```browser-console
-    //   usePageContext.tsx:10 Uncaught (in promise) Error: @vitejs/plugin-react can't detect preamble. Something is wrong.
-    //       at usePageContext.tsx:10:10
-    //   ```
-    // - Note the following race condition. Maybe making the second script non-async ensures execution order?
-    //   ```html
-    //   <script type="module">console.log("I can be printed *after* the other log")</script>
-    //   <script src="entry.js" type="module" async></script>
-    //   ```
-    //   ```js
-    //   // entry.js
-    //   console.log("I can be printed *before* the other log")
-    //   ```
-    // - Maybe an alternative would be to make Vike's client runtime entry <script> tag non-async. Would that work? Would it be a performance issue?
-    //   - The entry <script> shouldn't be `<script defer>` upon HTML streaming, otherwise progressive hydration while SSR streaming won't work.
-    scriptEntry = (0, mergeScriptTags_js_1.mergeScriptTags)(scriptEntry);
-    return scriptEntry;
+    const scriptTagsHtml = `${viteDevScript}${scriptEntries.map((asset) => (0, inferHtmlTags_js_1.inferAssetTag)(asset)).join('')}`;
+    const scriptTag = (0, mergeScriptTags_js_1.mergeScriptTags)(scriptTagsHtml);
+    return scriptTag;
 }
 function getPageContextJsonScriptTag(pageContext) {
     const pageContextClientSerialized = (0, sanitizeJson_js_1.sanitizeJson)((0, serializeContext_js_1.getPageContextClientSerialized)(pageContext));

package/dist/cjs/node/runtime/html/injectAssets/mergeScriptTags.js

@@ -21,13 +21,7 @@ function mergeScriptTags(scriptTagsHtml) {
                 const hasInnerHtml = !!innerHtml.trim();
                 if (src) {
                     (0, utils_js_1.assert)(!hasInnerHtml);
-                    // - We don't use a static import because static imports are hoisted => React's HMR preamble can be executed after user land code => triggering this error:
-                    //   ```
-                    //   [22:28:57.885][/test-dev.test.ts][pnpm run dev][Browser Error] Error: @vitejs/plugin-react-swc can't detect preamble. Something is wrong.
-                    //       at http://localhost:3000/@fs/home/rom/code/docpress/src/renderer/usePageContext.tsx:9:11
-                    //   ```
-                    // - We don't use `await` the dynamic import() to avoid waterfall
-                    contents.push(`import(${JSON.stringify(src)});`);
+                    contents.push(`import ${JSON.stringify(src)};`);
                 }
                 else if (hasInnerHtml) {
                     innerHtml = innerHtml.split('\n').filter(Boolean).join('\n');

package/dist/cjs/utils/PROJECT_VERSION.js

@@ -2,4 +2,4 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PROJECT_VERSION = void 0;
 // Automatically updated by @brillout/release-me
-exports.PROJECT_VERSION = '0.4.233-commit-e534fd6';
+exports.PROJECT_VERSION = '0.4.233';

package/dist/esm/client/runtime-client-routing/renderPageClientSide.d.ts

@@ -156,7 +156,7 @@ declare function getPageContextBegin(isForErrorPage: boolean, { urlOriginal, isB
 declare global {
     var _vike: {
         fullyRenderedUrl?: string;
-    } | undefined;
+    };
 }
 declare function disableClientRouting(err: unknown, log: boolean): void;
 declare function getRenderCount(): number;

package/dist/esm/node/runtime/html/injectAssets/getHtmlTags.js

@@ -160,26 +160,9 @@ async function getHtmlTags(pageContext, streamFromReactStreamingPackage, injectF
 }
 function mergeScriptEntries(pageAssets, viteDevScript) {
     const scriptEntries = pageAssets.filter((pageAsset) => pageAsset.isEntry && pageAsset.assetType === 'script');
-    let scriptEntry = `${viteDevScript}${scriptEntries.map((asset) => inferAssetTag(asset)).join('')}`;
-    // We merge scripts to avoid the infamous HMR preamble error.
-    // - Infamous HMR preamble error:
-    //   ```browser-console
-    //   usePageContext.tsx:10 Uncaught (in promise) Error: @vitejs/plugin-react can't detect preamble. Something is wrong.
-    //       at usePageContext.tsx:10:10
-    //   ```
-    // - Note the following race condition. Maybe making the second script non-async ensures execution order?
-    //   ```html
-    //   <script type="module">console.log("I can be printed *after* the other log")</script>
-    //   <script src="entry.js" type="module" async></script>
-    //   ```
-    //   ```js
-    //   // entry.js
-    //   console.log("I can be printed *before* the other log")
-    //   ```
-    // - Maybe an alternative would be to make Vike's client runtime entry <script> tag non-async. Would that work? Would it be a performance issue?
-    //   - The entry <script> shouldn't be `<script defer>` upon HTML streaming, otherwise progressive hydration while SSR streaming won't work.
-    scriptEntry = mergeScriptTags(scriptEntry);
-    return scriptEntry;
+    const scriptTagsHtml = `${viteDevScript}${scriptEntries.map((asset) => inferAssetTag(asset)).join('')}`;
+    const scriptTag = mergeScriptTags(scriptTagsHtml);
+    return scriptTag;
 }
 function getPageContextJsonScriptTag(pageContext) {
     const pageContextClientSerialized = sanitizeJson(getPageContextClientSerialized(pageContext));

package/dist/esm/node/runtime/html/injectAssets/mergeScriptTags.js

@@ -19,13 +19,7 @@ function mergeScriptTags(scriptTagsHtml) {
                 const hasInnerHtml = !!innerHtml.trim();
                 if (src) {
                     assert(!hasInnerHtml);
-                    // - We don't use a static import because static imports are hoisted => React's HMR preamble can be executed after user land code => triggering this error:
-                    //   ```
-                    //   [22:28:57.885][/test-dev.test.ts][pnpm run dev][Browser Error] Error: @vitejs/plugin-react-swc can't detect preamble. Something is wrong.
-                    //       at http://localhost:3000/@fs/home/rom/code/docpress/src/renderer/usePageContext.tsx:9:11
-                    //   ```
-                    // - We don't use `await` the dynamic import() to avoid waterfall
-                    contents.push(`import(${JSON.stringify(src)});`);
+                    contents.push(`import ${JSON.stringify(src)};`);
                 }
                 else if (hasInnerHtml) {
                     innerHtml = innerHtml.split('\n').filter(Boolean).join('\n');

package/dist/esm/utils/PROJECT_VERSION.d.ts

@@ -1 +1 @@
-export declare const PROJECT_VERSION: "0.4.233-commit-e534fd6";
+export declare const PROJECT_VERSION: "0.4.233";

package/dist/esm/utils/PROJECT_VERSION.js

@@ -1,2 +1,2 @@
 // Automatically updated by @brillout/release-me
-export const PROJECT_VERSION = '0.4.233-commit-e534fd6';
+export const PROJECT_VERSION = '0.4.233';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike",
-  "version": "0.4.233-commit-e534fd6",
+  "version": "0.4.233",
   "repository": "https://github.com/vikejs/vike",
   "exports": {
     "./server": {