vike 0.4.199-commit-5883046 → 0.4.199-commit-dc15087

package/dist/cjs/node/prerender/runPrerender.js

@@ -605,7 +605,9 @@ async function write(urlOriginal, pageContext, fileExtension, fileContent, root,
     (0, utils_js_1.assertPosixPath)(fileUrl);
     (0, utils_js_1.assert)(fileUrl.startsWith('/'));
     const filePathRelative = fileUrl.slice(1);
-    (0, utils_js_1.assert)(!filePathRelative.startsWith('/'));
+    (0, utils_js_1.assert)(!filePathRelative.startsWith('/'), 
+    // Let's remove this debug info after we add a assertUsage() avoiding https://github.com/vikejs/vike/issues/1929
+    { urlOriginal, fileUrl });
     (0, utils_js_1.assertPosixPath)(outDirClient);
     (0, utils_js_1.assertPosixPath)(filePathRelative);
     const filePath = path_1.default.posix.join(outDirClient, filePathRelative);

package/dist/cjs/utils/PROJECT_VERSION.js

@@ -2,4 +2,4 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PROJECT_VERSION = void 0;
 // Automatically updated by @brillout/release-me
-exports.PROJECT_VERSION = '0.4.199-commit-5883046';
+exports.PROJECT_VERSION = '0.4.199-commit-dc15087';

package/dist/esm/client/client-routing-runtime/history.d.ts

@@ -1,4 +1,8 @@
-export { getHistoryState, enhanceHistoryState, pushHistoryState, type ScrollPosition, saveScrollPosition };
+export { pushHistoryState };
+export { onPopStateBegin };
+export { saveScrollPosition };
+export type { HistoryInfo };
+export type { ScrollPosition };
 type StateEnhanced = {
     timestamp: number;
     scrollPosition: null | ScrollPosition;
@@ -9,7 +13,14 @@ type ScrollPosition = {
     x: number;
     y: number;
 };
-declare function enhanceHistoryState(): void;
-declare function getHistoryState(): StateEnhanced;
 declare function saveScrollPosition(): void;
 declare function pushHistoryState(url: string, overwriteLastHistoryEntry: boolean): void;
+type HistoryInfo = {
+    url: `/${string}`;
+    state: StateEnhanced;
+};
+declare function onPopStateBegin(): {
+    isNewState: boolean;
+    previous: HistoryInfo;
+    current: HistoryInfo;
+};

package/dist/esm/client/client-routing-runtime/history.js

@@ -1,7 +1,9 @@
-export { getHistoryState, enhanceHistoryState, pushHistoryState, saveScrollPosition };
-import { assert, assertUsage, hasProp, isObject } from './utils.js';
-let initStateEnhanced;
+export { pushHistoryState };
+export { onPopStateBegin };
+export { saveScrollPosition };
+import { assert, assertUsage, getCurrentUrl, getGlobalObject, hasProp, isObject } from './utils.js';
 init();
+const globalObject = getGlobalObject('history.ts', { previous: getHistoryInfo() });
 // `window.history.state === null` when:
 // - The very first render
 // - Click on `<a href="#some-hash" />`
@@ -38,11 +40,13 @@ function enhance(stateNotEnhanced) {
     assert(isVikeEnhanced(stateVikeEnhanced));
     return stateVikeEnhanced;
 }
-function getStateEnhanced() {
+function getState() {
     const state = getStateNotEnhanced();
-    // This assert() will most likely eventually cause issues. Let's then:
-    // - Replace the assert() call with enhanceHistoryState()
-    // - Remove the race condition buster `initStateEnhanced` as it won't be needed anymore
+    // *Every* state added to the history needs to go through Vike.
+    // - Otherwise Vike's `popstate` listener won't work. (Because, for example, if globalObject.previous is outdated => isHashNavigation faulty => client-side navigation wrongfully skipped.)
+    // - Therefore, we monkey patch history.pushState() and history.replaceState()
+    // - Therefore, we assert() below that history.state has been enhanced by Vike
+    // - If users stumble upon this assert() then make it a assertUsage()
     assert(isVikeEnhanced(state));
     return state;
 }
@@ -50,11 +54,6 @@ function getStateNotEnhanced() {
     const state = window.history.state;
     return state;
 }
-function getHistoryState() {
-    if (!initStateEnhanced)
-        enhanceHistoryState(); // avoid race condition
-    return getStateEnhanced();
-}
 function getScrollPosition() {
     const scrollPosition = { x: window.scrollX, y: window.scrollY };
     return scrollPosition;
@@ -64,48 +63,54 @@ function getTimestamp() {
 }
 function saveScrollPosition() {
     const scrollPosition = getScrollPosition();
-    const state = getStateEnhanced();
+    const state = getState();
     replaceHistoryState({ ...state, scrollPosition });
 }
 function pushHistoryState(url, overwriteLastHistoryEntry) {
     if (!overwriteLastHistoryEntry) {
-        const timestamp = getTimestamp();
-        pushState({
-            timestamp,
+        const state = {
+            timestamp: getTimestamp(),
             // I don't remember why I set it to `null`, maybe because setting it now would be too early? (Maybe there is a delay between renderPageClientSide() is finished and the browser updating the scroll position.) Anyways, it seems like autoSaveScrollPosition() is enough.
             scrollPosition: null,
             triggeredBy: 'vike',
             _isVikeEnhanced: true
-        }, url);
+        };
+        // Calling the monkey patched history.pushState() (and not the orignal) so that other tools (e.g. user tracking) can listen to Vike's pushState() calls
+        // https://github.com/vikejs/vike/issues/1582
+        window.history.pushState(state, '', url);
     }
     else {
-        replaceHistoryState(getStateEnhanced(), url);
+        replaceHistoryState(getState(), url);
     }
 }
 function replaceHistoryState(state, url) {
     const url_ = url ?? null; // Passing `undefined` chokes older Edge versions.
     window.history.replaceState(state, '', url_);
 }
-function pushState(state, url) {
-    // Vike should call window.history.pushState() (and not the orignal `pushStateOriginal()`) so that other tools (e.g. user tracking) can listen to Vike's pushState() calls, see https://github.com/vikejs/vike/issues/1582.
-    window.history.pushState(state, '', url);
-}
-function monkeyPatchHistoryPushState() {
-    const pushStateOriginal = window.history.pushState.bind(window.history);
-    window.history.pushState = (stateOriginal = {}, ...rest) => {
-        assertUsage(stateOriginal === undefined || stateOriginal === null || isObject(stateOriginal), 'history.pushState(state) argument state must be an object');
-        const stateEnhanced = isVikeEnhanced(stateOriginal)
-            ? stateOriginal
-            : {
-                _isVikeEnhanced: true,
-                scrollPosition: getScrollPosition(),
-                timestamp: getTimestamp(),
-                triggeredBy: 'user',
-                ...stateOriginal
-            };
-        assert(isVikeEnhanced(stateEnhanced));
-        return pushStateOriginal(stateEnhanced, ...rest);
-    };
+// Monkey patch:
+// - history.pushState()
+// - history.replaceState()
+function monkeyPatchHistoryAPI() {
+    ;
+    ['pushState', 'replaceState'].forEach((funcName) => {
+        const funcOriginal = window.history[funcName].bind(window.history);
+        window.history[funcName] = (stateOriginal = {}, ...rest) => {
+            assertUsage(stateOriginal === undefined || stateOriginal === null || isObject(stateOriginal), `history.${funcName}(state) argument state must be an object`);
+            const stateEnhanced = isVikeEnhanced(stateOriginal)
+                ? stateOriginal
+                : {
+                    _isVikeEnhanced: true,
+                    scrollPosition: getScrollPosition(),
+                    timestamp: getTimestamp(),
+                    triggeredBy: 'user',
+                    ...stateOriginal
+                };
+            assert(isVikeEnhanced(stateEnhanced));
+            const ret = funcOriginal(stateEnhanced, ...rest);
+            globalObject.previous = getHistoryInfo();
+            return ret;
+        };
+    });
 }
 function isVikeEnhanced(state) {
     const yes = isObject(state) && '_isVikeEnhanced' in state;
@@ -126,6 +131,20 @@ function assertStateVikeEnhanced(state) {
 }
 function init() {
     enhanceHistoryState();
-    initStateEnhanced = true;
-    monkeyPatchHistoryPushState();
+    monkeyPatchHistoryAPI();
+}
+function getHistoryInfo() {
+    return {
+        url: getCurrentUrl(),
+        state: getState()
+    };
+}
+function onPopStateBegin() {
+    const { previous } = globalObject;
+    const isNewState = window.history.state === null;
+    if (isNewState)
+        enhanceHistoryState();
+    const current = getHistoryInfo();
+    globalObject.previous = current;
+    return { isNewState, previous, current };
 }

package/dist/esm/client/client-routing-runtime/initOnPopState.d.ts

@@ -1,22 +1,12 @@
 export { initOnPopState };
-export { updateState };
 export { onPopState };
+import { type HistoryInfo } from './history.js';
 declare function initOnPopState(): void;
 type Listener = (arg: {
-    previous: ReturnType<typeof getInfo>;
+    previous: HistoryInfo;
 }) => void | boolean;
-/** Control client-side navigation.
+/** Control back-/forward navigation.
  *
  * https://vike.dev/onPopState
  */
 declare function onPopState(listener: Listener): void;
-declare function getInfo(): {
-    url: `/${string}`;
-    state: {
-        timestamp: number;
-        scrollPosition: null | import("./history.js").ScrollPosition;
-        triggeredBy: "user" | "vike" | "browser";
-        _isVikeEnhanced: true;
-    };
-};
-declare function updateState(): void;

package/dist/esm/client/client-routing-runtime/initOnPopState.js

@@ -1,11 +1,10 @@
 export { initOnPopState };
-export { updateState };
 export { onPopState };
-import { getCurrentUrl, getGlobalObject } from './utils.js';
-import { enhanceHistoryState, getHistoryState } from './history.js';
+import { getGlobalObject } from './utils.js';
+import { onPopStateBegin } from './history.js';
 import { renderPageClientSide } from './renderPageClientSide.js';
 import { setScrollPosition } from './setScrollPosition.js';
-const globalObject = getGlobalObject('initOnPopState.ts', { previous: getInfo(), listeners: [] });
+const globalObject = getGlobalObject('initOnPopState.ts', { listeners: [] });
 function initOnPopState() {
     // - The popstate event is trigged upon:
     //   - Back-/forward navigation.
@@ -17,18 +16,14 @@ function initOnPopState() {
     //     - `location.hash = 'some-hash'`
     // - The `event` argument of `window.addEventListener('popstate', (event) => /*...*/)` is useless: the History API doesn't provide the previous state (the popped state), see https://stackoverflow.com/questions/48055323/is-history-state-always-the-same-as-popstate-event-state
     window.addEventListener('popstate', async () => {
-        const isNewState = window.history.state === null;
-        if (isNewState)
-            enhanceHistoryState();
-        const { previous } = globalObject;
-        const current = getInfo();
-        globalObject.previous = current;
+        const { isNewState, previous, current } = onPopStateBegin();
         const scrollTarget = current.state.scrollPosition || undefined;
-        const isHashNavigation = removeHash(current.url) === removeHash(previous.url);
-        // - `history.state === null` when:
+        const isUserPushStateNavigation = current.state.triggeredBy === 'user' || previous.state.triggeredBy === 'user';
+        const isHashNavigation = current.url !== previous.url && removeHash(current.url) === removeHash(previous.url);
+        // - `isNewState === true` when:
         //   - Click on `<a href="#some-hash" />` (note that Vike's `initOnLinkClick()` handler skips hash links)
         //   - `location.hash = 'some-hash'`
-        // - `history.state !== null` when `popstate` was triggered by the user clicking on his browser's forward/backward history button.
+        // - `isNewState === false` when `popstate` was triggered by the user clicking on his browser's forward/backward history button.
         const isHashNavigationNew = isHashNavigation && isNewState;
         const isBackwardNavigation = !current.state.timestamp || !previous.state.timestamp ? null : current.state.timestamp < previous.state.timestamp;
         // We have to scroll ourselves because we use `window.history.scrollRestoration = 'manual'`. So far this seems to work. Alternatives in case it doesn't work:
@@ -49,31 +44,27 @@ function initOnPopState() {
             }
             return;
         }
+        let doNotRenderIfSamePage = isUserPushStateNavigation;
         let abort;
         globalObject.listeners.forEach((listener) => {
             abort || (abort = listener({ previous }));
         });
-        if (abort)
+        if (abort) {
             return;
-        await renderPageClientSide({ scrollTarget, isBackwardNavigation });
+        }
+        if (abort === false) {
+            doNotRenderIfSamePage = false;
+        }
+        await renderPageClientSide({ scrollTarget, isBackwardNavigation, doNotRenderIfSamePage });
     });
 }
-/** Control client-side navigation.
+/** Control back-/forward navigation.
  *
  * https://vike.dev/onPopState
  */
 function onPopState(listener) {
     globalObject.listeners.push(listener);
 }
-function getInfo() {
-    return {
-        url: getCurrentUrl(),
-        state: getHistoryState()
-    };
-}
 function removeHash(url) {
     return url.split('#')[0];
 }
-function updateState() {
-    globalObject.previous = getInfo();
-}

package/dist/esm/client/client-routing-runtime/renderPageClientSide.d.ts

@@ -12,6 +12,7 @@ type RenderArgs = {
     overwriteLastHistoryEntry?: boolean;
     pageContextsFromRewrite?: PageContextFromRewrite[];
     redirectCount?: number;
+    doNotRenderIfSamePage?: boolean;
     isClientSideNavigation?: boolean;
 };
 declare function renderPageClientSide(renderArgs: RenderArgs): Promise<void>;

package/dist/esm/client/client-routing-runtime/renderPageClientSide.js

@@ -15,7 +15,6 @@ import { assertNoInfiniteAbortLoop, getPageContextFromAllRewrites, isAbortError,
 import { route } from '../../shared/route/index.js';
 import { isClientSideRoutable } from './isClientSideRoutable.js';
 import { setScrollPosition } from './setScrollPosition.js';
-import { updateState } from './initOnPopState.js';
 import { browserNativeScrollRestoration_disable, setInitialRenderIsDone } from './scrollRestoration.js';
 import { getErrorPageId } from '../../shared/error-page.js';
 import { setPageContextCurrent } from './getPageContextCurrent.js';
@@ -30,7 +29,7 @@ const globalObject = getGlobalObject('renderPageClientSide.ts', (() => {
 })());
 const { firstRenderStartPromise } = globalObject;
 async function renderPageClientSide(renderArgs) {
-    const { urlOriginal = getCurrentUrl(), overwriteLastHistoryEntry = false, isBackwardNavigation, pageContextsFromRewrite = [], redirectCount = 0, isClientSideNavigation = true } = renderArgs;
+    const { urlOriginal = getCurrentUrl(), overwriteLastHistoryEntry = false, isBackwardNavigation, pageContextsFromRewrite = [], redirectCount = 0, doNotRenderIfSamePage, isClientSideNavigation = true } = renderArgs;
     let { scrollTarget } = renderArgs;
     const { previousPageContext } = globalObject;
     addLinkPrefetchHandlers_unwatch();
@@ -117,6 +116,13 @@ async function renderPageClientSide(renderArgs) {
                 redirectHard(urlOriginal);
                 return;
             }
+            const isSamePage = pageContextFromRoute.pageId &&
+                previousPageContext?.pageId &&
+                pageContextFromRoute.pageId === previousPageContext.pageId;
+            if (doNotRenderIfSamePage && isSamePage) {
+                // Skip's Vike's rendering; let the user handle the navigation
+                return;
+            }
             // TODO/eventually: create helper assertPageContextFromHook()
             assert(!('urlOriginal' in pageContextFromRoute));
             objectAssign(pageContext, pageContextFromRoute);
@@ -470,7 +476,6 @@ function changeUrl(url, overwriteLastHistoryEntry) {
         return;
     browserNativeScrollRestoration_disable();
     pushHistoryState(url, overwriteLastHistoryEntry);
-    updateState();
 }
 function handleErrorFetchingStaticAssets(err, pageContext, isFirstRender) {
     if (!isErrorFetchingStaticAssets(err)) {

package/dist/esm/node/prerender/runPrerender.js

@@ -577,7 +577,9 @@ async function write(urlOriginal, pageContext, fileExtension, fileContent, root,
     assertPosixPath(fileUrl);
     assert(fileUrl.startsWith('/'));
     const filePathRelative = fileUrl.slice(1);
-    assert(!filePathRelative.startsWith('/'));
+    assert(!filePathRelative.startsWith('/'), 
+    // Let's remove this debug info after we add a assertUsage() avoiding https://github.com/vikejs/vike/issues/1929
+    { urlOriginal, fileUrl });
     assertPosixPath(outDirClient);
     assertPosixPath(filePathRelative);
     const filePath = path.posix.join(outDirClient, filePathRelative);

package/dist/esm/utils/PROJECT_VERSION.d.ts

@@ -1 +1 @@
-export declare const PROJECT_VERSION: "0.4.199-commit-5883046";
+export declare const PROJECT_VERSION: "0.4.199-commit-dc15087";

package/dist/esm/utils/PROJECT_VERSION.js

@@ -1,2 +1,2 @@
 // Automatically updated by @brillout/release-me
-export const PROJECT_VERSION = '0.4.199-commit-5883046';
+export const PROJECT_VERSION = '0.4.199-commit-dc15087';

package/dist/esm/utils/projectInfo.d.ts

@@ -1,4 +1,4 @@
 export declare const projectInfo: {
     projectName: "Vike";
-    projectVersion: "0.4.199-commit-5883046";
+    projectVersion: "0.4.199-commit-dc15087";
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike",
-  "version": "0.4.199-commit-5883046",
+  "version": "0.4.199-commit-dc15087",
   "repository": "https://github.com/vikejs/vike",
   "exports": {
     "./server": {