vike 0.4.167-commit-cfadd0a → 0.4.168

package/dist/cjs/node/plugin/plugins/importUserCode/v1-design/getVikeConfig/loadFileAtConfigTime.js

@@ -68,7 +68,6 @@ async function loadExtendsConfigs(configFileExports, configFilePath, userRootDir
         const { importPath: importPathAbsolute } = importData;
         const filePathAbsoluteFilesystem = (0, resolveImportPath_js_1.resolveImportPath)(importData, configFilePath);
         (0, resolveImportPath_js_1.assertImportPath)(filePathAbsoluteFilesystem, importData, configFilePath);
-        warnUserLandExtension(importPathAbsolute, configFilePath);
         const filePath = (0, getFilePath_js_1.getFilePathResolved)({ filePathAbsoluteFilesystem, userRootDir, importPathAbsolute });
         extendsConfigFiles.push(filePath);
     });
@@ -81,13 +80,6 @@ async function loadExtendsConfigs(configFileExports, configFilePath, userRootDir
     const extendsFilePaths = extendsConfigFiles.map((f) => f.filePathAbsoluteFilesystem);
     return { extendsConfigs, extendsFilePaths };
 }
-function warnUserLandExtension(importPath, configFilePath) {
-    // We preserve this feature because we may need it for eject
-    (0, utils_js_1.assertWarning)((0, utils_js_1.isNpmPackageImport)(importPath, {
-        // Vike config files don't support path aliases. (If they do one day, then Vike will/should be able to resolve path aliases.)
-        cannotBePathAlias: true
-    }) || importPath.includes('/node_modules/'), `${configFilePath.filePathToShowToUser} uses ${picocolors_1.default.cyan('extends')} to inherit from ${picocolors_1.default.cyan(importPath)} which is a user-land file: this is experimental and may be remove at any time. Reach out to a maintainer if you need this.`, { onlyOnce: true });
-}
 function getExtendsImportData(configFileExports, configFilePath) {
     const { filePathToShowToUser } = configFilePath;
     const configFileExport = (0, getConfigFileExport_js_1.getConfigFileExport)(configFileExports, filePathToShowToUser);

package/dist/cjs/node/plugin/plugins/importUserCode/v1-design/getVikeConfig/transpileAndExecuteFile.js

@@ -82,98 +82,96 @@ async function transpileWithEsbuild(filePath, userRootDir, transformImports) {
         // Esbuild still sometimes removes unused imports because of TypeScript: https://github.com/evanw/esbuild/issues/3034
         treeShaking: false,
         minify: false,
-        metafile: transformImports !== 'all',
-        bundle: transformImports !== 'all'
+        metafile: true,
+        bundle: true
     };
-    let pointerImports;
-    if (transformImports === 'all') {
-        pointerImports = 'all';
-        options.packages = 'external';
-    }
-    else {
-        const pointerImports_ = (pointerImports = {});
-        options.plugins = [
-            // Determine whether an import should be:
-            //  - A pointer import
-            //  - Externalized
-            {
-                name: 'vike-esbuild-plugin',
-                setup(build) {
-                    // https://github.com/evanw/esbuild/issues/3095#issuecomment-1546916366
+    let pointerImports = {};
+    options.plugins = [
+        // Determine whether an import should be:
+        //  - A pointer import
+        //  - Externalized
+        {
+            name: 'vike-esbuild',
+            setup(build) {
+                // https://github.com/brillout/esbuild-playground
+                build.onResolve({ filter: /.*/ }, async (args) => {
+                    if (args.kind !== 'import-statement')
+                        return;
+                    // Avoid infinite loop: https://github.com/evanw/esbuild/issues/3095#issuecomment-1546916366
                     const useEsbuildResolver = 'useEsbuildResolver';
-                    // https://github.com/brillout/esbuild-playground
-                    build.onResolve({ filter: /.*/ }, async (args) => {
-                        if (args.kind !== 'import-statement')
-                            return;
-                        if (args.pluginData?.[useEsbuildResolver])
-                            return;
-                        const { path, ...opts } = args;
-                        opts.pluginData = { [useEsbuildResolver]: true };
-                        const resolved = await build.resolve(path, opts);
-                        if (resolved.errors.length > 0) {
-                            /* We could do the following to let Node.js throw the error, but we don't because the error shown by esbuild is prettier: the Node.js error refers to the transpiled [build-f7i251e0iwnw]+config.ts.mjs file which isn't that nice, whereas esbuild refers to the source +config.ts file.
-                            pointerImports_[args.path] = false
-                            return { external: true }
-                            */
-                            // Let esbuild throw the error. (It throws a nice & pretty error.)
-                            return resolved;
-                        }
-                        (0, utils_js_1.assert)(resolved.path);
-                        resolved.path = (0, utils_js_1.toPosixPath)(resolved.path);
-                        // vike-{react,vue,solid} follow the convention that their config export resolves to a file named +config.js
-                        //  - This is temporary, see comment below.
-                        const isVikeExtensionConfigImport = resolved.path.endsWith('+config.js');
-                        const isPointerImport = 
+                    if (args.pluginData?.[useEsbuildResolver])
+                        return;
+                    const { path, ...opts } = args;
+                    opts.pluginData = { [useEsbuildResolver]: true };
+                    const resolved = await build.resolve(path, opts);
+                    if (resolved.errors.length > 0) {
+                        /* We could do the following to let Node.js throw the error, but we don't because the error shown by esbuild is prettier: the Node.js error refers to the transpiled [build-f7i251e0iwnw]+config.ts.mjs file which isn't that nice, whereas esbuild refers to the source +config.ts file.
+                        pointerImports[args.path] = false
+                        return { external: true }
+                        */
+                        // Let esbuild throw the error. (It throws a nice & pretty error.)
+                        cleanEsbuildErrors(resolved.errors);
+                        return resolved;
+                    }
+                    (0, utils_js_1.assert)(resolved.path);
+                    resolved.path = (0, utils_js_1.toPosixPath)(resolved.path);
+                    // vike-{react,vue,solid} follow the convention that their config export resolves to a file named +config.js
+                    //  - This is temporary, see comment below.
+                    const isVikeExtensionConfigImport = resolved.path.endsWith('+config.js');
+                    const isPointerImport = transformImports === 'all' ||
                         // .jsx, .vue, .svg, ... => obviously not config code
                         !(0, utils_js_1.isJavaScriptFile)(resolved.path) ||
-                            // Import of a Vike extension config => make it a pointer import because we want to show nice error messages (that can display whether a configas been set by the user or by a Vike extension).
-                            //  - We should have Node.js directly load vike-{react,vue,solid} while enforcing Vike extensions to set 'name' in their +config.js file.
-                            //    - vike@0.4.162 already started soft-requiring Vike extensions to set the name config
-                            isVikeExtensionConfigImport ||
-                            // Cannot be resolved by esbuild => take a leap of faith and make it a pointer import.
-                            //  - For example if esbuild cannot resolve a path alias while Vite can.
-                            //    - When tsconfig.js#compilerOptions.paths is set, then esbuild is able to resolve the path alias.
-                            resolved.errors.length > 0;
-                        pointerImports_[resolved.path] = isPointerImport;
-                        (0, utils_js_1.assertPosixPath)(resolved.path);
-                        const isExternal = isPointerImport ||
-                            // Performance: npm package imports that aren't pointer imports can be externalized. For example, if Vike eventually adds support for setting Vite configs in the vike.config.js file, then the user may import a Vite plugin in his vike.config.js file. (We could as well let esbuild always transpile /node_modules/ code but it would be useless and would unnecessarily slow down transpilation.)
-                            resolved.path.includes('/node_modules/');
-                        if (debug.isActivated)
-                            debug('onResolved()', { args, resolved, isPointerImport, isExternal });
-                        if (isExternal) {
-                            return { external: true, path: resolved.path };
-                        }
-                        else {
-                            return resolved;
-                        }
-                    });
-                }
-            },
-            // Track dependencies
-            {
-                name: 'vike:dependency-tracker',
-                setup(b) {
-                    b.onLoad({ filter: /./ }, (args) => {
-                        // We collect the dependency `args.path` in case the bulid fails (upon build error => error is thrown => no metafile)
-                        let { path } = args;
-                        path = (0, utils_js_1.toPosixPath)(path);
-                        getVikeConfig_js_1.vikeConfigDependencies.add(path);
-                        return undefined;
-                    });
-                    /* To exhaustively collect all dependencies upon build failure, we would also need to use onResolve().
-                     *  - Because onLoad() isn't call if the config dependency can't be resolved.
-                     *  - For example, the following breaks auto-reload (the config is stuck in its error state and the user needs to touch the importer for the config to reload):
-                     *    ```bash
-                     *    mv ./some-config-dependency.js /tmp/ && mv /tmp/some-config-dependency.js .
-                     *    ```
-                     *  - But implementing a fix is complex and isn't worth it.
-                    b.onResolve(...)
-                    */
-                }
+                        // Import of a Vike extension config => make it a pointer import because we want to show nice error messages (that can display whether a configas been set by the user or by a Vike extension).
+                        //  - We should have Node.js directly load vike-{react,vue,solid} while enforcing Vike extensions to set 'name' in their +config.js file.
+                        //    - vike@0.4.162 already started soft-requiring Vike extensions to set the name config
+                        isVikeExtensionConfigImport ||
+                        // Cannot be resolved by esbuild => take a leap of faith and make it a pointer import.
+                        //  - For example if esbuild cannot resolve a path alias while Vite can.
+                        //    - When tsconfig.js#compilerOptions.paths is set, then esbuild is able to resolve the path alias.
+                        resolved.errors.length > 0;
+                    pointerImports[resolved.path] = isPointerImport;
+                    (0, utils_js_1.assertPosixPath)(resolved.path);
+                    const isExternal = isPointerImport ||
+                        // Performance: npm package imports that aren't pointer imports can be externalized. For example, if Vike eventually adds support for setting Vite configs in the vike.config.js file, then the user may import a Vite plugin in his vike.config.js file. (We could as well let esbuild always transpile /node_modules/ code but it would be useless and would unnecessarily slow down transpilation.)
+                        resolved.path.includes('/node_modules/');
+                    if (debug.isActivated)
+                        debug('onResolved()', { args, resolved, isPointerImport, isExternal });
+                    // We need esbuild to resolve path aliases so that we can use:
+                    //   isNpmPackageImport(str, { cannotBePathAlias: true })
+                    //   assertIsNpmPackageImport()
+                    (0, utils_js_1.assertPathIsFilesystemAbsolute)(resolved.path);
+                    if (isExternal) {
+                        return { external: true, path: resolved.path };
+                    }
+                    else {
+                        return resolved;
+                    }
+                });
             }
-        ];
-    }
+        },
+        // Track dependencies
+        {
+            name: 'vike:dependency-tracker',
+            setup(b) {
+                b.onLoad({ filter: /./ }, (args) => {
+                    // We collect the dependency `args.path` in case the bulid fails (upon build error => error is thrown => no metafile)
+                    let { path } = args;
+                    path = (0, utils_js_1.toPosixPath)(path);
+                    getVikeConfig_js_1.vikeConfigDependencies.add(path);
+                    return undefined;
+                });
+                /* To exhaustively collect all dependencies upon build failure, we would also need to use onResolve().
+                 *  - Because onLoad() isn't call if the config dependency can't be resolved.
+                 *  - For example, the following breaks auto-reload (the config is stuck in its error state and the user needs to touch the importer for the config to reload):
+                 *    ```bash
+                 *    mv ./some-config-dependency.js /tmp/ && mv /tmp/some-config-dependency.js .
+                 *    ```
+                 *  - But implementing a fix is complex and isn't worth it.
+                b.onResolve(...)
+                */
+            }
+        }
+    ];
     let result;
     try {
         result = await (0, esbuild_1.build)(options);
@@ -183,15 +181,13 @@ async function transpileWithEsbuild(filePath, userRootDir, transformImports) {
         throw err;
     }
     // Track dependencies
-    if (transformImports !== 'all') {
-        (0, utils_js_1.assert)(result.metafile);
-        Object.keys(result.metafile.inputs).forEach((filePathRelative) => {
-            filePathRelative = (0, utils_js_1.toPosixPath)(filePathRelative);
-            (0, utils_js_1.assertPosixPath)(userRootDir);
-            const filePathAbsoluteFilesystem = path_1.default.posix.join(userRootDir, filePathRelative);
-            getVikeConfig_js_1.vikeConfigDependencies.add(filePathAbsoluteFilesystem);
-        });
-    }
+    (0, utils_js_1.assert)(result.metafile);
+    Object.keys(result.metafile.inputs).forEach((filePathRelative) => {
+        filePathRelative = (0, utils_js_1.toPosixPath)(filePathRelative);
+        (0, utils_js_1.assertPosixPath)(userRootDir);
+        const filePathAbsoluteFilesystem = path_1.default.posix.join(userRootDir, filePathRelative);
+        getVikeConfig_js_1.vikeConfigDependencies.add(filePathAbsoluteFilesystem);
+    });
     const code = result.outputFiles[0].text;
     (0, utils_js_1.assert)(typeof code === 'string');
     return { code, pointerImports };
@@ -316,3 +312,23 @@ function getErrIntroMsg(operation, filePath) {
     ].join(' ');
     return msg;
 }
+function cleanEsbuildErrors(errors) {
+    errors.forEach((e) => (e.notes = e.notes.filter((note) => 
+    // Remove note:
+    // ```shell
+    // You can mark the path "#root/renderer/onRenderHtml_typo" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.
+    // ```
+    //
+    // From error:
+    // ```shell
+    // ✘ [ERROR] Could not resolve "#root/renderer/onRenderHtml_typo" [plugin vike-esbuild]
+    //
+    //    renderer/+config.h.js:1:29:
+    //      1 │ import { onRenderHtml } from "#root/renderer/onRenderHtml_typo"
+    //        ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    //
+    //  You can mark the path "#root/renderer/onRenderHtml_typo" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.
+    //
+    // ```
+    !note.text.includes('as external to exclude it from the bundle'))));
+}

package/dist/cjs/utils/assertPathIsFilesystemAbsolute.js

@@ -11,11 +11,11 @@ const filesystemPathHandling_js_1 = require("./filesystemPathHandling.js");
 function assertPathIsFilesystemAbsolute(p) {
     (0, filesystemPathHandling_js_1.assertPosixPath)(p);
     (0, assert_js_1.assert)(!p.startsWith('/@fs/'));
-    if (process.platform === 'win32') {
-        (0, assert_js_1.assert)(path_1.default.win32.isAbsolute(p));
+    if (process.platform !== 'win32') {
+        (0, assert_js_1.assert)(p.startsWith('/'));
     }
     else {
-        (0, assert_js_1.assert)(p.startsWith('/'));
+        (0, assert_js_1.assert)(path_1.default.win32.isAbsolute(p));
     }
 }
 exports.assertPathIsFilesystemAbsolute = assertPathIsFilesystemAbsolute;

package/dist/cjs/utils/projectInfo.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PROJECT_VERSION = exports.projectInfo = void 0;
-const PROJECT_VERSION = '0.4.167-commit-cfadd0a';
+const PROJECT_VERSION = '0.4.168';
 exports.PROJECT_VERSION = PROJECT_VERSION;
 const projectInfo = {
     projectName: 'Vike',

package/dist/esm/node/plugin/plugins/importUserCode/v1-design/getVikeConfig/loadFileAtConfigTime.js

@@ -2,7 +2,7 @@
 export { loadImportedFile };
 export { loadValueFile };
 export { loadConfigFile };
-import { assert, assertUsage, assertWarning, hasProp, assertIsNotProductionRuntime, isNpmPackageImport } from '../../../../utils.js';
+import { assert, assertUsage, hasProp, assertIsNotProductionRuntime } from '../../../../utils.js';
 import { transpileAndExecuteFile } from './transpileAndExecuteFile.js';
 import { assertPlusFileExport } from '../../../../../../shared/page-configs/assertPlusFileExport.js';
 import pc from '@brillout/picocolors';
@@ -62,7 +62,6 @@ async function loadExtendsConfigs(configFileExports, configFilePath, userRootDir
         const { importPath: importPathAbsolute } = importData;
         const filePathAbsoluteFilesystem = resolveImportPath(importData, configFilePath);
         assertImportPath(filePathAbsoluteFilesystem, importData, configFilePath);
-        warnUserLandExtension(importPathAbsolute, configFilePath);
         const filePath = getFilePathResolved({ filePathAbsoluteFilesystem, userRootDir, importPathAbsolute });
         extendsConfigFiles.push(filePath);
     });
@@ -75,13 +74,6 @@ async function loadExtendsConfigs(configFileExports, configFilePath, userRootDir
     const extendsFilePaths = extendsConfigFiles.map((f) => f.filePathAbsoluteFilesystem);
     return { extendsConfigs, extendsFilePaths };
 }
-function warnUserLandExtension(importPath, configFilePath) {
-    // We preserve this feature because we may need it for eject
-    assertWarning(isNpmPackageImport(importPath, {
-        // Vike config files don't support path aliases. (If they do one day, then Vike will/should be able to resolve path aliases.)
-        cannotBePathAlias: true
-    }) || importPath.includes('/node_modules/'), `${configFilePath.filePathToShowToUser} uses ${pc.cyan('extends')} to inherit from ${pc.cyan(importPath)} which is a user-land file: this is experimental and may be remove at any time. Reach out to a maintainer if you need this.`, { onlyOnce: true });
-}
 function getExtendsImportData(configFileExports, configFilePath) {
     const { filePathToShowToUser } = configFilePath;
     const configFileExport = getConfigFileExport(configFileExports, filePathToShowToUser);

package/dist/esm/node/plugin/plugins/importUserCode/v1-design/getVikeConfig/transformFileImports.d.ts

@@ -2,7 +2,7 @@ export { transformFileImports };
 export { parseImportData };
 export { isImportData };
 export type { ImportData };
-declare function transformFileImports(code: string, filePathToShowToUser2: string, pointerImports: 'all' | Record<string, boolean>, skipWarnings?: true): string | null;
+declare function transformFileImports(code: string, filePathToShowToUser2: string, pointerImports: Record<string, boolean> | 'all', skipWarnings?: true): string | null;
 /**
  * Data Structure holding info about import statement:
  *   `import { someExport as someImport } from './some-file'`

package/dist/esm/node/plugin/plugins/importUserCode/v1-design/getVikeConfig/transpileAndExecuteFile.js

@@ -7,7 +7,7 @@ import fs from 'fs';
 import path from 'path';
 import pc from '@brillout/picocolors';
 import { import_ } from '@brillout/import';
-import { assertPosixPath, getRandomId, assertIsNotProductionRuntime, assert, assertWarning, isObject, toPosixPath, assertUsage, isJavaScriptFile, createDebugger } from '../../../../utils.js';
+import { assertPosixPath, getRandomId, assertIsNotProductionRuntime, assert, assertWarning, isObject, toPosixPath, assertUsage, isJavaScriptFile, createDebugger, assertPathIsFilesystemAbsolute } from '../../../../utils.js';
 import { transformFileImports } from './transformFileImports.js';
 import { vikeConfigDependencies } from '../getVikeConfig.js';
 import 'source-map-support/register.js';
@@ -79,98 +79,96 @@ async function transpileWithEsbuild(filePath, userRootDir, transformImports) {
         // Esbuild still sometimes removes unused imports because of TypeScript: https://github.com/evanw/esbuild/issues/3034
         treeShaking: false,
         minify: false,
-        metafile: transformImports !== 'all',
-        bundle: transformImports !== 'all'
+        metafile: true,
+        bundle: true
     };
-    let pointerImports;
-    if (transformImports === 'all') {
-        pointerImports = 'all';
-        options.packages = 'external';
-    }
-    else {
-        const pointerImports_ = (pointerImports = {});
-        options.plugins = [
-            // Determine whether an import should be:
-            //  - A pointer import
-            //  - Externalized
-            {
-                name: 'vike-esbuild-plugin',
-                setup(build) {
-                    // https://github.com/evanw/esbuild/issues/3095#issuecomment-1546916366
+    let pointerImports = {};
+    options.plugins = [
+        // Determine whether an import should be:
+        //  - A pointer import
+        //  - Externalized
+        {
+            name: 'vike-esbuild',
+            setup(build) {
+                // https://github.com/brillout/esbuild-playground
+                build.onResolve({ filter: /.*/ }, async (args) => {
+                    if (args.kind !== 'import-statement')
+                        return;
+                    // Avoid infinite loop: https://github.com/evanw/esbuild/issues/3095#issuecomment-1546916366
                     const useEsbuildResolver = 'useEsbuildResolver';
-                    // https://github.com/brillout/esbuild-playground
-                    build.onResolve({ filter: /.*/ }, async (args) => {
-                        if (args.kind !== 'import-statement')
-                            return;
-                        if (args.pluginData?.[useEsbuildResolver])
-                            return;
-                        const { path, ...opts } = args;
-                        opts.pluginData = { [useEsbuildResolver]: true };
-                        const resolved = await build.resolve(path, opts);
-                        if (resolved.errors.length > 0) {
-                            /* We could do the following to let Node.js throw the error, but we don't because the error shown by esbuild is prettier: the Node.js error refers to the transpiled [build-f7i251e0iwnw]+config.ts.mjs file which isn't that nice, whereas esbuild refers to the source +config.ts file.
-                            pointerImports_[args.path] = false
-                            return { external: true }
-                            */
-                            // Let esbuild throw the error. (It throws a nice & pretty error.)
-                            return resolved;
-                        }
-                        assert(resolved.path);
-                        resolved.path = toPosixPath(resolved.path);
-                        // vike-{react,vue,solid} follow the convention that their config export resolves to a file named +config.js
-                        //  - This is temporary, see comment below.
-                        const isVikeExtensionConfigImport = resolved.path.endsWith('+config.js');
-                        const isPointerImport = 
+                    if (args.pluginData?.[useEsbuildResolver])
+                        return;
+                    const { path, ...opts } = args;
+                    opts.pluginData = { [useEsbuildResolver]: true };
+                    const resolved = await build.resolve(path, opts);
+                    if (resolved.errors.length > 0) {
+                        /* We could do the following to let Node.js throw the error, but we don't because the error shown by esbuild is prettier: the Node.js error refers to the transpiled [build-f7i251e0iwnw]+config.ts.mjs file which isn't that nice, whereas esbuild refers to the source +config.ts file.
+                        pointerImports[args.path] = false
+                        return { external: true }
+                        */
+                        // Let esbuild throw the error. (It throws a nice & pretty error.)
+                        cleanEsbuildErrors(resolved.errors);
+                        return resolved;
+                    }
+                    assert(resolved.path);
+                    resolved.path = toPosixPath(resolved.path);
+                    // vike-{react,vue,solid} follow the convention that their config export resolves to a file named +config.js
+                    //  - This is temporary, see comment below.
+                    const isVikeExtensionConfigImport = resolved.path.endsWith('+config.js');
+                    const isPointerImport = transformImports === 'all' ||
                         // .jsx, .vue, .svg, ... => obviously not config code
                         !isJavaScriptFile(resolved.path) ||
-                            // Import of a Vike extension config => make it a pointer import because we want to show nice error messages (that can display whether a configas been set by the user or by a Vike extension).
-                            //  - We should have Node.js directly load vike-{react,vue,solid} while enforcing Vike extensions to set 'name' in their +config.js file.
-                            //    - vike@0.4.162 already started soft-requiring Vike extensions to set the name config
-                            isVikeExtensionConfigImport ||
-                            // Cannot be resolved by esbuild => take a leap of faith and make it a pointer import.
-                            //  - For example if esbuild cannot resolve a path alias while Vite can.
-                            //    - When tsconfig.js#compilerOptions.paths is set, then esbuild is able to resolve the path alias.
-                            resolved.errors.length > 0;
-                        pointerImports_[resolved.path] = isPointerImport;
-                        assertPosixPath(resolved.path);
-                        const isExternal = isPointerImport ||
-                            // Performance: npm package imports that aren't pointer imports can be externalized. For example, if Vike eventually adds support for setting Vite configs in the vike.config.js file, then the user may import a Vite plugin in his vike.config.js file. (We could as well let esbuild always transpile /node_modules/ code but it would be useless and would unnecessarily slow down transpilation.)
-                            resolved.path.includes('/node_modules/');
-                        if (debug.isActivated)
-                            debug('onResolved()', { args, resolved, isPointerImport, isExternal });
-                        if (isExternal) {
-                            return { external: true, path: resolved.path };
-                        }
-                        else {
-                            return resolved;
-                        }
-                    });
-                }
-            },
-            // Track dependencies
-            {
-                name: 'vike:dependency-tracker',
-                setup(b) {
-                    b.onLoad({ filter: /./ }, (args) => {
-                        // We collect the dependency `args.path` in case the bulid fails (upon build error => error is thrown => no metafile)
-                        let { path } = args;
-                        path = toPosixPath(path);
-                        vikeConfigDependencies.add(path);
-                        return undefined;
-                    });
-                    /* To exhaustively collect all dependencies upon build failure, we would also need to use onResolve().
-                     *  - Because onLoad() isn't call if the config dependency can't be resolved.
-                     *  - For example, the following breaks auto-reload (the config is stuck in its error state and the user needs to touch the importer for the config to reload):
-                     *    ```bash
-                     *    mv ./some-config-dependency.js /tmp/ && mv /tmp/some-config-dependency.js .
-                     *    ```
-                     *  - But implementing a fix is complex and isn't worth it.
-                    b.onResolve(...)
-                    */
-                }
+                        // Import of a Vike extension config => make it a pointer import because we want to show nice error messages (that can display whether a configas been set by the user or by a Vike extension).
+                        //  - We should have Node.js directly load vike-{react,vue,solid} while enforcing Vike extensions to set 'name' in their +config.js file.
+                        //    - vike@0.4.162 already started soft-requiring Vike extensions to set the name config
+                        isVikeExtensionConfigImport ||
+                        // Cannot be resolved by esbuild => take a leap of faith and make it a pointer import.
+                        //  - For example if esbuild cannot resolve a path alias while Vite can.
+                        //    - When tsconfig.js#compilerOptions.paths is set, then esbuild is able to resolve the path alias.
+                        resolved.errors.length > 0;
+                    pointerImports[resolved.path] = isPointerImport;
+                    assertPosixPath(resolved.path);
+                    const isExternal = isPointerImport ||
+                        // Performance: npm package imports that aren't pointer imports can be externalized. For example, if Vike eventually adds support for setting Vite configs in the vike.config.js file, then the user may import a Vite plugin in his vike.config.js file. (We could as well let esbuild always transpile /node_modules/ code but it would be useless and would unnecessarily slow down transpilation.)
+                        resolved.path.includes('/node_modules/');
+                    if (debug.isActivated)
+                        debug('onResolved()', { args, resolved, isPointerImport, isExternal });
+                    // We need esbuild to resolve path aliases so that we can use:
+                    //   isNpmPackageImport(str, { cannotBePathAlias: true })
+                    //   assertIsNpmPackageImport()
+                    assertPathIsFilesystemAbsolute(resolved.path);
+                    if (isExternal) {
+                        return { external: true, path: resolved.path };
+                    }
+                    else {
+                        return resolved;
+                    }
+                });
             }
-        ];
-    }
+        },
+        // Track dependencies
+        {
+            name: 'vike:dependency-tracker',
+            setup(b) {
+                b.onLoad({ filter: /./ }, (args) => {
+                    // We collect the dependency `args.path` in case the bulid fails (upon build error => error is thrown => no metafile)
+                    let { path } = args;
+                    path = toPosixPath(path);
+                    vikeConfigDependencies.add(path);
+                    return undefined;
+                });
+                /* To exhaustively collect all dependencies upon build failure, we would also need to use onResolve().
+                 *  - Because onLoad() isn't call if the config dependency can't be resolved.
+                 *  - For example, the following breaks auto-reload (the config is stuck in its error state and the user needs to touch the importer for the config to reload):
+                 *    ```bash
+                 *    mv ./some-config-dependency.js /tmp/ && mv /tmp/some-config-dependency.js .
+                 *    ```
+                 *  - But implementing a fix is complex and isn't worth it.
+                b.onResolve(...)
+                */
+            }
+        }
+    ];
     let result;
     try {
         result = await build(options);
@@ -180,15 +178,13 @@ async function transpileWithEsbuild(filePath, userRootDir, transformImports) {
         throw err;
     }
     // Track dependencies
-    if (transformImports !== 'all') {
-        assert(result.metafile);
-        Object.keys(result.metafile.inputs).forEach((filePathRelative) => {
-            filePathRelative = toPosixPath(filePathRelative);
-            assertPosixPath(userRootDir);
-            const filePathAbsoluteFilesystem = path.posix.join(userRootDir, filePathRelative);
-            vikeConfigDependencies.add(filePathAbsoluteFilesystem);
-        });
-    }
+    assert(result.metafile);
+    Object.keys(result.metafile.inputs).forEach((filePathRelative) => {
+        filePathRelative = toPosixPath(filePathRelative);
+        assertPosixPath(userRootDir);
+        const filePathAbsoluteFilesystem = path.posix.join(userRootDir, filePathRelative);
+        vikeConfigDependencies.add(filePathAbsoluteFilesystem);
+    });
     const code = result.outputFiles[0].text;
     assert(typeof code === 'string');
     return { code, pointerImports };
@@ -310,3 +306,23 @@ function getErrIntroMsg(operation, filePath) {
     ].join(' ');
     return msg;
 }
+function cleanEsbuildErrors(errors) {
+    errors.forEach((e) => (e.notes = e.notes.filter((note) => 
+    // Remove note:
+    // ```shell
+    // You can mark the path "#root/renderer/onRenderHtml_typo" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.
+    // ```
+    //
+    // From error:
+    // ```shell
+    // ✘ [ERROR] Could not resolve "#root/renderer/onRenderHtml_typo" [plugin vike-esbuild]
+    //
+    //    renderer/+config.h.js:1:29:
+    //      1 │ import { onRenderHtml } from "#root/renderer/onRenderHtml_typo"
+    //        ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    //
+    //  You can mark the path "#root/renderer/onRenderHtml_typo" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.
+    //
+    // ```
+    !note.text.includes('as external to exclude it from the bundle'))));
+}

package/dist/esm/utils/assertPathIsFilesystemAbsolute.js

@@ -6,10 +6,10 @@ import { assertPosixPath } from './filesystemPathHandling.js';
 function assertPathIsFilesystemAbsolute(p) {
     assertPosixPath(p);
     assert(!p.startsWith('/@fs/'));
-    if (process.platform === 'win32') {
-        assert(path.win32.isAbsolute(p));
+    if (process.platform !== 'win32') {
+        assert(p.startsWith('/'));
     }
     else {
-        assert(p.startsWith('/'));
+        assert(path.win32.isAbsolute(p));
     }
 }

package/dist/esm/utils/projectInfo.d.ts

@@ -1,7 +1,7 @@
 export { projectInfo };
 export { PROJECT_VERSION };
-declare const PROJECT_VERSION: "0.4.167-commit-cfadd0a";
+declare const PROJECT_VERSION: "0.4.168";
 declare const projectInfo: {
     projectName: "Vike";
-    projectVersion: "0.4.167-commit-cfadd0a";
+    projectVersion: "0.4.168";
 };

package/dist/esm/utils/projectInfo.js

@@ -1,6 +1,6 @@
 export { projectInfo };
 export { PROJECT_VERSION };
-const PROJECT_VERSION = '0.4.167-commit-cfadd0a';
+const PROJECT_VERSION = '0.4.168';
 const projectInfo = {
     projectName: 'Vike',
     projectVersion: PROJECT_VERSION

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike",
-  "version": "0.4.167-commit-cfadd0a",
+  "version": "0.4.168",
   "scripts": {
     "dev": "tsc --watch",
     "build": "rimraf dist/ && pnpm run build:esm && pnpm run build:cjs",
@@ -16,7 +16,7 @@
     "@brillout/json-serializer": "^0.5.8",
     "@brillout/picocolors": "^1.0.10",
     "@brillout/require-shim": "^0.1.2",
-    "@brillout/vite-plugin-server-entry": "^0.4.4",
+    "@brillout/vite-plugin-server-entry": "^0.4.5",
     "acorn": "^8.0.0",
     "cac": "^6.0.0",
     "es-module-lexer": "^1.0.0",