vike-lite 1.18.0 → 1.18.2

package/dist/vite.mjs

@@ -122,6 +122,7 @@ function findPackageJsonPath(startDir) {
 	}
 }
 function extractPkgName(id) {
+	if (id.startsWith("\0")) return null;
 	const normalized = id.replaceAll("\\", "/");
 	const matches = [...normalized.matchAll(/(?:node_modules|\.yarn(?:\/__virtual__)?)\/(@[^/]+\/[^/]+|[^/]+)/g)];
 	if (matches.length > 0) {
@@ -143,6 +144,7 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 	let hasAnyPrerender;
 	let baseUrl;
 	let projectDependencies = null;
+	const bundleReports = {};
 	const VIRTUAL = {
 		routes: "virtual:vike-lite/routes",
 		manifest: "virtual:vike-lite/client-manifest",
@@ -168,21 +170,24 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 			viteConfigRoot = config.root ? path.resolve(config.root) : process.cwd();
 			if (isProd && printDependencies) {
 				const pkgJsonPath = findPackageJsonPath(viteConfigRoot);
-				if (pkgJsonPath) {
+				if (pkgJsonPath) try {
 					const pkgJson = JSON.parse(fs.readFileSync(pkgJsonPath, "utf8"));
 					projectDependencies = {};
 					for (const [k, v] of Object.entries(pkgJson.dependencies || {})) projectDependencies[k] = {
-						version: v,
+						version: String(v),
 						type: ""
 					};
-					for (const [k, v] of Object.entries(pkgJson.devDependencies || {})) projectDependencies[k] = {
-						version: v,
+					for (const [k, v] of Object.entries(pkgJson.devDependencies || {})) if (!projectDependencies[k]) projectDependencies[k] = {
+						version: String(v),
 						type: "dev"
 					};
 					for (const [k, v] of Object.entries(pkgJson.peerDependencies || {})) if (!projectDependencies[k]) projectDependencies[k] = {
-						version: v,
+						version: String(v),
 						type: "peer"
 					};
+				} catch (error) {
+					console.warn(`⚠️ Failed to parse package.json for printDependencies:`, error);
+					projectDependencies = null;
 				}
 			}
 			const { routes } = generateRoutes(viteConfigRoot, pagesDir);
@@ -349,39 +354,27 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 		},
 		generateBundle(_options, bundle) {
 			if (!printDependencies || !projectDependencies) return;
+			const deps = projectDependencies;
 			const usedDeps = /* @__PURE__ */ new Map();
+			function recordUsage(pkg, patch) {
+				if (!pkg || pkg.startsWith("vike-lite") || !Object.hasOwn(deps, pkg)) return;
+				const entry = usedDeps.get(pkg) ?? {
+					...deps[pkg],
+					isBundled: false,
+					isExternal: false
+				};
+				Object.assign(entry, patch);
+				usedDeps.set(pkg, entry);
+			}
 			for (const chunk of Object.values(bundle)) {
 				if (chunk.type !== "chunk") continue;
-				for (const id of chunk.moduleIds) {
-					const pkg = extractPkgName(id);
-					if (pkg && !pkg.startsWith("vike-lite") && Object.hasOwn(projectDependencies, pkg)) {
-						const entry = usedDeps.get(pkg) ?? {
-							...projectDependencies[pkg],
-							isBundled: false,
-							isExternal: false
-						};
-						entry.isBundled = true;
-						usedDeps.set(pkg, entry);
-					}
-				}
-				for (const imp of [...chunk.imports, ...chunk.dynamicImports]) {
-					if (bundle[imp]) continue;
-					const pkg = extractPkgName(imp);
-					if (pkg && !pkg.startsWith("vike-lite") && Object.hasOwn(projectDependencies, pkg)) {
-						const entry = usedDeps.get(pkg) ?? {
-							...projectDependencies[pkg],
-							isBundled: false,
-							isExternal: false
-						};
-						entry.isExternal = true;
-						usedDeps.set(pkg, entry);
-					}
-				}
+				for (const id of chunk.moduleIds) recordUsage(extractPkgName(id), { isBundled: true });
 			}
-			const sorted = [...usedDeps.entries()].sort(([a], [b]) => a.localeCompare(b));
+			for (const id of this.getModuleIds()) if (this.getModuleInfo(id)?.code === null) recordUsage(extractPkgName(id), { isExternal: true });
 			const envName = this.environment.name;
-			const label = envName === "client" ? "Client" : "Server";
-			console.log(`\n📦 [${label} bundle] ${sorted.length} dependencies used from package.json:`);
+			bundleReports[envName] = usedDeps;
+			const sorted = [...usedDeps.entries()].sort(([a], [b]) => a.localeCompare(b));
+			console.log(`\n📦 [${envName === "client" ? "Client" : "Server"} bundle] ${sorted.length} dependencies used from package.json:`);
 			if (sorted.length === 0) console.log("   (None)");
 			else for (const [name, info] of sorted) {
 				const typeTag = info.type ? ` \u{1B}[33m[${info.type}]\u{1B}[0m` : "";
@@ -390,12 +383,20 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 			}
 			const suggestions = [];
 			for (const [name, info] of sorted) if (envName === "ssr" && info.isExternal && info.type === "dev") suggestions.push(`\u{1B}[31m🚨 ${name}\u{1B}[0m is externalized by the server but listed as a \u{1B}[33mdevDependency\u{1B}[0m. Move it to \u{1B}[32mdependencies\u{1B}[0m to prevent production crashes.`);
-			else if (info.isBundled && !info.isExternal && info.type === "") {
-				const otherEnv = envName === "client" ? "server" : "client";
-				suggestions.push(`\u{1B}[34m💡 ${name}\u{1B}[0m is fully bundled here. If it's also bundled (or unused) in the ${otherEnv}, consider moving it to \u{1B}[33mdevDependencies\u{1B}[0m.`);
+			if (envName === "ssr") {
+				const clientDeps = bundleReports.client;
+				const allNames = /* @__PURE__ */ new Set([...clientDeps?.keys() ?? [], ...usedDeps.keys()]);
+				for (const name of allNames) {
+					const meta = deps[name];
+					if (!meta || meta.type !== "") continue;
+					const c = clientDeps?.get(name);
+					const s = usedDeps.get(name);
+					const externalAnywhere = c?.isExternal || s?.isExternal;
+					if ((c || s) && !externalAnywhere) suggestions.push(`\u{1B}[34m💡 ${name}\u{1B}[0m is fully bundled (or unused) in both client and server — never externalized. Safe to move to \u{1B}[33mdevDependencies\u{1B}[0m.`);
+				}
 			}
 			if (suggestions.length > 0) {
-				console.log(`\n   \u{1B}[1m${label} Suggestions:\u{1B}[0m`);
+				console.log(`\n   \u{1B}[1mSuggestions:\u{1B}[0m`);
 				for (const s of suggestions) console.log(`   ${s}`);
 			}
 		},

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike-lite",
-  "version": "1.18.0",
+  "version": "1.18.2",
   "license": "MIT",
   "repository": {
     "type": "git",