vike-lite 1.17.1 → 1.17.3

package/README.md

@@ -43,10 +43,10 @@ When set to `true`, at the end of each production build (client and server) the
 
 ```sh
 
-📦 [Client bundle] package.json dependencies used (1):
+📦 [Client bundle] 1 dependencies used from package.json:
    - solid-js@^1.9.3
 
-📦 [Server bundle] package.json dependencies used (2):
+📦 [Server bundle] 2 dependencies used from package.json:
    - solid-js@^1.9.3
    - hono@^4.12.31
 ```

package/dist/vite.mjs

@@ -121,15 +121,18 @@ function findPackageJsonPath(startDir) {
 		dir = parent;
 	}
 }
-function extractPackageNameFromPath(moduleId) {
-	const matches = [...moduleId.replaceAll("\\", "/").matchAll(/node_modules\/(@[^/]+\/[^/]+|[^/]+)/g)];
-	if (matches.length === 0) return null;
-	return matches[matches.length - 1][1];
-}
-function extractPackageNameFromImport(imp) {
-	if (imp.startsWith(".") || imp.startsWith("/") || imp.startsWith("\0") || path.isAbsolute(imp) || imp.startsWith("node:")) return null;
-	const parts = imp.split("/");
-	return imp.startsWith("@") && parts.length > 1 ? `${parts[0]}/${parts[1]}` : parts[0];
+function extractPkgName(id) {
+	const normalized = id.replaceAll("\\", "/");
+	const matches = [...normalized.matchAll(/(?:node_modules|\.yarn(?:\/__virtual__)?)\/(@[^/]+\/[^/]+|[^/]+)/g)];
+	if (matches.length > 0) {
+		const pkg = matches[matches.length - 1][1];
+		if (pkg !== ".pnpm") return pkg;
+	}
+	if (!normalized.startsWith(".") && !normalized.startsWith("/") && !normalized.includes(":")) {
+		const parts = normalized.split("/");
+		return normalized.startsWith("@") && parts.length > 1 ? `${parts[0]}/${parts[1]}` : parts[0];
+	}
+	return null;
 }
 //#endregion
 //#region src/vite/index.ts
@@ -140,6 +143,8 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 	let hasAnyPrerender;
 	let baseUrl;
 	let projectDependencies = null;
+	const depUsage = /* @__PURE__ */ new Map();
+	const processedEnvs = /* @__PURE__ */ new Set();
 	const VIRTUAL = {
 		routes: "virtual:vike-lite/routes",
 		manifest: "virtual:vike-lite/client-manifest",
@@ -167,10 +172,18 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 				const pkgJsonPath = findPackageJsonPath(viteConfigRoot);
 				if (pkgJsonPath) {
 					const pkgJson = JSON.parse(fs.readFileSync(pkgJsonPath, "utf8"));
-					projectDependencies = {
-						...pkgJson.dependencies,
-						...pkgJson.devDependencies,
-						...pkgJson.peerDependencies
+					projectDependencies = {};
+					for (const [k, v] of Object.entries(pkgJson.dependencies || {})) projectDependencies[k] = {
+						version: v,
+						type: ""
+					};
+					for (const [k, v] of Object.entries(pkgJson.devDependencies || {})) projectDependencies[k] = {
+						version: v,
+						type: "dev"
+					};
+					for (const [k, v] of Object.entries(pkgJson.peerDependencies || {})) if (!projectDependencies[k]) projectDependencies[k] = {
+						version: v,
+						type: "peer"
 					};
 				}
 			}
@@ -336,27 +349,68 @@ function vikeLite({ pagesDir = "pages", apiPrefix = "/api", prerender = false, s
 			if (!printDependencies || !projectDependencies) return;
 			const envName = this.environment.name;
 			if (envName !== "client" && envName !== "ssr") return;
-			const usedPackages = /* @__PURE__ */ new Set();
-			for (const file of Object.values(bundle)) {
-				if (file.type !== "chunk") continue;
-				for (const moduleId of file.moduleIds) {
-					const pkgName = extractPackageNameFromPath(moduleId);
-					if (pkgName && projectDependencies[pkgName] !== void 0) usedPackages.add(pkgName);
+			const usedDeps = /* @__PURE__ */ new Map();
+			for (const chunk of Object.values(bundle)) {
+				if (chunk.type !== "chunk") continue;
+				for (const id of chunk.moduleIds) {
+					const pkg = extractPkgName(id);
+					if (pkg && !pkg.startsWith("vike-lite") && Object.hasOwn(projectDependencies, pkg)) {
+						const entry = usedDeps.get(pkg) ?? {
+							...projectDependencies[pkg],
+							isBundled: false,
+							isExternal: false
+						};
+						entry.isBundled = true;
+						usedDeps.set(pkg, entry);
+					}
 				}
-				for (const imp of file.imports) {
-					const pkgName = extractPackageNameFromImport(imp);
-					if (pkgName && projectDependencies[pkgName] !== void 0) usedPackages.add(pkgName);
+				for (const imp of [...chunk.imports, ...chunk.dynamicImports]) {
+					if (bundle[imp]) continue;
+					const pkg = extractPkgName(imp);
+					if (pkg && !pkg.startsWith("vike-lite") && Object.hasOwn(projectDependencies, pkg)) {
+						const entry = usedDeps.get(pkg) ?? {
+							...projectDependencies[pkg],
+							isBundled: false,
+							isExternal: false
+						};
+						entry.isExternal = true;
+						usedDeps.set(pkg, entry);
+					}
 				}
-				for (const imp of file.dynamicImports) {
-					const pkgName = extractPackageNameFromImport(imp);
-					if (pkgName && projectDependencies[pkgName] !== void 0) usedPackages.add(pkgName);
+			}
+			for (const [name, info] of usedDeps) {
+				const global = depUsage.get(name) ?? {
+					version: info.version,
+					type: info.type,
+					isBundled: false,
+					isExternal: false,
+					externalEnvs: /* @__PURE__ */ new Set()
+				};
+				global.isBundled ||= info.isBundled;
+				global.isExternal ||= info.isExternal;
+				if (info.isExternal) global.externalEnvs.add(envName);
+				depUsage.set(name, global);
+			}
+			processedEnvs.add(envName);
+			const sorted = [...usedDeps.entries()].sort(([a], [b]) => a.localeCompare(b));
+			console.log(`\n📦 [${envName === "client" ? "Client" : "Server"} bundle] ${sorted.length} dependencies used from package.json:`);
+			if (sorted.length === 0) console.log("   (None)");
+			else for (const [name, info] of sorted) {
+				const typeTag = info.type ? ` \u{1B}[33m[${info.type}]\u{1B}[0m` : "";
+				const usageTag = info.isExternal ? " \x1B[90m(external)\x1B[0m" : " \x1B[90m(bundled)\x1B[0m";
+				console.log(`   - \u{1B}[36m${name}@${info.version}\u{1B}[0m${typeTag}${usageTag}`);
+			}
+			if (processedEnvs.has("client") && processedEnvs.has("ssr")) {
+				const suggestions = [];
+				for (const [name, info] of [...depUsage.entries()].sort(([a], [b]) => a.localeCompare(b))) if (info.externalEnvs.has("ssr") && info.type === "dev") suggestions.push(`\u{1B}[31m🚨 ${name}\u{1B}[0m is externalized in the server bundle but listed as a \u{1B}[33mdevDependency\u{1B}[0m. Move it to \u{1B}[32mdependencies\u{1B}[0m or it will break in production.`);
+				else if (info.type === "" && info.isBundled && !info.isExternal) suggestions.push(`\u{1B}[34m💡 ${name}\u{1B}[0m is always fully bundled (never externalized). Consider moving it to \u{1B}[33mdevDependencies\u{1B}[0m to reduce production node_modules size.`);
+				const unusedRegularDeps = Object.entries(projectDependencies).filter(([name, info]) => info.type === "" && !depUsage.has(name)).sort(([a], [b]) => a.localeCompare(b));
+				for (const [name, info] of unusedRegularDeps) suggestions.push(`\u{1B}[90m🗑️ ${name}@${info.version}\u{1B}[0m is listed in "dependencies" but wasn't found in any bundle — if it's only needed at build/dev time, move it to devDependencies (or remove it if unused).`);
+				if (suggestions.length > 0) {
+					console.log("\n   \x1B[1mSuggestions:\x1B[0m");
+					for (const s of suggestions) console.log(`   ${s}`);
 				}
 			}
-			const label = envName === "client" ? "Client" : "Server";
-			const sorted = [...usedPackages].sort();
-			console.log(`📦 [${label} bundle] package.json dependencies used (${sorted.length}):`);
-			if (sorted.length === 0) console.log(`   (None)`);
-			else for (const dep of sorted) console.log(`   - ${dep}@${projectDependencies[dep]}`);
 		},
 		closeBundle: {
 			order: "pre",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vike-lite",
-  "version": "1.17.1",
+  "version": "1.17.3",
   "license": "MIT",
   "repository": {
     "type": "git",