vigthoria-cli 1.11.43 → 1.11.44

package/dist/commands/chat.js

@@ -22,21 +22,28 @@ import { inferAgentTaskType as sharedInferAgentTaskType, inferAgentTaskTypeWithC
 import { resolveAgentRoute } from '../utils/agentRoute.js';
 import { runTemplateInstantPath } from '../utils/templateInstantPath.js';
 import { isV3StreamKeepaliveEvent } from '../utils/v3-stream-events.js';
-// Production safety net: previously these defaulted to 0 (disabled) unless an
-// operator manually set an env var. Real end-user installs never set these,
-// so a stalled/incomplete model stream (e.g. text ends after </think> with no
-// tool_call event) would hang the CLI forever with only a cosmetic
-// "[Wait] Model still working" notice and no actual abort. See TestFarm
-// incident 2026-07-04 (Gideon Lenz / C:\vigthoria\Apps\monopoly).
-// Set VIGTHORIA_AGENT_TIMEOUT_MS=0 / VIGTHORIA_AGENT_IDLE_TIMEOUT_MS=0 to
-// explicitly restore the old unbounded behavior for debugging.
+// Stream health policy (corrected 2026-07-04 after TestFarm incident with
+// Gideon Lenz / C:\vigthoria\Apps\monopoly): agentic tasks have no
+// predictable duration, so there is intentionally NO overall wall-clock
+// timeout -- DEFAULT_V3_AGENT_TIMEOUT_MS stays disabled (0) by default and
+// must never kill an actively-streaming request just because it's "taking
+// long". The only legitimate failure signal for SSE/chunked streams is
+// silence: DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS aborts only when zero bytes
+// arrive for a stretch, which is what "the model/agent has gone dark"
+// actually looks like on the wire.
 const DEFAULT_V3_AGENT_TIMEOUT_MS = (() => {
+    // Agentic tasks are open-ended by design — a build/refactor/analysis can
+    // legitimately take minutes or hours depending on scope. There must be NO
+    // overall wall-clock cap that kills an actively-streaming, healthy request.
+    // The only correct failure signal for SSE/streamed responses is silence:
+    // see DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS below, which aborts only when zero
+    // bytes arrive for a stretch — never based on total elapsed duration.
     const rawValue = process.env.VIGTHORIA_AGENT_TIMEOUT_MS || process.env.V3_AGENT_TIMEOUT_MS;
     if (!rawValue) {
-        return 1_200_000; // 20 min hard cap on the whole agent request
+        return 0; // disabled — no overall duration cap
     }
     const parsed = Number.parseInt(rawValue, 10);
-    return Number.isFinite(parsed) && parsed >= 0 ? parsed : 1_200_000;
+    return Number.isFinite(parsed) && parsed >= 0 ? parsed : 0;
 })();
 const DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS = (() => {
     const rawValue = process.env.VIGTHORIA_AGENT_IDLE_TIMEOUT_MS || process.env.V3_AGENT_IDLE_TIMEOUT_MS;
@@ -880,9 +887,9 @@ export class ChatCommand {
             }
             const seconds = Math.round(idleMs / 1000);
             const idleTimeoutSec = Math.round(DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS / 1000);
-            process.stderr.write(chalk.yellow(`  [Wait] Model still working (${seconds}s) — large context or server retry may take a while. ` +
+            process.stderr.write(chalk.yellow(`  [Wait] Model still working (${seconds}s) — this can legitimately take a while for large tasks. ` +
                 (idleTimeoutSec > 0
-                    ? `A hard timeout (~${idleTimeoutSec}s of silence) will auto-recover and offer /retry if the model stalls.\n`
+                    ? `Only complete silence (~${idleTimeoutSec}s with zero bytes received) will trigger an auto-recover/retry — active progress is never interrupted.\n`
                     : `\n`)));
             spinner.start();
             spinner.text = 'Waiting for model response...';

package/dist/utils/api.js

@@ -260,17 +260,24 @@ export function propagateError(err) {
         },
     };
 }
-// Production safety net — see matching comment in src/commands/chat.ts.
-// These previously defaulted to 0 (disabled), letting a stalled model stream
-// hang the CLI forever with no abort. Set the env vars to 0 to restore the
-// old unbounded behavior for debugging.
+// Stream health policy — see matching comment in src/commands/chat.ts.
+// No overall wall-clock timeout for agentic requests (duration is
+// unpredictable and must never kill a healthy, actively-streaming request).
+// Only silence (zero bytes for a stretch, see DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS)
+// is a legitimate failure signal for SSE/chunked streams.
 const DEFAULT_V3_AGENT_TIMEOUT_MS = (() => {
+    // Agentic tasks are open-ended by design — a build/refactor/analysis can
+    // legitimately take minutes or hours depending on scope. There must be NO
+    // overall wall-clock cap that kills an actively-streaming, healthy request.
+    // The only correct failure signal for SSE/streamed responses is silence:
+    // see DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS below, which aborts only when zero
+    // bytes arrive for a stretch — never based on total elapsed duration.
     const rawValue = process.env.VIGTHORIA_AGENT_TIMEOUT_MS || process.env.V3_AGENT_TIMEOUT_MS;
     if (!rawValue) {
-        return 1_200_000; // 20 min hard cap on the whole agent request
+        return 0; // disabled — no overall duration cap
     }
     const parsed = Number.parseInt(rawValue, 10);
-    return Number.isFinite(parsed) && parsed >= 0 ? parsed : 1_200_000;
+    return Number.isFinite(parsed) && parsed >= 0 ? parsed : 0;
 })();
 const DEFAULT_V3_AGENT_IDLE_TIMEOUT_MS = (() => {
     const rawValue = process.env.VIGTHORIA_AGENT_IDLE_TIMEOUT_MS || process.env.V3_AGENT_IDLE_TIMEOUT_MS;
@@ -3825,14 +3832,18 @@ document.addEventListener('DOMContentLoaded', () => {
                     else {
                         chunk = await new Promise((resolve, reject) => {
                             let idleTimer = null;
-                            // Hard backstop for the reschedule branches below: even when the
-                            // workspace looks empty (nothing to recover yet) or client tools
-                            // are pending, we must not reschedule forever. Cap total
-                            // unproductive idle time at 10x the idle window (10 min at the
-                            // 60s default) before giving up with a clean timeout instead of
-                            // hanging the CLI indefinitely (TestFarm incident 2026-07-04).
+                            // Idle/silence detection (NOT a task-duration timeout): this timer
+                            // only ever fires after idleTimeoutMs with ZERO new bytes on the
+                            // wire. What we do next depends on WHY it's silent:
+                            //  - A client-side tool is genuinely still running (e.g. a local
+                            //    build/install the CLI itself launched) -- its own duration is
+                            //    unpredictable by design, so we reschedule indefinitely; this
+                            //    is known, bounded-elsewhere work, not "the agent went dark".
+                            //  - Otherwise, silence really does mean nothing is coming from
+                            //    the agent, so after a generous grace window we recover
+                            //    (if the workspace already has output) or fail cleanly.
                             let idleRescheduleCount = 0;
-                            const maxIdleReschedules = 10;
+                            const maxIdleReschedules = 20; // ~20 min of genuine zero-byte silence
                             const clearIdleTimer = () => {
                                 if (idleTimer) {
                                     clearTimeout(idleTimer);
@@ -3842,8 +3853,9 @@ document.addEventListener('DOMContentLoaded', () => {
                             const scheduleIdleTimer = () => {
                                 clearIdleTimer();
                                 idleTimer = setTimeout(() => {
-                                    if (this.pendingV3ClientToolTasks.size > 0 && idleRescheduleCount < maxIdleReschedules) {
-                                        idleRescheduleCount += 1;
+                                    if (this.pendingV3ClientToolTasks.size > 0) {
+                                        // Known local work in progress -- never cap this, its own
+                                        // completion will produce the next chunk/event.
                                         scheduleIdleTimer();
                                         return;
                                     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vigthoria-cli",
-  "version": "1.11.43",
+  "version": "1.11.44",
   "description": "Vigthoria Coder CLI - AI-powered terminal coding assistant",
   "type": "module",
   "main": "dist/index.js",