vigiles 31.0.0 → 32.0.0

package/dist/scan.js

@@ -230,13 +230,14 @@ function scanPlugin(dir, layout, dialect, opts = {}) {
     const coverage = (0, test_coverage_js_1.findUntestedSurfaces)({
         basePath: dir,
         layout: lay,
-        // The SAME `.vigilesrc.json#exclude`, in this walk's string face. Untested-
-        // surface discovery is a second walk over the same trees, so leaving it out
-        // would have excluded a skill from the GRADE while still naming it in
-        // "Untested surfaces: 1" — a report contradicting itself about whether the
-        // file exists. `exclude` here NARROWS (it unions with DEFAULT_IGNORE), which
-        // is the documented relationship between the repo floor and a rule's own list.
-        exclude: opts.excludes ? [...opts.excludes.ignore] : undefined,
+        // The SAME `.vigilesrc.json#exclude`. Untested-surface discovery is a
+        // second walk over the same trees, so leaving it out would have excluded a
+        // skill from the GRADE while still naming it in "Untested surfaces: 1" — a
+        // report contradicting itself about whether the file exists. Passed WHOLE,
+        // not as a pattern list: `dir` is often not the repo root (`audit plugins/p`),
+        // and a root-relative list globbed from here matched nothing it named —
+        // `inventory.skills: 1` beside `untested: 2` (#281, D7).
+        excludes: opts.excludes,
     });
     const caveats = (0, test_coverage_js_1.coverageCaveats)(coverage);
     return {

package/dist/test-coverage.d.ts

@@ -60,6 +60,8 @@
  * magnitude in cost without saying which. {@link UntestedReport} therefore carries
  * a per-tier {@link CoverageTier} alongside the (unchanged) union fields.
  */
+import { type ExcludeSet } from "./exclude.js";
+import type { RepoPath } from "./core/frame.js";
 import { type PluginLayout } from "./core/layout.js";
 import { type CoverageEvidence, type EvidenceCounts } from "./coverage-evidence.js";
 export type SurfaceKind = "skill" | "agent" | "hook";
@@ -185,8 +187,14 @@ export interface UntestedReport {
     readonly evals: CoverageTier;
 }
 export interface TestCoverageOptions {
-    /** Repository root. Defaults to `process.cwd()`. */
+    /** The bundle whose surfaces are discovered. Defaults to `process.cwd()`. */
     readonly basePath?: string;
+    /**
+     * The directory `include`, `exclude`, the coverage artifact and every REPORTED
+     * path are relative to — where `.vigilesrc.json` lives. Defaults to `basePath`.
+     * Differs from it for a nested bundle under `bundles: "all"` (#281).
+     */
+    readonly root?: string;
     /** Scan skills under `skills/` and `.claude/skills/`. Default true. */
     readonly skills?: boolean;
     /** Scan subagents under `agents/` and `.claude/agents/`. Default true. */
@@ -210,8 +218,17 @@ export interface TestCoverageOptions {
      * `mjs` was silently ignored on any TypeScript-shaped repo.
      */
     readonly testExtension?: string;
-    /** Extra ignore globs (added to node_modules/dist/.git/.vigiles). */
+    /**
+     * The rule's own `exclude` globs, relative to `root` (added to
+     * node_modules/dist/.git/.vigiles). NARROWS on top of {@link excludes}.
+     */
     readonly exclude?: readonly string[];
+    /**
+     * The repo-wide `.vigilesrc.json#exclude`. It carries its own root, so it is
+     * applied correctly whichever directory is being discovered — a string list
+     * here was correct only when that directory WAS the repo root (#281).
+     */
+    readonly excludes?: ExcludeSet;
     /**
      * Harness layout — where skills/agents live, the plugin-root token, the
      * manifest/settings paths. Defaults to Claude Code; a non-CC adapter passes its
@@ -266,7 +283,7 @@ export declare function coverageEvidenceCounts(report: UntestedReport): Evidence
  * Returns `null` when the edited file isn't a skill/agent surface, or when it is
  * covered on both tiers. Never throws — a nudge must not disrupt an edit.
  */
-export declare function skillTestNudge(filePath: string, options: TestCoverageOptions): string | null;
+export declare function skillTestNudge(filePath: RepoPath, options: TestCoverageOptions): string | null;
 /**
  * What the PAID eval tier measures for a surface of this kind — or `null` when
  * it measures nothing for it.

package/dist/test-coverage.js

@@ -71,10 +71,13 @@ exports.coverageCaveats = coverageCaveats;
 exports.formatUntestedReport = formatUntestedReport;
 const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
+const minimatch_1 = require("minimatch");
 const test_file_ext_js_1 = require("./core/test-file-ext.js");
 const assert_never_js_1 = require("./core/assert-never.js");
 const ts_runner_caps_js_1 = require("./ts-runner-caps.js");
 const glob_1 = require("glob");
+const glob_ignore_js_1 = require("./core/glob-ignore.js");
+const exclude_js_1 = require("./exclude.js");
 const layout_js_1 = require("./core/layout.js");
 const coverage_evidence_js_1 = require("./coverage-evidence.js");
 const coverage_artifact_js_1 = require("./coverage-artifact.js");
@@ -427,27 +430,47 @@ function tierOf(considered, tests, index, tier, globs) {
  */
 function findUntestedSurfaces(options) {
     const basePath = options.basePath ?? process.cwd();
+    const root = options.root ?? basePath;
     const { layout } = options;
-    const ignore = [...DEFAULT_IGNORE, ...(options.exclude ?? [])];
+    const ruleIgnore = [...DEFAULT_IGNORE, ...(options.exclude ?? [])];
+    const ignore = (0, glob_ignore_js_1.withIgnored)(ruleIgnore, options.excludes?.globIgnore);
     const globs = options.include ?? DEFAULT_TEST_GLOBS;
-    const surfaces = [];
+    // #281: surfaces are FOUND under the bundle and then re-expressed from `root`,
+    // so every later comparison (colocation, `{surface}` globs, the run index,
+    // exclude, the printed path) happens in ONE frame.
+    const prefix = (0, node_path_1.relative)(root, basePath).split(node_path_1.sep).join("/");
+    const toRoot = (s) => prefix === "" ? s : { ...s, path: `${prefix}/${s.path}` };
+    const repoExcluded = (0, exclude_js_1.excludedBy)(options.excludes);
+    const excluded = (p) => ruleIgnore.some((g) => (0, minimatch_1.minimatch)(p, g, { dot: true })) ||
+        repoExcluded((0, node_path_1.join)(root, p));
+    // Discovery globs from the BUNDLE, so it gets only the frame-free floor; the
+    // rule's patterns are root-relative and the repo's carry their own root, so
+    // both are applied below, to the root-relative path.
+    const floor = [...DEFAULT_IGNORE];
+    const found = [];
     if (options.skills !== false)
-        surfaces.push(...discoverSkills(basePath, ignore, layout));
+        found.push(...discoverSkills(basePath, floor, layout));
     if (options.agents !== false)
-        surfaces.push(...discoverAgents(basePath, ignore, layout));
+        found.push(...discoverAgents(basePath, floor, layout));
     if (options.hooks !== false)
-        surfaces.push(...discoverHooks(basePath, layout));
+        found.push(...discoverHooks(basePath, layout));
+    // Hooks were never subject to `ignore` (a compiled hook lives under the
+    // default-ignored `.vigiles/`); keep that, and re-apply exclude to the kinds
+    // whose discovery glob used it — now from `root`, where the patterns live.
+    const surfaces = found
+        .map(toRoot)
+        .filter((s) => s.kind === "hook" || !excluded(s.path));
     // Every skill/agent/hook is held to the requirement — only an explicit
     // `vigiles:ignore-test` marker exempts a surface (a visible, deliberate skip).
     const considered = surfaces.filter((s) => !s.ignored);
     const exempt = surfaces.length - considered.length;
-    const tests = discoverTests(basePath, globs, ignore);
+    const tests = discoverTests(root, globs, ignore);
     const split = partitionTests(tests);
     // The run record, if there is one. NO artifact ⇒ an empty index ⇒ every
     // decision below falls through to colocation, byte-for-byte as before: a fresh
     // clone and someone else's repo must not get one extra nudge from this tier.
-    const runIndex = (0, coverage_artifact_js_1.indexRuns)((0, coverage_artifact_js_1.readCoverageArtifact)(basePath), (p) => {
-        const abs = (0, node_path_1.join)(basePath, p);
+    const runIndex = (0, coverage_artifact_js_1.indexRuns)((0, coverage_artifact_js_1.readCoverageArtifact)(root), (p) => {
+        const abs = (0, node_path_1.join)(root, p);
         return (0, node_fs_1.existsSync)(abs) ? (0, coverage_artifact_js_1.surfaceSha)(read(abs)) : null;
     }, 
     // The SCRIPT that did the exercising has to still be here too — a deleted or
@@ -455,7 +478,7 @@ function findUntestedSurfaces(options) {
     // record is permanent, unfalsifiable coverage. `canonicalScript` first: one
     // file has several legitimate spellings (`x.mjs`, `./x.mjs`, absolute), and
     // the artifact records whichever one was typed.
-    (by) => (0, node_fs_1.existsSync)((0, node_path_1.join)(basePath, (0, coverage_artifact_js_1.canonicalScript)(by, basePath))));
+    (by) => (0, node_fs_1.existsSync)((0, node_path_1.join)(root, (0, coverage_artifact_js_1.canonicalScript)(by, root))));
     const union = tierOf(considered, tests, runIndex, undefined, globs);
     return {
         total: considered.length,
@@ -477,8 +500,8 @@ function findUntestedSurfaces(options) {
         }),
         legacyCoversFiles: tests
             .map((t) => t.path)
-            .filter((path) => read((0, node_path_1.join)(basePath, path)).includes(LEGACY_COVERS)),
-        retiredTestNames: retiredTestNamesFor(basePath, union.untested),
+            .filter((path) => read((0, node_path_1.join)(root, path)).includes(LEGACY_COVERS)),
+        retiredTestNames: retiredTestNamesFor(root, union.untested),
         decisions: union.decisions,
         harness: tierOf(considered, split.harness, runIndex, "harness", globs),
         evals: tierOf(considered, split.evals, runIndex, "eval", globs),
@@ -549,9 +572,12 @@ function skillTestNudge(filePath, options) {
     catch {
         return null; // a broken scan must never surface as a broken edit
     }
-    const norm = (p) => p.replaceAll("\\", "/");
-    const target = norm(filePath);
-    const isTarget = (s) => norm(s.path) === target || target.endsWith(`/${norm(s.path)}`);
+    // 🔴 EQUALITY, IN ONE FRAME (#281, D6). This used to accept any path ENDING in
+    // a surface's path, so editing `plugins/p/skills/x/SKILL.md` matched the root
+    // bundle's `skills/x/SKILL.md` and reported THAT skill's coverage as the
+    // edited one's. The caller now hands a `RepoPath` and the report's paths are
+    // relative to the same `root`, so a suffix has nothing left to rescue.
+    const isTarget = (s) => s.path === filePath;
     const untested = report.untested.find(isTarget);
     if (untested)
         return (`vigiles: you edited ${untested.path}, and nothing measures whether it ` +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vigiles",
-  "version": "31.0.0",
+  "version": "32.0.0",
   "description": "Audit, test and measure the harness your AI agent runs on — grade your CLAUDE.md / AGENTS.md, skills, subagents and hooks, run them against a scripted model, and measure whether they actually fire.",
   "keywords": [
     "claude-code",
@@ -109,7 +109,7 @@
     "@typescript-eslint/eslint-plugin": "^8.58.0",
     "@typescript-eslint/parser": "^8.58.0",
     "@vitest/coverage-v8": "^4.1.8",
-    "conventional-changelog-conventionalcommits": "^10.3.0",
+    "conventional-changelog-conventionalcommits": "9.3.1",
     "eslint": "^10.1.0",
     "eslint-import-resolver-typescript": "^4.4.5",
     "eslint-plugin-boundaries": "^6.0.2",
@@ -118,6 +118,7 @@
     "jest": "^30.4.2",
     "picomatch": "^4.0.4",
     "prettier": "^3.8.1",
+    "semantic-release": "25.0.9",
     "tsx": "^4.21.0",
     "typedoc": "^0.28.19",
     "typescript": "^5.9.3",