videomail-client 9.2.20 → 9.2.22

package/.github/workflows/push.yml

@@ -0,0 +1,42 @@
+name: Test Runner for videomail-client
+
+on:
+  push:
+    branches:
+      - develop
+
+  pull_request:
+    branches:
+      - develop
+
+jobs:
+  build-test-lint-check:
+    name: Build, Test, Prettier, Lint and Check
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Install Node.js via nvm
+        shell: bash --login {0}
+        run: |
+          nvm install --no-progress
+          echo "$(dirname $(nvm which node))" >> $GITHUB_PATH
+
+      - name: Install npm dependencies
+        run: npm ci
+
+      - name: Build assets
+        run: npm run build
+
+      # Electron issues, to fix later:
+      # https://github.com/marketplace/actions/run-with-xvfb
+      # - name: Run tests
+      #   run: npm run test
+
+      - name: Run prettier
+        run: npm run prettier
+
+      - name: Run linter
+        run: npm run lint

package/.vscode/settings.json

@@ -24,6 +24,7 @@
     "keymirror",
     "KHTML",
     "Mbit",
+    "MSIE",
     "packagejson",
     "playsinline",
     "plusplus",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "videomail-client",
-  "version": "9.2.20",
+  "version": "9.2.22",
   "description": "A wicked npm package to record videos directly in the browser, wohooo!",
   "keywords": [
     "webcam",
@@ -54,7 +54,7 @@
     "defined": "1.0.1",
     "despot": "2.0.0",
     "document-visibility": "1.0.1",
-    "filesize": "10.1.4",
+    "filesize": "10.1.6",
     "format-util": "1.0.5",
     "get-form-data": "3.0.0",
     "hidden": "1.1.1",
@@ -86,7 +86,7 @@
     "del": "6.1.1",
     "eslint": "8.57.0",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-import": "2.29.1",
+    "eslint-plugin-import": "2.30.0",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "6.2.0",
     "fancy-log": "2.0.0",
@@ -108,7 +108,7 @@
     "gulp-terser": "2.1.0",
     "minimist": "1.2.8",
     "nib": "1.2.0",
-    "postcss": "8.4.43",
+    "postcss": "8.4.45",
     "prettier": "3.3.3",
     "prettier-plugin-curly": "0.2.2",
     "prettier-plugin-organize-imports": "4.0.0",

package/prototype/js/videomail-client.js

@@ -4732,7 +4732,7 @@ function replaceGetterValues (replacer) {
  *
  * @copyright 2024 Jason Mulligan <jason.mulligan@avoidwork.com>
  * @license BSD-3-Clause
- * @version 10.1.4
+ * @version 10.1.6
  */
 'use strict';
 
@@ -4900,9 +4900,10 @@ function filesize (arg, {
 		result[0] = result[0].toString().replace(PERIOD, separator);
 	}
 
-	if (pad && Number.isInteger(result[0]) === false && round > 0) {
-		const x = separator || PERIOD,
-			tmp = result[0].toString().split(x),
+	if (pad && round > 0) {
+		const i =  result[0].toString(),
+			x = separator || ((i.match(/(\D)/g) || []).pop() || PERIOD),
+			tmp = i.toString().split(x),
 			s = tmp[1] || EMPTY,
 			l = s.length,
 			n = round - l;
@@ -17267,7 +17268,7 @@ function wrappy (fn, cb) {
 },{}],116:[function(_dereq_,module,exports){
 module.exports={
   "name": "videomail-client",
-  "version": "9.2.20",
+  "version": "9.2.22",
   "description": "A wicked npm package to record videos directly in the browser, wohooo!",
   "keywords": [
     "webcam",
@@ -17321,7 +17322,7 @@ module.exports={
     "defined": "1.0.1",
     "despot": "2.0.0",
     "document-visibility": "1.0.1",
-    "filesize": "10.1.4",
+    "filesize": "10.1.6",
     "format-util": "1.0.5",
     "get-form-data": "3.0.0",
     "hidden": "1.1.1",
@@ -17353,7 +17354,7 @@ module.exports={
     "del": "6.1.1",
     "eslint": "8.57.0",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-import": "2.29.1",
+    "eslint-plugin-import": "2.30.0",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-promise": "6.2.0",
     "fancy-log": "2.0.0",
@@ -17375,7 +17376,7 @@ module.exports={
     "gulp-terser": "2.1.0",
     "minimist": "1.2.8",
     "nib": "1.2.0",
-    "postcss": "8.4.43",
+    "postcss": "8.4.45",
     "prettier": "3.3.3",
     "prettier-plugin-curly": "0.2.2",
     "prettier-plugin-organize-imports": "4.0.0",
@@ -17836,7 +17837,7 @@ var options = {
     // in milliseconds, increase if you want user give more time to enable webcam
     connection: 1e4,
     // in seconds, increase if api is slow
-    pingInterval: 35e3 // in milliseconds, keeps web stream (connection) alive when pausing
+    pingInterval: 30e3 // in milliseconds, keeps web stream (connection) alive when pausing
   },
   loadUserMediaOnRecord: false,
   // when true, user media is loaded only when record button is pressed
@@ -17922,6 +17923,7 @@ function _default(options) {
       var originalError = res.body.error;
       var packedError = new Error();
       setProperty(packedError, "name", originalError.name);
+      setProperty(packedError, "type", originalError.type);
       setProperty(packedError, "message", originalError.message || res.statusText);
       setProperty(packedError, "cause", originalError.cause);
       setProperty(packedError, "status", originalError.status);
@@ -18937,6 +18939,7 @@ VideomailError.INVALID_STATE_ERROR = "InvalidStateError";
 
 // static function to convert an error into a videomail error
 VideomailError.create = function (err, explanation, options, parameters) {
+  var _err$constructor;
   if (err && err.name === VIDEOMAIL_ERR_NAME) {
     return err;
   }
@@ -19086,7 +19089,7 @@ VideomailError.create = function (err, explanation, options, parameters) {
       switch (err.code) {
         case 8:
           message = "Requested webcam not found";
-          explanation = "A webcam is needed but could not be found.";
+          explanation = "A webcam is needed but could not be found";
           classList.push(VideomailError.WEBCAM_PROBLEM);
           break;
         case 9:
@@ -19146,7 +19149,7 @@ VideomailError.create = function (err, explanation, options, parameters) {
             message = err;
           } else {
             if (err.message) {
-              message = pretty(err.message);
+              message = pretty(err.message) + " (pretty)";
             }
             if (err.explanation) {
               if (!explanation) {
@@ -19169,7 +19172,7 @@ VideomailError.create = function (err, explanation, options, parameters) {
         // for weird, undefined cases
         if (!message) {
           if (errType) {
-            message = errType;
+            message = errType + " (weird)";
           }
           if (!explanation && err) {
             explanation = pretty(err, {
@@ -19209,7 +19212,14 @@ VideomailError.create = function (err, explanation, options, parameters) {
     location: window.location.href,
     cookie: cookies.length > 0 ? cookies.join(",\n") : undefined,
     screen: [screen.width, screen.height, screen.colorDepth].join("×"),
-    orientation: typeof screen.orientation === "string" ? screen.orientation : screen.orientation.type.toString()
+    orientation: typeof screen.orientation === "string" ? screen.orientation : screen.orientation.type.toString(),
+    // Consider removing later once sorted
+    errNo: err === null || err === void 0 ? void 0 : err.errno,
+    errCode: err === null || err === void 0 ? void 0 : err.code,
+    errName: err === null || err === void 0 ? void 0 : err.name,
+    errType: err === null || err === void 0 ? void 0 : err.type,
+    errConstraint: err === null || err === void 0 ? void 0 : err.constraint,
+    errConstructorName: err === null || err === void 0 || (_err$constructor = err.constructor) === null || _err$constructor === void 0 ? void 0 : _err$constructor.name
   };
   var videomailError = new VideomailError(err instanceof Error ? err : message, errData);
   var resource;
@@ -22218,7 +22228,7 @@ var Recorder = function Recorder(visuals, replay) {
   function initSocket(cb) {
     if (!connected) {
       connecting = true;
-      debug("Recorder: initialising web socket to %s", options.socketUrl);
+      debug("Recorder: initializing web socket to %s", options.socketUrl);
       self.emit(_events.default.CONNECTING);
 
       // https://github.com/maxogden/websocket-stream#binary-sockets
@@ -22307,29 +22317,44 @@ var Recorder = function Recorder(visuals, replay) {
         });
         stream.on("error", function (err) {
           debug("".concat(PIPE_SYMBOL, "Stream *error* event emitted: ").concat(err.message));
-          connecting = connected = false;
-          var videomailError;
-          if (browser.isIOS()) {
-            /*
-             * setting custom text since that err object isn't really an error
-             * on iPhones when locked, and unlocked, this err is actually
-             * an event object with stuff we can't use at all (an external bug)
-             */
-            videomailError = _videomailError.default.create(err, "iPhones cannot maintain a live connection for too long. Original error message is: ".concat(err.toString()), options);
 
-            /*
-             * Changed to the above temporarily for better investigations
-             * videomailError = VideomailError.create(
-             *   'Sorry, connection has timed out',
-             *   'iPhones cannot maintain a live connection for too long,
-             *   options
-             * )
-             */
-          } else {
-            // or else it could be a poor wifi connection...
-            videomailError = _videomailError.default.create("Data exchange interrupted", "Please check your network connection and reload", options);
-          }
-          self.emit(_events.default.ERROR, videomailError);
+          // OLD CODE, COMMENTED OUT TEMPORARILY FOR INVESTIGATIONS
+          // IT SHOULD RECONNECT INSTEAD OF CLOSING THE CONNECTION
+
+          // connecting = connected = false;
+
+          // let videomailError;
+
+          // if (browser.isIOS()) {
+          //   /*
+          //    * setting custom text since that err object isn't really an error
+          //    * on iPhones when locked, and unlocked, this err is actually
+          //    * an event object with stuff we can't use at all (an external bug)
+          //    */
+          //   videomailError = VideomailError.create(
+          //     err,
+          //     `iPhones cannot maintain a live connection for too long. Original error message is: ${err.toString()}`,
+          //     options,
+          //   );
+
+          //   /*
+          //    * Changed to the above temporarily for better investigations
+          //    * videomailError = VideomailError.create(
+          //    *   'Sorry, connection has timed out',
+          //    *   'iPhones cannot maintain a live connection for too long,
+          //    *   options
+          //    * )
+          //    */
+          // } else {
+          //   // or else it could be a poor wifi connection...
+          //   videomailError = VideomailError.create(
+          //     "Data exchange interrupted",
+          //     "Please check your network connection and reload",
+          //     options,
+          //   );
+          // }
+
+          // self.emit(Events.ERROR, videomailError);
         });
 
         // just experimental
@@ -22377,12 +22402,10 @@ var Recorder = function Recorder(visuals, replay) {
      */
     return connected && (isNotifying() || !isHidden() || blocking);
   }
-  function userMediaErrorCallback(err, extraA, extraB) {
+  function userMediaErrorCallback(err) {
     userMediaLoading = false;
     clearUserMediaTimeout();
-    debug("Recorder: userMediaErrorCallback()", ", name:", err.name, ", message:", err.message, ", Webcam characteristics:", userMedia.getCharacteristics(),
-    // added recently in the hope to investigate weird webcam issues
-    ", extraA arguments:", extraA ? extraA.toString() : undefined, ", extraB arguments:", extraB ? extraB.toString() : undefined);
+    debug("Recorder: userMediaErrorCallback(), name: ".concat(err.name, ", message: ").concat(err.message, " and Webcam characteristics: ").concat((0, _safeJsonStringify.default)(userMedia.getCharacteristics())));
     var errorListeners = self.listeners(_events.default.ERROR);
     if (errorListeners && errorListeners.length) {
       if (err.name !== _videomailError.default.MEDIA_DEVICE_NOT_SUPPORTED) {
@@ -22690,8 +22713,8 @@ var Recorder = function Recorder(visuals, replay) {
     this.reset();
     writeCommand("back", cb);
   };
-  function reInitialiseAudio() {
-    debug("Recorder: reInitialiseAudio()");
+  function reInitializeAudio() {
+    debug("Recorder: reInitializeAudio()");
     clearUserMediaTimeout();
 
     // important to free memory
@@ -22973,9 +22996,9 @@ var Recorder = function Recorder(visuals, replay) {
     }).on(_events.default.LOADED_META_DATA, function () {
       correctDimensions();
     }).on(_events.default.DISABLING_AUDIO, function () {
-      reInitialiseAudio();
+      reInitializeAudio();
     }).on(_events.default.ENABLING_AUDIO, function () {
-      reInitialiseAudio();
+      reInitializeAudio();
     }).on(_events.default.INVISIBLE, function () {
       loopWithTimeouts();
     }).on(_events.default.VISIBLE, function () {