victory-stack 31.1.0 → 31.2.0

package/es/victory-stack.js

@@ -1,3 +1,4 @@
+import _isEmpty from "lodash/isEmpty";
 import _defaults from "lodash/defaults";
 import _assign from "lodash/assign";
 
@@ -22,6 +23,7 @@ import React from "react";
 import { Helpers, VictoryContainer, VictoryTheme, CommonProps, Wrapper } from "victory-core";
 import { VictorySharedEvents } from "victory-shared-events";
 import { getChildren, getCalculatedProps } from "./helper-methods";
+import isEqual from "react-fast-compare";
 var fallbackProps = {
   width: 450,
   height: 300,
@@ -47,27 +49,23 @@ function (_React$Component) {
         animating: true
       };
       _this.setAnimationState = Wrapper.setAnimationState.bind(_assertThisInitialized(_this));
-      _this.events = Wrapper.getAllEvents(props);
     }
 
     return _this;
   }
 
   _createClass(VictoryStack, [{
-    key: "componentWillMount",
-    value: function componentWillMount() {
-      this.events = Wrapper.getAllEvents(this.props);
-    }
-  }, {
-    key: "componentWillReceiveProps",
-    value: function componentWillReceiveProps(nextProps) {
+    key: "shouldComponentUpdate",
+    value: function shouldComponentUpdate(nextProps) {
       if (this.props.animate) {
-        this.setAnimationState(this.props, nextProps);
+        if (!isEqual(this.props, nextProps)) {
+          this.setAnimationState(this.props, nextProps);
+          return false;
+        }
       }
 
-      this.events = Wrapper.getAllEvents(nextProps);
-    } // the old ones were bad
-
+      return true;
+    }
   }, {
     key: "getNewChildren",
     value: function getNewChildren(props, childComponents, calculatedProps) {
@@ -132,12 +130,13 @@ function (_React$Component) {
       var newChildren = this.getNewChildren(modifiedProps, childComponents, calculatedProps);
       var containerProps = standalone ? this.getContainerProps(modifiedProps, calculatedProps) : {};
       var container = standalone ? this.renderContainer(containerComponent, containerProps) : groupComponent;
+      var events = Wrapper.getAllEvents(props);
 
-      if (this.events) {
+      if (!_isEmpty(events)) {
         return React.createElement(VictorySharedEvents, {
           container: container,
           eventKey: eventKey,
-          events: this.events,
+          events: events,
           externalEventMutations: externalEventMutations
         }, newChildren);
       }

package/lib/victory-stack.js

@@ -5,6 +5,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 
+var _isEmpty2 = _interopRequireDefault(require("lodash/isEmpty"));
+
 var _defaults2 = _interopRequireDefault(require("lodash/defaults"));
 
 var _assign2 = _interopRequireDefault(require("lodash/assign"));
@@ -19,6 +21,8 @@ var _victorySharedEvents = require("victory-shared-events");
 
 var _helperMethods = require("./helper-methods");
 
+var _reactFastCompare = _interopRequireDefault(require("react-fast-compare"));
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; var ownKeys = Object.keys(source); if (typeof Object.getOwnPropertySymbols === 'function') { ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) { return Object.getOwnPropertyDescriptor(source, sym).enumerable; })); } ownKeys.forEach(function (key) { _defineProperty(target, key, source[key]); }); } return target; }
@@ -62,27 +66,23 @@ function (_React$Component) {
         animating: true
       };
       _this.setAnimationState = _victoryCore.Wrapper.setAnimationState.bind(_assertThisInitialized(_this));
-      _this.events = _victoryCore.Wrapper.getAllEvents(props);
     }
 
     return _this;
   }
 
   _createClass(VictoryStack, [{
-    key: "componentWillMount",
-    value: function componentWillMount() {
-      this.events = _victoryCore.Wrapper.getAllEvents(this.props);
-    }
-  }, {
-    key: "componentWillReceiveProps",
-    value: function componentWillReceiveProps(nextProps) {
+    key: "shouldComponentUpdate",
+    value: function shouldComponentUpdate(nextProps) {
       if (this.props.animate) {
-        this.setAnimationState(this.props, nextProps);
+        if (!(0, _reactFastCompare.default)(this.props, nextProps)) {
+          this.setAnimationState(this.props, nextProps);
+          return false;
+        }
       }
 
-      this.events = _victoryCore.Wrapper.getAllEvents(nextProps);
-    } // the old ones were bad
-
+      return true;
+    }
   }, {
     key: "getNewChildren",
     value: function getNewChildren(props, childComponents, calculatedProps) {
@@ -152,11 +152,13 @@ function (_React$Component) {
       var containerProps = standalone ? this.getContainerProps(modifiedProps, calculatedProps) : {};
       var container = standalone ? this.renderContainer(containerComponent, containerProps) : groupComponent;
 
-      if (this.events) {
+      var events = _victoryCore.Wrapper.getAllEvents(props);
+
+      if (!(0, _isEmpty2.default)(events)) {
         return _react.default.createElement(_victorySharedEvents.VictorySharedEvents, {
           container: container,
           eventKey: eventKey,
-          events: this.events,
+          events: events,
           externalEventMutations: externalEventMutations
         }, newChildren);
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "victory-stack",
-  "version": "31.1.0",
+  "version": "31.2.0",
   "description": "Stack Layout Component for Victory",
   "keywords": [
     "data visualization",
@@ -21,7 +21,8 @@
   "dependencies": {
     "lodash": "^4.17.5",
     "prop-types": "^15.5.8",
-    "victory-core": "^31.1.0"
+    "react-fast-compare": "^2.0.0",
+    "victory-core": "^31.2.0"
   },
   "scripts": {
     "version": "nps build-libs && nps build-dists"

package/src/victory-stack.js

@@ -1,9 +1,10 @@
-import { assign, defaults } from "lodash";
+import { assign, defaults, isEmpty } from "lodash";
 import PropTypes from "prop-types";
 import React from "react";
 import { Helpers, VictoryContainer, VictoryTheme, CommonProps, Wrapper } from "victory-core";
 import { VictorySharedEvents } from "victory-shared-events";
 import { getChildren, getCalculatedProps } from "./helper-methods";
+import isEqual from "react-fast-compare";
 
 const fallbackProps = {
   width: 450,
@@ -73,22 +74,19 @@ export default class VictoryStack extends React.Component {
         animating: true
       };
       this.setAnimationState = Wrapper.setAnimationState.bind(this);
-      this.events = Wrapper.getAllEvents(props);
     }
   }
 
-  componentWillMount() {
-    this.events = Wrapper.getAllEvents(this.props);
-  }
-
-  componentWillReceiveProps(nextProps) {
+  shouldComponentUpdate(nextProps) {
     if (this.props.animate) {
-      this.setAnimationState(this.props, nextProps);
+      if (!isEqual(this.props, nextProps)) {
+        this.setAnimationState(this.props, nextProps);
+        return false;
+      }
     }
-    this.events = Wrapper.getAllEvents(nextProps);
+    return true;
   }
 
-  // the old ones were bad
   getNewChildren(props, childComponents, calculatedProps) {
     const children = getChildren(props, childComponents, calculatedProps);
     const getAnimationProps = Wrapper.getAnimationProps.bind(this);
@@ -140,12 +138,13 @@ export default class VictoryStack extends React.Component {
     const container = standalone
       ? this.renderContainer(containerComponent, containerProps)
       : groupComponent;
-    if (this.events) {
+    const events = Wrapper.getAllEvents(props);
+    if (!isEmpty(events)) {
       return (
         <VictorySharedEvents
           container={container}
           eventKey={eventKey}
-          events={this.events}
+          events={events}
           externalEventMutations={externalEventMutations}
         >
           {newChildren}