victory-core 37.3.2 → 37.3.3

package/lib/victory-util/transitions.js

@@ -5,9 +5,9 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.getInitialTransitionState = getInitialTransitionState;
 exports.getTransitionPropsFactory = getTransitionPropsFactory;
-var _identity2 = _interopRequireDefault(require("lodash/identity"));
-var _defaults2 = _interopRequireDefault(require("lodash/defaults"));
 var _react = _interopRequireDefault(require("react"));
+var _defaults = _interopRequireDefault(require("lodash/defaults"));
+var _identity = _interopRequireDefault(require("lodash/identity"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 function getDatumKey(datum, idx) {
   return (datum.key || idx).toString();
@@ -116,7 +116,7 @@ function getInitialTransitionState(oldChildren, nextChildren) {
   };
 }
 function getInitialChildProps(animate, data) {
-  const after = animate.onEnter && animate.onEnter.after ? animate.onEnter.after : _identity2.default;
+  const after = animate.onEnter && animate.onEnter.after ? animate.onEnter.after : _identity.default;
   return {
     data: data.map((datum, idx) => Object.assign({}, datum, after(datum, idx, data)))
   };
@@ -133,7 +133,7 @@ function getChildBeforeLoad(animate, child, data, cb) {
       data
     };
   }
-  const before = newAnimate.onLoad && newAnimate.onLoad.before ? newAnimate.onLoad.before : _identity2.default;
+  const before = newAnimate.onLoad && newAnimate.onLoad.before ? newAnimate.onLoad.before : _identity.default;
   // If nodes need to exit, transform them with the provided onLoad.before function.
   const newData = data.map((datum, idx) => {
     return Object.assign({}, datum, before(datum, idx, data));
@@ -155,7 +155,7 @@ function getChildOnLoad(animate, data, cb) {
       data
     };
   }
-  const after = animate.onLoad && animate.onLoad.after ? animate.onLoad.after : _identity2.default;
+  const after = animate.onLoad && animate.onLoad.after ? animate.onLoad.after : _identity.default;
   // If nodes need to exit, transform them with the provided onLoad.after function.
   newData = data.map((datum, idx) => {
     return Object.assign({}, datum, after(datum, idx, data));
@@ -177,7 +177,7 @@ function getChildPropsOnExit(animate, child, data, exitingNodes, cb) {
     // After the exit transition occurs, trigger the animations for
     // nodes that are neither exiting nor entering.
     animate.onEnd = cb;
-    const before = animate.onExit && animate.onExit.before ? animate.onExit.before : _identity2.default;
+    const before = animate.onExit && animate.onExit.before ? animate.onExit.before : _identity.default;
     // If nodes need to exit, transform them with the provided onExit.before function.
     newData = data.map((datum, idx) => {
       const key = (datum.key || idx).toString();
@@ -200,7 +200,7 @@ function getChildPropsBeforeEnter(animate, child, data, enteringNodes, cb) {
     newAnimate = Object.assign({}, animate, {
       onEnd: cb
     });
-    const before = animate.onEnter && animate.onEnter.before ? animate.onEnter.before : _identity2.default;
+    const before = animate.onEnter && animate.onEnter.before ? animate.onEnter.before : _identity.default;
     // We want the entering nodes to be included in the transition target
     // domain.  However, we may not want these nodes to be displayed initially,
     // so perform the `onEnter.before` transformation on each node.
@@ -227,7 +227,7 @@ function getChildPropsOnEnter(animate, data, enteringNodes, cb) {
     // domain should encompass the nodes that will now enter. So perform
     // the `onEnter.after` transformation on each node.
     newAnimate.onEnd = cb;
-    const after = newAnimate.onEnter && newAnimate.onEnter.after ? newAnimate.onEnter.after : _identity2.default;
+    const after = newAnimate.onEnter && newAnimate.onEnter.after ? newAnimate.onEnter.after : _identity.default;
     newData = data.map((datum, idx) => {
       const key = getDatumKey(datum, idx);
       return enteringNodes[key] ? Object.assign({}, datum, after(datum, idx, data)) : datum;
@@ -324,11 +324,11 @@ function getTransitionPropsFactory(props, state, setState) {
   };
   return function getTransitionProps(child, index) {
     const data = getChildData(child) || [];
-    const animate = (0, _defaults2.default)({}, props.animate, child.props.animate);
+    const animate = (0, _defaults.default)({}, props.animate, child.props.animate);
     const defaultTransitions = child.props.polar ? child.type.defaultPolarTransitions || child.type.defaultTransitions : child.type.defaultTransitions;
-    animate.onExit = (0, _defaults2.default)({}, animate.onExit, defaultTransitions && defaultTransitions.onExit);
-    animate.onEnter = (0, _defaults2.default)({}, animate.onEnter, defaultTransitions && defaultTransitions.onEnter);
-    animate.onLoad = (0, _defaults2.default)({}, animate.onLoad, defaultTransitions && defaultTransitions.onLoad);
+    animate.onExit = (0, _defaults.default)({}, animate.onExit, defaultTransitions && defaultTransitions.onExit);
+    animate.onEnter = (0, _defaults.default)({}, animate.onEnter, defaultTransitions && defaultTransitions.onEnter);
+    animate.onLoad = (0, _defaults.default)({}, animate.onLoad, defaultTransitions && defaultTransitions.onLoad);
     const childTransitions = childrenTransitions[index] || childrenTransitions[0];
     if (!nodesDoneLoad) {
       // should do onLoad animation

package/lib/victory-util/type-helpers.d.ts

@@ -2,7 +2,6 @@ import { ForAxes, AxisType, Tuple, Datum, DatumValue } from "../types/prop-types
 export declare function hasValueForAxis<T = unknown>(value: unknown | ForAxes<T>, axis: AxisType): value is ForAxes<T>;
 export declare function isTuple<T = unknown>(value: unknown): value is Tuple<T>;
 export declare function getValueForAxis<T = unknown>(value: T | ForAxes<T> | undefined, axis: AxisType): T | undefined;
-export declare function isFunction<T = Function>(func?: unknown): func is T;
 export declare function isDate(value: unknown): value is Date;
 export declare function isKeyValueObject(datum: Datum): datum is {
     [key: string]: DatumValue;

package/lib/victory-util/type-helpers.js

@@ -6,7 +6,6 @@ Object.defineProperty(exports, "__esModule", {
 exports.getValueForAxis = getValueForAxis;
 exports.hasValueForAxis = hasValueForAxis;
 exports.isDate = isDate;
-exports.isFunction = isFunction;
 exports.isKeyValueObject = isKeyValueObject;
 exports.isTuple = isTuple;
 function hasValueForAxis(value, axis) {
@@ -24,11 +23,6 @@ function getValueForAxis(value, axis) {
   }
   return value;
 }
-
-// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-function isFunction(func) {
-  return typeof func === "function";
-}
 function isDate(value) {
   return value instanceof Date;
 }

package/lib/victory-util/user-props.d.ts

@@ -1,5 +1,5 @@
 import * as React from "react";
-declare type SafeAttribute = string;
+type SafeAttribute = string;
 /**
  * Asserts that value is not null or undefined, throwing an error if it is.
  * @param value The value to assert
@@ -14,7 +14,7 @@ export declare function assert<T>(value: T, message?: string): asserts value is
  * @param {Object} props: props to be filtered against USER_PROPS_SAFELIST
  * @returns {Object}: object containing remaining acceptable props
  */
-export declare const getSafeUserProps: <T>(props: T) => Record<SafeAttribute, string>;
+export declare const getSafeUserProps: <T>(props: T extends Record<string, any> ? T : never) => Record<SafeAttribute, string>;
 /**
  * Wraps a component and adds safe user props
  *

package/lib/victory-util/wrapper.js

@@ -20,11 +20,11 @@ exports.getStringsFromChildrenCategories = getStringsFromChildrenCategories;
 exports.getStringsFromData = getStringsFromData;
 exports.getStyle = getStyle;
 exports.getWidth = getWidth;
-var _uniqBy2 = _interopRequireDefault(require("lodash/uniqBy"));
-var _groupBy2 = _interopRequireDefault(require("lodash/groupBy"));
-var _uniq2 = _interopRequireDefault(require("lodash/uniq"));
-var _defaults2 = _interopRequireDefault(require("lodash/defaults"));
 var _react = _interopRequireDefault(require("react"));
+var _defaults = _interopRequireDefault(require("lodash/defaults"));
+var _uniq = _interopRequireDefault(require("lodash/uniq"));
+var _groupBy = _interopRequireDefault(require("lodash/groupBy"));
+var _uniqBy = _interopRequireDefault(require("lodash/uniqBy"));
 var Axis = _interopRequireWildcard(require("./axis"));
 var Style = _interopRequireWildcard(require("./style"));
 var Data = _interopRequireWildcard(require("./data"));
@@ -133,10 +133,10 @@ function getDataFromChildren(props, childComponents) {
     }, datum));
   };
   const stacked = children.filter(c => c.type && c.type.role === "stack").length;
-  const combine = (memo, val) => memo.concat((0, _uniqBy2.default)(val, "_group"));
+  const combine = (memo, val) => memo.concat((0, _uniqBy.default)(val, "_group"));
   const datasets = Helpers.reduceChildren(children, iteratee, props, [], combine);
   const group = stacked ? "_group" : "_stack";
-  return Object.values((0, _groupBy2.default)(datasets, group));
+  return Object.values((0, _groupBy.default)(datasets, group));
 }
 function getData(props, childComponents) {
   if (props.data) {
@@ -263,7 +263,7 @@ function getScale(props, axis, childComponents) {
     });
     return Scale.getScaleType(sharedProps, axis);
   };
-  const childScale = (0, _uniq2.default)(Helpers.reduceChildren(children, iteratee, props));
+  const childScale = (0, _uniq.default)(Helpers.reduceChildren(children, iteratee, props));
 
   // default to linear scale if more than one uniq scale type is given by children
   return childScale.length > 1 ? Scale.getScaleFromName("linear") : Scale.getScaleFromName(childScale[0]);
@@ -325,8 +325,8 @@ function getChildStyle(child, index, calculatedProps, theme) {
   const dataWidth = role === "stack" ? {} : {
     width: getWidth(calculatedProps)
   };
-  const dataStyle = (0, _defaults2.default)({}, childStyle.data, Object.assign({}, dataWidth, style.data, defaultColor));
-  const labelsStyle = (0, _defaults2.default)({}, childStyle.labels, style.labels);
+  const dataStyle = (0, _defaults.default)({}, childStyle.data, Object.assign({}, dataWidth, style.data, defaultColor));
+  const labelsStyle = (0, _defaults.default)({}, childStyle.labels, style.labels);
   return {
     ...childStyle,
     parent: style.parent,
@@ -379,7 +379,7 @@ function getCategoryAndAxisStringsFromChildren(props, axis, childComponents) {
   const axisComponent = Axis.getAxisComponent(childComponents, axis);
   const axisStrings = axisComponent ? Data.getStringsFromAxes(axisComponent.props, axis) : [];
   const categoryStrings = categories.length ? categories : getStringsFromChildrenCategories(childComponents, axis);
-  return (0, _uniq2.default)([...categoryStrings, ...axisStrings].flat());
+  return (0, _uniq.default)([...categoryStrings, ...axisStrings].flat());
 }
 function getStringsFromChildren(props, childComponents) {
   const children = childComponents || _react.default.Children.toArray(props.children);
@@ -387,8 +387,8 @@ function getStringsFromChildren(props, childComponents) {
   const yStrings = getCategoryAndAxisStringsFromChildren(props, "y", children);
   const dataStrings = getStringsFromData(children);
   return {
-    x: (0, _uniq2.default)([...xStrings, ...dataStrings.x].flat()),
-    y: (0, _uniq2.default)([...yStrings, ...dataStrings.y].flat())
+    x: (0, _uniq.default)([...xStrings, ...dataStrings.x].flat()),
+    y: (0, _uniq.default)([...yStrings, ...dataStrings.y].flat())
   };
 }
 function getCategories(props, childComponents, allStrings) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "victory-core",
-  "version": "37.3.2",
+  "version": "37.3.3",
   "description": "Victory Core",
   "keywords": [
     "data visualization",
@@ -22,7 +22,7 @@
   "dependencies": {
     "lodash": "^4.17.21",
     "react-fast-compare": "^3.2.0",
-    "victory-vendor": "37.3.2"
+    "victory-vendor": "37.3.3"
   },
   "peerDependencies": {
     "react": ">=16.6.0"
@@ -180,32 +180,6 @@
         "pnpm-lock.yaml"
       ]
     },
-    "format": {
-      "command": "nps format:pkg",
-      "files": [
-        "src/**",
-        "*.json",
-        "../../.prettierignore",
-        "../../.prettierrc.json"
-      ],
-      "output": [],
-      "packageLocks": [
-        "pnpm-lock.yaml"
-      ]
-    },
-    "format:fix": {
-      "command": "pnpm run format || nps format:pkg:fix",
-      "files": [
-        "src/**",
-        "*.json",
-        "../../.prettierignore",
-        "../../.prettierrc.json"
-      ],
-      "output": [],
-      "packageLocks": [
-        "pnpm-lock.yaml"
-      ]
-    },
     "lint": {
       "command": "eslint src",
       "files": [
@@ -267,8 +241,6 @@
     "check": "wireit",
     "types:check": "wireit",
     "types:create": "wireit",
-    "format": "wireit",
-    "format:fix": "wireit",
     "lint": "wireit",
     "lint:fix": "wireit",
     "jest": "wireit"

package/src/victory-animation/util.ts

@@ -1,5 +1,7 @@
+import isPlainObject from "lodash/isPlainObject";
+import orderBy from "lodash/orderBy";
+
 import { interpolate } from "victory-vendor/d3-interpolate";
-import { isPlainObject, orderBy } from "lodash";
 
 export const isInterpolatable = function (obj) {
   // d3 turns null into 0 and undefined into NaN, which we don't want.

package/src/victory-clip-container/victory-clip-container.tsx

@@ -1,7 +1,9 @@
 import React from "react";
+import defaults from "lodash/defaults";
+import uniqueId from "lodash/uniqueId";
+
 import * as Helpers from "../victory-util/helpers";
 import * as UserProps from "../victory-util/user-props";
-import { defaults, isObject, uniqueId } from "lodash";
 import { ClipPath } from "../victory-primitives/clip-path";
 import { Circle } from "../victory-primitives/circle";
 import { Rect } from "../victory-primitives/rect";
@@ -29,7 +31,14 @@ export interface VictoryClipContainerProps {
   translateY?: number;
 }
 
-export class VictoryClipContainer extends React.Component<VictoryClipContainerProps> {
+interface VictoryClipContainerState {
+  clipId?: number | string;
+}
+
+export class VictoryClipContainer extends React.Component<
+  VictoryClipContainerProps,
+  VictoryClipContainerState
+> {
   static displayName = "VictoryClipContainer";
   static role = "container";
 
@@ -43,10 +52,18 @@ export class VictoryClipContainer extends React.Component<VictoryClipContainerPr
 
   constructor(props: VictoryClipContainerProps) {
     super(props);
-    this.clipId =
-      !isObject(props) || props.clipId === undefined
-        ? uniqueId("victory-clip-")
-        : props.clipId;
+    this.state = {
+      clipId: props?.clipId,
+    };
+  }
+
+  // The clipId state is used to prevent hydration mismatches between the server and client (issue #2941).
+  // A better alternative would be to utilize React 18's useId hook instead of uniqueId, which would avoid needing state for this purpose.
+  // However, this component currently supports React 16 at the time of writing, so this workaround is necessary.
+  componentDidMount() {
+    if (!this.state.clipId) {
+      this.setState({ clipId: uniqueId("victory-clip-") });
+    }
   }
 
   calculateAttributes(props) {
@@ -58,7 +75,7 @@ export class VictoryClipContainer extends React.Component<VictoryClipContainerPr
       translateX = 0,
       translateY = 0,
     } = props;
-    const clipPadding = Helpers.getPadding({ padding: props.clipPadding });
+    const clipPadding = Helpers.getPadding(props.clipPadding);
     const radius = props.radius || Helpers.getRadius(props);
     return {
       x: (polar ? origin.x : translateX) - clipPadding.left,
@@ -141,9 +158,7 @@ export class VictoryClipContainer extends React.Component<VictoryClipContainerPr
       rectComponent,
       clipPathComponent,
     } = props;
-    const { top, bottom, left, right } = Helpers.getPadding({
-      padding: props.clipPadding,
-    });
+    const { top, bottom, left, right } = Helpers.getPadding(props.clipPadding);
     let child;
     if (polar) {
       const radius = props.radius || Helpers.getRadius(props);
@@ -201,6 +216,6 @@ export class VictoryClipContainer extends React.Component<VictoryClipContainerPr
       translateX,
       translateY,
     });
-    return this.renderClippedGroup(clipProps, this.clipId);
+    return this.renderClippedGroup(clipProps, this.state.clipId);
   }
 }

package/src/victory-container/victory-container.tsx

@@ -1,5 +1,5 @@
 import React, { useRef } from "react";
-import { uniqueId } from "lodash";
+import uniqueId from "lodash/uniqueId";
 import { Portal } from "../victory-portal/portal";
 import * as UserProps from "../victory-util/user-props";
 import { OriginType } from "../victory-label/victory-label";

package/src/victory-label/victory-label.tsx

@@ -1,6 +1,8 @@
 /* eslint no-magic-numbers: ["error", { "ignore": [-0.5, 0.5, 0, 1, 2] }]*/
-import { defaults, isEmpty } from "lodash";
 import React from "react";
+import defaults from "lodash/defaults";
+import isEmpty from "lodash/isEmpty";
+
 import { VictoryPortal } from "../victory-portal/victory-portal";
 import { Rect } from "../victory-primitives/rect";
 import { Text } from "../victory-primitives/text";
@@ -144,11 +146,11 @@ const getBackgroundPadding = (props) => {
   if (props.backgroundPadding && Array.isArray(props.backgroundPadding)) {
     return props.backgroundPadding.map((backgroundPadding) => {
       const padding = Helpers.evaluateProp(backgroundPadding, props);
-      return Helpers.getPadding({ padding });
+      return Helpers.getPadding(padding);
     });
   }
   const padding = Helpers.evaluateProp(props.backgroundPadding, props);
-  return Helpers.getPadding({ padding });
+  return Helpers.getPadding(padding);
 };
 
 const getLineHeight = (props) => {

package/src/victory-portal/victory-portal.tsx

@@ -1,5 +1,7 @@
 import React, { useState } from "react";
-import { defaults, uniqueId } from "lodash";
+import defaults from "lodash/defaults";
+import uniqueId from "lodash/uniqueId";
+
 import * as Log from "../victory-util/log";
 import * as Helpers from "../victory-util/helpers";
 import { usePortalContext } from "./portal-context";

package/src/victory-primitives/arc.tsx

@@ -1,6 +1,6 @@
 /* eslint no-magic-numbers: ["error", { "ignore": [0, 1, 2, 180] }]*/
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

package/src/victory-primitives/background.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

package/src/victory-primitives/border.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

package/src/victory-primitives/line-segment.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

package/src/victory-primitives/point.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import * as pathHelpers from "../victory-util/point-path-helpers";

package/src/victory-primitives/whisker.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { defaults } from "lodash";
+import defaults from "lodash/defaults";
 
 import * as Helpers from "../victory-util/helpers";
 import { VictoryCommonPrimitiveProps } from "../victory-util/common-props";

package/src/victory-transition/victory-transition.tsx

@@ -1,11 +1,13 @@
 import React from "react";
+import defaults from "lodash/defaults";
+import pick from "lodash/pick";
+import isEqual from "react-fast-compare";
+
 import { VictoryAnimation } from "../victory-animation/victory-animation";
 import * as Collection from "../victory-util/collection";
 import * as Helpers from "../victory-util/helpers";
 import TimerContext from "../victory-util/timer-context";
 import * as Transitions from "../victory-util/transitions";
-import { defaults, pick } from "lodash";
-import isEqual from "react-fast-compare";
 import Timer from "../victory-util/timer";
 
 type VictoryTransitionChild = React.ReactElement<

package/src/victory-util/add-events.tsx

@@ -1,5 +1,8 @@
 import React from "react";
-import { defaults, isEmpty, pick } from "lodash";
+import defaults from "lodash/defaults";
+import isEmpty from "lodash/isEmpty";
+import pick from "lodash/pick";
+
 import isEqual from "react-fast-compare";
 
 import { VictoryLabelableProps } from "../types/prop-types";
@@ -54,7 +57,7 @@ export interface EventsMixinClass<TProps> {
   ): React.ReactElement;
   cacheValues<TThis>(this: TThis, obj: Partial<TThis>): void;
   getEventState: typeof Events.getEventState;
-  renderData(props: TProps);
+  renderData(props: TProps, shouldRenderDatum?: () => boolean);
   renderContinuousData(props: TProps);
   animateComponent(
     props: TProps,

package/src/victory-util/axis.tsx

@@ -1,5 +1,9 @@
 import React from "react";
-import { defaults, isObject, uniq, orderBy } from "lodash";
+import defaults from "lodash/defaults";
+import isObject from "lodash/isObject";
+import uniq from "lodash/uniq";
+import orderBy from "lodash/orderBy";
+
 import * as Collection from "./collection";
 import * as Domain from "./domain";
 import * as Helpers from "./helpers";
@@ -214,8 +218,8 @@ function getTickArray(props) {
       arr.forEach((t, index) => {
         if (Array.isArray(domain)) {
           if (
-            t >= Collection.getMinValue(domain) &&
-            t <= Collection.getMaxValue(domain)
+            t >= Collection.getMinValue(domain).valueOf() &&
+            t <= Collection.getMaxValue(domain).valueOf()
           ) {
             newTickArray.push({
               value: t,

package/src/victory-util/data.ts

@@ -1,14 +1,13 @@
 import React from "react";
-import {
-  uniq,
-  isPlainObject,
-  property,
-  orderBy,
-  isEmpty,
-  isEqual,
-  isUndefined,
-  omitBy,
-} from "lodash";
+import isEmpty from "lodash/isEmpty";
+import isEqual from "lodash/isEqual";
+import isPlainObject from "lodash/isPlainObject";
+import isUndefined from "lodash/isUndefined";
+import omitBy from "lodash/omitBy";
+import orderBy from "lodash/orderBy";
+import property from "lodash/property";
+import uniq from "lodash/uniq";
+
 import * as Helpers from "./helpers";
 import * as Collection from "./collection";
 import * as Scale from "./scale";

package/src/victory-util/domain.ts

@@ -1,5 +1,8 @@
 import React from "react";
-import { isPlainObject, sortedUniq, isDate } from "lodash";
+import isDate from "lodash/isDate";
+import isPlainObject from "lodash/isPlainObject";
+import sortedUniq from "lodash/sortedUniq";
+
 import * as Data from "./data";
 import * as Scale from "./scale";
 import * as Helpers from "./helpers";
@@ -108,12 +111,13 @@ function padDomain(domain, props, axis) {
     : props.singleQuadrantDomainPadding;
 
   const addsQuadrants =
-    (min >= 0 && paddedDomain.min <= 0) || (max <= 0 && paddedDomain.max >= 0);
+    (min.valueOf() >= 0 && paddedDomain.min <= 0) ||
+    (max.valueOf() <= 0 && paddedDomain.max >= 0);
 
   const adjust = (val, type) => {
     const coerce =
-      (type === "min" && min >= 0 && val <= 0) ||
-      (type === "max" && max <= 0 && val >= 0);
+      (type === "min" && min.valueOf() >= 0 && val <= 0) ||
+      (type === "max" && max.valueOf() <= 0 && val >= 0);
     return coerce ? 0 : val;
   };
 

package/src/victory-util/events.ts

@@ -1,6 +1,9 @@
 import React from "react";
+import isEmpty from "lodash/isEmpty";
+import pickBy from "lodash/pickBy";
+import omitBy from "lodash/omitBy";
+import uniq from "lodash/uniq";
 
-import { isEmpty, pickBy, omitBy, uniq } from "lodash";
 import type { EventMixinCalculatedValues } from "./add-events";
 import { isFunction } from "./helpers";