victory-core 37.0.3-next.0 → 37.1.0

package/CHANGELOG.md

@@ -1,11 +1,12 @@
 # victory-core
 
-## 37.0.3-next.0
+## 37.1.0
 
-### Patch Changes
+### Minor Changes
+
+- Refactor containers and portal to function components ([#2799](https://github.com/FormidableLabs/victory/pull/2799))
 
-- 65d02419f: Refactor containers and portal to function components
-  - victory-vendor@37.0.3-next.0
+* Pin all internal victory package versions ([#2876](https://github.com/FormidableLabs/victory/pull/2876))
 
 ## 37.0.2
 

package/dist/victory-core.js

@@ -635,9 +635,9 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony import */ var react__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/__webpack_require__.n(react__WEBPACK_IMPORTED_MODULE_1__);
 /* harmony import */ var _victory_portal_portal__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(/*! ../victory-portal/portal */ "./victory-portal/portal.tsx");
 /* harmony import */ var _victory_util_user_props__WEBPACK_IMPORTED_MODULE_3__ = __webpack_require__(/*! ../victory-util/user-props */ "./victory-util/user-props.ts");
-/* harmony import */ var _victory_util__WEBPACK_IMPORTED_MODULE_5__ = __webpack_require__(/*! ../victory-util */ "./victory-util/merge-refs.ts");
+/* harmony import */ var _victory_util__WEBPACK_IMPORTED_MODULE_4__ = __webpack_require__(/*! ../victory-util */ "./victory-util/merge-refs.ts");
 /* harmony import */ var _victory_portal_portal_outlet__WEBPACK_IMPORTED_MODULE_6__ = __webpack_require__(/*! ../victory-portal/portal-outlet */ "./victory-portal/portal-outlet.tsx");
-/* harmony import */ var _victory_portal_portal_context__WEBPACK_IMPORTED_MODULE_4__ = __webpack_require__(/*! ../victory-portal/portal-context */ "./victory-portal/portal-context.tsx");
+/* harmony import */ var _victory_portal_portal_context__WEBPACK_IMPORTED_MODULE_5__ = __webpack_require__(/*! ../victory-portal/portal-context */ "./victory-portal/portal-context.tsx");
 
 function _extends() { _extends = Object.assign ? Object.assign.bind() : function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }
 
@@ -737,7 +737,7 @@ const VictoryContainer = initialProps => {
     };
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
-  return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement(_victory_portal_portal_context__WEBPACK_IMPORTED_MODULE_4__.PortalProvider, null, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement("div", {
+  return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement("div", {
     className: className,
     style: {
       ...style,
@@ -750,8 +750,8 @@ const VictoryContainer = initialProps => {
     "data-ouia-component-id": ouiaId,
     "data-ouia-component-type": ouiaType,
     "data-ouia-safe": ouiaSafe,
-    ref: (0,_victory_util__WEBPACK_IMPORTED_MODULE_5__.mergeRefs)([localContainerRef, containerRef])
-  }, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement("svg", _extends({
+    ref: (0,_victory_util__WEBPACK_IMPORTED_MODULE_4__.mergeRefs)([localContainerRef, containerRef])
+  }, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement(_victory_portal_portal_context__WEBPACK_IMPORTED_MODULE_5__.PortalProvider, null, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().createElement("svg", _extends({
     width: width,
     height: height,
     tabIndex: tabIndex,
@@ -1312,9 +1312,6 @@ const PortalContext = /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default().
 PortalContext.displayName = "PortalContext";
 const usePortalContext = () => {
   const context = react__WEBPACK_IMPORTED_MODULE_0___default().useContext(PortalContext);
-  if (!context) {
-    throw new Error("`usePortalContext` must be used within a `<PortalProvider />`");
-  }
   return context;
 };
 const PortalProvider = _ref => {
@@ -1370,12 +1367,10 @@ const PortalOutlet = _ref => {
     ...props
   } = _ref;
   const portalContext = (0,_portal_context__WEBPACK_IMPORTED_MODULE_1__.usePortalContext)();
-  const children = Array.from(portalContext.children.entries()).map(_ref2 => {
-    let [key, node] = _ref2;
-    return !node.key ? /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default().cloneElement(node, {
-      key
-    }) : node;
-  });
+  if (!portalContext) {
+    return null;
+  }
+  const children = Array.from(portalContext.children.values());
   return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default().cloneElement(portalComponent, props, children);
 };
 
@@ -1441,26 +1436,28 @@ const VictoryPortal = initialProps => {
     const msg = "`renderInPortal` is not supported outside of `VictoryContainer`. " + "Component will be rendered in place";
     _victory_util_log__WEBPACK_IMPORTED_MODULE_3__.warn(msg);
   }
+  const children = Array.isArray(props.children) ? props.children[0] : props.children;
+  const {
+    groupComponent
+  } = props;
+  const childProps = children && children.props || {};
+  const standardProps = childProps.groupComponent ? {
+    groupComponent,
+    standalone: false
+  } : {};
+  const newProps = lodash_defaults__WEBPACK_IMPORTED_MODULE_0___default()(standardProps, childProps, _victory_util_helpers__WEBPACK_IMPORTED_MODULE_4__.omit(props, ["children", "groupComponent"]), {
+    key: childProps.key ?? id
+  });
+  const child = children && /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().cloneElement(children, newProps);
   react__WEBPACK_IMPORTED_MODULE_1___default().useEffect(() => {
-    const children = Array.isArray(props.children) ? props.children[0] : props.children;
-    const {
-      groupComponent
-    } = props;
-    const childProps = children && children.props || {};
-    const standardProps = childProps.groupComponent ? {
-      groupComponent,
-      standalone: false
-    } : {};
-    const newProps = lodash_defaults__WEBPACK_IMPORTED_MODULE_0___default()(standardProps, childProps, _victory_util_helpers__WEBPACK_IMPORTED_MODULE_4__.omit(props, ["children", "groupComponent"]));
-    const child = children && /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default().cloneElement(children, newProps);
-    portalContext.addChild(id, child);
+    portalContext?.addChild(id, child);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [props.children]);
   react__WEBPACK_IMPORTED_MODULE_1___default().useEffect(() => {
-    return () => portalContext.removeChild(id);
+    return () => portalContext?.removeChild(id);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
-  return null;
+  return portalContext ? null : child;
 };
 VictoryPortal.role = "portal";