victory-core 36.8.2 → 36.8.4

package/lib/victory-label/victory-label.js

@@ -119,8 +119,7 @@ var getStyles = function (style, props) {
   }
 
   var getSingleStyle = function (s) {
-    s = s ? (0, _defaults2.default)({}, s, defaultStyles) : defaultStyles;
-    var baseStyles = Helpers.evaluateStyle(s, props);
+    var baseStyles = Helpers.evaluateStyle(s ? (0, _defaults2.default)({}, s, defaultStyles) : defaultStyles, props);
     return (0, _assign2.default)({}, baseStyles, {
       fontSize: getFontSize(baseStyles)
     });
@@ -324,22 +323,19 @@ var getInlineXOffset = function (calculatedProps, textElements, index) {
   switch (textAnchor) {
     case "start":
       return widths.reduce(function (memo, width, i) {
-        memo = i < index ? memo + width : memo;
-        return memo;
+        return i < index ? memo + width : memo;
       }, 0);
 
     case "end":
       return widths.reduce(function (memo, width, i) {
-        memo = i > index ? memo - width : memo;
-        return memo;
+        return i > index ? memo - width : memo;
       }, 0);
 
     default:
       // middle
       return widths.reduce(function (memo, width, i) {
         var offsetWidth = i < index ? width : 0;
-        memo = i === index ? memo + width / 2 : memo + offsetWidth;
-        return memo;
+        return i === index ? memo + width / 2 : memo + offsetWidth;
       }, centerOffset);
   }
 };
@@ -542,8 +538,8 @@ var defaultProps = {
   lineHeight: 1
 };
 
-var VictoryLabel = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var VictoryLabel = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
 
   if (props.text === null || props.text === undefined) {
     return null;
@@ -564,7 +560,7 @@ var VictoryLabel = function (props) {
       fontSize: currentStyle.fontSize || defaultStyles.fontSize,
       capHeight: capHeightPx,
       text: line,
-      // @ts-expect-error TODO: This looks like a bug:
+      // TODO: This looks like a bug:
       textSize: TextSize.approximateTextSize(line, currentStyle),
       lineHeight: currentLineHeight,
       backgroundPadding: getSingleValue(backgroundPadding, i)

package/lib/victory-primitives/arc.d.ts

@@ -12,7 +12,7 @@ export interface ArcProps extends VictoryCommonPrimitiveProps {
     startAngle?: number;
 }
 export declare const Arc: {
-    (props: ArcProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: ArcProps): React.DetailedReactHTMLElement<any, HTMLElement>;
     propTypes: {
         closedPath: PropTypes.Requireable<boolean>;
         cx: PropTypes.Requireable<number>;

package/lib/victory-primitives/arc.js

@@ -85,8 +85,8 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var Arc = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var Arc = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
   return /*#__PURE__*/_react.default.cloneElement(props.pathComponent, _objectSpread(_objectSpread({}, props.events), {}, {
     "aria-label": props.ariaLabel,
     d: getArcPath(props),

package/lib/victory-primitives/background.d.ts

@@ -12,7 +12,7 @@ export interface BackgroundProps extends VictoryCommonPrimitiveProps {
     y?: number;
 }
 export declare const Background: {
-    (props: BackgroundProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: BackgroundProps): React.DetailedReactHTMLElement<any, HTMLElement>;
     propTypes: {
         circleComponent: PropTypes.Requireable<PropTypes.ReactElementLike>;
         height: PropTypes.Requireable<number>;

package/lib/victory-primitives/background.js

@@ -49,8 +49,8 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var Background = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var Background = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
   return props.polar ? /*#__PURE__*/_react.default.cloneElement(props.circleComponent, _objectSpread(_objectSpread({}, props.events), {}, {
     style: props.style,
     role: props.role,

package/lib/victory-primitives/border.d.ts

@@ -9,7 +9,7 @@ export interface BorderProps extends VictoryCommonPrimitiveProps {
     y?: number;
 }
 export declare const Border: {
-    (props: BorderProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: BorderProps): React.DetailedReactHTMLElement<any, HTMLElement>;
     propTypes: {
         height: PropTypes.Requireable<number>;
         rectComponent: PropTypes.Requireable<PropTypes.ReactElementLike>;

package/lib/victory-primitives/border.js

@@ -60,8 +60,8 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var Border = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var Border = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
   return /*#__PURE__*/_react.default.cloneElement(props.rectComponent, _objectSpread(_objectSpread({}, props.events), {}, {
     "aria-label": props.ariaLabel,
     style: props.style,

package/lib/victory-primitives/line-segment.d.ts

@@ -10,7 +10,7 @@ export interface LineSegmentProps extends VictoryCommonPrimitiveProps {
     y2?: number;
 }
 export declare const LineSegment: {
-    (props: LineSegmentProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: LineSegmentProps): React.DetailedReactHTMLElement<any, HTMLElement>;
     propTypes: {
         datum: PropTypes.Requireable<any>;
         lineComponent: PropTypes.Requireable<PropTypes.ReactElementLike>;

package/lib/victory-primitives/line-segment.js

@@ -60,8 +60,8 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var LineSegment = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var LineSegment = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
   return /*#__PURE__*/_react.default.cloneElement(props.lineComponent, _objectSpread(_objectSpread({}, props.events), {}, {
     "aria-label": props.ariaLabel,
     style: props.style,

package/lib/victory-primitives/point.d.ts

@@ -12,7 +12,7 @@ export interface PointProps extends VictoryCommonPrimitiveProps {
     y?: number;
 }
 export declare const Point: {
-    (props: PointProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: PointProps): React.DetailedReactHTMLElement<any, HTMLElement>;
     propTypes: {
         datum: PropTypes.Requireable<object>;
         getPath: PropTypes.Requireable<(...args: any[]) => any>;

package/lib/victory-primitives/point.js

@@ -83,8 +83,8 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var Point = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
+var Point = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
   var userProps = UserProps.getSafeUserProps(props);
   return /*#__PURE__*/_react.default.cloneElement(props.pathComponent, _objectSpread(_objectSpread({}, props.events), {}, {
     "aria-label": props.ariaLabel,

package/lib/victory-primitives/whisker.d.ts

@@ -14,7 +14,7 @@ export interface WhiskerProps extends VictoryCommonPrimitiveProps {
     minorWhisker?: WhiskerAxes;
 }
 export declare const Whisker: {
-    (props: WhiskerProps): React.ReactElement<any, string | React.JSXElementConstructor<any>>;
+    (initialProps: WhiskerProps): React.DetailedReactHTMLElement<{}, HTMLElement>;
     propTypes: {
         groupComponent: PropTypes.Requireable<PropTypes.ReactElementLike>;
         lineComponent: PropTypes.Requireable<PropTypes.ReactElementLike>;

package/lib/victory-primitives/whisker.js

@@ -59,23 +59,22 @@ var defaultProps = {
   shapeRendering: "auto"
 };
 
-var Whisker = function (props) {
-  props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), props));
-  var _props = props,
-      ariaLabel = _props.ariaLabel,
-      groupComponent = _props.groupComponent,
-      lineComponent = _props.lineComponent,
-      events = _props.events,
-      className = _props.className,
-      majorWhisker = _props.majorWhisker,
-      minorWhisker = _props.minorWhisker,
-      transform = _props.transform,
-      clipPath = _props.clipPath,
-      role = _props.role,
-      shapeRendering = _props.shapeRendering,
-      style = _props.style,
-      desc = _props.desc,
-      tabIndex = _props.tabIndex;
+var Whisker = function (initialProps) {
+  var props = evaluateProps(_objectSpread(_objectSpread({}, defaultProps), initialProps));
+  var ariaLabel = props.ariaLabel,
+      groupComponent = props.groupComponent,
+      lineComponent = props.lineComponent,
+      events = props.events,
+      className = props.className,
+      majorWhisker = props.majorWhisker,
+      minorWhisker = props.minorWhisker,
+      transform = props.transform,
+      clipPath = props.clipPath,
+      role = props.role,
+      shapeRendering = props.shapeRendering,
+      style = props.style,
+      desc = props.desc,
+      tabIndex = props.tabIndex;
 
   var baseProps = _objectSpread(_objectSpread({}, events), {}, {
     style: style,

package/lib/victory-util/add-events.js

@@ -240,8 +240,7 @@ function addEvents(WrappedComponent) {
       value: function applyExternalMutations(props, externalMutations) {
         if (!(0, _isEmpty2.default)(externalMutations)) {
           var callbacks = props.externalEventMutations.reduce(function (memo, mutation) {
-            memo = (0, _isFunction2.default)(mutation.callback) ? memo.concat(mutation.callback) : memo;
-            return memo;
+            return (0, _isFunction2.default)(mutation.callback) ? memo.concat(mutation.callback) : memo;
           }, []);
           var compiledCallbacks = callbacks.length ? function () {
             callbacks.forEach(function (c) {
@@ -294,8 +293,8 @@ function addEvents(WrappedComponent) {
     }, {
       key: "getBaseProps",
       value: function getBaseProps(props, getSharedEventState) {
-        getSharedEventState = getSharedEventState || this.getSharedEventState.bind(this);
-        var sharedParentState = getSharedEventState("parent", "parent");
+        var getSharedEventStateFunction = getSharedEventState || this.getSharedEventState.bind(this);
+        var sharedParentState = getSharedEventStateFunction("parent", "parent");
         var parentState = this.getEventState("parent", "parent");
         var baseParentProps = (0, _defaults2.default)({}, parentState, sharedParentState);
         var parentPropsList = baseParentProps.parentControlledProps;
@@ -385,13 +384,15 @@ function addEvents(WrappedComponent) {
             groupComponent = props.groupComponent;
         var dataKeys = (0, _without2.default)(this.dataKeys, "all");
         var labelComponents = dataKeys.reduce(function (memo, key) {
+          var newMemo = memo;
+
           var labelProps = _this8.getComponentProps(labelComponent, "labels", key);
 
           if (labelProps && labelProps.text !== undefined && labelProps.text !== null) {
-            memo = memo.concat( /*#__PURE__*/_react.default.cloneElement(labelComponent, labelProps));
+            newMemo = newMemo.concat( /*#__PURE__*/_react.default.cloneElement(labelComponent, labelProps));
           }
 
-          return memo;
+          return newMemo;
         }, []);
         var dataProps = this.getComponentProps(dataComponent, "data", "all");
         var children = [/*#__PURE__*/_react.default.cloneElement(dataComponent, dataProps)].concat(_toConsumableArray(labelComponents));

package/lib/victory-util/axis.js

@@ -86,11 +86,11 @@ function getAxis(props) {
 
 
 function findAxisComponents(childComponents, predicate) {
-  predicate = predicate || _identity2.default;
+  var predicateFunction = predicate || _identity2.default;
 
   var findAxes = function (children) {
     return children.reduce(function (memo, child) {
-      if (child.type && child.type.role === "axis" && predicate(child)) {
+      if (child.type && child.type.role === "axis" && predicateFunction(child)) {
         return memo.concat(child);
       } else if (child.props && child.props.children) {
         return memo.concat(findAxes(_react.default.Children.toArray(child.props.children)));

package/lib/victory-util/common-props.d.ts

@@ -20,6 +20,7 @@ export interface VictoryCommonThemeProps {
     animate?: boolean | AnimatePropTypeInterface;
     colorScale?: ColorScalePropType;
     containerComponent?: React.ReactElement;
+    disableInlineStyles?: boolean;
     domainPadding?: DomainPaddingPropType;
     externalEventMutations?: EventCallbackInterface<string | string[], StringOrNumberOrList>[];
     groupComponent?: React.ReactElement;

package/lib/victory-util/data.js

@@ -103,12 +103,14 @@ function sortData(dataset, sortKey) {
   } // Ensures previous VictoryLine api for sortKey prop stays consistent
 
 
+  var formattedSortKey = sortKey;
+
   if (sortKey === "x" || sortKey === "y") {
-    sortKey = "_".concat(sortKey);
+    formattedSortKey = "_".concat(sortKey);
   }
 
   var order = sortOrder === "ascending" ? "asc" : "desc";
-  return (0, _orderBy2.default)(dataset, sortKey, order);
+  return (0, _orderBy2.default)(dataset, formattedSortKey, order);
 } // This method will remove data points that break certain scales. (log scale only)
 
 
@@ -300,7 +302,10 @@ function formatData(dataset, props, expectedKeys) {
     return [];
   }
 
-  var defaultKeys = ["x", "y", "y0"];
+  var defaultKeys = ["x", "y", "y0"]; // TODO: We shouldn’t mutate the expectedKeys param here,
+  // but we need to figure out why changing it causes regressions in tests.
+  // eslint-disable-next-line no-param-reassign
+
   expectedKeys = Array.isArray(expectedKeys) ? expectedKeys : defaultKeys;
 
   var createAccessor = function (name) {
@@ -325,13 +330,13 @@ function formatData(dataset, props, expectedKeys) {
 
   var data = preformattedData ? dataset : dataset.reduce(function (dataArr, datum, index) {
     // eslint-disable-line complexity
-    datum = parseDatum(datum);
+    var parsedDatum = parseDatum(datum);
     var fallbackValues = {
       x: index,
-      y: datum
+      y: parsedDatum
     };
     var processedValues = expectedKeys.reduce(function (memo, type) {
-      var processedValue = accessor[type](datum);
+      var processedValue = accessor[type](parsedDatum);
       var value = processedValue !== undefined ? processedValue : fallbackValues[type];
 
       if (value !== undefined) {
@@ -345,7 +350,7 @@ function formatData(dataset, props, expectedKeys) {
 
       return memo;
     }, {});
-    var formattedDatum = (0, _assign2.default)({}, processedValues, datum);
+    var formattedDatum = (0, _assign2.default)({}, processedValues, parsedDatum);
 
     if (!(0, _isEmpty2.default)(formattedDatum)) {
       dataArr.push(formattedDatum);
@@ -462,8 +467,8 @@ function getStringsFromData(props, axis) {
   }, []);
   var sortedData = sortData(data, props.sortKey, props.sortOrder);
   var dataStrings = sortedData.reduce(function (dataArr, datum) {
-    datum = parseDatum(datum);
-    dataArr.push(accessor(datum));
+    var parsedDatum = parseDatum(datum);
+    dataArr.push(accessor(parsedDatum));
     return dataArr;
   }, []).filter(function (datum) {
     return typeof datum === "string";

package/lib/victory-util/domain.js

@@ -195,18 +195,18 @@ function padDomain(domain, props, axis) {
 
 
 function createDomainFunction(getDomainFromDataFunction, formatDomainFunction) {
-  getDomainFromDataFunction = (0, _isFunction2.default)(getDomainFromDataFunction) ? getDomainFromDataFunction : getDomainFromData;
-  formatDomainFunction = (0, _isFunction2.default)(formatDomainFunction) ? formatDomainFunction : formatDomain;
+  var getDomainFromDataFn = (0, _isFunction2.default)(getDomainFromDataFunction) ? getDomainFromDataFunction : getDomainFromData;
+  var formatDomainFn = (0, _isFunction2.default)(formatDomainFunction) ? formatDomainFunction : formatDomain;
   return function (props, axis) {
     var propsDomain = getDomainFromProps(props, axis);
 
     if (propsDomain) {
-      return formatDomainFunction(propsDomain, props, axis);
+      return formatDomainFn(propsDomain, props, axis);
     }
 
     var categories = Data.getCategories(props, axis);
-    var domain = categories ? getDomainFromCategories(props, axis, categories) : getDomainFromDataFunction(props, axis);
-    return domain ? formatDomainFunction(domain, props, axis) : undefined;
+    var domain = categories ? getDomainFromCategories(props, axis, categories) : getDomainFromDataFn(props, axis);
+    return domain ? formatDomainFn(domain, props, axis) : undefined;
   };
 }
 /**
@@ -242,27 +242,27 @@ function getDomain(props, axis) {
 
 
 function getDomainFromCategories(props, axis, categories) {
-  categories = categories || Data.getCategories(props, axis);
+  var categoriesArray = categories || Data.getCategories(props, axis);
   var polar = props.polar,
       _props$startAngle = props.startAngle,
       startAngle = _props$startAngle === void 0 ? 0 : _props$startAngle,
       _props$endAngle = props.endAngle,
       endAngle = _props$endAngle === void 0 ? 360 : _props$endAngle;
 
-  if (!categories) {
+  if (!categoriesArray) {
     return undefined;
   }
 
   var minDomain = getMinFromProps(props, axis);
   var maxDomain = getMaxFromProps(props, axis);
-  var stringArray = Collection.containsStrings(categories) ? Data.getStringsFromCategories(props, axis) : [];
+  var stringArray = Collection.containsStrings(categoriesArray) ? Data.getStringsFromCategories(props, axis) : [];
   var stringMap = stringArray.length === 0 ? null : stringArray.reduce(function (memo, string, index) {
     memo[string] = index + 1;
     return memo;
   }, {});
-  var categoryValues = stringMap ? categories.map(function (value) {
+  var categoryValues = stringMap ? categoriesArray.map(function (value) {
     return stringMap[value];
-  }) : categories;
+  }) : categoriesArray;
   var min = minDomain !== undefined ? minDomain : Collection.getMinValue(categoryValues);
   var max = maxDomain !== undefined ? maxDomain : Collection.getMaxValue(categoryValues);
   var categoryDomain = getDomainFromMinMax(min, max);
@@ -278,7 +278,7 @@ function getDomainFromCategories(props, axis, categories) {
 
 
 function getDomainFromData(props, axis, dataset) {
-  dataset = dataset || Data.getData(props);
+  var datasetArray = dataset || Data.getData(props);
   var polar = props.polar,
       _props$startAngle2 = props.startAngle,
       startAngle = _props$startAngle2 === void 0 ? 0 : _props$startAngle2,
@@ -287,14 +287,14 @@ function getDomainFromData(props, axis, dataset) {
   var minDomain = getMinFromProps(props, axis);
   var maxDomain = getMaxFromProps(props, axis);
 
-  if (dataset.length < 1) {
+  if (datasetArray.length < 1) {
     return minDomain !== undefined && maxDomain !== undefined ? getDomainFromMinMax(minDomain, maxDomain) : undefined;
   }
 
-  var min = minDomain !== undefined ? minDomain : getExtremeFromData(dataset, axis, "min");
-  var max = maxDomain !== undefined ? maxDomain : getExtremeFromData(dataset, axis, "max");
+  var min = minDomain !== undefined ? minDomain : getExtremeFromData(datasetArray, axis, "min");
+  var max = maxDomain !== undefined ? maxDomain : getExtremeFromData(datasetArray, axis, "max");
   var domain = getDomainFromMinMax(min, max);
-  return polar && axis === "x" && Math.abs(startAngle - endAngle) === 360 ? getSymmetricDomain(domain, getFlatData(dataset, axis)) : domain;
+  return polar && axis === "x" && Math.abs(startAngle - endAngle) === 360 ? getSymmetricDomain(domain, getFlatData(datasetArray, axis)) : domain;
 }
 /**
  * Returns a domain in the form of a two element array given a min and max value.

package/lib/victory-util/events.d.ts

@@ -16,7 +16,7 @@ interface ComponentWithEvents extends EventMixinCalculatedValues {
     state: any;
     setState: any;
 }
-export declare function getEvents(this: ComponentWithEvents, props: any, target: any, eventKey: any, getScopedEvents: any): any;
+export declare function getEvents(this: ComponentWithEvents, props: any, target?: any, eventKey?: any, getScopedEvents?: any): any;
 export declare function getScopedEvents(this: ComponentWithEvents, events: any, namespace: any, childType: any, baseProps: any): {};
 export declare function getPartialEvents(events: ComponentEventHandlers, eventKey: ComponentEventKey, childProps: unknown): PartialEvents;
 export interface PartialEvents {
@@ -33,7 +33,7 @@ export declare function getEventState(this: ComponentWithEvents, eventKey: Compo
  *
  * @return {Object} a object describing all mutations for VictorySharedEvents
  */
-export declare function getExternalMutationsWithChildren(mutations: any, baseProps: any, baseState: any, childNames: any): any;
+export declare function getExternalMutationsWithChildren(mutations: any, baseProps: {} | undefined, baseState: {} | undefined, childNames: any): any;
 /**
  * Returns a set of all mutations for a component
  *
@@ -44,7 +44,7 @@ export declare function getExternalMutationsWithChildren(mutations: any, basePro
  *
  * @return {Object} a object describing mutations for a given component
  */
-export declare function getExternalMutations(mutations: any, baseProps: any, baseState: any, childName?: any): {};
+export declare function getExternalMutations(mutations: any, baseProps?: {}, baseState?: {}, childName?: any): {};
 /**
  * Returns a set of mutations for a particular element given scoped baseProps and baseState
  *

package/lib/victory-util/events.js

@@ -146,14 +146,14 @@ function getScopedEvents(events, namespace, childType, baseProps) {
   // eslint-disable-next-line no-invalid-this
 
 
-  baseProps = baseProps || this.baseProps; // returns the original base props or base state of a given target element
+  var newBaseProps = baseProps || this.baseProps; // returns the original base props or base state of a given target element
 
   var getTargetProps = function (identifier, type) {
     var childName = identifier.childName,
         target = identifier.target,
         key = identifier.key; // eslint-disable-next-line no-invalid-this
 
-    var baseType = type === "props" ? baseProps : _this2.state || {};
+    var baseType = type === "props" ? newBaseProps : _this2.state || {};
     var base = childName === undefined || childName === null || !baseType[childName] ? baseType : baseType[childName];
     return key === "parent" ? base.parent : base[key] && base[key][target];
   }; // Returns the state object with the mutation caused by a given eventReturn
@@ -170,9 +170,9 @@ function getScopedEvents(events, namespace, childType, baseProps) {
       }
 
       if (eventReturn.eventKey === "all") {
-        return baseProps[childName] ? (0, _without2.default)((0, _keys2.default)(baseProps[childName]), "parent") : (0, _without2.default)((0, _keys2.default)(baseProps), "parent");
+        return newBaseProps[childName] ? (0, _without2.default)((0, _keys2.default)(newBaseProps[childName]), "parent") : (0, _without2.default)((0, _keys2.default)(newBaseProps), "parent");
       } else if (eventReturn.eventKey === undefined && eventKey === "parent") {
-        return baseProps[childName] ? (0, _keys2.default)(baseProps[childName]) : (0, _keys2.default)(baseProps);
+        return newBaseProps[childName] ? (0, _keys2.default)(newBaseProps[childName]) : (0, _keys2.default)(newBaseProps);
       }
 
       return eventReturn.eventKey !== undefined ? eventReturn.eventKey : eventKey;
@@ -197,7 +197,7 @@ function getScopedEvents(events, namespace, childType, baseProps) {
         key: key,
         target: target
       }, "state");
-      var mutatedProps = eventReturn.mutation((0, _assign6.default)({}, mutationTargetProps, mutationTargetState), baseProps);
+      var mutatedProps = eventReturn.mutation((0, _assign6.default)({}, mutationTargetProps, mutationTargetState), newBaseProps);
       var childState = baseState[childName] || {};
 
       var filterState = function (state) {
@@ -232,7 +232,7 @@ function getScopedEvents(events, namespace, childType, baseProps) {
     }; // returns an entire mutated state for all children
 
 
-    var allChildNames = childNames === "all" ? (0, _without2.default)((0, _keys2.default)(baseProps), "parent") : childNames;
+    var allChildNames = childNames === "all" ? (0, _without2.default)((0, _keys2.default)(newBaseProps), "parent") : childNames;
     return Array.isArray(allChildNames) ? allChildNames.reduce(function (memo, childName) {
       return (0, _assign6.default)(memo, getReturnByChild(childName));
     }, {}) : getReturnByChild(allChildNames);
@@ -241,8 +241,7 @@ function getScopedEvents(events, namespace, childType, baseProps) {
 
   var parseEventReturn = function (eventReturn, eventKey) {
     return Array.isArray(eventReturn) ? eventReturn.reduce(function (memo, props) {
-      memo = (0, _assign6.default)({}, memo, parseEvent(props, eventKey));
-      return memo;
+      return (0, _assign6.default)({}, memo, parseEvent(props, eventKey));
     }, {}) : parseEvent(eventReturn, eventKey);
   };
 
@@ -330,9 +329,10 @@ function getEventState(eventKey, namespace, childType) {
 // eslint-disable-next-line max-params
 
 
-function getExternalMutationsWithChildren(mutations, baseProps, baseState, childNames) {
-  baseProps = baseProps || {};
-  baseState = baseState || {};
+function getExternalMutationsWithChildren(mutations) {
+  var baseProps = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
+  var baseState = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
+  var childNames = arguments.length > 3 ? arguments[3] : undefined;
   return childNames.reduce(function (memo, childName) {
     var childState = baseState[childName];
     var mutation = getExternalMutations(mutations, baseProps[childName], baseState[childName], childName);
@@ -355,9 +355,10 @@ function getExternalMutationsWithChildren(mutations, baseProps, baseState, child
 // eslint-disable-next-line max-params
 
 
-function getExternalMutations(mutations, baseProps, baseState, childName) {
-  baseProps = baseProps || {};
-  baseState = baseState || {};
+function getExternalMutations(mutations) {
+  var baseProps = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
+  var baseState = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
+  var childName = arguments.length > 3 ? arguments[3] : undefined;
   var eventKeys = (0, _keys2.default)(baseProps);
   return eventKeys.reduce(function (memo, eventKey) {
     var keyState = baseState[eventKey] || {};
@@ -421,8 +422,7 @@ function getExternalMutation(mutations, baseProps, baseState, identifier) {
     return false;
   };
 
-  mutations = Array.isArray(mutations) ? mutations : [mutations];
-  var scopedMutations = mutations;
+  var scopedMutations = Array.isArray(mutations) ? mutations : [mutations];
 
   if (identifier.childName) {
     scopedMutations = mutations.filter(function (m) {
@@ -462,13 +462,10 @@ function getExternalMutation(mutations, baseProps, baseState, identifier) {
 
 function getComponentEvents(props, components) {
   var events = Array.isArray(components) && components.reduce(function (memo, componentName) {
-    var _memo;
-
     var component = props[componentName];
     var defaultEvents = component && component.type && component.type.defaultEvents;
     var componentEvents = (0, _isFunction2.default)(defaultEvents) ? defaultEvents(component.props) : defaultEvents;
-    memo = Array.isArray(componentEvents) ? (_memo = memo).concat.apply(_memo, _toConsumableArray(componentEvents)) : memo;
-    return memo;
+    return Array.isArray(componentEvents) ? memo.concat.apply(memo, _toConsumableArray(componentEvents)) : memo;
   }, []);
   return events && events.length ? events : undefined;
 }

package/lib/victory-util/helpers.js

@@ -338,6 +338,7 @@ function reduceChildren(children, iteratee) {
 
   var traverseChildren = function (childArray, names, parent) {
     return childArray.reduce(function (memo, child, index) {
+      var newMemo = memo;
       var childRole = child.type && child.type.role;
       var childName = child.props.name || "".concat(childRole, "-").concat(names[index]);
 
@@ -353,16 +354,16 @@ function reduceChildren(children, iteratee) {
         });
 
         var nestedResults = traverseChildren(nestedChildren, _childNames, child);
-        memo = combine(memo, nestedResults);
+        newMemo = combine(newMemo, nestedResults);
       } else {
         var result = iteratee(child, childName, parent);
 
         if (result) {
-          memo = combine(memo, result);
+          newMemo = combine(newMemo, result);
         }
       }
 
-      return memo;
+      return newMemo;
     }, initialMemo);
   };
 
@@ -389,8 +390,7 @@ function isHorizontal(props) {
       var childProps = child.props || {};
 
       if (memo || childProps.horizontal || !childProps.children) {
-        memo = memo || childProps.horizontal;
-        return memo;
+        return memo || childProps.horizontal;
       }
 
       return traverseChildren(_react.default.Children.toArray(childProps.children));

package/lib/victory-util/immutable.js

@@ -41,11 +41,13 @@ function isMap(x) {
 
 function shallowToJS(x, whitelist) {
   return isIterable(x) ? x.reduce(function (result, curr, key) {
+    var newCurr = curr;
+
     if (whitelist && whitelist[key]) {
-      curr = shallowToJS(curr);
+      newCurr = shallowToJS(curr);
     }
 
-    result[key] = curr;
+    result[key] = newCurr;
     return result;
   }, isList(x) ? [] : {}) : x;
 }

package/lib/victory-util/label-helpers.d.ts

@@ -1,4 +1,4 @@
-export declare function getText(props: any, datum: any, index: any): any;
+export declare function getText(props: any, datum: Record<string, any> | undefined, index: any): any;
 export declare function getPolarTextAnchor(props: any, degrees: any): "end" | "start" | "middle";
 export declare function getPolarVerticalAnchor(props: any, degrees: any): "end" | "start" | "middle";
 export declare function getPolarAngle(props: any, baseAngle?: any): number;