victory-core 36.8.2 → 36.8.3

package/lib/victory-util/transitions.js

@@ -148,36 +148,37 @@ function getInitialChildProps(animate, data) {
 
 
 function getChildBeforeLoad(animate, child, data, cb) {
-  animate = (0, _assign2.default)({}, animate, {
+  var newAnimate = (0, _assign2.default)({}, animate, {
     onEnd: cb
   });
 
-  if (animate && animate.onLoad && !animate.onLoad.duration) {
+  if (newAnimate && newAnimate.onLoad && !newAnimate.onLoad.duration) {
     return {
-      animate: animate,
+      animate: newAnimate,
       data: data
     };
   }
 
-  var before = animate.onLoad && animate.onLoad.before ? animate.onLoad.before : _identity2.default; // If nodes need to exit, transform them with the provided onLoad.before function.
+  var before = newAnimate.onLoad && newAnimate.onLoad.before ? newAnimate.onLoad.before : _identity2.default; // If nodes need to exit, transform them with the provided onLoad.before function.
 
-  data = data.map(function (datum, idx) {
+  var newData = data.map(function (datum, idx) {
     return (0, _assign2.default)({}, datum, before(datum, idx, data));
   });
   return {
-    animate: animate,
-    data: data,
+    animate: newAnimate,
+    data: newData,
     clipWidth: 0
   };
 } // eslint-disable-next-line max-params
 
 
 function getChildOnLoad(animate, data, cb) {
-  animate = (0, _assign2.default)({}, animate, {
+  var newAnimate = (0, _assign2.default)({}, animate, {
     onEnd: cb
   });
+  var newData = data;
 
-  if (animate && animate.onLoad && !animate.onLoad.duration) {
+  if (newAnimate && newAnimate.onLoad && !newAnimate.onLoad.duration) {
     return {
       animate: animate,
       data: data
@@ -186,12 +187,12 @@ function getChildOnLoad(animate, data, cb) {
 
   var after = animate.onLoad && animate.onLoad.after ? animate.onLoad.after : _identity2.default; // If nodes need to exit, transform them with the provided onLoad.after function.
 
-  data = data.map(function (datum, idx) {
+  newData = data.map(function (datum, idx) {
     return (0, _assign2.default)({}, datum, after(datum, idx, data));
   });
   return {
-    animate: animate,
-    data: data
+    animate: newAnimate,
+    data: newData
   };
 } // eslint-disable-next-line max-params, max-len
 
@@ -200,7 +201,8 @@ function getChildPropsOnExit(animate, child, data, exitingNodes, cb) {
   // Whether or not _this_ child has exiting nodes, we want the exit-
   // transition for all children to have the same duration, delay, etc.
   var onExit = animate && animate.onExit;
-  animate = (0, _assign2.default)({}, animate, onExit);
+  var newAnimate = (0, _assign2.default)({}, animate, onExit);
+  var newData = data;
 
   if (exitingNodes) {
     // After the exit transition occurs, trigger the animations for
@@ -208,39 +210,42 @@ function getChildPropsOnExit(animate, child, data, exitingNodes, cb) {
     animate.onEnd = cb;
     var before = animate.onExit && animate.onExit.before ? animate.onExit.before : _identity2.default; // If nodes need to exit, transform them with the provided onExit.before function.
 
-    data = data.map(function (datum, idx) {
+    newData = data.map(function (datum, idx) {
       var key = (datum.key || idx).toString();
       return exitingNodes[key] ? (0, _assign2.default)({}, datum, before(datum, idx, data)) : datum;
     });
   }
 
   return {
-    animate: animate,
-    data: data
+    animate: newAnimate,
+    data: newData
   };
 } // eslint-disable-next-line max-params,max-len
 
 
 function getChildPropsBeforeEnter(animate, child, data, enteringNodes, cb) {
+  var newAnimate = animate;
+  var newData = data;
+
   if (enteringNodes) {
     // Perform a normal animation here, except - when it finishes - trigger
     // the transition for entering nodes.
-    animate = (0, _assign2.default)({}, animate, {
+    newAnimate = (0, _assign2.default)({}, animate, {
       onEnd: cb
     });
     var before = animate.onEnter && animate.onEnter.before ? animate.onEnter.before : _identity2.default; // We want the entering nodes to be included in the transition target
     // domain.  However, we may not want these nodes to be displayed initially,
     // so perform the `onEnter.before` transformation on each node.
 
-    data = data.map(function (datum, idx) {
+    newData = data.map(function (datum, idx) {
       var key = (datum.key || idx).toString();
       return enteringNodes[key] ? (0, _assign2.default)({}, datum, before(datum, idx, data)) : datum;
     });
   }
 
   return {
-    animate: animate,
-    data: data
+    animate: newAnimate,
+    data: newData
   };
 } // eslint-disable-next-line max-params, max-len
 
@@ -249,23 +254,24 @@ function getChildPropsOnEnter(animate, data, enteringNodes, cb) {
   // Whether or not _this_ child has entering nodes, we want the entering-
   // transition for all children to have the same duration, delay, etc.
   var onEnter = animate && animate.onEnter;
-  animate = (0, _assign2.default)({}, animate, onEnter);
+  var newAnimate = (0, _assign2.default)({}, animate, onEnter);
+  var newData = data;
 
   if (enteringNodes) {
     // Old nodes have been transitioned to their new values, and the
     // domain should encompass the nodes that will now enter. So perform
     // the `onEnter.after` transformation on each node.
-    animate.onEnd = cb;
-    var after = animate.onEnter && animate.onEnter.after ? animate.onEnter.after : _identity2.default;
-    data = data.map(function (datum, idx) {
+    newAnimate.onEnd = cb;
+    var after = newAnimate.onEnter && newAnimate.onEnter.after ? newAnimate.onEnter.after : _identity2.default;
+    newData = data.map(function (datum, idx) {
       var key = getDatumKey(datum, idx);
       return enteringNodes[key] ? (0, _assign2.default)({}, datum, after(datum, idx, data)) : datum;
     });
   }
 
   return {
-    animate: animate,
-    data: data
+    animate: newAnimate,
+    data: newData
   };
 }
 /**

package/lib/victory-util/user-props.d.ts

@@ -1,5 +1,11 @@
 import * as React from "react";
 declare type SafeAttribute = string;
+/**
+ * Asserts that value is not null or undefined, throwing an error if it is.
+ * @param value The value to assert
+ * @param message The error message to throw
+ */
+export declare function assert<T>(value: T, message?: string): asserts value is NonNullable<T>;
 /**
  * getSafeUserProps - function that takes in a props object and removes any
  * key-value entries that do not match filter strings in the USER_PROPS_SAFELIST

package/lib/victory-util/user-props.js

@@ -3,6 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.assert = assert;
 exports.withSafeUserProps = exports.getSafeUserProps = void 0;
 
 var React = _interopRequireWildcard(require("react"));
@@ -84,6 +85,18 @@ var testIfSafeProp = function (key) {
   if (doesPropStartWith(key) || isExactMatch(key)) return true;
   return false;
 };
+/**
+ * Asserts that value is not null or undefined, throwing an error if it is.
+ * @param value The value to assert
+ * @param message The error message to throw
+ */
+
+
+function assert(value, message) {
+  if (value === undefined || value === null) {
+    throw new Error(message);
+  }
+}
 /**
  * getSafeUserProps - function that takes in a props object and removes any
  * key-value entries that do not match filter strings in the USER_PROPS_SAFELIST

package/lib/victory-util/wrapper.js

@@ -161,12 +161,13 @@ function getDataFromChildren(props, childComponents) {
   var iteratee = function (child, childName, parent) {
     var childProps = (0, _assign2.default)({}, child.props, parentProps);
     var childData;
+    var childElement = child;
 
     if (!Data.isDataComponent(child)) {
       return null;
     } else if (child.type && (0, _isFunction2.default)(child.type.getData)) {
-      child = parent ? /*#__PURE__*/_react.default.cloneElement(child, parent.props) : child;
-      childData = child.type.getData(childProps);
+      childElement = parent ? /*#__PURE__*/_react.default.cloneElement(child, parent.props) : child;
+      childData = childElement.type.getData(childProps);
     } else {
       childData = Data.getData(childProps);
     }
@@ -198,8 +199,7 @@ function getData(props, childComponents) {
     return Data.getData(props);
   }
 
-  childComponents = childComponents || _react.default.Children.toArray(props.children);
-  return getDataFromChildren(props, childComponents);
+  return getDataFromChildren(props, childComponents || _react.default.Children.toArray(props.children));
 }
 
 function getWidth(props, groupLength, seriesLength) {
@@ -207,9 +207,9 @@ function getWidth(props, groupLength, seriesLength) {
       horizontal = props.horizontal;
   var range = horizontal ? Helpers.getRange(props, "y") : Helpers.getRange(props, "x");
   var extent = Math.abs(range[1] - range[0]);
-  seriesLength = seriesLength !== undefined ? seriesLength : Array.isArray(datasets[0]) && datasets[0].length || 1;
-  groupLength = groupLength || datasets.length;
-  var bars = groupLength * seriesLength;
+  var seriesLengthValue = seriesLength !== undefined ? seriesLength : Array.isArray(datasets[0]) && datasets[0].length || 1;
+  var groupLengthValue = groupLength || datasets.length;
+  var bars = groupLengthValue * seriesLengthValue;
   var barRatio = 0.5;
   return Math.round(barRatio * extent / bars);
 }
@@ -304,9 +304,10 @@ function getDomainFromChildren(props, axis, childComponents) {
 }
 
 function getDomain(props, axis, childComponents) {
-  childComponents = childComponents || _react.default.Children.toArray(props.children);
+  var children = childComponents || _react.default.Children.toArray(props.children);
+
   var propsDomain = Domain.getDomainFromProps(props, axis);
-  var domainPadding = getDefaultDomainPadding(props, axis, childComponents);
+  var domainPadding = getDefaultDomainPadding(props, axis, children);
   var domain;
 
   if (propsDomain) {
@@ -316,7 +317,7 @@ function getDomain(props, axis, childComponents) {
     var maxDomain = Domain.getMaxFromProps(props, axis);
     var dataset = (props.data || props.y) && Data.getData(props);
     var dataDomain = dataset ? Domain.getDomainFromData(props, axis, dataset) : [];
-    var childDomain = getDomainFromChildren(props, axis, childComponents);
+    var childDomain = getDomainFromChildren(props, axis, children);
     var min = minDomain || Collection.getMinValue([].concat(_toConsumableArray(dataDomain), _toConsumableArray(childDomain)));
     var max = maxDomain || Collection.getMaxValue([].concat(_toConsumableArray(dataDomain), _toConsumableArray(childDomain)));
     domain = Domain.getDomainFromMinMax(min, max);
@@ -482,10 +483,11 @@ function getCategoryAndAxisStringsFromChildren(props, axis, childComponents) {
 }
 
 function getStringsFromChildren(props, childComponents) {
-  childComponents = childComponents || _react.default.Children.toArray(props.children);
-  var xStrings = getCategoryAndAxisStringsFromChildren(props, "x", childComponents);
-  var yStrings = getCategoryAndAxisStringsFromChildren(props, "y", childComponents);
-  var dataStrings = getStringsFromData(childComponents);
+  var children = childComponents || _react.default.Children.toArray(props.children);
+
+  var xStrings = getCategoryAndAxisStringsFromChildren(props, "x", children);
+  var yStrings = getCategoryAndAxisStringsFromChildren(props, "y", children);
+  var dataStrings = getStringsFromData(children);
   return {
     x: (0, _uniq2.default)((0, _flatten2.default)([].concat(_toConsumableArray(xStrings), _toConsumableArray(dataStrings.x)))),
     y: (0, _uniq2.default)((0, _flatten2.default)([].concat(_toConsumableArray(yStrings), _toConsumableArray(dataStrings.y))))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "victory-core",
-  "version": "36.8.2",
+  "version": "36.8.3",
   "description": "Victory Core",
   "keywords": [
     "data visualization",
@@ -23,7 +23,7 @@
     "lodash": "^4.17.21",
     "prop-types": "^15.8.1",
     "react-fast-compare": "^3.2.0",
-    "victory-vendor": "^36.8.2"
+    "victory-vendor": "^36.8.3"
   },
   "peerDependencies": {
     "react": ">=16.6.0"

package/src/types/callbacks.ts

@@ -1,4 +1,4 @@
-import { D3Scale, Datum, ID } from "./prop-types";
+import { D3Scale, Datum, ID, ScalePropType } from "./prop-types";
 import { BlockProps, OrientationTypes } from "../victory-theme/types";
 
 /**
@@ -16,10 +16,13 @@ export interface CallbackArgs {
   index?: ID;
   x?: number;
   y?: number;
-  scale?: {
-    x?: D3Scale;
-    y?: D3Scale;
-  };
+  scale?:
+    | ScalePropType
+    | D3Scale
+    | {
+        x?: ScalePropType | D3Scale;
+        y?: ScalePropType | D3Scale;
+      };
   tick?: any;
   ticks?: any;
   text?: any;

package/src/victory-animation/util.ts

@@ -97,11 +97,11 @@ export const interpolateFunction = function (a, b) {
  * differs in that it uses our custom interpolators when interpolating the value of each property in
  * an object. This allows the correct interpolation of nested objects, including styles
  *
- * @param {any} a - Start value.
- * @param {any} b - End value.
+ * @param {any} startValue - Start value.
+ * @param {any} endValue - End value.
  * @returns {Function} An interpolation function.
  */
-export const interpolateObject = function (a, b) {
+export const interpolateObject = function (startValue, endValue) {
   const interpolateTypes = (x, y) => {
     if (x === y || !isInterpolatable(x) || !isInterpolatable(y)) {
       return interpolateImmediate(x, y);
@@ -126,6 +126,8 @@ export const interpolateObject = function (a, b) {
 
   const i = {};
   const c = {};
+  let a = startValue;
+  let b = endValue;
   let k;
 
   if (a === null || typeof a !== "object") {

package/src/victory-animation/victory-animation.tsx

@@ -259,8 +259,9 @@ export class VictoryAnimation extends React.Component<
       step can generate imprecise values, sometimes greater than 1
       if this happens set the state to 1 and return, cancelling the timer
     */
-    duration = duration !== undefined ? duration : this.props.duration;
-    const step = duration ? elapsed / duration : 1;
+    const animationDuration =
+      duration !== undefined ? duration : this.props.duration;
+    const step = animationDuration ? elapsed / animationDuration : 1;
     if (step >= 1) {
       this.setState({
         data: this.interpolator!(1),

package/src/victory-label/victory-label.tsx

@@ -38,7 +38,7 @@ export interface VictoryLabelProps {
   capHeight?: StringOrNumberOrCallback;
   children?: StringOrNumberOrCallback;
   className?: string;
-  datum?: object;
+  datum?: Record<string, any>;
   data?: any[];
   desc?: string;
   direction?: string;
@@ -121,8 +121,10 @@ const getStyles = (style, props) => {
     };
   }
   const getSingleStyle = (s) => {
-    s = s ? defaults({}, s, defaultStyles) : defaultStyles;
-    const baseStyles = Helpers.evaluateStyle(s, props);
+    const baseStyles = Helpers.evaluateStyle(
+      s ? defaults({}, s, defaultStyles) : defaultStyles,
+      props,
+    );
     return assign({}, baseStyles, { fontSize: getFontSize(baseStyles) });
   };
 
@@ -320,21 +322,20 @@ const getInlineXOffset = (calculatedProps, textElements, index) => {
   const centerOffset = -totalWidth / 2;
   switch (textAnchor) {
     case "start":
-      return widths.reduce((memo, width, i) => {
-        memo = i < index ? memo + width : memo;
-        return memo;
-      }, 0);
+      return widths.reduce(
+        (memo, width, i) => (i < index ? memo + width : memo),
+        0,
+      );
     case "end":
-      return widths.reduce((memo, width, i) => {
-        memo = i > index ? memo - width : memo;
-        return memo;
-      }, 0);
+      return widths.reduce(
+        (memo, width, i) => (i > index ? memo - width : memo),
+        0,
+      );
     default:
       // middle
       return widths.reduce((memo, width, i) => {
         const offsetWidth = i < index ? width : 0;
-        memo = i === index ? memo + width / 2 : memo + offsetWidth;
-        return memo;
+        return i === index ? memo + width / 2 : memo + offsetWidth;
       }, centerOffset);
   }
 };
@@ -584,8 +585,8 @@ const defaultProps = {
 export const VictoryLabel: {
   role: string;
   defaultStyles: typeof defaultStyles;
-} & React.FC<VictoryLabelProps> = (props) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+} & React.FC<VictoryLabelProps> = (initialProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
 
   if (props.text === null || props.text === undefined) {
     return null;
@@ -596,7 +597,7 @@ export const VictoryLabel: {
     calculatedProps;
 
   const tspanValues = (text as string[]).map((line, i) => {
-    const currentStyle = getSingleValue(style!, i);
+    const currentStyle = getSingleValue(style, i);
     const capHeightPx = TextSize.convertLengthToPixels(
       `${capHeight}em`,
       currentStyle.fontSize as number,
@@ -607,7 +608,7 @@ export const VictoryLabel: {
       fontSize: currentStyle.fontSize || defaultStyles.fontSize,
       capHeight: capHeightPx,
       text: line,
-      // @ts-expect-error TODO: This looks like a bug:
+      // TODO: This looks like a bug:
       textSize: TextSize.approximateTextSize(line, currentStyle),
       lineHeight: currentLineHeight,
       backgroundPadding: getSingleValue(backgroundPadding, i),

package/src/victory-primitives/arc.tsx

@@ -68,8 +68,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const Arc = (props: ArcProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const Arc = (initialProps: ArcProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
 
   return React.cloneElement(props.pathComponent!, {
     ...props.events,

package/src/victory-primitives/background.tsx

@@ -37,8 +37,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const Background = (props: BackgroundProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const Background = (initialProps: BackgroundProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
 
   return props.polar
     ? React.cloneElement(props.circleComponent!, {

package/src/victory-primitives/border.tsx

@@ -43,8 +43,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const Border = (props: BorderProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const Border = (initialProps: BorderProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
 
   return React.cloneElement(props.rectComponent!, {
     ...props.events,

package/src/victory-primitives/line-segment.tsx

@@ -44,8 +44,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const LineSegment = (props: LineSegmentProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const LineSegment = (initialProps: LineSegmentProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
 
   return React.cloneElement(props.lineComponent!, {
     ...props.events,

package/src/victory-primitives/point.tsx

@@ -72,8 +72,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const Point = (props: PointProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const Point = (initialProps: PointProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
   const userProps = UserProps.getSafeUserProps(props);
 
   return React.cloneElement(props.pathComponent!, {

package/src/victory-primitives/whisker.tsx

@@ -47,8 +47,8 @@ const defaultProps = {
   shapeRendering: "auto",
 };
 
-export const Whisker = (props: WhiskerProps) => {
-  props = evaluateProps({ ...defaultProps, ...props });
+export const Whisker = (initialProps: WhiskerProps) => {
+  const props = evaluateProps({ ...defaultProps, ...initialProps });
   const {
     ariaLabel,
     groupComponent,
@@ -77,9 +77,9 @@ export const Whisker = (props: WhiskerProps) => {
     shapeRendering,
   };
 
-  return React.cloneElement(groupComponent!, {}, [
+  return React.cloneElement(groupComponent, {}, [
     React.cloneElement(
-      lineComponent!,
+      lineComponent,
       assign(
         { key: "major-whisker", "aria-label": ariaLabel },
         baseProps,
@@ -87,7 +87,7 @@ export const Whisker = (props: WhiskerProps) => {
       ),
     ),
     React.cloneElement(
-      lineComponent!,
+      lineComponent,
       assign(
         { key: "minor-whisker", "aria-label": ariaLabel },
         baseProps,

package/src/victory-util/add-events.tsx

@@ -270,12 +270,10 @@ export function addEvents<
     applyExternalMutations(props, externalMutations) {
       if (!isEmpty(externalMutations)) {
         const callbacks = props.externalEventMutations.reduce(
-          (memo, mutation) => {
-            memo = isFunction(mutation.callback)
+          (memo, mutation) =>
+            isFunction(mutation.callback)
               ? memo.concat(mutation.callback)
-              : memo;
-            return memo;
-          },
+              : memo,
           [] as Array<() => void>,
         );
         const compiledCallbacks = callbacks.length
@@ -327,9 +325,9 @@ export function addEvents<
     }
 
     getBaseProps(props, getSharedEventState): this["baseProps"] {
-      getSharedEventState =
+      const getSharedEventStateFunction =
         getSharedEventState || this.getSharedEventState.bind(this);
-      const sharedParentState = getSharedEventState("parent", "parent");
+      const sharedParentState = getSharedEventStateFunction("parent", "parent");
       const parentState = this.getEventState("parent", "parent");
       const baseParentProps = defaults({}, parentState, sharedParentState);
       const parentPropsList = baseParentProps.parentControlledProps;
@@ -437,6 +435,7 @@ export function addEvents<
       const { dataComponent, labelComponent, groupComponent } = props;
       const dataKeys = without(this.dataKeys, "all");
       const labelComponents = dataKeys.reduce((memo, key) => {
+        let newMemo = memo;
         const labelProps = this.getComponentProps(
           labelComponent,
           "labels",
@@ -447,9 +446,11 @@ export function addEvents<
           labelProps.text !== undefined &&
           labelProps.text !== null
         ) {
-          memo = memo.concat(React.cloneElement(labelComponent!, labelProps));
+          newMemo = newMemo.concat(
+            React.cloneElement(labelComponent!, labelProps),
+          );
         }
-        return memo;
+        return newMemo;
       }, [] as React.ReactElement[]);
 
       const dataProps = this.getComponentProps(dataComponent, "data", "all");

package/src/victory-util/axis.tsx

@@ -36,10 +36,14 @@ export function getAxis(props) {
  * @returns {Array} all axis components that pass the given predicate or []
  */
 export function findAxisComponents(childComponents, predicate?) {
-  predicate = predicate || identity;
+  const predicateFunction = predicate || identity;
   const findAxes = (children) => {
     return children.reduce((memo, child) => {
-      if (child.type && child.type.role === "axis" && predicate(child)) {
+      if (
+        child.type &&
+        child.type.role === "axis" &&
+        predicateFunction(child)
+      ) {
         return memo.concat(child);
       } else if (child.props && child.props.children) {
         return memo.concat(

package/src/victory-util/common-props.tsx

@@ -95,6 +95,7 @@ export interface VictoryCommonThemeProps {
   animate?: boolean | AnimatePropTypeInterface;
   colorScale?: ColorScalePropType;
   containerComponent?: React.ReactElement;
+  disableInlineStyles?: boolean;
   domainPadding?: DomainPaddingPropType;
   externalEventMutations?: EventCallbackInterface<
     string | string[],

package/src/victory-util/data.ts

@@ -58,11 +58,12 @@ function sortData(dataset, sortKey, sortOrder = "ascending") {
   }
 
   // Ensures previous VictoryLine api for sortKey prop stays consistent
+  let formattedSortKey = sortKey;
   if (sortKey === "x" || sortKey === "y") {
-    sortKey = `_${sortKey}`;
+    formattedSortKey = `_${sortKey}`;
   }
   const order = sortOrder === "ascending" ? "asc" : "desc";
-  return orderBy(dataset, sortKey, order);
+  return orderBy(dataset, formattedSortKey, order);
 }
 
 // This method will remove data points that break certain scales. (log scale only)
@@ -239,6 +240,9 @@ export function formatData(
   }
 
   const defaultKeys = ["x", "y", "y0"];
+  // TODO: We shouldn’t mutate the expectedKeys param here,
+  // but we need to figure out why changing it causes regressions in tests.
+  // eslint-disable-next-line no-param-reassign
   expectedKeys = Array.isArray(expectedKeys) ? expectedKeys : defaultKeys;
 
   const createAccessor = (name) => {
@@ -281,10 +285,10 @@ export function formatData(
     ? dataset
     : dataset.reduce((dataArr, datum, index) => {
         // eslint-disable-line complexity
-        datum = parseDatum(datum);
-        const fallbackValues = { x: index, y: datum };
+        const parsedDatum = parseDatum(datum);
+        const fallbackValues = { x: index, y: parsedDatum };
         const processedValues = expectedKeys!.reduce((memo, type) => {
-          const processedValue = accessor[type](datum);
+          const processedValue = accessor[type](parsedDatum);
           const value =
             processedValue !== undefined
               ? processedValue
@@ -300,7 +304,7 @@ export function formatData(
           return memo;
         }, {});
 
-        const formattedDatum = assign({}, processedValues, datum);
+        const formattedDatum = assign({}, processedValues, parsedDatum);
         if (!isEmpty(formattedDatum)) {
           dataArr.push(formattedDatum);
         }
@@ -408,8 +412,8 @@ export function getStringsFromData(props, axis) {
   const sortedData = sortData(data, props.sortKey, props.sortOrder);
   const dataStrings = sortedData
     .reduce((dataArr, datum) => {
-      datum = parseDatum(datum);
-      dataArr.push(accessor(datum));
+      const parsedDatum = parseDatum(datum);
+      dataArr.push(accessor(parsedDatum));
       return dataArr;
     }, [])
     .filter((datum) => typeof datum === "string");