victory-core 36.6.10 → 36.6.12

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # victory-core
 
+## 36.6.12
+
+### Patch Changes
+
+- Add aria-hidden flag to svg for textsize util to fix accessibility issue ([#2661](https://github.com/FormidableLabs/victory/pull/2661))
+
+## 36.6.11
+
+### Patch Changes
+
+- Fix text size regression when using line-height ([#2615](https://github.com/FormidableLabs/victory/pull/2615))
+
 ## 36.6.10
 
 ### Patch Changes

package/README.md

@@ -17,4 +17,4 @@
 Please visit our documentation site to read more about these components
 https://formidable.com/open-source/victory
 
-To suggest an addition or correction to this documentation please see https://github.com/FormidableLabs/victory/blob/main/docs/src/content/docs
+To suggest an addition or correction to this documentation please see https://github.com/FormidableLabs/victory/blob/main/docs/src/content/docs

package/dist/victory-core.js

@@ -8888,6 +8888,10 @@ var _approximateDimensionsInternal = function (text, style) {
 var _getMeasurementContainer = lodash_memoize__WEBPACK_IMPORTED_MODULE_0___default()(function () {
   var element = document.createElementNS("http://www.w3.org/2000/svg", "svg");
   element.setAttribute("xlink", "http://www.w3.org/1999/xlink");
+  element.setAttribute("width", "300");
+  element.setAttribute("height", "300");
+  element.setAttribute("viewBox", "0 0 300 300");
+  element.setAttribute("aria-hidden", "true");
   var containerElement = document.createElementNS("http://www.w3.org/2000/svg", "text");
   element.appendChild(containerElement);
   element.style.position = "fixed";
@@ -8922,7 +8926,6 @@ var _measureDimensionsInternal = lodash_memoize__WEBPACK_IMPORTED_MODULE_0___def
     var params = _prepareParams(style, i);
 
     textElement.style.fontFamily = params.fontFamily;
-    textElement.style.transform = "rotate(".concat(params.angle, ")");
     textElement.style.fontSize = "".concat(params.fontSize, "px");
     textElement.style.lineHeight = params.lineHeight;
     textElement.style.fontFamily = params.fontFamily;
@@ -8930,18 +8933,17 @@ var _measureDimensionsInternal = lodash_memoize__WEBPACK_IMPORTED_MODULE_0___def
     textElement.textContent = line;
     textElement.setAttribute("x", "0");
     textElement.setAttribute("y", "".concat(heightAcc));
-    heightAcc += params.lineHeight * params.fontSize;
     containerElement.appendChild(textElement);
+    heightAcc += params.lineHeight * textElement.getBoundingClientRect().height;
   }
 
   var _containerElement$get = containerElement.getBoundingClientRect(),
-      width = _containerElement$get.width,
-      height = _containerElement$get.height;
+      width = _containerElement$get.width;
 
   containerElement.innerHTML = "";
   return {
-    width: width,
-    height: height
+    width: style !== null && style !== void 0 && style.angle ? _getSizeWithRotate(width, heightAcc, style === null || style === void 0 ? void 0 : style.angle) : width,
+    height: style !== null && style !== void 0 && style.angle ? _getSizeWithRotate(heightAcc, width, style === null || style === void 0 ? void 0 : style.angle) : heightAcc
   };
 }, function (text, style) {
   var totalText = Array.isArray(text) ? text.join() : text;