victory-core 17.2.6 → 17.2.7

package/CHANGELOG.md

@@ -1,6 +1,11 @@
 VictoryCore Changelog
 =====================
 
+## 17.2.7 (2017-08-22)
+
+- [291](https://github.com/FormidableLabs/victory-core/pull/291) Domain should include negative y0 values
+- [292](https://github.com/FormidableLabs/victory-core/pull/292) Fix single point domain logic for dates
+
 ## 17.2.6 (2017-08-19)
 
 - [290](https://github.com/FormidableLabs/victory-core/pull/290) Bugfix: VictoryPortal with VictoryZoomContainer

package/dist/victory-core.js

@@ -25239,27 +25239,36 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
    * @returns {Array} the domain for the given axis
    */
   getDomainWithZero: function (props, axis) {
-    var _this = this;
-
     var propsDomain = this.getDomainFromProps(props, axis);
     if (propsDomain) {
       return this.cleanDomain(this.padDomain(propsDomain, props, axis), props, axis);
     }
     var horizontal = props.horizontal;
 
-    var ensureZero = function (domain) {
-      var isDependent = axis === "y" && !horizontal || axis === "x" && horizontal;
-      var min = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue(domain, 0);
-      var max = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMaxValue(domain, 0);
-      var zeroDomain = isDependent ? [min, max] : domain;
-      return _this.padDomain(zeroDomain, props, axis);
+    var ensureZero = function (domain, dataset) {
+      var currentAxis = __WEBPACK_IMPORTED_MODULE_6__helpers__["a" /* default */].getCurrentAxis(axis, horizontal);
+      if (currentAxis === "x") {
+        return domain;
+      } else if (!dataset) {
+        return [__WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue(domain, 0), __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMaxValue(domain, 0)];
+      }
+      var flatData = __WEBPACK_IMPORTED_MODULE_3_lodash_flatten___default()(dataset);
+      var minData = flatData.map(function (datum) {
+        return datum["_" + currentAxis + "0"] || 0;
+      });
+      var maxData = flatData.map(function (datum) {
+        return datum["_" + currentAxis + "1"] || datum["_" + currentAxis] || 0;
+      });
+      var min = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue([].concat(_toConsumableArray(domain), _toConsumableArray(minData)));
+      var max = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMaxValue([].concat(_toConsumableArray(domain), _toConsumableArray(maxData)));
+      return [min, max];
     };
     var categoryDomain = this.getDomainFromCategories(props, axis);
     if (categoryDomain) {
       return this.cleanDomain(this.padDomain(ensureZero(categoryDomain), props, axis), props, axis);
     }
     var dataset = __WEBPACK_IMPORTED_MODULE_4__data__["a" /* default */].getData(props);
-    var domain = ensureZero(this.getDomainFromData(props, axis, dataset));
+    var domain = ensureZero(this.getDomainFromData(props, axis, dataset), dataset);
     return this.cleanDomain(this.padDomain(domain, props, axis), props, axis);
   },
 
@@ -25289,18 +25298,21 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
    */
   getDomainFromData: function (props, axis, dataset) {
     var currentAxis = __WEBPACK_IMPORTED_MODULE_6__helpers__["a" /* default */].getCurrentAxis(axis, props.horizontal);
-    var allData = __WEBPACK_IMPORTED_MODULE_3_lodash_flatten___default()(dataset).map(function (datum) {
-      return datum["_" + currentAxis];
+    var flatData = __WEBPACK_IMPORTED_MODULE_3_lodash_flatten___default()(dataset);
+    var allData = flatData.map(function (datum) {
+      return typeof datum["_" + currentAxis + "1"] === "undefined" ? datum["_" + currentAxis] : datum["_" + currentAxis + "1"];
+    });
+    var allMinData = flatData.map(function (datum) {
+      return typeof datum["_" + currentAxis + "0"] === "undefined" ? datum["_" + currentAxis] : datum["_" + currentAxis + "0"];
     });
-
     if (allData.length < 1) {
       return __WEBPACK_IMPORTED_MODULE_5__scale__["a" /* default */].getBaseScale(props, axis).domain();
     }
 
-    var min = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue(allData);
+    var min = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue(allMinData);
     var max = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMaxValue(allData);
     var domain = void 0;
-    if (min === max) {
+    if (+min === +max) {
       domain = this.getSinglePointDomain(max);
     } else {
       domain = [min, max];
@@ -25311,10 +25323,11 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
   getSinglePointDomain: function (val) {
     // d3-scale does not properly resolve very small differences.
     // eslint-disable-next-line no-magic-numbers
-    var verySmallNumber = Math.pow(10, -15);
-    var adjustedMin = val instanceof Date ? new Date(val - 1) : val - verySmallNumber;
-    var adjustedMax = val instanceof Date ? new Date(val + 1) : val + verySmallNumber;
-    return [adjustedMin, adjustedMax];
+    var verySmallNumber = Math.pow(10, -10);
+    var verySmallDate = 1;
+    var min = val instanceof Date ? new Date(+val - verySmallDate) : val - verySmallNumber;
+    var max = val instanceof Date ? new Date(+val + verySmallDate) : val + verySmallNumber;
+    return [min, max];
   },
   getSymmetricDomain: function (domain, data) {
     var processedData = __WEBPACK_IMPORTED_MODULE_0_lodash_sortedUniq___default()(data.sort(function (a, b) {
@@ -25405,8 +25418,8 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
     // use greatest min / max
     var domainMin = cumulativeMin < 0 ? cumulativeMin : __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMinValue(globalDomain);
     var domainMax = __WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */].getMaxValue.apply(__WEBPACK_IMPORTED_MODULE_7__collection__["a" /* default */], [globalDomain].concat(_toConsumableArray(cumulativeMaxArray)));
-    if (domainMin === domainMax) {
-      return this.getSinglePointDomain(domainMax);
+    if (+domainMin === +domainMax) {
+      return this.getSinglePointDomain(domainMin);
     }
     return [domainMin, domainMax];
   },