victory-chart 36.8.1 → 36.8.2

package/es/victory-chart.js

@@ -42,7 +42,9 @@ var defaultProps = {
 };
 
 var VictoryChartImpl = function (initialProps) {
-  initialProps = _objectSpread(_objectSpread({}, defaultProps), initialProps);
+  var propsWithDefaults = React.useMemo(function () {
+    return _objectSpread(_objectSpread({}, defaultProps), initialProps);
+  }, [initialProps]);
   var role = "chart";
 
   var _Hooks$useAnimationSt = Hooks.useAnimationState(),
@@ -50,7 +52,7 @@ var VictoryChartImpl = function (initialProps) {
       setAnimationState = _Hooks$useAnimationSt.setAnimationState,
       getProps = _Hooks$useAnimationSt.getProps;
 
-  var props = getProps(initialProps);
+  var props = getProps(propsWithDefaults);
   var modifiedProps = Helpers.modifyProps(props, fallbackProps, role);
   var desc = modifiedProps.desc,
       eventKey = modifiedProps.eventKey,
@@ -116,25 +118,25 @@ var VictoryChartImpl = function (initialProps) {
   }, [desc, domain, height, horizontal, name, origin, polar, scale, standalone, style, title, theme, width]);
   var container = React.useMemo(function () {
     if (standalone) {
-      var defaultContainerProps = _defaults({}, containerComponent.props, containerProps, UserProps.getSafeUserProps(initialProps));
+      var defaultContainerProps = _defaults({}, containerComponent.props, containerProps, UserProps.getSafeUserProps(propsWithDefaults));
 
       return /*#__PURE__*/React.cloneElement(containerComponent, defaultContainerProps);
     }
 
     return groupComponent;
-  }, [groupComponent, standalone, containerComponent, containerProps, initialProps]);
+  }, [groupComponent, standalone, containerComponent, containerProps, propsWithDefaults]);
   var events = React.useMemo(function () {
     return Wrapper.getAllEvents(props);
   }, [props]);
-  var previousProps = Hooks.usePreviousProps(initialProps);
+  var previousProps = Hooks.usePreviousProps(propsWithDefaults);
   React.useEffect(function () {
     // This is called before dismount to keep state in sync
     return function () {
-      if (initialProps.animate) {
-        setAnimationState(previousProps, initialProps);
+      if (propsWithDefaults.animate) {
+        setAnimationState(previousProps, propsWithDefaults);
       }
     };
-  }, [setAnimationState, previousProps, initialProps]);
+  }, [setAnimationState, previousProps, propsWithDefaults]);
 
   if (!_isEmpty(events)) {
     return /*#__PURE__*/React.createElement(VictorySharedEvents, {

package/lib/victory-chart.js

@@ -61,7 +61,10 @@ var defaultProps = {
 };
 
 var VictoryChartImpl = function (initialProps) {
-  initialProps = _objectSpread(_objectSpread({}, defaultProps), initialProps);
+  var propsWithDefaults = _react.default.useMemo(function () {
+    return _objectSpread(_objectSpread({}, defaultProps), initialProps);
+  }, [initialProps]);
+
   var role = "chart";
 
   var _Hooks$useAnimationSt = _victoryCore.Hooks.useAnimationState(),
@@ -69,7 +72,7 @@ var VictoryChartImpl = function (initialProps) {
       setAnimationState = _Hooks$useAnimationSt.setAnimationState,
       getProps = _Hooks$useAnimationSt.getProps;
 
-  var props = getProps(initialProps);
+  var props = getProps(propsWithDefaults);
 
   var modifiedProps = _victoryCore.Helpers.modifyProps(props, fallbackProps, role);
 
@@ -142,27 +145,27 @@ var VictoryChartImpl = function (initialProps) {
 
   var container = _react.default.useMemo(function () {
     if (standalone) {
-      var defaultContainerProps = (0, _defaults2.default)({}, containerComponent.props, containerProps, _victoryCore.UserProps.getSafeUserProps(initialProps));
+      var defaultContainerProps = (0, _defaults2.default)({}, containerComponent.props, containerProps, _victoryCore.UserProps.getSafeUserProps(propsWithDefaults));
       return /*#__PURE__*/_react.default.cloneElement(containerComponent, defaultContainerProps);
     }
 
     return groupComponent;
-  }, [groupComponent, standalone, containerComponent, containerProps, initialProps]);
+  }, [groupComponent, standalone, containerComponent, containerProps, propsWithDefaults]);
 
   var events = _react.default.useMemo(function () {
     return _victoryCore.Wrapper.getAllEvents(props);
   }, [props]);
 
-  var previousProps = _victoryCore.Hooks.usePreviousProps(initialProps);
+  var previousProps = _victoryCore.Hooks.usePreviousProps(propsWithDefaults);
 
   _react.default.useEffect(function () {
     // This is called before dismount to keep state in sync
     return function () {
-      if (initialProps.animate) {
-        setAnimationState(previousProps, initialProps);
+      if (propsWithDefaults.animate) {
+        setAnimationState(previousProps, propsWithDefaults);
       }
     };
-  }, [setAnimationState, previousProps, initialProps]);
+  }, [setAnimationState, previousProps, propsWithDefaults]);
 
   if (!(0, _isEmpty2.default)(events)) {
     return /*#__PURE__*/_react.default.createElement(_victorySharedEvents.VictorySharedEvents, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "victory-chart",
-  "version": "36.8.1",
+  "version": "36.8.2",
   "description": "Chart Component for Victory",
   "keywords": [
     "data visualization",
@@ -23,10 +23,10 @@
     "lodash": "^4.17.19",
     "prop-types": "^15.8.1",
     "react-fast-compare": "^3.2.0",
-    "victory-axis": "^36.8.1",
-    "victory-core": "^36.8.1",
-    "victory-polar-axis": "^36.8.1",
-    "victory-shared-events": "^36.8.1"
+    "victory-axis": "^36.8.2",
+    "victory-core": "^36.8.2",
+    "victory-polar-axis": "^36.8.2",
+    "victory-shared-events": "^36.8.2"
   },
   "peerDependencies": {
     "react": ">=16.6.0"

package/src/victory-chart.tsx

@@ -53,11 +53,14 @@ const defaultProps = {
 };
 
 const VictoryChartImpl: React.FC<VictoryChartProps> = (initialProps) => {
-  initialProps = { ...defaultProps, ...initialProps };
+  const propsWithDefaults = React.useMemo(
+    () => ({ ...defaultProps, ...initialProps }),
+    [initialProps],
+  );
   const role = "chart";
   const { getAnimationProps, setAnimationState, getProps } =
     Hooks.useAnimationState();
-  const props = getProps(initialProps);
+  const props = getProps(propsWithDefaults);
 
   const modifiedProps = Helpers.modifyProps(props, fallbackProps, role);
   const {
@@ -154,7 +157,7 @@ const VictoryChartImpl: React.FC<VictoryChartProps> = (initialProps) => {
         {},
         containerComponent.props,
         containerProps,
-        UserProps.getSafeUserProps(initialProps),
+        UserProps.getSafeUserProps(propsWithDefaults),
       );
       return React.cloneElement(containerComponent, defaultContainerProps);
     }
@@ -164,23 +167,23 @@ const VictoryChartImpl: React.FC<VictoryChartProps> = (initialProps) => {
     standalone,
     containerComponent,
     containerProps,
-    initialProps,
+    propsWithDefaults,
   ]);
 
   const events = React.useMemo(() => {
     return Wrapper.getAllEvents(props);
   }, [props]);
 
-  const previousProps = Hooks.usePreviousProps(initialProps);
+  const previousProps = Hooks.usePreviousProps(propsWithDefaults);
 
   React.useEffect(() => {
     // This is called before dismount to keep state in sync
     return () => {
-      if (initialProps.animate) {
-        setAnimationState(previousProps, initialProps);
+      if (propsWithDefaults.animate) {
+        setAnimationState(previousProps, propsWithDefaults);
       }
     };
-  }, [setAnimationState, previousProps, initialProps]);
+  }, [setAnimationState, previousProps, propsWithDefaults]);
 
   if (!isEmpty(events)) {
     return (