victory-chart 18.2.0 → 19.1.1

package/src/components/victory-bar/victory-bar.js

@@ -1,10 +1,11 @@
-import React, { PropTypes } from "react";
+import PropTypes from "prop-types";
+import React from "react";
 import BarHelpers from "./helper-methods";
 import { partialRight } from "lodash";
 import {
-  PropTypes as CustomPropTypes, Helpers, VictoryTransition, VictoryLabel, VictoryContainer,
-  VictoryTheme, Bar, addEvents, Data, Domain
+  Helpers, VictoryLabel, VictoryContainer, VictoryTheme, Bar, addEvents, Data, Domain
 } from "victory-core";
+import { BaseProps, DataProps } from "../../helpers/common-props";
 
 const fallbackProps = {
   width: 450,
@@ -13,10 +14,10 @@ const fallbackProps = {
 };
 
 const defaultData = [
-  {x: 1, y: 1},
-  {x: 2, y: 2},
-  {x: 3, y: 3},
-  {x: 4, y: 4}
+  { x: 1, y: 1 },
+  { x: 2, y: 2 },
+  { x: 3, y: 3 },
+  { x: 4, y: 4 }
 ];
 
 const animationWhitelist = ["data", "domain", "height", "padding", "style", "width"];
@@ -44,87 +45,9 @@ class VictoryBar extends React.Component {
   };
 
   static propTypes = {
-    animate: PropTypes.object,
-    categories: PropTypes.oneOfType([
-      PropTypes.arrayOf(PropTypes.string),
-      PropTypes.shape({
-        x: PropTypes.arrayOf(PropTypes.string), y: PropTypes.arrayOf(PropTypes.string)
-      })
-    ]),
-    containerComponent: PropTypes.element,
-    data: PropTypes.array,
-    domainPadding: PropTypes.oneOfType([
-      PropTypes.shape({
-        x: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ]),
-        y: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ])
-      }),
-      PropTypes.number
-    ]),
-    dataComponent: PropTypes.element,
-    domain: PropTypes.oneOfType([
-      CustomPropTypes.domain,
-      PropTypes.shape({ x: CustomPropTypes.domain, y: CustomPropTypes.domain })
-    ]),
-    events: PropTypes.arrayOf(PropTypes.shape({
-      target: PropTypes.oneOf(["data", "labels", "parent"]),
-      eventKey: PropTypes.oneOfType([
-        PropTypes.array,
-        CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-        PropTypes.string
-      ]),
-      eventHandlers: PropTypes.object
-    })),
-    eventKey: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string
-    ]),
-    groupComponent: PropTypes.element,
-    height: CustomPropTypes.nonNegative,
-    horizontal: PropTypes.bool,
-    labels: PropTypes.oneOfType([ PropTypes.func, PropTypes.array ]),
-    labelComponent: PropTypes.element,
-    name: PropTypes.string,
-    padding: PropTypes.oneOfType([
-      PropTypes.number,
-      PropTypes.shape({
-        top: PropTypes.number, bottom: PropTypes.number,
-        left: PropTypes.number, right: PropTypes.number
-      })
-    ]),
-    samples: CustomPropTypes.nonNegative,
-    scale: PropTypes.oneOfType([
-      CustomPropTypes.scale,
-      PropTypes.shape({ x: CustomPropTypes.scale, y: CustomPropTypes.scale })
-    ]),
-    sharedEvents: PropTypes.shape({
-      events: PropTypes.array,
-      getEventState: PropTypes.func
-    }),
-    sortKey: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string,
-      PropTypes.arrayOf(PropTypes.string)
-    ]),
-    standalone: PropTypes.bool,
-    style: PropTypes.shape({
-      parent: PropTypes.object, data: PropTypes.object, labels: PropTypes.object
-    }),
-    theme: PropTypes.object,
-    width: CustomPropTypes.nonNegative,
-    x: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string,
-      PropTypes.arrayOf(PropTypes.string)
-    ]),
-    y: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string,
-      PropTypes.arrayOf(PropTypes.string)
-    ])
+    ...BaseProps,
+    ...DataProps,
+    horizontal: PropTypes.bool
   };
 
   static defaultProps = {
@@ -145,48 +68,19 @@ class VictoryBar extends React.Component {
     "dataComponent", "labelComponent", "groupComponent", "containerComponent"
   ];
 
-  renderData(props) {
-    const { dataComponent, labelComponent, groupComponent } = props;
-
-    const dataComponents = this.dataKeys.map((_dataKey, index) => {
-      const dataProps = this.getComponentProps(dataComponent, "data", index);
-      return React.cloneElement(dataComponent, dataProps);
-    });
-
-    const labelComponents = this.dataKeys.map((_dataKey, index) => {
-      const labelProps = this.getComponentProps(labelComponent, "labels", index);
-      if (labelProps.text !== undefined && labelProps.text !== null) {
-        return React.cloneElement(labelComponent, labelProps);
-      }
-    }).filter(Boolean);
-
-    const children = [...dataComponents, ...labelComponents];
-    return this.renderContainer(groupComponent, children);
-
-  }
-
+  // Overridden in native versions
   shouldAnimate() {
     return !!this.props.animate;
   }
 
-  renderContainer(component, children) {
-    const isContainer = component.type && component.type.role === "container";
-    const parentProps = isContainer ? this.getComponentProps(component, "parent", "parent") : {};
-    return React.cloneElement(component, parentProps, children);
-  }
-
   render() {
     const { role } = this.constructor;
     const props = Helpers.modifyProps((this.props), fallbackProps, role);
     if (this.shouldAnimate()) {
-      return (
-        <VictoryTransition animate={props.animate} animationWhitelist={animationWhitelist}>
-          {React.createElement(this.constructor, props)}
-        </VictoryTransition>
-      );
+      return this.animateComponent(props, animationWhitelist);
     }
     const children = this.renderData(props);
-    return this.renderContainer(props.containerComponent, children);
+    return props.standalone ? this.renderContainer(props.containerComponent, children) : children;
   }
 }
 

package/src/components/victory-candlestick/helper-methods.js

@@ -1,3 +1,4 @@
+/*eslint no-magic-numbers: ["error", { "ignore": [0, 1] }]*/
 import { assign, pick, sortBy, omit, defaults } from "lodash";
 import { Helpers, Log, Scale, Domain, Data } from "victory-core";
 
@@ -7,9 +8,9 @@ export default {
     const calculatedValues = this.getCalculatedValues(props);
     const { data, style, scale, domain } = calculatedValues;
     const { groupComponent, width, height, padding, standalone, theme } = props;
-    const initialChildProps = {parent: {
+    const initialChildProps = { parent: {
       domain, scale, width, height, data, standalone, theme, style: style.parent
-    }};
+    } };
 
     return data.reduce((childProps, datum, index) => {
       const eventKey = datum.eventKey || index;
@@ -37,7 +38,7 @@ export default {
   },
 
   getLabelProps(dataProps, text, calculatedStyle) {
-    const {x, y1, index, scale, datum, data } = dataProps;
+    const { x, y1, index, scale, datum, data } = dataProps;
     const labelStyle = this.getLabelStyle(calculatedStyle.labels, dataProps) || {};
     return {
       style: labelStyle,
@@ -58,7 +59,7 @@ export default {
     const { theme } = props;
     const defaultStyle = theme && theme.candlestick && theme.candlestick.style ?
       theme.candlestick.style : {};
-    const style = Helpers.getStyles(props.style, defaultStyle, "auto", "100%");
+    const style = Helpers.getStyles(props.style, defaultStyle);
     const data = Data.addEventKeys(props, this.getData(props));
     const range = {
       x: Helpers.getRange(props, "x"),
@@ -72,7 +73,7 @@ export default {
       x: Scale.getBaseScale(props, "x").domain(domain.x).range(range.x),
       y: Scale.getBaseScale(props, "y").domain(domain.y).range(range.y)
     };
-    return {domain, data, scale, style};
+    return { domain, data, scale, style };
   },
 
   getData(props) {
@@ -102,7 +103,7 @@ export default {
       return assign(
         {},
         datum,
-        {_x, _y, _open, _close, _high, _low},
+        { _x, _y, _open, _close, _high, _low },
         typeof _x === "string" ? { _x: stringMap.x[_x], x: _x } : {}
       );
     }), props.sortKey);
@@ -163,7 +164,7 @@ export default {
     const fill = datum.fill || style.fill || candleColor;
     const strokeColor = datum.stroke || style.stroke;
     const stroke = this.isTransparent(strokeColor) ? fill : strokeColor || "black";
-    return defaults({}, stylesFromData, {stroke, fill}, style);
+    return defaults({}, stylesFromData, { stroke, fill }, style);
   },
 
   getLabelText(props, datum, index) {
@@ -175,7 +176,7 @@ export default {
     labelStyle = labelStyle || {};
     const { size, style } = dataProps;
     const matchedStyle = pick(style, ["opacity", "fill"]);
-    const padding = labelStyle.padding || size * 0.25;
-    return defaults({}, labelStyle, matchedStyle, {padding});
+    const padding = labelStyle.padding || size * 0.25; // eslint-disable-line no-magic-numbers
+    return defaults({}, labelStyle, matchedStyle, { padding });
   }
 };

package/src/components/victory-candlestick/victory-candlestick.js

@@ -1,11 +1,14 @@
-import React, { PropTypes } from "react";
+import PropTypes from "prop-types";
+import React from "react";
 import { partialRight } from "lodash";
 import {
-  PropTypes as CustomPropTypes, Helpers, VictoryTransition, VictoryLabel, addEvents,
+  PropTypes as CustomPropTypes, Helpers, VictoryLabel, addEvents,
   VictoryContainer, VictoryTheme, DefaultTransitions, Candle
 } from "victory-core";
 import CandlestickHelpers from "./helper-methods";
+import { BaseProps, DataProps } from "../../helpers/common-props";
 
+/*eslint-disable no-magic-numbers */
 const fallbackProps = {
   width: 450,
   height: 300,
@@ -17,15 +20,16 @@ const fallbackProps = {
 };
 
 const defaultData = [
-  {x: new Date(2016, 6, 1), open: 5, close: 10, high: 15, low: 0},
-  {x: new Date(2016, 6, 2), open: 10, close: 15, high: 20, low: 5},
-  {x: new Date(2016, 6, 3), open: 15, close: 20, high: 25, low: 10},
-  {x: new Date(2016, 6, 4), open: 20, close: 25, high: 30, low: 15},
-  {x: new Date(2016, 6, 5), open: 25, close: 30, high: 35, low: 20},
-  {x: new Date(2016, 6, 6), open: 30, close: 35, high: 40, low: 25},
-  {x: new Date(2016, 6, 7), open: 35, close: 40, high: 45, low: 30},
-  {x: new Date(2016, 6, 8), open: 40, close: 45, high: 50, low: 35}
+  { x: new Date(2016, 6, 1), open: 5, close: 10, high: 15, low: 0 },
+  { x: new Date(2016, 6, 2), open: 10, close: 15, high: 20, low: 5 },
+  { x: new Date(2016, 6, 3), open: 15, close: 20, high: 25, low: 10 },
+  { x: new Date(2016, 6, 4), open: 20, close: 25, high: 30, low: 15 },
+  { x: new Date(2016, 6, 5), open: 25, close: 30, high: 35, low: 20 },
+  { x: new Date(2016, 6, 6), open: 30, close: 35, high: 40, low: 25 },
+  { x: new Date(2016, 6, 7), open: 35, close: 40, high: 45, low: 30 },
+  { x: new Date(2016, 6, 8), open: 40, close: 45, high: 50, low: 35 }
 ];
+/*eslint-enable no-magic-numbers */
 
 const animationWhitelist = [
   "data", "domain", "height", "padding", "samples", "size", "style", "width"
@@ -37,109 +41,32 @@ class VictoryCandlestick extends React.Component {
   static defaultTransitions = DefaultTransitions.discreteTransitions();
 
   static propTypes = {
-    animate: PropTypes.object,
+    ...BaseProps,
+    ...DataProps,
     candleColors: PropTypes.shape({ positive: PropTypes.string, negative: PropTypes.string }),
-    categories: PropTypes.oneOfType([
-      PropTypes.arrayOf(PropTypes.string),
-      PropTypes.shape({
-        x: PropTypes.arrayOf(PropTypes.string), y: PropTypes.arrayOf(PropTypes.string)
-      })
-    ]),
     close: PropTypes.oneOfType([
       PropTypes.func,
       CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
       PropTypes.string,
       PropTypes.arrayOf(PropTypes.string)
     ]),
-    containerComponent: PropTypes.element,
-    data: PropTypes.array,
-    domainPadding: PropTypes.oneOfType([
-      PropTypes.shape({
-        x: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ]),
-        y: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ])
-      }),
-      PropTypes.number
-    ]),
-    dataComponent: PropTypes.element,
-    domain: PropTypes.oneOfType([
-      CustomPropTypes.domain,
-      PropTypes.shape({ x: CustomPropTypes.domain, y: CustomPropTypes.domain })
-    ]),
-    events: PropTypes.arrayOf(PropTypes.shape({
-      target: PropTypes.oneOf(["data", "labels", "parent"]),
-      eventKey: PropTypes.oneOfType([
-        PropTypes.array,
-        PropTypes.func,
-        CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-        PropTypes.string
-      ]),
-      eventHandlers: PropTypes.object
-    })),
-    eventKey: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string
-    ]),
-    groupComponent: PropTypes.element,
-    height: CustomPropTypes.nonNegative,
     high: PropTypes.oneOfType([
       PropTypes.func,
       CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
       PropTypes.string,
       PropTypes.arrayOf(PropTypes.string)
     ]),
-    labels: PropTypes.oneOfType([ PropTypes.func, PropTypes.array ]),
-    labelComponent: PropTypes.element,
     low: PropTypes.oneOfType([
       PropTypes.func,
       CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
       PropTypes.string,
       PropTypes.arrayOf(PropTypes.string)
     ]),
-    name: PropTypes.string,
     open: PropTypes.oneOfType([
       PropTypes.func,
       CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
       PropTypes.string,
       PropTypes.arrayOf(PropTypes.string)
-    ]),
-    padding: PropTypes.oneOfType([
-      PropTypes.number,
-      PropTypes.shape({
-        top: PropTypes.number, bottom: PropTypes.number,
-        left: PropTypes.number, right: PropTypes.number
-      })
-    ]),
-    samples: CustomPropTypes.nonNegative,
-    scale: PropTypes.oneOfType([
-      CustomPropTypes.scale,
-      PropTypes.shape({ x: CustomPropTypes.scale, y: CustomPropTypes.scale })
-    ]),
-    sharedEvents: PropTypes.shape({
-      events: PropTypes.array,
-      getEventState: PropTypes.func
-    }),
-    sortKey: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string,
-      PropTypes.arrayOf(PropTypes.string)
-    ]),
-    size: PropTypes.oneOfType([
-      CustomPropTypes.nonNegative,
-      PropTypes.func
-    ]),
-    standalone: PropTypes.bool,
-    style: PropTypes.shape({
-      parent: PropTypes.object, data: PropTypes.object, labels: PropTypes.object
-    }),
-    theme: PropTypes.object,
-    width: CustomPropTypes.nonNegative,
-    x: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string,
-      PropTypes.arrayOf(PropTypes.string)
     ])
   };
 
@@ -163,47 +90,19 @@ class VictoryCandlestick extends React.Component {
     "dataComponent", "labelComponent", "groupComponent", "containerComponent"
   ];
 
-  renderData(props) {
-    const { dataComponent, labelComponent, groupComponent} = props;
-
-    const dataComponents = this.dataKeys.map((_dataKey, index) => {
-      const dataProps = this.getComponentProps(dataComponent, "data", index);
-      return React.cloneElement(dataComponent, dataProps);
-    });
-
-    const labelComponents = this.dataKeys.map((_dataKey, index) => {
-      const labelProps = this.getComponentProps(labelComponent, "labels", index);
-      if (labelProps.text !== undefined && labelProps.text !== null) {
-        return React.cloneElement(labelComponent, labelProps);
-      }
-    }).filter(Boolean);
-
-    const children = [...dataComponents, ...labelComponents];
-    return this.renderContainer(groupComponent, children);
-  }
-
+  // Overridden in native versions
   shouldAnimate() {
     return !!this.props.animate;
   }
 
-  renderContainer(component, children) {
-    const isContainer = component.type && component.type.role === "container";
-    const parentProps = isContainer ? this.getComponentProps(component, "parent", "parent") : {};
-    return React.cloneElement(component, parentProps, children);
-  }
-
   render() {
-    const {role} = this.constructor;
+    const { role } = this.constructor;
     const props = Helpers.modifyProps(this.props, fallbackProps, role);
     if (this.shouldAnimate()) {
-      return (
-        <VictoryTransition animate={props.animate} animationWhitelist={animationWhitelist}>
-          {React.createElement(this.constructor, props)}
-        </VictoryTransition>
-      );
+      return this.animateComponent(props, animationWhitelist);
     }
     const children = this.renderData(props);
-    return this.renderContainer(props.containerComponent, children);
+    return props.standalone ? this.renderContainer(props.containerComponent, children) : children;
   }
 }
 

package/src/components/victory-chart/helper-methods.js

@@ -1,3 +1,4 @@
+/*eslint no-magic-numbers: ["error", { "ignore": [0, 1, 2] }]*/
 import { invert, sortBy, values } from "lodash";
 import Axis from "../../helpers/axis";
 import Wrapper from "../../helpers/wrapper";
@@ -22,9 +23,9 @@ export default {
       return childComponents.concat([defaultAxes.independent, defaultAxes.dependent]);
     }
     if (axisComponents.dependent.length > 1 || axisComponents.independent.length > 1) {
-      const msg = `Only one VictoryAxis component of each axis type is allowed when ` +
-        `using the VictoryChart wrapper. Only the first axis will be used. Please compose ` +
-        `multi-axis charts manually`;
+      const msg = "Only one VictoryAxis component of each axis type is allowed when " +
+        "using the VictoryChart wrapper. Only the first axis will be used. Please compose " +
+        "multi-axis charts manually";
       Log.warn(msg);
       const dataComponents = this.getDataComponents(childComponents);
       return Collection.removeUndefined(
@@ -45,8 +46,8 @@ export default {
 
     const { offset, children } = groupComponent[0].props;
     return horizontal ?
-      {y: (offset * children.length) / 2} :
-      {x: (offset * children.length) / 2};
+      { y: (offset * children.length) / 2 } :
+      { x: (offset * children.length) / 2 };
   },
 
   getDataComponents(childComponents) {
@@ -72,7 +73,7 @@ export default {
   },
 
   getAxisOffset(props, calculatedProps) {
-    const {axisComponents, scale, origin, originSign} = calculatedProps;
+    const { axisComponents, scale, origin, originSign } = calculatedProps;
     // make the axes line up, and cross when appropriate
     const axisOrientations = {
       x: Axis.getOrientation(axisComponents.x, "x", originSign.x),

package/src/components/victory-chart/victory-chart.js

@@ -1,13 +1,12 @@
 import { defaults } from "lodash";
-import React, { PropTypes } from "react";
-import {
-  PropTypes as CustomPropTypes, Helpers, VictorySharedEvents, VictoryContainer,
-  VictoryTheme, Scale
-} from "victory-core";
+import PropTypes from "prop-types";
+import React from "react";
+import { Helpers, VictorySharedEvents, VictoryContainer, VictoryTheme, Scale } from "victory-core";
 import VictoryAxis from "../victory-axis/victory-axis";
 import ChartHelpers from "./helper-methods";
 import Axis from "../../helpers/axis";
 import Wrapper from "../../helpers/wrapper";
+import { BaseProps } from "../../helpers/common-props";
 
 const fallbackProps = {
   width: 450,
@@ -19,79 +18,26 @@ export default class VictoryChart extends React.Component {
   static displayName = "VictoryChart";
 
   static propTypes = {
-    animate: PropTypes.object,
-    children: React.PropTypes.oneOfType([
-      React.PropTypes.arrayOf(React.PropTypes.node),
-      React.PropTypes.node
+    ...BaseProps,
+    children: PropTypes.oneOfType([
+      PropTypes.arrayOf(PropTypes.node),
+      PropTypes.node
     ]),
-    containerComponent: PropTypes.element,
     defaultAxes: PropTypes.shape({
       independent: PropTypes.element,
       dependent: PropTypes.element
-    }),
-    domain: PropTypes.oneOfType([
-      CustomPropTypes.domain,
-      PropTypes.shape({
-        x: CustomPropTypes.domain,
-        y: CustomPropTypes.domain
-      })
-    ]),
-    domainPadding: PropTypes.oneOfType([
-      PropTypes.shape({
-        x: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ]),
-        y: PropTypes.oneOfType([ PropTypes.number, CustomPropTypes.domain ])
-      }),
-      PropTypes.number
-    ]),
-    events: PropTypes.arrayOf(PropTypes.shape({
-      childName: PropTypes.oneOfType([ PropTypes.string, PropTypes.array ]),
-      target: PropTypes.string,
-      eventKey: PropTypes.oneOfType([
-        PropTypes.array,
-        PropTypes.func,
-        CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-        PropTypes.string
-      ]),
-      eventHandlers: PropTypes.object
-    })),
-    eventKey: PropTypes.oneOfType([
-      PropTypes.func,
-      CustomPropTypes.allOfType([CustomPropTypes.integer, CustomPropTypes.nonNegative]),
-      PropTypes.string
-    ]),
-    groupComponent: PropTypes.element,
-    height: CustomPropTypes.nonNegative,
-    padding: PropTypes.oneOfType([
-      PropTypes.number,
-      PropTypes.shape({
-        top: PropTypes.number, bottom: PropTypes.number,
-        left: PropTypes.number, right: PropTypes.number
-      })
-    ]),
-    scale: PropTypes.oneOfType([
-      CustomPropTypes.scale,
-      PropTypes.shape({ x: CustomPropTypes.scale, y: CustomPropTypes.scale })
-    ]),
-    sharedEvents: PropTypes.shape({
-      events: PropTypes.array,
-      getEventState: PropTypes.func
-    }),
-    standalone: PropTypes.bool,
-    style: PropTypes.object,
-    theme: PropTypes.object,
-    width: CustomPropTypes.nonNegative,
-    modifyChildren: PropTypes.func
+    })
   };
 
   static defaultProps = {
-    standalone: true,
     containerComponent: <VictoryContainer/>,
-    groupComponent: <g/>,
-    theme: VictoryTheme.grayscale,
     defaultAxes: {
       independent: <VictoryAxis/>,
       dependent: <VictoryAxis dependentAxis/>
-    }
+    },
+    groupComponent: <g/>,
+    standalone: true,
+    theme: VictoryTheme.grayscale
   };
 
   static expectedComponents = [
@@ -126,13 +72,15 @@ export default class VictoryChart extends React.Component {
   getStyles(props) {
     const styleProps = props.style && props.style.parent;
     return {
-      parent: defaults({
-        height: "auto",
-        width: "100%",
-        userSelect: "none"
-      },
-      styleProps
-    )};
+      parent: defaults(
+        {},
+        styleProps,
+        {
+          height: "100%",
+          width: "100%",
+          userSelect: "none"
+        }
+    ) };
   }
 
   getAxisProps(child, props, calculatedProps) {
@@ -235,7 +183,7 @@ export default class VictoryChart extends React.Component {
     const getAnimationProps = Wrapper.getAnimationProps.bind(this);
 
     return childComponents.map((child, index) => {
-      const style = defaults({}, child.props.style, {parent: baseStyle});
+      const style = defaults({}, child.props.style, { parent: baseStyle });
       const childProps = this.getChildProps(child, props, calculatedProps);
       const newProps = defaults({
         animate: getAnimationProps(props, child, index),
@@ -275,10 +223,7 @@ export default class VictoryChart extends React.Component {
     const childComponents = ChartHelpers.getChildComponents(modifiedProps,
       modifiedProps.defaultAxes);
     const calculatedProps = this.getCalculatedProps(modifiedProps, childComponents);
-    let newChildren = this.getNewChildren(modifiedProps, childComponents, calculatedProps);
-    if (this.props.modifyChildren) {
-      newChildren = this.props.modifyChildren(newChildren, modifiedProps);
-    }
+    const newChildren = this.getNewChildren(modifiedProps, childComponents, calculatedProps);
     const containerProps = this.getContainerProps(modifiedProps, calculatedProps);
     const container = this.renderContainer(containerComponent, containerProps);
     if (this.events) {

package/src/components/victory-errorbar/helper-methods.js

@@ -8,7 +8,7 @@ export default {
     const { groupComponent, height, width, borderWidth, standalone, theme } = props;
     const initialChildProps = { parent: {
       domain, style: style.parent, scale, data, height, width, standalone, theme
-    }};
+    } };
 
     return data.reduce((childProps, datum, index) => {
       const eventKey = datum.eventKey || index;
@@ -35,7 +35,7 @@ export default {
   },
 
   getLabelProps(dataProps, text, calculatedStyle) {
-    const { x, index, scale, errorY} = dataProps;
+    const { x, index, scale, errorY } = dataProps;
     const error = errorY && Array.isArray(errorY) ? errorY[0] : errorY;
     const y = error || dataProps.y;
     const labelStyle = this.getLabelStyle(calculatedStyle.labels, dataProps) || {};
@@ -76,7 +76,7 @@ export default {
      * @return {String or Array}
      */
 
-    const errorNames = {x: "errorX", y: "errorY"};
+    const errorNames = { x: "errorX", y: "errorY" };
     const errors = datum[errorNames[axis]];
     if (errors === 0) {
       return false;
@@ -197,7 +197,7 @@ export default {
   getCalculatedValues(props) {
     const defaultStyles = props.theme && props.theme.errorbar && props.theme.errorbar.style ?
       props.theme.errorbar.style : {};
-    const style = Helpers.getStyles(props.style, defaultStyles, "auto", "100%") || {};
+    const style = Helpers.getStyles(props.style, defaultStyles) || {};
     const dataWithErrors = assign(Data.getData(props), this.getErrorData(props));
     const data = Data.addEventKeys(props, dataWithErrors);
     const range = {
@@ -213,7 +213,7 @@ export default {
       y: Scale.getBaseScale(props, "y").domain(domain.y).range(range.y)
     };
 
-    return {domain, data, scale, style};
+    return { domain, data, scale, style };
   },
 
   getDataStyles(datum, style) {
@@ -232,7 +232,7 @@ export default {
     labelStyle = labelStyle || {};
     const { size, style } = dataProps;
     const matchedStyle = pick(style, ["opacity", "fill"]);
-    const padding = labelStyle.padding || size * 0.25;
-    return defaults({}, labelStyle, matchedStyle, {padding}) || {};
+    const padding = labelStyle.padding || size * 0.25; // eslint-disable-line no-magic-numbers
+    return defaults({}, labelStyle, matchedStyle, { padding }) || {};
   }
 };