viberoom 0.5.7 → 0.5.9

package/dist/room.js

@@ -3,7 +3,7 @@ import { EventEmitter } from "node:events";
 import { randomUUID } from "node:crypto";
 import { appendFileSync, existsSync, mkdirSync, readFileSync, statSync } from "node:fs";
 import { writeFileAtomic } from "./atomic.js";
-import { NOTES_ONLY_PROMPT, NOTES_REQUEST, crossedThreshold, extractNotes, isBareContextFullError, isContextFullError, overThreshold, visibleChunk } from "./context.js";
+import { NOTES_ONLY_PROMPT, NOTES_REQUEST, crossedThreshold, emptyUsageReport, extractNotes, isBareContextFullError, isContextFullError, looksCompacted, overThreshold, visibleChunk } from "./context.js";
 import { affectedByEdit, editNotice, partitionHistory, rewriteNotice } from "./edit.js";
 import { saveImages } from "./files.js";
 import { join, resolve } from "node:path";
@@ -12,11 +12,12 @@ import { RemoteError } from "./jsonrpc.js";
 import { getRecipe, listRecipes } from "./recipes.js";
 import { composeSkillBlock, skillPull, SKILL_TOOL_NAME } from "./persona.js";
 import { BUILTIN_AUTHOR, parseSkillInvocation, renderSkillBody, SKILL_NAME_PATTERN, } from "./skills.js";
-import { BRIEF_AFFECTING_SETTINGS, DEFAULT_ROOM_SETTINGS, REQUEST_BRIEF_MARKER, SILENT_MARKER, buildBrief, buildHeader, composeCorrectionPrompt, composePrompt, countSentences, ensureDir, } from "./persona.js";
+import { templateId } from "./templates.js";
+import { applyVibemateChanges, diffSettings, lintRoomDesign, ruleLines } from "./room-design.js";
+import { BRIEF_AFFECTING_SETTINGS, AGENT_SETTINGS, coerceSetting, describeSettings, DEFAULT_ROOM_SETTINGS, ROOM_SETTINGS_SPEC, REQUEST_BRIEF_MARKER, NAME_PATTERN, SILENT_MARKER, buildBrief, buildHeader, composeCorrectionPrompt, composePrompt, countSentences, ensureDir, } from "./persona.js";
 import { Transcript } from "./log.js";
 const SKILL_TOOL_READY_MS = 5000;
 const COLORS = ["#6d5dfc", "#16a34a", "#d97706", "#dc2626", "#0891b2", "#be185d", "#4d7c0f", "#7c3aed"];
-const NAME_PATTERN = /^[\p{L}\p{N}][\p{L}\p{N}_-]{0,23}$/u;
 const MENTION_PATTERN = /@([\p{L}\p{N}][\p{L}\p{N}_-]*)/gu;
 const RULE_REF_TOKEN = /@\{p:([^}]+)\}/g;
 const ADAPTER_ERROR_PATTERN = /^(?:Warning: Falling back from WebSockets|unexpected status \d{3}|Error when talking to|API Error|You have exhausted your (?:daily )?quota|Rate limit|429 |5\d\d )/i;
@@ -45,6 +46,8 @@ export class Room extends EventEmitter {
     runtimes = new Map();
     drafts = new Map();
     permissions = new Map();
+    proposals = new Map();
+    proposalPlans = new Map();
     optionCache;
     log;
     colorIndex = 0;
@@ -231,6 +234,7 @@ export class Room extends EventEmitter {
             participants: [...this.participants.values()],
             messages: [...this.messages, ...this.drafts.values()],
             permissions: [...this.permissions.values()].map(({ resolve: _r, ...p }) => p),
+            proposals: [...this.proposals.values()],
             recipes: listRecipes().map(({ build: _b, ...r }) => r),
             lastMessageAt: last?.ts ?? this.createdAt,
         };
@@ -612,124 +616,20 @@ export class Room extends EventEmitter {
     updateSettings(patch) {
         const next = { ...this.settings };
         const changed = [];
-        const setNumber = (key, min, max) => {
-            if (patch[key] === undefined)
-                return;
-            const value = Number(patch[key]);
-            if (!Number.isInteger(value) || value < min || value > max)
-                throw new Error(`${key} must be an integer between ${min} and ${max}`);
-            if (value !== next[key]) {
-                next[key] = value;
-                changed.push(key);
+        let unknownRefs = [];
+        for (const key of Object.keys(ROOM_SETTINGS_SPEC)) {
+            if (patch[key] === undefined || ROOM_SETTINGS_SPEC[key].kind === "own-path")
+                continue;
+            let value = coerceSetting(key, patch[key]);
+            if (key === "customRules") {
+                const resolved = this.resolveRuleReferences(value);
+                unknownRefs = resolved.unknown;
+                value = resolved.stored;
             }
-        };
-        setNumber("hopLimit", 0, 10_000);
-        setNumber("fullBriefEveryTurns", 1, 10_000);
-        setNumber("fullBriefEveryTokens", 1000, 10_000_000);
-        setNumber("replayAfterRestart", 0, 200);
-        setNumber("backlogCap", 1, 1000);
-        if (patch.replyDelay !== undefined) {
-            const value = Number(patch.replyDelay);
-            if (!Number.isFinite(value) || value < 0 || value > 120)
-                throw new Error("replyDelay must be between 0 and 120 seconds");
-            next.replyDelay = value;
-        }
-        const setText = (key, max) => {
-            if (patch[key] === undefined)
-                return;
-            const value = String(patch[key]).slice(0, max);
-            if (value !== next[key]) {
+            if (JSON.stringify(value) !== JSON.stringify(next[key])) {
                 next[key] = value;
                 changed.push(key);
             }
-        };
-        setText("topic", 2000);
-        setText("emoji", 8);
-        setText("humanDescription", 200);
-        let unknownRefs = [];
-        if (patch.customRules !== undefined) {
-            const resolved = this.resolveRuleReferences(String(patch.customRules).slice(0, 4000));
-            unknownRefs = resolved.unknown;
-            if (resolved.stored !== next.customRules) {
-                next.customRules = resolved.stored;
-                changed.push("customRules");
-            }
-        }
-        if (patch.humanDescriptionMode !== undefined) {
-            const mode = String(patch.humanDescriptionMode);
-            if (mode !== "inherit" && mode !== "override" && mode !== "append" && mode !== "none")
-                throw new Error("humanDescriptionMode must be inherit, override, append or none");
-            if (mode !== next.humanDescriptionMode) {
-                next.humanDescriptionMode = mode;
-                changed.push("humanDescriptionMode");
-            }
-        }
-        if (patch.refereeAction !== undefined) {
-            const action = String(patch.refereeAction);
-            if (action !== "next-header" && action !== "retry-hidden")
-                throw new Error("refereeAction must be next-header or retry-hidden");
-            if (action !== next.refereeAction) {
-                next.refereeAction = action;
-                changed.push("refereeAction");
-            }
-        }
-        if (patch.turnTaking !== undefined) {
-            const mode = String(patch.turnTaking);
-            if (mode !== "parallel" && mode !== "one-at-a-time")
-                throw new Error("turnTaking must be parallel or one-at-a-time");
-            if (mode !== next.turnTaking) {
-                next.turnTaking = mode;
-                changed.push("turnTaking");
-            }
-        }
-        if (patch.agentsWakeEachOther !== undefined) {
-            const on = patch.agentsWakeEachOther === true || patch.agentsWakeEachOther === "true";
-            if (on !== next.agentsWakeEachOther) {
-                next.agentsWakeEachOther = on;
-                changed.push("agentsWakeEachOther");
-            }
-        }
-        if (patch.waitWhileHumanTypes !== undefined) {
-            const on = patch.waitWhileHumanTypes === true || patch.waitWhileHumanTypes === "true";
-            if (on !== next.waitWhileHumanTypes) {
-                next.waitWhileHumanTypes = on;
-                changed.push("waitWhileHumanTypes");
-            }
-        }
-        if (patch.language !== undefined) {
-            const raw = String(patch.language).trim();
-            const language = !raw || raw === "follow-human" ? { mode: "follow-human" } : { mode: "fixed", language: raw };
-            if (JSON.stringify(language) !== JSON.stringify(next.language)) {
-                next.language = language;
-                changed.push("language");
-            }
-        }
-        if (patch.tools !== undefined) {
-            const tools = String(patch.tools);
-            if (tools !== "on-request" && tools !== "never")
-                throw new Error("tools must be on-request or never");
-            if (tools !== next.tools) {
-                next.tools = tools;
-                changed.push("tools");
-            }
-        }
-        if (patch.maxSentences !== undefined) {
-            const value = patch.maxSentences === null || patch.maxSentences === "" ? null : Number(patch.maxSentences);
-            if (value !== null && (!Number.isInteger(value) || value < 1 || value > 100))
-                throw new Error("maxSentences must be 1-100 or empty");
-            if (value !== next.maxSentences) {
-                next.maxSentences = value;
-                changed.push("maxSentences");
-            }
-        }
-        for (const key of ["headerRules", "showVendorInRoster"]) {
-            if (patch[key] !== undefined) {
-                const value = patch[key] === true || patch[key] === "true";
-                if (value !== next[key]) {
-                    next[key] = value;
-                    changed.push(key);
-                }
-            }
         }
         this.settings = next;
         this.push(this.roomEvent());
@@ -1294,6 +1194,237 @@ export class Room extends EventEmitter {
             return undefined;
         return { items, channel, canCreate: channel === "tool" };
     }
+    skillsForDesign(participantId) {
+        if (!this.skills)
+            return undefined;
+        const runtime = this.runtimes.get(participantId);
+        const channel = runtime?.skillChannel === "tool" ? "tool" : "marker";
+        return {
+            library: this.skills.library.list().filter((s) => !s.problems.length && !s.draft && s.agentInvocable).map((s) => ({ name: s.name, description: s.description })),
+            channel,
+            canCreate: channel === "tool",
+        };
+    }
+    agentInRoom(participantId) {
+        const participant = this.participants.get(participantId);
+        if (!participant || !this.runtimes.has(participantId))
+            throw new Error("this agent is not in the room any more");
+        return participant;
+    }
+    describeRoomForAgent(participantId) {
+        const participant = this.agentInRoom(participantId);
+        const shape = this.templateOf();
+        const skills = this.skills ? this.skills.library.list().filter((s) => !s.problems.length && !s.draft).map((s) => ({ name: s.name, description: s.description })) : [];
+        const templates = this.skills ? this.skills.templates.list().map((t) => ({ id: t.id, name: t.name, builtin: !!t.builtin })) : [];
+        return {
+            room: { name: this.settings.name, topic: this.settings.topic, emoji: this.settings.emoji, dir: this.dir },
+            human: this.settings.humanName,
+            you: participant.name,
+            settings: describeSettings({ ...this.settings, customRules: this.renderRuleReferences(this.settings.customRules) }),
+            rules: ruleLines(this.renderRuleReferences(this.settings.customRules)),
+            vibemates: shape.vibemates.map((v) => {
+                const role = v.role ?? "";
+                const own = v.name === participant.name;
+                return {
+                    name: v.name,
+                    tagline: v.tagline ?? "",
+                    ...(own ? { role } : { rolePrivate: true, roleLength: role.length }),
+                    avatar: v.avatar ?? "",
+                    skills: v.skills ?? [],
+                    agentType: v.agentType,
+                };
+            }),
+            skills,
+            templates,
+            yourBrief: buildBrief(this.settings, this.personaOf(participant), this.roster(), undefined, this.skillsForPrompt(participant, this.runtimes.get(participant.id))),
+            howTo: "Settings are proposed by key with the values above; rules are one per line in customRules; a vibemate is { name, tagline, role, avatar, skills }. Another vibemate's role is private: you learn only that it has one and how long it is, and you may still propose a new one, which the human reads in full on the card. Check a design with lint_room_design, then create_template (a file for the human to pick) or propose_room_changes (a card the human applies).",
+        };
+    }
+    lintDesignForAgent(participantId, kind, design) {
+        this.agentInRoom(participantId);
+        const result = lintRoomDesign(design, { ...this.designContext(kind), skills: this.skillsForDesign(participantId) });
+        return { ok: !result.errors.length, errors: result.errors.map((e) => e.message), warnings: result.warnings.map((w) => w.message), preview: result.preview };
+    }
+    designContext(kind) {
+        return {
+            kind,
+            humanName: this.settings.humanName,
+            roomName: this.settings.name,
+            base: kind === "room" ? { ...this.settings, customRules: this.renderRuleReferences(this.settings.customRules) } : undefined,
+            knownSkills: this.skills ? this.skills.library.list().map((s) => s.name) : undefined,
+        };
+    }
+    createTemplateForAgent(participantId, design, replace) {
+        const participant = this.agentInRoom(participantId);
+        if (!this.skills)
+            throw new Error("templates are not available in this hub");
+        const result = lintRoomDesign(design, this.designContext("template"));
+        if (result.errors.length)
+            throw new Error(`not saved: ${result.errors.map((e) => e.message).join("; ")}`);
+        const settings = result.settings;
+        const rest = {};
+        for (const key of Object.keys(design.settings ?? {}))
+            if (AGENT_SETTINGS.includes(key))
+                rest[key] = settings[key];
+        const draft = {
+            name: String(design.name).trim(),
+            description: String(design.description ?? "").trim(),
+            emoji: settings.emoji || undefined,
+            settings: rest,
+            vibemates: (design.vibemates ?? []).map((v) => {
+                const out = { name: v.name.trim() };
+                if (v.tagline?.trim())
+                    out.tagline = v.tagline.trim();
+                if (v.role?.trim())
+                    out.role = v.role.trim();
+                if (v.avatar?.trim())
+                    out.avatar = v.avatar.trim();
+                if (v.skills?.length)
+                    out.skills = v.skills.map((s) => s.trim()).filter(Boolean);
+                if (typeof v.replyDelay === "number")
+                    out.replyDelay = v.replyDelay;
+                return out;
+            }),
+        };
+        const library = this.skills.templates;
+        const wanted = templateId(draft.name);
+        const existing = library.list().find((t) => t.id === wanted);
+        let saved;
+        if (existing && replace) {
+            if (existing.builtin)
+                throw new Error(`"${existing.name}" is a template viberoom ships and cannot be replaced; pick another name`);
+            saved = library.overwrite(wanted, draft);
+        }
+        else
+            saved = library.save(draft);
+        this.skills.templatesChanged();
+        const warnings = result.warnings.map((w) => w.message);
+        this.postSystem(`${participant.name} ${existing && replace ? "updated" : "created"} the room template "${saved.name}" (${saved.vibemates.map((v) => v.name).join(", ") || "no vibemates"}); it is in the picker under New room.`);
+        this.log.info(`templates: ${participant.name} ${existing && replace ? "updated" : "created"} "${saved.name}" (${saved.id})`);
+        return {
+            ok: true,
+            message: `Template "${saved.name}" saved as ${saved.id}${existing && !replace ? ` (the name was taken, so the id got a number; pass replace: true to update your own template instead)` : ""}. The human creates a room from it under New room; nothing in this room changed.${warnings.length ? ` Warnings: ${warnings.join("; ")}` : ""}`,
+            id: saved.id,
+            path: join(library.dir, saved.id, "template.json"),
+            warnings,
+        };
+    }
+    proposeRoomChanges(participantId, why, changes) {
+        const participant = this.agentInRoom(participantId);
+        const shape = this.templateOf();
+        const current = shape.vibemates;
+        const vibes = applyVibemateChanges(current, changes.vibemates);
+        if (vibes.errors.length)
+            throw new Error(`not proposed: ${vibes.errors.join("; ")}`);
+        const touched = vibes.ops.flatMap((op) => [op.name, ...(op.fields ?? []).filter((f) => f.field === "name").map((f) => f.to)]);
+        const result = lintRoomDesign({ settings: changes.settings, vibemates: vibes.next }, { ...this.designContext("room"), changedVibemates: touched });
+        if (result.errors.length)
+            throw new Error(`not proposed: ${result.errors.map((e) => e.message).join("; ")}`);
+        const base = this.designContext("room").base;
+        const settingChanges = diffSettings(base, result.settings);
+        if (!settingChanges.length && !vibes.ops.length)
+            throw new Error("not proposed: the change set leaves the room as it is");
+        const touchesOwn = vibes.ops.some((op) => op.name.toLowerCase() === participant.name.toLowerCase()) || settingChanges.some((c) => c.key === "customRules");
+        const proposal = {
+            key: randomUUID(),
+            participantId,
+            participantName: participant.name,
+            ts: Date.now(),
+            why: String(why ?? "").trim().slice(0, 600),
+            settings: settingChanges,
+            vibemates: vibes.ops,
+            warnings: result.warnings.map((w) => w.message),
+            touchesOwn,
+            status: "pending",
+        };
+        const ids = {};
+        for (const op of vibes.ops) {
+            const target = op.op === "add" ? undefined : this.findByName(op.name);
+            if (target)
+                ids[op.name] = target.id;
+        }
+        this.proposalPlans.set(proposal.key, { settings: settingChanges, vibemates: vibes.next, ops: vibes.ops, ids });
+        this.proposals.set(proposal.key, proposal);
+        this.push({ type: "proposal", proposal });
+        const what = [...settingChanges.map((c) => c.key), ...vibes.ops.map((o) => `${o.op} ${o.name}`)].join(", ");
+        this.postSystem(`${participant.name} proposes changes to the room (${what}); apply or reject them on the card.`, "human");
+        this.log.info(`proposal ${proposal.key} from ${participant.name}: ${what}`);
+        return {
+            ok: true,
+            message: `Proposal sent to ${this.settings.humanName} as a card in the room (${what}). Nothing changes until they apply it; you will see a room line with the outcome.${proposal.warnings.length ? ` Warnings shown on the card: ${proposal.warnings.join("; ")}` : ""}`,
+            key: proposal.key,
+            warnings: proposal.warnings,
+        };
+    }
+    async resolveProposal(key, accept) {
+        const proposal = this.proposals.get(key);
+        const plan = this.proposalPlans.get(key);
+        if (!proposal || !plan)
+            throw new Error("no such pending proposal");
+        if (proposal.status !== "pending")
+            return proposal;
+        const what = [...proposal.settings.map((c) => c.key), ...proposal.vibemates.map((o) => `${o.op} ${o.name}`)].join(", ");
+        if (!accept) {
+            proposal.status = "rejected";
+            this.proposalPlans.delete(key);
+            this.push({ type: "proposal.resolved", key, status: "rejected" });
+            this.postSystem(`${this.settings.humanName} rejected ${proposal.participantName}'s proposal (${what}).`);
+            return proposal;
+        }
+        const skipped = [];
+        for (const op of plan.ops) {
+            const known = plan.ids[op.name];
+            const existing = known ? this.participants.get(known) : this.findByName(op.name);
+            if (op.op !== "add" && (!existing || existing.kind !== "agent" || existing.status === "left")) {
+                skipped.push(`${op.op} ${op.name} (no longer in the room)`);
+                continue;
+            }
+            if (op.op === "remove") {
+                if (existing && existing.kind === "agent")
+                    await this.removeParticipant(existing.id);
+            }
+            else if (op.op === "update") {
+                if (!existing || existing.kind !== "agent")
+                    continue;
+                const target = plan.vibemates.find((v) => v.name === op.name) ?? plan.vibemates.find((v) => op.fields?.some((f) => f.field === "name" && f.to === v.name));
+                const patch = {};
+                for (const f of op.fields ?? []) {
+                    if (f.field === "name")
+                        patch.name = f.to;
+                    else if (f.field === "tagline")
+                        patch.tagline = target?.tagline ?? f.to;
+                    else if (f.field === "role")
+                        patch.role = target?.role ?? f.to;
+                    else if (f.field === "avatar")
+                        patch.avatar = target?.avatar ?? f.to;
+                    else if (f.field === "skills")
+                        patch.skills = target?.skills ?? [];
+                    else if (f.field === "replyDelay")
+                        patch.replyDelay = target?.replyDelay ?? null;
+                }
+                this.updatePersona(existing.id, patch);
+            }
+            else {
+                const v = plan.vibemates.find((x) => x.name === op.name);
+                if (!v || this.findByName(op.name))
+                    skipped.push(`add ${op.name} (the name is taken now)`);
+                else
+                    this.addUnstaffed({ name: v.name, tagline: v.tagline, role: v.role, avatar: v.avatar, skills: v.skills });
+            }
+        }
+        if (plan.settings.length) {
+            const patch = {};
+            for (const c of plan.settings)
+                patch[c.key] = c.key === "language" ? c.to : c.to;
+            this.updateSettings(patch);
+        }
+        proposal.status = "applied";
+        proposal.skipped = skipped;
+        this.proposalPlans.delete(key);
+        this.push({ type: "proposal.resolved", key, status: "applied", skipped });
+        this.postSystem(`${this.settings.humanName} applied ${proposal.participantName}'s proposal (${what}).${skipped.length ? ` Not applied: ${skipped.join("; ")}.` : ""}`);
+        return proposal;
+    }
     createSkillForAgent(participantId, input) {
         const participant = this.participants.get(participantId);
         if (!participant || !this.runtimes.has(participantId))
@@ -2127,11 +2258,15 @@ export class Room extends EventEmitter {
             }
             case "usage_update": {
                 const u = update;
+                if (emptyUsageReport(runtime.lastUsed, u.used)) {
+                    runtime.log.info(`usage report of 0 after ${runtime.lastUsed} tokens ignored (failed request?)`);
+                    return;
+                }
                 participant.contextUsed = u.used;
                 participant.contextSize = u.size;
                 if (u.cost)
                     participant.cost = { amount: u.cost.amount, currency: u.cost.currency };
-                if (runtime.lastUsed > 0 && u.used < runtime.lastUsed * 0.7 && !runtime.briefPending) {
+                if (looksCompacted(runtime.lastUsed, u.used) && !runtime.briefPending) {
                     runtime.briefPending = `context shrank from ${runtime.lastUsed} to ${u.used} tokens (compaction?)`;
                     runtime.log.info(`usage dropped ${runtime.lastUsed} -> ${u.used}; brief scheduled`);
                     participant.contextEvent = { kind: "compacted", at: Date.now(), used: u.used, size: u.size };

package/dist/server.js

@@ -193,7 +193,7 @@ export function startServer(hub, port, log, info, onShutdownRequest) {
             if (!latest)
                 throw new Error("no newer version is known; check for updates first");
             log.info(`installing viberoom ${latest} (npm install -g)`);
-            const result = await installUpdate(latest);
+            const result = await installUpdate(latest, hub.dataDir);
             if (!result.ok)
                 throw new Error(`npm install failed: ${result.output.slice(-600) || "no output"}`);
             log.info(`viberoom ${latest} installed; starting the new build, which replaces this hub`);
@@ -219,6 +219,15 @@ export function startServer(hub, port, log, info, onShutdownRequest) {
             sendJson(res, 200, { skill });
             return;
         }
+        if (req.method === "GET" && path === "/api/mcp/room") {
+            const target = hub.resolveMcpToken(url.searchParams.get("token") ?? "");
+            if (!target) {
+                sendJson(res, 403, { error: "unknown skills token (the session it belonged to is gone)" });
+                return;
+            }
+            sendJson(res, 200, target.room.describeRoomForAgent(target.participantId));
+            return;
+        }
         if (req.method === "GET" && path === "/api/mcp/skill") {
             const target = hub.resolveMcpToken(url.searchParams.get("token") ?? "");
             if (!target) {
@@ -325,6 +334,50 @@ export function startServer(hub, port, log, info, onShutdownRequest) {
             sendJson(res, 200, { ok: true, skill: hub.approveSkill(decodeURIComponent(skillApprove[1])) });
             return;
         }
+        if (path === "/api/mcp/design/lint" || path === "/api/mcp/templates") {
+            const target = hub.resolveMcpToken(String(body.token ?? ""));
+            if (!target) {
+                sendJson(res, 403, { error: "unknown skills token (the session it belonged to is gone)" });
+                return;
+            }
+            const design = {
+                name: optionalString(body.name) ?? undefined,
+                description: optionalString(body.description) ?? undefined,
+                emoji: optionalString(body.emoji) ?? undefined,
+                settings: body.settings && typeof body.settings === "object" && !Array.isArray(body.settings) ? body.settings : undefined,
+                vibemates: Array.isArray(body.vibemates) ? body.vibemates.map((v) => ({ ...v, name: String(v?.name ?? "") })) : undefined,
+            };
+            if (path === "/api/mcp/design/lint") {
+                sendJson(res, 200, target.room.lintDesignForAgent(target.participantId, body.kind === "room" ? "room" : "template", design));
+                return;
+            }
+            sendJson(res, 200, target.room.createTemplateForAgent(target.participantId, design, body.replace === true || body.replace === "true"));
+            return;
+        }
+        if (path === "/api/mcp/propose") {
+            const target = hub.resolveMcpToken(String(body.token ?? ""));
+            if (!target) {
+                sendJson(res, 403, { error: "unknown skills token (the session it belonged to is gone)" });
+                return;
+            }
+            const vib = body.vibemates && typeof body.vibemates === "object" ? body.vibemates : {};
+            const list = (v) => (Array.isArray(v) ? v.map((x) => ({ ...x, name: String(x?.name ?? "") })) : undefined);
+            sendJson(res, 200, target.room.proposeRoomChanges(target.participantId, String(body.why ?? ""), {
+                settings: body.settings && typeof body.settings === "object" && !Array.isArray(body.settings) ? body.settings : undefined,
+                vibemates: {
+                    add: list(vib.add),
+                    update: list(vib.update),
+                    remove: Array.isArray(vib.remove) ? vib.remove.map((x) => String(x)) : undefined,
+                },
+            }));
+            return;
+        }
+        const proposal = path.match(/^\/api\/rooms\/([^/]+)\/proposals\/([^/]+)$/);
+        if (proposal) {
+            const room = hub.getRoom(decodeURIComponent(proposal[1]));
+            sendJson(res, 200, await room.resolveProposal(decodeURIComponent(proposal[2]), body.accept === true || body.accept === "true"));
+            return;
+        }
         if (path === "/api/mcp/skills" || path === "/api/mcp/attach") {
             const target = hub.resolveMcpToken(String(body.token ?? ""));
             if (!target) {

package/dist/shortcuts.js

@@ -4,8 +4,8 @@ import { chmodSync, copyFileSync, existsSync, mkdirSync, writeFileSync } from "n
 import { homedir } from "node:os";
 import { basename, join } from "node:path";
 import { findChromium } from "./launcher.js";
-export function vbsLauncher(node, main) {
-    return ["' viberoom: start the hub without a console window and open the app window.", 'Set sh = CreateObject("WScript.Shell")', `sh.Run """${node}"" ""${main}"" start", 0, False`, ""].join("\r\n");
+export function vbsLauncher(node, main, workingDir) {
+    return ["' viberoom: start the hub without a console window and open the app window.", 'Set sh = CreateObject("WScript.Shell")', `sh.CurrentDirectory = "${workingDir}"`, `sh.Run """${node}"" ""${main}"" start", 0, False`, ""].join("\r\n");
 }
 const AUMID_BASE = { "chrome.exe": "Chrome", "msedge.exe": "MSEdge", "brave.exe": "Brave", "chromium.exe": "Chromium" };
 export function appUserModelId(browserPath, url = "http://127.0.0.1:4810/", profileDirName = "browser") {
@@ -42,13 +42,13 @@ public static class LnkAumid {
   }
 }`;
 const psq = (s) => s.replace(/'/g, "''");
-export function shortcutScript(lnk, wscript, vbs, root, ico, aumid = null) {
+export function shortcutScript(lnk, wscript, vbs, workingDir, ico, aumid = null) {
     const lines = [
         "$ErrorActionPreference = 'Stop'",
         `$s = (New-Object -ComObject WScript.Shell).CreateShortcut('${psq(lnk)}')`,
         `$s.TargetPath = '${psq(wscript)}'`,
         `$s.Arguments = '"${psq(vbs)}"'`,
-        `$s.WorkingDirectory = '${psq(root)}'`,
+        `$s.WorkingDirectory = '${psq(workingDir)}'`,
         `$s.Description = 'viberoom: rooms for you and your coding agents'`,
         ico ? `$s.IconLocation = '${psq(ico)},0'` : "",
         "$s.Save()",
@@ -82,8 +82,8 @@ export function windowsShortcutPaths(home, env, desktop) {
         targets.push(join(home, "Desktop", "viberoom.lnk"));
     return targets;
 }
-export function desktopEntry(node, main, icon) {
-    return ["[Desktop Entry]", "Type=Application", "Name=viberoom", "Comment=Rooms for you and your coding agents", `Exec="${node}" "${main}" start`, `Icon=${icon}`, "Terminal=false", "StartupWMClass=viberoom", "Categories=Development;Chat;", ""].join("\n");
+export function desktopEntry(node, main, icon, workingDir) {
+    return ["[Desktop Entry]", "Type=Application", "Name=viberoom", "Comment=Rooms for you and your coding agents", `Exec="${node}" "${main}" start`, `Path=${workingDir}`, `Icon=${icon}`, "Terminal=false", "StartupWMClass=viberoom", "Categories=Development;Chat;", ""].join("\n");
 }
 export function macPlist(version) {
     return `<?xml version="1.0" encoding="UTF-8"?>
@@ -113,7 +113,7 @@ export function installShortcuts(o) {
     const icnsSrc = join(o.root, "assets", "icon.icns");
     if (platform === "win32") {
         const vbs = join(launcherDir, "viberoom.vbs");
-        writeFileSync(vbs, vbsLauncher(o.node, main));
+        writeFileSync(vbs, vbsLauncher(o.node, main, o.dataDir));
         result.files.push(vbs);
         let ico = null;
         if (existsSync(icoSrc)) {
@@ -126,7 +126,7 @@ export function installShortcuts(o) {
         const aumid = appUserModelId(browser, "http://127.0.0.1:4810/", basename(join(o.dataDir, "browser")));
         for (const lnk of windowsShortcutPaths(home, env, o.desktop)) {
             mkdirSync(join(lnk, ".."), { recursive: true });
-            const r = spawnSync("powershell", ["-NoProfile", "-Command", shortcutScript(lnk, wscript, vbs, o.root, ico, aumid)], { encoding: "utf8" });
+            const r = spawnSync("powershell", ["-NoProfile", "-Command", shortcutScript(lnk, wscript, vbs, o.dataDir, ico, aumid)], { encoding: "utf8" });
             if (r.status === 0)
                 result.files.push(lnk);
             else
@@ -142,7 +142,7 @@ export function installShortcuts(o) {
         mkdirSync(join(app, "Contents", "Resources"), { recursive: true });
         writeFileSync(join(app, "Contents", "Info.plist"), macPlist(o.version));
         const exe = join(app, "Contents", "MacOS", "viberoom");
-        writeFileSync(exe, `#!/bin/sh\nexec "${o.node}" "${main}" start\n`);
+        writeFileSync(exe, `#!/bin/sh\ncd "${o.dataDir}" 2>/dev/null\nexec "${o.node}" "${main}" start\n`);
         chmodSync(exe, 0o755);
         if (existsSync(icnsSrc))
             copyFileSync(icnsSrc, join(app, "Contents", "Resources", "icon.icns"));
@@ -157,7 +157,7 @@ export function installShortcuts(o) {
         copyFileSync(pngSrc, icon);
         result.files.push(icon);
     }
-    const entry = desktopEntry(o.node, main, icon);
+    const entry = desktopEntry(o.node, main, icon, o.dataDir);
     const appsDir = join(home, ".local", "share", "applications");
     mkdirSync(appsDir, { recursive: true });
     const menuEntry = join(appsDir, "viberoom.desktop");

package/dist/skills.js

@@ -4,6 +4,7 @@ import { join, resolve } from "node:path";
 import { isReservedSkillName, RESERVED_SKILL_NAMES } from "./commands.js";
 export const SKILL_NAME_PATTERN = /^[A-Za-z0-9][A-Za-z0-9_-]{0,31}$/;
 export const SKILL_FILE = "SKILL.md";
+import { ROOM_DESIGNER_NAME } from "./persona.js";
 export const BUILTIN_AUTHOR = "viberoom";
 export const HUMAN_AUTHOR = "human";
 const DESCRIPTION_MAX = 300;
@@ -85,6 +86,29 @@ export const SKILL_WRITER = {
     reviewed: true,
     draft: false,
 };
+export const ROOM_DESIGNER = {
+    name: ROOM_DESIGNER_NAME,
+    description: "How to design a good viberoom room: rules, vibemates and settings, as a template or as a change to this room. Load it before lint_room_design, create_template or propose_room_changes.",
+    argumentHint: "",
+    body: [
+        "A room is a protocol between one human and a few vibemates. The hub already tells every vibemate the mechanics (who it is, @Name addressing, the [silent] reply, tools, language, Markdown); your design adds only what the mechanics do not say. Facts about the settings (keys, bounds, defaults, current values) come from the describe_room tool; do not guess them.",
+        "",
+        "Rules are the protocol; roles are the people. Write how the vibemates work together once, in the room rules, where all of them read it. A role says who this one is and which way it leans, then ends with \"Everything else is in the room rules\". Two roles that each restate the protocol drift apart.",
+        "",
+        "Every rule answers a question this room will actually meet. Find the questions before you write the rules: walk through a working day of this particular room and stop wherever two answers are possible. Who acts, who waits, who decides, what \"done\" looks like, what happens when they disagree. The set differs per room: a pair sharing one codebase has to settle ownership and reporting; a room where one drafts and another critiques has to settle when the critique comes and what it is measured against; a room that only answers questions may need almost nothing. A rule that answers no foreseeable question is weight the vibemate carries on every turn.",
+        "",
+        "Explain, do not enumerate: a rule with its reason generalises (\"Reply only when addressed: every message to agents costs a turn\"); a list of cases fails at the first case not on it. Silence is a design tool: the most useful rule in a multi-mate room is the one that keeps a vibemate at [silent] when a message does not concern it. Pair it with the settings: agentsWakeEachOther off and a low hopLimit for rooms that report to the human; on and higher (about three times the number of vibemates) for rooms that work things out among themselves. Each vibemate works only on its own task and never touches the other's; when a report changes something the other relies on, it is addressed to the other with one line saying what is wanted.",
+        "",
+        "Names: short, distinct first letters, ideally a hint of the leaning that survives translation. The tagline is the one line the others see in the roster: what this one leans to and what it does when asked. Keep the whole thing short: eight to twelve rules, one per line, is a full protocol; a role is a few sentences; if a rule needs a paragraph it is a skill, not a rule. Do not pin an agent or model in a template: the human picks from what the machine has.",
+        "",
+        "Before you write anything: describe_room for the facts, then lint_room_design with your draft and read its warnings and the brief preview (that is exactly what the vibemates will read). Play the risky cases against the rules: an unaddressed task, both starting at once, one finding a bug in the other's work unasked, a question in the middle of a task. Then create_template (a file the human picks from; no effect on any room) or propose_room_changes (a card the human applies or rejects; nothing changes without the click). Say in the room what you made and why, in a few lines.",
+    ].join("\n"),
+    userInvocable: true,
+    agentInvocable: true,
+    author: BUILTIN_AUTHOR,
+    reviewed: true,
+    draft: false,
+};
 export function parseFrontmatter(text) {
     const normalized = text.replace(/^/, "").replace(/\r\n/g, "\n");
     const match = normalized.match(/^---\n([\s\S]*?)\n---\n?([\s\S]*)$/);
@@ -151,8 +175,10 @@ export function renderSkillBody(body, args) {
         .replace(/\r\n/g, "\n")
         .trim();
 }
+export const BUILTIN_SKILLS = [SKILL_WRITER, ROOM_DESIGNER];
 export function isBuiltinSkill(name) {
-    return name.trim().toLowerCase() === SKILL_WRITER.name;
+    const lower = name.trim().toLowerCase();
+    return BUILTIN_SKILLS.some((b) => b.name === lower);
 }
 export class SkillLibrary {
     dir;
@@ -253,7 +279,7 @@ export class SkillLibrary {
         });
     }
     seedBuiltins() {
-        for (const builtin of [SKILL_WRITER]) {
+        for (const builtin of BUILTIN_SKILLS) {
             const folder = this.folderFor(builtin.name);
             const current = folder ? this.load(folder) : undefined;
             if (current && current.description === builtin.description && current.body === builtin.body && (current.argumentHint ?? "") === (builtin.argumentHint ?? ""))