viberoom 0.5.7 → 0.5.8

package/README.md

@@ -14,7 +14,7 @@ Open a room, summon the agents you already have, give each one a role, and let t
 </p>
 
 <p align="center">
-  <img src="https://raw.githubusercontent.com/todor-rusev/viberoom/main/docs/screenshots/conversation.png" width="960" alt="A Wren & Quinn room: Wren explains a git command from a screenshot, Quinn adds the part that changes whose problem it is">
+  <img src="https://raw.githubusercontent.com/todor-rusev/viberoom/main/docs/screenshots/conversation.png" width="960" alt="A room with two vibemates: one explains a git command from a screenshot, the other adds the part that changes whose problem it is">
 </p>
 
 <p align="center">

package/dist/main.js

@@ -192,7 +192,8 @@ function openWindow(url, options, log) {
         }
         catch {
         }
-        spawn(chromium, args, { detached: true, stdio: "ignore" }).unref();
+        mkdirSync(options.dataDir, { recursive: true });
+        spawn(chromium, args, { cwd: options.dataDir, detached: true, stdio: "ignore" }).unref();
         if (process.platform === "win32") {
             const shortcuts = windowsShortcutPaths(homedir(), process.env, true).filter((p) => existsSync(p));
             if (shortcuts.length)
@@ -325,7 +326,7 @@ async function startBackground(options, log, info) {
     const args = [fileURLToPath(import.meta.url), "serve", "--port", String(options.port), "--data-dir", options.dataDir, "--no-open"];
     if (options.name)
         args.push("--name", options.name);
-    const child = spawn(process.execPath, args, { detached: true, stdio: ["ignore", fd, fd], windowsHide: true });
+    const child = spawn(process.execPath, args, { cwd: options.dataDir, detached: true, stdio: ["ignore", fd, fd], windowsHide: true });
     child.unref();
     closeSync(fd);
     log.info(`hub started in the background (pid ${child.pid}); log: ${logPath}`);

package/dist/server.js

@@ -193,7 +193,7 @@ export function startServer(hub, port, log, info, onShutdownRequest) {
             if (!latest)
                 throw new Error("no newer version is known; check for updates first");
             log.info(`installing viberoom ${latest} (npm install -g)`);
-            const result = await installUpdate(latest);
+            const result = await installUpdate(latest, hub.dataDir);
             if (!result.ok)
                 throw new Error(`npm install failed: ${result.output.slice(-600) || "no output"}`);
             log.info(`viberoom ${latest} installed; starting the new build, which replaces this hub`);

package/dist/shortcuts.js

@@ -4,8 +4,8 @@ import { chmodSync, copyFileSync, existsSync, mkdirSync, writeFileSync } from "n
 import { homedir } from "node:os";
 import { basename, join } from "node:path";
 import { findChromium } from "./launcher.js";
-export function vbsLauncher(node, main) {
-    return ["' viberoom: start the hub without a console window and open the app window.", 'Set sh = CreateObject("WScript.Shell")', `sh.Run """${node}"" ""${main}"" start", 0, False`, ""].join("\r\n");
+export function vbsLauncher(node, main, workingDir) {
+    return ["' viberoom: start the hub without a console window and open the app window.", 'Set sh = CreateObject("WScript.Shell")', `sh.CurrentDirectory = "${workingDir}"`, `sh.Run """${node}"" ""${main}"" start", 0, False`, ""].join("\r\n");
 }
 const AUMID_BASE = { "chrome.exe": "Chrome", "msedge.exe": "MSEdge", "brave.exe": "Brave", "chromium.exe": "Chromium" };
 export function appUserModelId(browserPath, url = "http://127.0.0.1:4810/", profileDirName = "browser") {
@@ -42,13 +42,13 @@ public static class LnkAumid {
   }
 }`;
 const psq = (s) => s.replace(/'/g, "''");
-export function shortcutScript(lnk, wscript, vbs, root, ico, aumid = null) {
+export function shortcutScript(lnk, wscript, vbs, workingDir, ico, aumid = null) {
     const lines = [
         "$ErrorActionPreference = 'Stop'",
         `$s = (New-Object -ComObject WScript.Shell).CreateShortcut('${psq(lnk)}')`,
         `$s.TargetPath = '${psq(wscript)}'`,
         `$s.Arguments = '"${psq(vbs)}"'`,
-        `$s.WorkingDirectory = '${psq(root)}'`,
+        `$s.WorkingDirectory = '${psq(workingDir)}'`,
         `$s.Description = 'viberoom: rooms for you and your coding agents'`,
         ico ? `$s.IconLocation = '${psq(ico)},0'` : "",
         "$s.Save()",
@@ -82,8 +82,8 @@ export function windowsShortcutPaths(home, env, desktop) {
         targets.push(join(home, "Desktop", "viberoom.lnk"));
     return targets;
 }
-export function desktopEntry(node, main, icon) {
-    return ["[Desktop Entry]", "Type=Application", "Name=viberoom", "Comment=Rooms for you and your coding agents", `Exec="${node}" "${main}" start`, `Icon=${icon}`, "Terminal=false", "StartupWMClass=viberoom", "Categories=Development;Chat;", ""].join("\n");
+export function desktopEntry(node, main, icon, workingDir) {
+    return ["[Desktop Entry]", "Type=Application", "Name=viberoom", "Comment=Rooms for you and your coding agents", `Exec="${node}" "${main}" start`, `Path=${workingDir}`, `Icon=${icon}`, "Terminal=false", "StartupWMClass=viberoom", "Categories=Development;Chat;", ""].join("\n");
 }
 export function macPlist(version) {
     return `<?xml version="1.0" encoding="UTF-8"?>
@@ -113,7 +113,7 @@ export function installShortcuts(o) {
     const icnsSrc = join(o.root, "assets", "icon.icns");
     if (platform === "win32") {
         const vbs = join(launcherDir, "viberoom.vbs");
-        writeFileSync(vbs, vbsLauncher(o.node, main));
+        writeFileSync(vbs, vbsLauncher(o.node, main, o.dataDir));
         result.files.push(vbs);
         let ico = null;
         if (existsSync(icoSrc)) {
@@ -126,7 +126,7 @@ export function installShortcuts(o) {
         const aumid = appUserModelId(browser, "http://127.0.0.1:4810/", basename(join(o.dataDir, "browser")));
         for (const lnk of windowsShortcutPaths(home, env, o.desktop)) {
             mkdirSync(join(lnk, ".."), { recursive: true });
-            const r = spawnSync("powershell", ["-NoProfile", "-Command", shortcutScript(lnk, wscript, vbs, o.root, ico, aumid)], { encoding: "utf8" });
+            const r = spawnSync("powershell", ["-NoProfile", "-Command", shortcutScript(lnk, wscript, vbs, o.dataDir, ico, aumid)], { encoding: "utf8" });
             if (r.status === 0)
                 result.files.push(lnk);
             else
@@ -142,7 +142,7 @@ export function installShortcuts(o) {
         mkdirSync(join(app, "Contents", "Resources"), { recursive: true });
         writeFileSync(join(app, "Contents", "Info.plist"), macPlist(o.version));
         const exe = join(app, "Contents", "MacOS", "viberoom");
-        writeFileSync(exe, `#!/bin/sh\nexec "${o.node}" "${main}" start\n`);
+        writeFileSync(exe, `#!/bin/sh\ncd "${o.dataDir}" 2>/dev/null\nexec "${o.node}" "${main}" start\n`);
         chmodSync(exe, 0o755);
         if (existsSync(icnsSrc))
             copyFileSync(icnsSrc, join(app, "Contents", "Resources", "icon.icns"));
@@ -157,7 +157,7 @@ export function installShortcuts(o) {
         copyFileSync(pngSrc, icon);
         result.files.push(icon);
     }
-    const entry = desktopEntry(o.node, main, icon);
+    const entry = desktopEntry(o.node, main, icon, o.dataDir);
     const appsDir = join(home, ".local", "share", "applications");
     mkdirSync(appsDir, { recursive: true });
     const menuEntry = join(appsDir, "viberoom.desktop");

package/dist/update.js

@@ -74,10 +74,10 @@ export function installCommandLine(version) {
         throw new Error(`not a version: ${version}`);
     return `npm install -g viberoom@${version} --no-audit --no-fund`;
 }
-export function installUpdate(version) {
+export function installUpdate(version, cwd) {
     const line = installCommandLine(version);
     return new Promise((resolve) => {
-        const child = process.platform === "win32" ? spawn(line, { shell: true, windowsHide: true }) : spawn("npm", line.split(" ").slice(1));
+        const child = process.platform === "win32" ? spawn(line, { cwd, shell: true, windowsHide: true }) : spawn("npm", line.split(" ").slice(1), { cwd });
         let output = "";
         const collect = (chunk) => {
             output = (output + chunk.toString()).slice(-4000);
@@ -90,6 +90,6 @@ export function installUpdate(version) {
 }
 export function restartWithNewBuild(mainModuleUrl, port, dataDir) {
     const main = fileURLToPath(mainModuleUrl);
-    const child = spawn(process.execPath, [main, "start", "--port", String(port), "--data-dir", dataDir, "--no-open"], { detached: true, stdio: "ignore", windowsHide: true });
+    const child = spawn(process.execPath, [main, "start", "--port", String(port), "--data-dir", dataDir, "--no-open"], { cwd: dataDir, detached: true, stdio: "ignore", windowsHide: true });
     child.unref();
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "viberoom",
-  "version": "0.5.7",
+  "version": "0.5.8",
   "description": "viberoom: group chat rooms for a human and several coding agents over the Agent Client Protocol",
   "type": "module",
   "engines": {

package/scripts/install.mjs

@@ -11,9 +11,14 @@ const args = new Set(process.argv.slice(2));
 const dataDir = process.env.VIBEROOM_DATA_DIR ? resolve(process.env.VIBEROOM_DATA_DIR) : join(homedir(), ".viberoom");
 const isWin = process.platform === "win32";
 
+function npmEnv() {
+  return Object.fromEntries(Object.entries(process.env).filter(([name]) => !/^npm_config_/i.test(name)));
+}
+
 function run(cmd, cmdArgs, opts = {}) {
   console.log(`> ${cmd} ${cmdArgs.join(" ")}`);
-  const r = isWin && cmd === "npm" ? spawnSync(`npm ${cmdArgs.join(" ")}`, { cwd: root, stdio: "inherit", shell: true, ...opts }) : spawnSync(cmd, cmdArgs, { cwd: root, stdio: "inherit", ...opts });
+  const env = cmd === "npm" ? npmEnv() : process.env;
+  const r = isWin && cmd === "npm" ? spawnSync(`npm ${cmdArgs.join(" ")}`, { cwd: root, stdio: "inherit", env, shell: true, ...opts }) : spawnSync(cmd, cmdArgs, { cwd: root, stdio: "inherit", env, ...opts });
   if (r.status !== 0) throw new Error(`${cmd} ${cmdArgs.join(" ")} failed with exit code ${r.status}`);
 }
 

package/scripts/update.mjs

@@ -10,9 +10,14 @@ const args = new Set(process.argv.slice(2));
 const isWin = process.platform === "win32";
 const main = join(root, "dist", "main.js");
 
+function npmEnv() {
+  return Object.fromEntries(Object.entries(process.env).filter(([name]) => !/^npm_config_/i.test(name)));
+}
+
 function run(cmd, cmdArgs, opts = {}) {
   console.log(`> ${cmd} ${cmdArgs.join(" ")}`);
-  const r = isWin && cmd === "npm" ? spawnSync(`npm ${cmdArgs.join(" ")}`, { cwd: root, stdio: "inherit", shell: true, ...opts }) : spawnSync(cmd, cmdArgs, { cwd: root, stdio: "inherit", ...opts });
+  const env = cmd === "npm" ? npmEnv() : process.env;
+  const r = isWin && cmd === "npm" ? spawnSync(`npm ${cmdArgs.join(" ")}`, { cwd: root, stdio: "inherit", env, shell: true, ...opts }) : spawnSync(cmd, cmdArgs, { cwd: root, stdio: "inherit", env, ...opts });
   if (r.status !== 0) throw new Error(`${cmd} ${cmdArgs.join(" ")} failed with exit code ${r.status}`);
 }
 

package/templates/maken-and-elaine/template.json

@@ -0,0 +1,30 @@
+{
+  "name": "Maken & Elaine",
+  "order": 1,
+  "emoji": "⚒️",
+  "recommended": true,
+  "description": "Two equals around one piece of work. Maken makes by default, Elaine explains by default; either does either when asked, and either reviews the other's work when you ask for it. The way viberoom itself was made.",
+  "settings": {
+    "language": {
+      "mode": "follow-human"
+    },
+    "turnTaking": "parallel",
+    "agentsWakeEachOther": true,
+    "hopLimit": 24,
+    "customRules": "Both make, both explain, both review; @ decides who does what. Without @, a task goes to the one who has worked on that part the most, or most recently; if neither has touched it, to Maken. A question without @ goes to Elaine.\nThe human decides when work is reviewed: ask the other one to review it. Unasked, the other answers questions and otherwise stays silent; it does not review, comment on or extend work it was not asked about. When asked to review, first say in one line what you will check, then check it by that criterion: a number, a live check, the risky case. Whoever made it reports to the human. Address the other vibemate too only when the report changes something it works on or relies on: a shared file, an interface, a convention, a measurement that overturns its claim; then say in one line what you want from it (\"nothing, for your context\" counts). Otherwise it reads the report later, unaddressed. A report is never a request for review; only the human asks for one. Finished work is reported as: what changed (the files, and the commit if the project uses version control), how to verify it (a command, a script, a screenshot), what was not verified, what is left.\nMeasure before diagnosing; say no with a reason and a cheaper alternative; keep replies short.\nWork only on your own task, never on the other's; do not touch what the other is working on.\nReply only when addressed. On a message to everyone, only the one it concerns answers; the other stays silent. Never add to, correct or comment on the other's reply unless the human asks.\nFollow the conventions of the project you work in (its instructions, notes, tests). Where it keeps decision notes, write the decision there before reporting it here.\nRead every proposal and analyse it; agree or reject only with a real argument. Never concede to be agreeable, never object to seem rigorous.\nReply in the human's language. Code identifiers, commands, file paths, protocol and tool names stay exactly as in the code; established technical terms (kernel, thread, commit, pull request, layout) stay in English."
+  },
+  "vibemates": [
+    {
+      "name": "Maken",
+      "tagline": "makes by default; explains and reviews when asked",
+      "role": "You are Maken, one of two equal vibemates, Maken and Elaine. You lean to making: a task without an address is yours when it touches what you have made, or when neither of you has; before you change anything, read what is already there, the notes, the docs and the files, and keep each change small. Everything else is in the room rules.",
+      "avatar": "🔨"
+    },
+    {
+      "name": "Elaine",
+      "tagline": "explains by default; makes and reviews when asked",
+      "role": "You are Elaine, one of two equal vibemates, Maken and Elaine. You lean to explaining: a question without an address is yours; when you review, it is by a criterion, not an impression. Everything else is in the room rules.",
+      "avatar": "💡"
+    }
+  ]
+}

package/templates/wren-and-quinn/template.json

@@ -1,30 +0,0 @@
-{
-  "name": "Wren & Quinn",
-  "order": 1,
-  "emoji": "⚒️",
-  "recommended": true,
-  "description": "Two equals around one codebase. Wren builds by default, Quinn explains by default; either does either when asked, and either reviews the other's work when you ask for it. The way viberoom itself was built.",
-  "settings": {
-    "language": {
-      "mode": "follow-human"
-    },
-    "turnTaking": "parallel",
-    "agentsWakeEachOther": true,
-    "hopLimit": 24,
-    "customRules": "Both build, both explain, both review; @ decides who does what. Without @, a task goes to the one who has worked on that part the most, or most recently; if neither has touched it, to Wren. A question without @ goes to Quinn.\nThe human decides when work is reviewed: ask the other one to review it. Unasked, the other answers questions and otherwise stays silent; it does not review, comment on or extend work it was not asked about. When asked to review, first say in one line what you will check, then check it by that criterion: a number, a live check, the risky case. Whoever built reports to the human. Address the other vibemate too only when the report changes something it works on or relies on: a shared file, an interface, a convention, a measurement that overturns its claim; then say in one line what you want from it (\"nothing, for your context\" counts). Otherwise it reads the report later, unaddressed. A report is never a request for review; only the human asks for one. A build is reported as: what changed (the files, and the commit if the project uses version control), how to verify it (a command, a script, a screenshot), what was not verified, what is left.\nMeasure before diagnosing; say no with a reason and a cheaper alternative; keep replies short.\nWork only on your own task, never on the other's; do not touch what the other is working on.\nReply only when addressed. On a message to everyone, only the one it concerns answers; the other stays silent. Never add to, correct or comment on the other's reply unless the human asks.\nFollow the conventions of the project you work in (its instructions, notes, tests). Where it keeps decision notes, write the decision there before reporting it here.\nRead every proposal and analyse it; agree or reject only with a real argument. Never concede to be agreeable, never object to seem rigorous.\nReply in the human's language. Code identifiers, commands, file paths, protocol and tool names stay exactly as in the code; established technical terms (kernel, thread, commit, pull request, layout) stay in English."
-  },
-  "vibemates": [
-    {
-      "name": "Wren",
-      "tagline": "builds by default; explains and reviews when asked",
-      "role": "You are Wren, one of two equal vibemates, Wren and Quinn. You lean to building: a task without an address is yours when it touches what you have built, or when neither of you has; before you change anything, read what is already there, the notes, the docs and the code, and keep each change small. Everything else is in the room rules.",
-      "avatar": "🔨"
-    },
-    {
-      "name": "Quinn",
-      "tagline": "explains by default; builds and reviews when asked",
-      "role": "You are Quinn, one of two equal vibemates, Wren and Quinn. You lean to explaining: a question without an address is yours; when you review, it is by a criterion, not an impression. Everything else is in the room rules.",
-      "avatar": "💡"
-    }
-  ]
-}