viberag 0.2.0 → 0.3.0

package/README.md

@@ -580,7 +580,7 @@ Choose your embedding provider during `/init`:
 | Provider | Model                  | Dims | Cost      | Get API Key                                             |
 | -------- | ---------------------- | ---- | --------- | ------------------------------------------------------- |
 | Gemini   | gemini-embedding-001   | 1536 | Free tier | [Google AI Studio](https://aistudio.google.com)         |
-| Mistral  | codestral-embed        | 1024 | $0.10/1M  | [Mistral Console](https://console.mistral.ai/api-keys/) |
+| Mistral  | codestral-embed        | 1536 | $0.10/1M  | [Mistral Console](https://console.mistral.ai/api-keys/) |
 | OpenAI   | text-embedding-3-small | 1536 | $0.02/1M  | [OpenAI Platform](https://platform.openai.com/api-keys) |
 
 - **Gemini** - Free tier available, great for getting started

package/dist/cli/commands/mcp-setup.d.ts

@@ -47,7 +47,7 @@ export declare function generateMcpConfig(editor: EditorConfig): object;
 export declare function generateTomlConfig(): string;
 /**
  * Read existing TOML config file.
- * Returns the raw content string.
+ * Returns the raw content string, or null if file doesn't exist or can't be read.
  */
 export declare function readTomlConfig(configPath: string): Promise<string | null>;
 /**

package/dist/cli/commands/mcp-setup.js

@@ -150,13 +150,20 @@ args = ["-y", "viberag-mcp"]
 }
 /**
  * Read existing TOML config file.
- * Returns the raw content string.
+ * Returns the raw content string, or null if file doesn't exist or can't be read.
  */
 export async function readTomlConfig(configPath) {
     try {
         return await fs.readFile(configPath, 'utf-8');
     }
-    catch {
+    catch (error) {
+        // Log non-ENOENT errors to help with debugging
+        if (error instanceof Error && 'code' in error) {
+            const code = error.code;
+            if (code !== 'ENOENT') {
+                console.warn(`[mcp-setup] Failed to read ${configPath}: ${code} - ${error.message}`);
+            }
+        }
         return null;
     }
 }
@@ -242,7 +249,20 @@ export async function readJsonConfig(configPath) {
         const stripped = stripJsonComments(content);
         return JSON.parse(stripped);
     }
-    catch {
+    catch (error) {
+        // Log non-ENOENT errors to help with debugging
+        if (error instanceof Error) {
+            if ('code' in error) {
+                const code = error.code;
+                if (code !== 'ENOENT') {
+                    console.warn(`[mcp-setup] Failed to read ${configPath}: ${code} - ${error.message}`);
+                }
+            }
+            else if (error instanceof SyntaxError) {
+                // JSON parse error
+                console.warn(`[mcp-setup] Failed to parse ${configPath}: ${error.message}`);
+            }
+        }
         return null;
     }
 }

package/dist/cli/components/CleanWizard.js

@@ -73,7 +73,22 @@ export function CleanWizard({ projectRoot, viberagDir, onComplete, onCancel, add
             setViberagRemoved(true);
         }
         catch (error) {
-            addOutput('system', `Failed to remove ${viberagDir}: ${error instanceof Error ? error.message : String(error)}`);
+            const message = error instanceof Error ? error.message : String(error);
+            // Check if directory just doesn't exist (not critical)
+            const isNotFound = error instanceof Error &&
+                'code' in error &&
+                error.code === 'ENOENT';
+            if (isNotFound) {
+                // Directory doesn't exist - that's fine, consider it removed
+                setViberagRemoved(true);
+            }
+            else {
+                // Critical failure (permission denied, etc.) - stop cleanup
+                addOutput('system', `Failed to remove ${viberagDir}: ${message}`);
+                addOutput('system', 'Stopping cleanup due to critical failure.');
+                setStep('summary');
+                return;
+            }
         }
         const results = [];
         // Clean project MCP configs if requested

package/dist/cli/components/InitWizard.js

@@ -2,7 +2,7 @@
  * Multi-step initialization wizard component.
  * Guides users through embedding provider selection and API key configuration.
  */
-import React, { useState } from 'react';
+import React, { useState, useEffect } from 'react';
 import { Box, Text, useInput } from 'ink';
 import SelectInput from 'ink-select-input';
 /**
@@ -48,7 +48,7 @@ const PROVIDER_CONFIG = {
         name: 'Gemini',
         model: 'gemini-embedding-001',
         modelFull: 'gemini-embedding-001',
-        dims: '768',
+        dims: '1536',
         context: '2K',
         cost: 'Free tier',
         note: 'API key required',
@@ -58,7 +58,7 @@ const PROVIDER_CONFIG = {
         name: 'Mistral',
         model: 'codestral-embed',
         modelFull: 'codestral-embed',
-        dims: '1024',
+        dims: '1536',
         context: '8K',
         cost: '$0.10/1M',
         note: 'API key required',
@@ -98,13 +98,13 @@ const FRONTIER_MODELS_DATA = [
     {
         Provider: 'Gemini',
         Model: 'gemini-embedding-001',
-        Dims: '768',
+        Dims: '1536',
         Cost: 'Free tier',
     },
     {
         Provider: 'Mistral',
         Model: 'codestral-embed',
-        Dims: '1024',
+        Dims: '1536',
         Cost: '$0.10/1M',
     },
     {
@@ -178,21 +178,35 @@ const API_KEY_ACTION_ITEMS = [
 ];
 /**
  * Simple text input component for API key entry.
+ * Uses a ref to accumulate input, which handles paste better than
+ * relying on React state updates between rapid useInput calls.
  */
 function ApiKeyInputStep({ providerName, apiKeyInput, setApiKeyInput, onSubmit, }) {
+    // Use a ref to accumulate input - avoids closure stale state issues during rapid paste
+    const inputRef = React.useRef(apiKeyInput);
+    inputRef.current = apiKeyInput;
     // Handle text input (supports paste)
     useInput((input, key) => {
         if (key.return) {
-            onSubmit(apiKeyInput);
+            onSubmit(inputRef.current);
         }
         else if (key.backspace || key.delete) {
-            setApiKeyInput(apiKeyInput.slice(0, -1));
+            setApiKeyInput(inputRef.current.slice(0, -1));
         }
         else if (!key.ctrl && !key.meta && input) {
             // Add printable characters (supports multi-char paste)
-            setApiKeyInput(apiKeyInput + input);
+            // Filter out control characters that might slip through
+            // eslint-disable-next-line no-control-regex
+            const printable = input.replace(/[\x00-\x1F\x7F]/g, '');
+            if (printable) {
+                setApiKeyInput(inputRef.current + printable);
+            }
         }
     });
+    // Mask API key display (show first 7 and last 4 chars)
+    const maskedKey = apiKeyInput.length > 15
+        ? `${apiKeyInput.slice(0, 7)}${'•'.repeat(Math.min(apiKeyInput.length - 11, 20))}${apiKeyInput.slice(-4)}`
+        : apiKeyInput;
     return (React.createElement(Box, { marginTop: 1, flexDirection: "column" },
         React.createElement(Text, null,
             "Enter your ",
@@ -200,8 +214,12 @@ function ApiKeyInputStep({ providerName, apiKeyInput, setApiKeyInput, onSubmit,
             " API key:"),
         React.createElement(Box, { marginTop: 1 },
             React.createElement(Text, { color: "blue" }, "> "),
-            React.createElement(Text, null, apiKeyInput),
+            React.createElement(Text, null, maskedKey),
             React.createElement(Text, { color: "gray" }, "\u2588")),
+        apiKeyInput.length > 0 && (React.createElement(Text, { dimColor: true },
+            "Length: ",
+            apiKeyInput.length,
+            " characters")),
         apiKeyInput.trim() === '' && (React.createElement(Text, { color: "yellow", dimColor: true }, "API key is required")),
         React.createElement(Text, { dimColor: true }, "Press Enter to continue")));
 }
@@ -221,13 +239,19 @@ export function InitWizard({ step, config, isReinit, existingApiKey, existingPro
     // Check if current provider is a cloud provider
     const currentProvider = config.provider ?? 'local';
     const needsApiKey = isCloudProvider(currentProvider);
-    // Check if we have an existing API key for the same provider
-    const hasExistingKeyForProvider = existingApiKey && existingProvider === currentProvider;
     // Compute effective step (adjusted for non-reinit flow)
     // Steps: 0=reinit confirm, 1=provider select, 2=api key (cloud only), 3=final confirm
     const effectiveStep = normalizedIsReinit
         ? normalizedStep
         : normalizedStep + 1;
+    // Auto-advance past API key step for local providers (must be in useEffect, not render)
+    useEffect(() => {
+        if (effectiveStep === 2 && !needsApiKey) {
+            onStepChange(normalizedStep + 1);
+        }
+    }, [effectiveStep, needsApiKey, normalizedStep, onStepChange]);
+    // Check if we have an existing API key for the same provider
+    const hasExistingKeyForProvider = existingApiKey && existingProvider === currentProvider;
     // Step 0 (reinit only): Confirmation
     if (normalizedIsReinit && normalizedStep === 0) {
         return (React.createElement(Box, { flexDirection: "column", borderStyle: "round", paddingX: 2, paddingY: 1 },
@@ -264,12 +288,10 @@ export function InitWizard({ step, config, isReinit, existingApiKey, existingPro
                 React.createElement(Text, { dimColor: true }, "\u2191/\u2193 navigate, Enter select, Esc cancel"))));
     }
     // Step 2: API Key input (cloud providers only)
-    // For local providers, skip to step 3 (confirmation)
+    // For local providers, skip to step 3 (confirmation) - handled by useEffect above
     if (effectiveStep === 2) {
-        // Skip API key step for local providers
+        // Show loading while useEffect auto-advances for local providers
         if (!needsApiKey) {
-            // Auto-advance to confirmation
-            onStepChange(normalizedStep + 1);
             return (React.createElement(Box, null,
                 React.createElement(Text, { dimColor: true }, "Loading...")));
         }

package/dist/common/types.d.ts

@@ -82,8 +82,8 @@ export type IndexDisplayStats = {
  * - local-4b: Qwen3-Embedding-4B FP32 (2560d) - ~8GB download, ~8GB RAM
  *
  * API providers:
- * - gemini: gemini-embedding-001 (768d) - Free tier
- * - mistral: codestral-embed (1024d) - Code-optimized
+ * - gemini: gemini-embedding-001 (1536d) - Free tier
+ * - mistral: codestral-embed (1536d) - Code-optimized
  * - openai: text-embedding-3-small (1536d) - Fast API
  */
 export type EmbeddingProviderType = 'local' | 'local-4b' | 'gemini' | 'mistral' | 'openai';

package/dist/mcp/index.js

@@ -13,7 +13,7 @@ import { createMcpServer } from './server.js';
 import { configExists, Indexer } from '../rag/index.js';
 // Use current working directory as project root (same behavior as CLI)
 const projectRoot = process.cwd();
-const { server, startWatcher, stopWatcher, startWarmup } = createMcpServer(projectRoot);
+const { server, startWatcher, stopWatcher, startWarmup, warmupManager } = createMcpServer(projectRoot);
 // Handle shutdown signals
 async function shutdown(signal) {
     console.error(`[viberag-mcp] Received ${signal}, shutting down...`);
@@ -35,6 +35,10 @@ setImmediate(async () => {
         if (await configExists(projectRoot)) {
             startWarmup();
             console.error('[viberag-mcp] Warmup started');
+            // Monitor warmup completion for logging (non-blocking)
+            warmupManager.getWarmupPromise()?.catch(error => {
+                console.error('[viberag-mcp] Warmup failed:', error instanceof Error ? error.message : error);
+            });
         }
     }
     catch (error) {

package/dist/mcp/warmup.d.ts

@@ -59,6 +59,11 @@ export declare class WarmupManager {
      * Check if warmup is in progress.
      */
     isInitializing(): boolean;
+    /**
+     * Get the warmup promise for external error monitoring.
+     * Returns null if warmup hasn't started.
+     */
+    getWarmupPromise(): Promise<SearchEngine> | null;
     /**
      * Start warmup if not already started.
      * Returns immediately - doesn't wait for completion.

package/dist/mcp/warmup.js

@@ -65,6 +65,13 @@ export class WarmupManager {
     isInitializing() {
         return this.state.status === 'initializing';
     }
+    /**
+     * Get the warmup promise for external error monitoring.
+     * Returns null if warmup hasn't started.
+     */
+    getWarmupPromise() {
+        return this.warmupPromise;
+    }
     /**
      * Start warmup if not already started.
      * Returns immediately - doesn't wait for completion.

package/dist/rag/config/index.d.ts

@@ -48,6 +48,10 @@ export declare const DEFAULT_CONFIG: ViberagConfig;
  * Load config from disk, merging with defaults.
  * Returns DEFAULT_CONFIG if no config file exists.
  * Handles nested watch config merge for backward compatibility.
+ *
+ * IMPORTANT: If the config file exists but can't be read/parsed,
+ * this throws an error instead of silently falling back to defaults.
+ * This prevents dimension mismatches when switching providers.
  */
 export declare function loadConfig(projectRoot: string): Promise<ViberagConfig>;
 /**

package/dist/rag/config/index.js

@@ -18,7 +18,7 @@ export const PROVIDER_CONFIGS = {
     },
     mistral: {
         model: 'codestral-embed',
-        dimensions: 1024,
+        dimensions: 1536,
     },
     openai: {
         model: 'text-embedding-3-small',
@@ -65,26 +65,50 @@ export const DEFAULT_CONFIG = {
  * Load config from disk, merging with defaults.
  * Returns DEFAULT_CONFIG if no config file exists.
  * Handles nested watch config merge for backward compatibility.
+ *
+ * IMPORTANT: If the config file exists but can't be read/parsed,
+ * this throws an error instead of silently falling back to defaults.
+ * This prevents dimension mismatches when switching providers.
  */
 export async function loadConfig(projectRoot) {
     const configPath = getConfigPath(projectRoot);
+    // First check if the file exists
     try {
-        const content = await fs.readFile(configPath, 'utf-8');
-        const loaded = JSON.parse(content);
-        // Deep merge watch config with defaults
-        const watchConfig = {
-            ...DEFAULT_WATCH_CONFIG,
-            ...(loaded.watch ?? {}),
-        };
-        return {
-            ...DEFAULT_CONFIG,
-            ...loaded,
-            watch: watchConfig,
-        };
+        await fs.access(configPath);
     }
     catch {
+        // Config doesn't exist - return defaults (expected for first run)
         return { ...DEFAULT_CONFIG };
     }
+    // File exists - must be readable and valid
+    // Don't silently fall back to defaults as this could cause dimension mismatches
+    const content = await fs.readFile(configPath, 'utf-8');
+    let loaded;
+    try {
+        loaded = JSON.parse(content);
+    }
+    catch (parseError) {
+        throw new Error(`Invalid config.json at ${configPath}: ${parseError instanceof Error ? parseError.message : String(parseError)}`);
+    }
+    // Validate embedding dimensions match provider
+    const provider = loaded.embeddingProvider ?? DEFAULT_CONFIG.embeddingProvider;
+    const expectedDimensions = PROVIDER_CONFIGS[provider]?.dimensions;
+    if (expectedDimensions && loaded.embeddingDimensions !== expectedDimensions) {
+        // Dimensions mismatch - this can happen after provider change
+        // Auto-correct to prevent search failures
+        loaded.embeddingDimensions = expectedDimensions;
+        loaded.embeddingModel = PROVIDER_CONFIGS[provider].model;
+    }
+    // Deep merge watch config with defaults
+    const watchConfig = {
+        ...DEFAULT_WATCH_CONFIG,
+        ...(loaded.watch ?? {}),
+    };
+    return {
+        ...DEFAULT_CONFIG,
+        ...loaded,
+        watch: watchConfig,
+    };
 }
 /**
  * Save config to disk.

package/dist/rag/embeddings/gemini.js

@@ -35,7 +35,8 @@ export class GeminiEmbeddingProvider {
             writable: true,
             value: false
         });
-        this.apiKey = apiKey ?? '';
+        // Trim the key to remove any accidental whitespace
+        this.apiKey = (apiKey ?? '').trim();
     }
     async initialize(_onProgress) {
         if (!this.apiKey) {
@@ -60,11 +61,12 @@ export class GeminiEmbeddingProvider {
         return results;
     }
     async embedBatch(texts) {
-        const url = `${GEMINI_API_BASE}/${MODEL}:batchEmbedContents?key=${this.apiKey}`;
+        const url = `${GEMINI_API_BASE}/${MODEL}:batchEmbedContents`;
         const response = await fetch(url, {
             method: 'POST',
             headers: {
                 'Content-Type': 'application/json',
+                'x-goog-api-key': this.apiKey,
             },
             body: JSON.stringify({
                 requests: texts.map(text => ({
@@ -78,8 +80,20 @@ export class GeminiEmbeddingProvider {
             }),
         });
         if (!response.ok) {
-            const error = await response.text();
-            throw new Error(`Gemini API error: ${response.status} - ${error}`);
+            const errorText = await response.text();
+            let errorMessage;
+            try {
+                const errorJson = JSON.parse(errorText);
+                errorMessage = errorJson.error?.message || errorText;
+            }
+            catch {
+                errorMessage = errorText;
+            }
+            if (response.status === 400 || response.status === 403) {
+                throw new Error(`Gemini API authentication failed (${response.status}). ` +
+                    `Verify your API key at https://aistudio.google.com/apikey. Error: ${errorMessage}`);
+            }
+            throw new Error(`Gemini API error (${response.status}): ${errorMessage}`);
         }
         const data = (await response.json());
         return data.embeddings.map(e => e.values);
@@ -88,11 +102,12 @@ export class GeminiEmbeddingProvider {
         if (!this.initialized) {
             await this.initialize();
         }
-        const url = `${GEMINI_API_BASE}/${MODEL}:embedContent?key=${this.apiKey}`;
+        const url = `${GEMINI_API_BASE}/${MODEL}:embedContent`;
         const response = await fetch(url, {
             method: 'POST',
             headers: {
                 'Content-Type': 'application/json',
+                'x-goog-api-key': this.apiKey,
             },
             body: JSON.stringify({
                 model: `models/${MODEL}`,
@@ -104,8 +119,20 @@ export class GeminiEmbeddingProvider {
             }),
         });
         if (!response.ok) {
-            const error = await response.text();
-            throw new Error(`Gemini API error: ${response.status} - ${error}`);
+            const errorText = await response.text();
+            let errorMessage;
+            try {
+                const errorJson = JSON.parse(errorText);
+                errorMessage = errorJson.error?.message || errorText;
+            }
+            catch {
+                errorMessage = errorText;
+            }
+            if (response.status === 400 || response.status === 403) {
+                throw new Error(`Gemini API authentication failed (${response.status}). ` +
+                    `Verify your API key at https://aistudio.google.com/apikey. Error: ${errorMessage}`);
+            }
+            throw new Error(`Gemini API error (${response.status}): ${errorMessage}`);
         }
         const data = (await response.json());
         return data.embedding.values;

package/dist/rag/embeddings/index.d.ts

@@ -7,4 +7,5 @@ export { Local4BEmbeddingProvider } from './local-4b.js';
 export { LocalEmbeddingProvider } from './local.js';
 export { MistralEmbeddingProvider } from './mistral.js';
 export { OpenAIEmbeddingProvider } from './openai.js';
+export { validateApiKey, type ValidationResult } from './validate.js';
 export type { EmbeddingProvider, ModelProgressCallback } from './types.js';

package/dist/rag/embeddings/index.js

@@ -7,3 +7,4 @@ export { Local4BEmbeddingProvider } from './local-4b.js';
 export { LocalEmbeddingProvider } from './local.js';
 export { MistralEmbeddingProvider } from './mistral.js';
 export { OpenAIEmbeddingProvider } from './openai.js';
+export { validateApiKey } from './validate.js';

package/dist/rag/embeddings/mistral.d.ts

@@ -1,7 +1,7 @@
 /**
  * Mistral embedding provider using Mistral AI API.
  *
- * Uses codestral-embed model (1024 dimensions).
+ * Uses codestral-embed model (1536 dimensions).
  * Optimized for code and technical content.
  */
 import type { EmbeddingProvider, ModelProgressCallback } from './types.js';
@@ -10,7 +10,7 @@ import type { EmbeddingProvider, ModelProgressCallback } from './types.js';
  * Uses codestral-embed model via Mistral AI API.
  */
 export declare class MistralEmbeddingProvider implements EmbeddingProvider {
-    readonly dimensions = 1024;
+    readonly dimensions = 1536;
     private apiKey;
     private initialized;
     constructor(apiKey?: string);

package/dist/rag/embeddings/mistral.js

@@ -1,7 +1,7 @@
 /**
  * Mistral embedding provider using Mistral AI API.
  *
- * Uses codestral-embed model (1024 dimensions).
+ * Uses codestral-embed model (1536 dimensions).
  * Optimized for code and technical content.
  */
 const MISTRAL_API_BASE = 'https://api.mistral.ai/v1';
@@ -17,7 +17,7 @@ export class MistralEmbeddingProvider {
             enumerable: true,
             configurable: true,
             writable: true,
-            value: 1024
+            value: 1536
         });
         Object.defineProperty(this, "apiKey", {
             enumerable: true,
@@ -31,7 +31,8 @@ export class MistralEmbeddingProvider {
             writable: true,
             value: false
         });
-        this.apiKey = apiKey ?? '';
+        // Trim the key to remove any accidental whitespace
+        this.apiKey = (apiKey ?? '').trim();
     }
     async initialize(_onProgress) {
         if (!this.apiKey) {
@@ -68,8 +69,20 @@ export class MistralEmbeddingProvider {
             }),
         });
         if (!response.ok) {
-            const error = await response.text();
-            throw new Error(`Mistral API error: ${response.status} - ${error}`);
+            const errorText = await response.text();
+            let errorMessage;
+            try {
+                const errorJson = JSON.parse(errorText);
+                errorMessage = errorJson.message || errorJson.detail || errorText;
+            }
+            catch {
+                errorMessage = errorText;
+            }
+            if (response.status === 401) {
+                throw new Error(`Mistral API authentication failed (401). ` +
+                    `Verify your API key at https://console.mistral.ai/api-keys. Error: ${errorMessage}`);
+            }
+            throw new Error(`Mistral API error (${response.status}): ${errorMessage}`);
         }
         const data = (await response.json());
         // Sort by index to ensure correct order

package/dist/rag/embeddings/openai.js

@@ -31,12 +31,17 @@ export class OpenAIEmbeddingProvider {
             writable: true,
             value: false
         });
-        this.apiKey = apiKey ?? '';
+        // Trim the key to remove any accidental whitespace
+        this.apiKey = (apiKey ?? '').trim();
     }
     async initialize(_onProgress) {
         if (!this.apiKey) {
             throw new Error('OpenAI API key required. Run /init to configure your API key.');
         }
+        // Validate key format (should start with sk-)
+        if (!this.apiKey.startsWith('sk-')) {
+            throw new Error(`Invalid OpenAI API key format. Key should start with "sk-" but got "${this.apiKey.slice(0, 3)}..."`);
+        }
         this.initialized = true;
     }
     async embed(texts) {
@@ -68,8 +73,22 @@ export class OpenAIEmbeddingProvider {
             }),
         });
         if (!response.ok) {
-            const error = await response.text();
-            throw new Error(`OpenAI API error: ${response.status} - ${error}`);
+            const errorText = await response.text();
+            let errorMessage;
+            try {
+                const errorJson = JSON.parse(errorText);
+                errorMessage = errorJson.error?.message || errorText;
+            }
+            catch {
+                errorMessage = errorText;
+            }
+            // Provide helpful context for common errors
+            if (response.status === 401) {
+                const keyPreview = `${this.apiKey.slice(0, 7)}...${this.apiKey.slice(-4)}`;
+                throw new Error(`OpenAI API authentication failed (401). Key format: ${keyPreview}. ` +
+                    `Verify your API key at https://platform.openai.com/api-keys. Error: ${errorMessage}`);
+            }
+            throw new Error(`OpenAI API error (${response.status}): ${errorMessage}`);
         }
         const data = (await response.json());
         // Sort by index to ensure correct order

package/dist/rag/embeddings/validate.d.ts

@@ -0,0 +1,22 @@
+/**
+ * API key validation for cloud embedding providers.
+ *
+ * Makes a minimal test embedding call to verify the API key is valid
+ * before proceeding with indexing.
+ */
+import type { EmbeddingProviderType } from '../../common/types.js';
+/**
+ * Result of API key validation.
+ */
+export interface ValidationResult {
+    valid: boolean;
+    error?: string;
+}
+/**
+ * Validate an API key by making a minimal test embedding call.
+ *
+ * @param provider - The embedding provider type
+ * @param apiKey - The API key to validate
+ * @returns Validation result with error message if invalid
+ */
+export declare function validateApiKey(provider: EmbeddingProviderType, apiKey: string): Promise<ValidationResult>;