viber-channel 0.8.22 → 0.8.23

package/lib/gateway_features.ts

@@ -0,0 +1,76 @@
+/**
+ * gateway_features.ts — which `capabilities.version` this runner may announce (#647).
+ *
+ * The server refuses a NAMED agent to a runner announcing < 2. That refusal is the only stop
+ * BEFORE launch: an older gateway ignores `--name` (and an unknown verb falls through to its
+ * startup sweep), so the runner must never announce 2 unless its gateway says it carries `name`.
+ * Probed with `<gateway> version`; any failure, timeout or unreadable output → 1 (fail closed).
+ *
+ * A 2 is cached for the life of the process. A 1 is re-probed after `RETRY_ONE_MS`: an owner
+ * who updates viber-gateway must not have to restart the runner too (Opus step-02 review).
+ * The probe is SYNCHRONOUS (up to its 5 s timeout) on the heartbeat that runs it — bounded,
+ * and at most once per retry window.
+ */
+import { execFileSync } from "./hidden_proc.js";
+import { viberGatewayBaseCmd } from "./runner_exec.js";
+
+export type VersionProbe = (base: string[]) => string;
+
+/** The default probe: no shell, short timeout; throws on non-zero exit or spawn error. */
+export const spawnVersionProbe: VersionProbe = (base) =>
+  // execFileSync throws on spawn error, non-zero exit and timeout — all three mean "announce 1".
+  execFileSync(base[0] as string, [...base.slice(1), "version"], {
+    timeout: 5_000,
+    encoding: "utf-8",
+    stdio: ["ignore", "pipe", "ignore"],
+  });
+
+/** The feature tokens of a `viber-gateway <ver> features=a,b` line; [] when absent. */
+export function parseGatewayFeatures(output: string): string[] {
+  const line = output.split(/\r?\n/).find((l) => l.startsWith("viber-gateway ")) ?? "";
+  const m = / features=(\S+)/.exec(line);
+  return m ? (m[1] as string).split(",").filter((t) => t.length > 0) : [];
+}
+
+export function capabilitiesVersionFrom(output: string): 1 | 2 {
+  return parseGatewayFeatures(output).includes("name") ? 2 : 1;
+}
+
+const RETRY_ONE_MS = 10 * 60 * 1000;
+
+let cached: 1 | 2 | undefined;
+let cachedAt = 0;
+let probeBase: string[] | undefined;
+
+/** #632 app mode: the gateway IS this process — probe it, not a `viber-gateway` on PATH. */
+export function setGatewayProbeBase(base: string[]): void {
+  probeBase = base;
+}
+
+export function announcedCapabilitiesVersion(
+  probe: VersionProbe = spawnVersionProbe,
+  log: (line: string) => void = (l) => process.stderr.write(`${l}\n`),
+  now: () => number = Date.now,
+): 1 | 2 {
+  if (cached === 2) return cached;
+  if (cached === 1 && now() - cachedAt < RETRY_ONE_MS) return cached;
+  cachedAt = now();
+  let out: string;
+  try {
+    out = probe(probeBase ?? viberGatewayBaseCmd());
+  } catch (err) {
+    log(`[runner] gateway version probe failed (${String(err)}): announcing capabilities.version 1 — named agents refused`);
+    cached = 1;
+    return cached;
+  }
+  cached = capabilitiesVersionFrom(out);
+  if (cached === 1) log(`[runner] gateway has no 'name' feature (${out.trim().slice(0, 80)}): announcing capabilities.version 1`);
+  return cached;
+}
+
+/** Tests only. */
+export function resetGatewayFeatureProbe(): void {
+  cached = undefined;
+  cachedAt = 0;
+  probeBase = undefined;
+}

package/lib/gateway_result.ts

@@ -65,6 +65,8 @@ export interface ParsedGatewayResult {
    *  caller has a proven FAILURE with no cause to render — which is honest, and is not a success. */
   reason?: SpawnReason;
   detail?: string;
+  /** #647: the agent name the gateway echoes for a `--name` spawn. Absent from an older gateway. */
+  agentName?: string;
 }
 
 /**
@@ -115,8 +117,10 @@ export function parseGatewayResult(
       reason,
       detail,
       noVerdictTreeMayStand,
+      agentName,
       nonce: echoed,
     } = parsed as {
+      agentName?: unknown;
       verdict?: unknown;
       reason?: unknown;
       detail?: unknown;
@@ -141,6 +145,7 @@ export function parseGatewayResult(
       ...(typeof detail === "string" && detail.length > 0
         ? { detail: detail.slice(0, DETAIL_MAX) }
         : {}),
+      ...(typeof agentName === "string" ? { agentName } : {}),
     };
   }
   return null;

package/lib/runner_exec.ts

@@ -48,6 +48,9 @@ export interface ClaimedCommand {
   /** #627: `relaunch` brings back ONE agent from the runner's registry; absent = team. */
   kind?: "team" | "relaunch";
   relaunch_instance_id?: string | null;
+  /** #647: a ONE-agent spawn — its role and chosen label (both or neither, server-side). */
+  agent_role?: string | null;
+  agent_label?: string | null;
 }
 
 export interface RunnerAuthLite {
@@ -208,6 +211,11 @@ export function validateAgainstPolicy(cmd: ClaimedCommand, policy: RunnerPolicy)
   // never something that could be read as a flag by vibe-master.
   if (!ARGV_NAME_RE.test(cmd.prefix)) return `invalid prefix '${cmd.prefix}'`;
   if (cmd.team_name !== null && !ARGV_NAME_RE.test(cmd.team_name)) return `invalid team_name '${cmd.team_name}'`;
+  // #647: the chosen label becomes argv AND the agent id — same charset, and one agent only.
+  if (cmd.agent_label != null) {
+    if (!ARGV_NAME_RE.test(cmd.agent_label)) return `invalid agent_label '${cmd.agent_label}'`;
+    if (totalAgents !== 1) return `agent_label '${cmd.agent_label}' names one agent, the spec has ${totalAgents}`;
+  }
   const cap = PERMISSION_RANK[policy.maxPermission] ?? 1;
   for (const r of roles) {
     if (!policy.allowedRuntimes.includes(r.runtime)) return `runtime '${r.runtime}' not allowed locally`;
@@ -231,6 +239,8 @@ export type TeamSpawnRunner = (
   recap: string;
   reason?: SpawnReason;
   detail?: string;
+  /** #647: the agent name the launcher confirms it launched (gateway marker echo). */
+  agentName?: string;
   /**
    * ⚠⚠ #590: **the LAUNCHER states whether the desired state was already in place** — the reader
    * no longer infers it from a bare `reason` string.
@@ -451,6 +461,8 @@ export function buildGatewayTeamArgs(cmd: {
   env?: string;
   nonce: string;
   vibeMasterCmd?: string;
+  /** #647: the chosen label of a one-agent spawn. Absent = argv unchanged. */
+  agentName?: string;
 }): string[] {
   const args = [
     "team",
@@ -495,6 +507,7 @@ export function buildGatewayTeamArgs(cmd: {
     cmd.nonce,
   ];
   if (cmd.env) args.push("--env", cmd.env);
+  if (cmd.agentName !== undefined) args.push("--name", cmd.agentName);
   // #627: the gateway writes the team into the runner registry, keyed by project.
   if (cmd.projectId !== undefined) args.push("--project", String(cmd.projectId));
   // ▶ Only when set: an empty `--vibe-master-cmd` would make the gateway resolve an
@@ -555,6 +568,7 @@ export const gatewayTeamSpawnWith = (base: string[]): TeamSpawnRunner => (args,
           recap,
           ...(parsed?.reason ? { reason: parsed.reason } : {}),
           ...(parsed?.detail ? { detail: parsed.detail } : {}),
+          ...(parsed?.agentName !== undefined ? { agentName: parsed.agentName } : {}),
         });
       },
     );
@@ -892,6 +906,7 @@ export async function executeClaim(
       permission: cmd.template_spec.roles[0]?.permission ?? "read-only",
       ...(launchEnv.env ? { env: launchEnv.env } : {}),
       nonce,
+      ...(cmd.agent_label ? { agentName: cmd.agent_label } : {}),
       // ⚠ See (3) on `buildGatewayTeamArgs`: the runner no longer launches
       // `vibe-master`, so this must TRAVEL or dev silently uses the installed
       // binary. Read from the env here, where the variable is already the
@@ -904,8 +919,17 @@ export async function executeClaim(
     });
 
     inflight.mark(cmd.id); // durable "started here" BEFORE launch (C4)
-    const { ok, recap, reason, detail, nothingToDo: launcherSaysNothingToDo } =
-      await runTeamSpawn(args, nonce);
+    const launched = await runTeamSpawn(args, nonce);
+    // #647 FAIL CLOSED: a chosen name the launcher does not echo back (an older gateway ignores
+    // `--name`) is a failure, never a success under another name.
+    // A launcher that FAILED keeps its own reason; only a claimed success is re-checked.
+    const nameUnconfirmed =
+      !!cmd.agent_label &&
+      (launched.ok || launched.nothingToDo === true) &&
+      launched.agentName !== cmd.agent_label;
+    const { recap, reason, detail } = launched;
+    const ok = launched.ok && !nameUnconfirmed;
+    const launcherSaysNothingToDo = nameUnconfirmed ? false : launched.nothingToDo;
     // ⚠⚠ JP's arbitration of 2026-08-27: a replayed spawn that is CORRECTLY de-duplicated is a
     // NORMAL outcome, not a failure. ▶ Measured live (TIR D): second emission of the same command
     // -> `member: existing`, ONE record, ONE manifest, same jobName, same host anchor. **Nothing is
@@ -947,6 +971,7 @@ export async function executeClaim(
         project_id: cmd.project_id ?? null,
         workspace,
         roles: cmd.template_spec.roles,
+        ...(cmd.agent_label ? { agent_name: cmd.agent_label } : {}),
       });
     }
 
@@ -991,17 +1016,21 @@ export async function executeClaim(
         : {
             fencing_token: cmd.fencing_token,
             status: "failed",
-            error: reason
+            error: nameUnconfirmed
+              ? `the launcher on that machine did not confirm the agent name '${cmd.agent_label}' — ` +
+                "update viber-gateway; it may have launched under another name, see " +
+                (logRef ?? "the machine's log")
+              : reason
               ? messageForReason(
                   reason,
                   detail,
-                  rosterNames(cmd.prefix, cmd.template_spec.roles),
+                  cmd.agent_label ? [cmd.agent_label] : rosterNames(cmd.prefix, cmd.template_spec.roles),
                   logRef,
                 )
               : logRef
                 ? `team spawn failed — see ${logRef} on that machine`
                 : "team spawn failed, and the local log could not be written on that machine",
-            ...(reason ? { reason } : {}),
+            ...(reason && !nameUnconfirmed ? { reason } : {}),
           },
       fetchImpl,
     );

package/lib/runner_registry.ts

@@ -250,6 +250,8 @@ export interface SpawnForRegistry {
   project_id: number | null;
   workspace: string;
   roles: readonly (RegistryRole & { count?: number })[];
+  /** #647: the chosen label of a ONE-agent spawn; replaces `{prefix}-{role}`. */
+  agent_name?: string;
 }
 
 /**
@@ -259,8 +261,17 @@ export interface SpawnForRegistry {
 export function rosterMembers(
   prefix: string,
   roles: readonly (RegistryRole & { count?: number })[],
+  agentName?: string,
 ): { name: string; role: RegistryRole }[] {
   const members: { name: string; role: RegistryRole }[] = [];
+  // #647: a chosen name is ONE agent. On a wider roster nothing is recorded rather than
+  // one member mislabelled — the launch path refuses that roster anyway.
+  if (agentName !== undefined) {
+    const only = roles.length === 1 ? roles[0] : undefined;
+    if (!only || (only.count ?? 1) !== 1) return [];
+    const { count: _count, ...role } = only;
+    return [{ name: agentName, role }];
+  }
   for (const r of roles) {
     const { count, ...role } = r;
     const n = count && count > 1 ? count : 1;
@@ -280,7 +291,7 @@ export function rosterMembers(
  */
 export function recordSpawn(registry: Registry, spawn: SpawnForRegistry, now: number): void {
   pruneClosed(registry, now);
-  for (const { name, role } of rosterMembers(spawn.prefix, spawn.roles)) {
+  for (const { name, role } of rosterMembers(spawn.prefix, spawn.roles, spawn.agent_name)) {
     registry.entries[registryKey(spawn.project_id, name)] = {
       name,
       command_id: spawn.command_id,

package/lib/runner_roster.ts

@@ -30,6 +30,7 @@ import {
   readPresenceRecord,
 } from "./presence_record.js";
 import { enumerateStartTimes } from "./process_start.js";
+import { announcedCapabilitiesVersion } from "./gateway_features.js";
 import { runnerIdentity } from "./runner_exec.js";
 import * as reg from "./runner_registry.js";
 import type { SeenAgent } from "./runner_registry.js";
@@ -337,6 +338,8 @@ export interface RosterBeatDeps {
   now?: () => number;
   log?: (line: string) => void;
   headers?: () => Record<string, string>;
+  /** #647: the announced capabilities version (default: the cached gateway probe). */
+  capabilitiesVersion?: () => 1 | 2;
 }
 
 /**
@@ -398,7 +401,7 @@ async function rosterBeatOnce(auth: RosterBeatAuth, deps: RosterBeatDeps): Promi
         ...(deps.headers?.() ?? {}),
       },
       body: JSON.stringify({
-        capabilities: { runtimes: ["claude-code", "codex", "gemma"], platform: process.platform, version: 1 },
+        capabilities: { runtimes: ["claude-code", "codex", "gemma"], platform: process.platform, version: (deps.capabilitiesVersion ?? announcedCapabilitiesVersion)() },
         // #627 (JP, decision A): the new instance of each pair takes the old one's
         // conversations — the server re-invites it once it is online.
         roster: replaced.length > 0 ? { ...collected.roster, replaced } : collected.roster,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "viber-channel",
-  "version": "0.8.22",
+  "version": "0.8.23",
   "description": "Voice + text MCP channel between a Claude Code session and the Viber UI (https://viber.dgypx.dev). Push transcripts to Claude; send_message tool delivers text back to the UI.",
   "type": "module",
   "bin": {