vibe-splain 2.7.0 → 2.7.1

package/dist/index.js

@@ -2175,7 +2175,6 @@ import { join as join7 } from "path";
 import { writeFile as writeFile7, readFile as readFile6 } from "fs/promises";
 var FUNCTION_TYPES2 = /* @__PURE__ */ new Set([
   "function_declaration",
-  "function",
   "function_expression",
   "arrow_function",
   "method_definition",
@@ -2191,24 +2190,33 @@ var FUNCTION_TYPES2 = /* @__PURE__ */ new Set([
 function firstLine2(s) {
   return s.split("\n")[0].trim();
 }
+function walkNodes(node, cb) {
+  cb(node);
+  for (let i = 0; i < node.childCount; i++) {
+    const child = node.child(i);
+    if (child)
+      walkNodes(child, cb);
+  }
+}
 function resolveCallee(node) {
   if (node.type === "identifier") {
     return { root: node.text, prop: null };
   }
-  if (node.type === "member_expression" || node.type === "property_identifier") {
+  if (node.type === "member_expression") {
     const obj = node.childForFieldName("object");
     const prop = node.childForFieldName("property");
     if (obj && prop) {
-      if (obj.type === "identifier") {
-        return { root: obj.text, prop: prop.text };
-      } else {
-        const nested = resolveCallee(obj);
-        if (nested) {
-          return { root: nested.root, prop: nested.prop ? `${nested.prop}.${prop.text}` : prop.text };
-        }
+      const nested = resolveCallee(obj);
+      if (nested) {
+        return { root: nested.root, prop: nested.prop ? `${nested.prop}.${prop.text}` : prop.text };
       }
     }
   }
+  if (node.type === "parenthesized_expression" || node.type === "await_expression") {
+    const inner = node.namedChildren.find((c) => c.type !== "(" && c.type !== ")" && c.type !== "await");
+    if (inner)
+      return resolveCallee(inner);
+  }
   return null;
 }
 async function runActionBinding(projectRoot, inv, res) {
@@ -2255,25 +2263,26 @@ async function runActionBinding(projectRoot, inv, res) {
       });
     }
     const functions = [];
+    const nodeToRecord = /* @__PURE__ */ new Map();
     if (!w.tree)
       continue;
-    const walkNodes = (node, cb) => {
-      cb(node);
-      for (const child of node.children)
-        walkNodes(child, cb);
-    };
-    const functionNodes = [];
+    const allNodes = [];
     walkNodes(w.tree.rootNode, (n) => {
-      if (FUNCTION_TYPES2.has(n.type))
-        functionNodes.push(n);
+      allNodes.push(n);
     });
-    for (const node of functionNodes) {
+    for (const node of allNodes) {
+      if (!FUNCTION_TYPES2.has(node.type))
+        continue;
+      const startLine = node.startPosition.row + 1;
+      const startCol = node.startPosition.column;
+      const endLine = node.endPosition.row + 1;
+      const isDuplicate = functions.some((f) => f.startLine === startLine && f.endLine === endLine);
+      if (isDuplicate)
+        continue;
       functionsExtracted++;
       let displayName = "";
       let nameSource = "position_fallback";
       const p = node.parent;
-      const startLine = node.startPosition.row + 1;
-      const startCol = node.startPosition.column;
       if (node.childForFieldName("name")) {
         displayName = node.childForFieldName("name").text;
         nameSource = node.type === "method_definition" ? "method_definition" : "function_declaration";
@@ -2330,176 +2339,179 @@ async function runActionBinding(projectRoot, inv, res) {
         evidenceText: firstLine2(node.text).slice(0, 200)
       };
       functions.push(fnRecord);
+      nodeToRecord.set(node.id, fnRecord);
     }
-    for (const fnRecord of functions) {
-      const fnNode = functionNodes.find((n) => n.startPosition.row + 1 === fnRecord.startLine && n.startPosition.column === fnRecord.startCol);
-      if (!fnNode)
+    for (const node of allNodes) {
+      if (node.type !== "call_expression" && node.type !== "call")
         continue;
-      const callNodes = [];
-      walkNodes(fnNode, (n) => {
-        if (n.type === "call_expression")
-          callNodes.push(n);
-      });
-      for (const callNode of callNodes) {
-        let isNested = false;
-        let curr = callNode.parent;
-        while (curr && curr !== fnNode) {
-          if (FUNCTION_TYPES2.has(curr.type)) {
-            isNested = true;
-            break;
-          }
-          curr = curr.parent;
-        }
-        if (isNested)
-          continue;
-        callsExtracted++;
-        const calleeNode = callNode.childForFieldName("function");
-        if (!calleeNode)
-          continue;
-        let actualCalleeNode = calleeNode;
-        if (calleeNode.type === "await_expression" && calleeNode.children.length > 1) {
-          actualCalleeNode = calleeNode.children[1];
+      let curr = node.parent;
+      let containingFnRecord = null;
+      while (curr) {
+        const rec = nodeToRecord.get(curr.id);
+        if (rec) {
+          containingFnRecord = rec;
+          break;
         }
-        const resolvedCallee = resolveCallee(actualCalleeNode);
-        if (!resolvedCallee)
-          continue;
-        const { root: calleeRoot, prop: calleeProperty } = resolvedCallee;
-        const calleeText = actualCalleeNode.text.slice(0, 100);
-        const sourceLine = callNode.startPosition.row + 1;
-        const callId = `${fnRecord.functionId}::${calleeText}::${sourceLine}`;
-        let isSemantic = false;
-        let actionKind = null;
-        let targetModel = null;
-        let targetOperation = null;
-        if (calleeRoot === "prisma" && calleeProperty) {
-          if (/\.(create|update|upsert|delete|deleteMany|updateMany|createMany|executeRaw|queryRaw)$/.test("." + calleeProperty)) {
-            isSemantic = true;
-            actionKind = "database_write";
-            const parts = calleeProperty.split(".");
-            if (parts.length >= 2) {
-              targetModel = parts[0].charAt(0).toUpperCase() + parts[0].slice(1);
-              targetOperation = parts[parts.length - 1];
-            }
-          } else if (/\.(findMany|findUnique|findFirst|findFirstOrThrow|findUniqueOrThrow|count|aggregate|groupBy)$/.test("." + calleeProperty)) {
-            isSemantic = true;
-            actionKind = "database_read";
-            const parts = calleeProperty.split(".");
-            if (parts.length >= 2) {
-              targetModel = parts[0].charAt(0).toUpperCase() + parts[0].slice(1);
-              targetOperation = parts[parts.length - 1];
-            }
+        curr = curr.parent;
+      }
+      if (!containingFnRecord)
+        continue;
+      callsExtracted++;
+      const calleeNode = node.childForFieldName("function") || node.namedChild(0);
+      if (!calleeNode)
+        continue;
+      const resolvedCallee = resolveCallee(calleeNode);
+      if (!resolvedCallee)
+        continue;
+      const { root: calleeRoot, prop: calleeProperty } = resolvedCallee;
+      const calleeText = calleeNode.text.slice(0, 100);
+      const sourceLine = node.startPosition.row + 1;
+      let isSemantic = false;
+      let actionKind = null;
+      let targetModel = null;
+      let targetOperation = null;
+      if (calleeRoot === "prisma" && calleeProperty) {
+        if (/\.(create|update|upsert|delete|deleteMany|updateMany|createMany|executeRaw|queryRaw)$/.test("." + calleeProperty)) {
+          isSemantic = true;
+          actionKind = "database_write";
+          const parts = calleeProperty.split(".");
+          if (parts.length >= 2) {
+            targetModel = parts[0].charAt(0).toUpperCase() + parts[0].slice(1);
+            targetOperation = parts[parts.length - 1];
+          }
+        } else if (/\.(findMany|findUnique|findFirst|findFirstOrThrow|findUniqueOrThrow|count|aggregate|groupBy)$/.test("." + calleeProperty)) {
+          isSemantic = true;
+          actionKind = "database_read";
+          const parts = calleeProperty.split(".");
+          if (parts.length >= 2) {
+            targetModel = parts[0].charAt(0).toUpperCase() + parts[0].slice(1);
+            targetOperation = parts[parts.length - 1];
           }
         }
-        if (!isSemantic) {
-          if (calleeRoot === "fetch" || calleeRoot === "axios" && calleeProperty && /\.(get|post|put|patch|delete)$/.test("." + calleeProperty)) {
-            isSemantic = true;
-            actionKind = "external_api_call";
-          } else if (/validate|schema\.parse|schema\.safeParse|z\.parse/i.test(calleeText) || /validate|validator/i.test(calleeRoot)) {
-            isSemantic = true;
-            actionKind = "validation";
-          } else if (/getSession|getServerSession|auth\(\)|verifyToken|requireAuth|checkPermission/i.test(calleeText) || /auth|session/i.test(calleeRoot) && calleeProperty && /check|verify|get|require/i.test("." + calleeProperty)) {
-            isSemantic = true;
-            actionKind = "auth_check";
-          } else if (/sendEmail|sendMail|mailer\./i.test(calleeText)) {
+      } else if (calleeRoot === "trpc" && calleeProperty && /\.(useMutation|mutate|mutateAsync)$/.test("." + calleeProperty)) {
+        isSemantic = true;
+        actionKind = "external_api_call";
+        const parts = calleeProperty.split(".");
+        if (parts.length >= 2) {
+          targetModel = parts[0];
+          targetOperation = parts[parts.length - 1];
+        }
+      }
+      if (!isSemantic) {
+        if (calleeRoot === "fetch" || calleeRoot === "axios" && calleeProperty && /\.(get|post|put|patch|delete)$/.test("." + calleeProperty)) {
+          isSemantic = true;
+          actionKind = "external_api_call";
+        } else if (/validate|schema\.parse|schema\.safeParse|z\.parse/i.test(calleeText) || /validate|validator/i.test(calleeRoot)) {
+          isSemantic = true;
+          actionKind = "validation";
+        } else if (/getSession|getServerSession|auth\(\)|verifyToken|requireAuth|checkPermission/i.test(calleeText) || /auth|session/i.test(calleeRoot) && calleeProperty && /check|verify|get|require/i.test("." + calleeProperty)) {
+          isSemantic = true;
+          actionKind = "auth_check";
+        } else if (/sendEmail|sendMail|mailer\./i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "email_send";
+        } else if (/createCalendarEvent|updateCalendarEvent|deleteCalendarEvent|calendar\.events\.(insert|update|delete)/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "calendar_mutation";
+        } else if (/triggerWebhook|sendWebhook|webhook\.send/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "webhook_delivery";
+        } else if (/stripe\.webhooks\.constructEvent|validateWebhook|verifySignature/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "webhook_ingress";
+        } else if (/revalidatePath|revalidateTag/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "cache_revalidation";
+        } else if (/posthog\.|mixpanel\.|amplitude\.|ga\(/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "analytics_event";
+        } else if (calleeRoot === "redirect" || /router|redirect|notFound|permanentRedirect/.test(calleeRoot) && calleeProperty && /push|replace|back/i.test("." + calleeProperty)) {
+          isSemantic = true;
+          actionKind = "redirect";
+        } else if (/cookies\(\)|headers\(\)/.test(calleeText) || calleeRoot === "cookies" || calleeRoot === "headers") {
+          isSemantic = true;
+          actionKind = "side_effect";
+        } else if (/checkRateLimitAndThrowError/i.test(calleeText)) {
+          isSemantic = true;
+          actionKind = "auth_check";
+        } else {
+          const emailImport = imports.find((i) => i.localName === calleeRoot && /nodemailer|resend|sendgrid|postmark|mailgun/i.test(i.moduleSpecifier));
+          if (emailImport) {
             isSemantic = true;
             actionKind = "email_send";
-          } else if (/createCalendarEvent|updateCalendarEvent|deleteCalendarEvent|calendar\.events\.(insert|update|delete)/i.test(calleeText)) {
-            isSemantic = true;
-            actionKind = "calendar_mutation";
-          } else if (/triggerWebhook|sendWebhook|webhook\.send/i.test(calleeText)) {
-            isSemantic = true;
-            actionKind = "webhook_delivery";
-          } else if (/stripe\.webhooks\.constructEvent|validateWebhook|verifySignature/i.test(calleeText)) {
-            isSemantic = true;
-            actionKind = "webhook_ingress";
-          } else if (/revalidatePath|revalidateTag/i.test(calleeText)) {
-            isSemantic = true;
-            actionKind = "cache_revalidation";
-          } else if (/posthog\.|mixpanel\.|amplitude\.|ga\(/i.test(calleeText)) {
-            isSemantic = true;
-            actionKind = "analytics_event";
-          } else if (calleeRoot === "redirect" || /router|redirect|notFound|permanentRedirect/.test(calleeRoot) && calleeProperty && /push|replace|back/i.test("." + calleeProperty)) {
-            isSemantic = true;
-            actionKind = "redirect";
-          } else {
-            const emailImport = imports.find((i) => i.localName === calleeRoot && /nodemailer|resend|sendgrid|postmark|mailgun/i.test(i.moduleSpecifier));
-            if (emailImport) {
-              isSemantic = true;
-              actionKind = "email_send";
-            }
           }
         }
-        if (isSemantic && actionKind) {
-          semanticActionsExtracted++;
-          const actionId = `${fnRecord.functionId}::${actionKind}::${sourceLine}`;
-          fnRecord.semanticActions.push({
-            actionId,
-            sourceFunctionId: fnRecord.functionId,
-            actionKind,
-            targetModel,
-            targetOperation,
-            calleeText,
-            sourceLine,
-            confidence: "high",
-            evidenceText: firstLine2(callNode.text).slice(0, 200)
-          });
-          if (!artifact.actionIndex[actionKind])
-            artifact.actionIndex[actionKind] = [];
-          artifact.actionIndex[actionKind].push(fnRecord.functionId);
-          if (targetModel) {
-            const key1 = `${actionKind}::${targetModel}`;
-            if (!artifact.actionIndex[key1])
-              artifact.actionIndex[key1] = [];
-            artifact.actionIndex[key1].push(fnRecord.functionId);
-            if (targetOperation) {
-              const key2 = `${actionKind}::${targetModel}::${targetOperation}`;
-              if (!artifact.actionIndex[key2])
-                artifact.actionIndex[key2] = [];
-              artifact.actionIndex[key2].push(fnRecord.functionId);
-            }
+      }
+      if (isSemantic && actionKind) {
+        semanticActionsExtracted++;
+        const actionId = `${containingFnRecord.functionId}::${actionKind}::${sourceLine}`;
+        containingFnRecord.semanticActions.push({
+          actionId,
+          sourceFunctionId: containingFnRecord.functionId,
+          actionKind,
+          targetModel,
+          targetOperation,
+          calleeText,
+          sourceLine,
+          confidence: "high",
+          evidenceText: firstLine2(node.text).slice(0, 200)
+        });
+        if (!artifact.actionIndex[actionKind])
+          artifact.actionIndex[actionKind] = [];
+        artifact.actionIndex[actionKind].push(containingFnRecord.functionId);
+        if (targetModel) {
+          const key1 = `${actionKind}::${targetModel}`;
+          if (!artifact.actionIndex[key1])
+            artifact.actionIndex[key1] = [];
+          artifact.actionIndex[key1].push(containingFnRecord.functionId);
+          if (targetOperation) {
+            const key2 = `${actionKind}::${targetModel}::${targetOperation}`;
+            if (!artifact.actionIndex[key2])
+              artifact.actionIndex[key2] = [];
+            artifact.actionIndex[key2].push(containingFnRecord.functionId);
           }
+        }
+      } else {
+        let resolvedTargetFunctionId = null;
+        let resolvedFilePath = null;
+        let resolutionKind = "unresolved";
+        let confidence = "unresolved";
+        const sameFileFn = functions.find((f) => f.displayName === calleeRoot);
+        if (sameFileFn) {
+          resolvedTargetFunctionId = sameFileFn.functionId;
+          resolutionKind = "same_file_function";
+          confidence = "high";
         } else {
-          let resolvedTargetFunctionId = null;
-          let resolvedFilePath = null;
-          let resolutionKind = "unresolved";
-          let confidence = "unresolved";
-          const sameFileFn = functions.find((f) => f.displayName === calleeRoot);
-          if (sameFileFn) {
-            resolvedTargetFunctionId = sameFileFn.functionId;
-            resolutionKind = "same_file_function";
+          const namedImp = imports.find((i) => i.localName === calleeRoot && i.importKind !== "namespace" && !i.isTypeOnly);
+          if (namedImp && namedImp.resolvedFilePath) {
+            resolvedFilePath = namedImp.resolvedFilePath;
+            resolutionKind = "named_import_match";
             confidence = "high";
           } else {
-            const namedImp = imports.find((i) => i.localName === calleeRoot && i.importKind !== "namespace" && !i.isTypeOnly);
-            if (namedImp && namedImp.resolvedFilePath) {
-              resolvedFilePath = namedImp.resolvedFilePath;
-              resolutionKind = "named_import_match";
-              confidence = "high";
-            } else {
-              const nsImp = imports.find((i) => i.localName === calleeRoot && i.importKind === "namespace");
-              if (nsImp && nsImp.resolvedFilePath) {
-                resolvedFilePath = nsImp.resolvedFilePath;
-                resolutionKind = "namespace_import_property";
-                confidence = "medium";
-              }
+            const nsImp = imports.find((i) => i.localName === calleeRoot && i.importKind === "namespace");
+            if (nsImp && nsImp.resolvedFilePath) {
+              resolvedFilePath = nsImp.resolvedFilePath;
+              resolutionKind = "namespace_import_property";
+              confidence = "medium";
             }
           }
-          if (resolutionKind !== "unresolved")
-            callsResolved++;
-          fnRecord.calls.push({
-            callId,
-            sourceFunctionId: fnRecord.functionId,
-            calleeText,
-            calleeRoot,
-            calleeProperty,
-            sourceLine,
-            sourceSpan: { startLine: callNode.startPosition.row + 1, endLine: callNode.endPosition.row + 1 },
-            resolvedTargetFunctionId,
-            resolvedFilePath,
-            resolutionKind,
-            confidence,
-            evidenceText: firstLine2(callNode.text).slice(0, 200)
-          });
         }
+        if (resolutionKind !== "unresolved")
+          callsResolved++;
+        containingFnRecord.calls.push({
+          callId: `${containingFnRecord.functionId}::${calleeText}::${sourceLine}`,
+          sourceFunctionId: containingFnRecord.functionId,
+          calleeText,
+          calleeRoot,
+          calleeProperty,
+          sourceLine,
+          sourceSpan: { startLine: node.startPosition.row + 1, endLine: node.endPosition.row + 1 },
+          resolvedTargetFunctionId,
+          resolvedFilePath,
+          resolutionKind,
+          confidence,
+          evidenceText: firstLine2(node.text).slice(0, 200)
+        });
       }
     }
     artifact.files[filePath] = {
@@ -2992,6 +3004,9 @@ async function runScoring(projectRoot, cr, binding) {
             const callPts = Math.min(3, resolvedOutbound);
             fnScore += callPts;
             reasons.push(`Has ${resolvedOutbound} resolved outbound calls`);
+          } else if (fn.calls.length > 0) {
+            fnScore += 1;
+            reasons.push(`Has ${fn.calls.length} outbound calls`);
           }
           const writesModel = fn.semanticActions.some((a) => a.actionKind === "database_write" && a.targetModel);
           if (writesModel) {
@@ -3003,10 +3018,15 @@ async function runScoring(projectRoot, cr, binding) {
             fnScore += 1;
             reasons.push("Performs auth/validation");
           }
+          const hasEvidenceOverlap = rawEvidence.some((e) => fn.startLine <= e.endLine && fn.endLine >= e.startLine);
+          if (hasEvidenceOverlap) {
+            fnScore += 2;
+            reasons.push("Overlaps with raw evidence span");
+          }
           return { fn, fnScore, reasons };
         });
         scoredFunctions.sort((a, b) => b.fnScore - a.fnScore);
-        const topFns = scoredFunctions.slice(0, 5);
+        const topFns = scoredFunctions.filter((x) => x.reasons.length > 0).slice(0, 5);
         if (topFns.length > 0) {
           criticalFunctions = topFns.map(({ fn, reasons }) => {
             const evidence = fn.semanticActions.slice(0, 5).sort((a, b) => a.sourceLine - b.sourceLine).map((a) => ({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibe-splain",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "description": "Architectural dossier engine for vibe-coded TypeScript/JavaScript projects. Runs as an MCP server inside your coding agent.",
   "type": "module",
   "license": "MIT",