vibe-gx 1.0.4 → 1.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibe-gx",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "A lightweight, regex-based Node.js web framework built for speed and simplicity.",
   "type": "module",
   "main": "vibe.js",

package/utils/core/handler.js

@@ -140,21 +140,34 @@ export async function runIntercept(intercept, req, res, isRoute = true) {
  */
 export function handleError(error, req, res) {
   const isDev = process.env.NODE_ENV !== "production";
+  const message = error.message || "Unknown error";
 
   // Log error (full stack in dev, message only in production)
   if (isDev) {
     console.error("[VIBE ERROR]:", error);
   } else {
-    console.error("[VIBE ERROR]:", error.message || "Unknown error");
+    console.error("[VIBE ERROR]:", message);
   }
 
   if (!res.headersSent) {
-    res.writeHead(500, { "content-type": "application/json" });
+    // Determine status code based on error type
+    let statusCode = 500;
+    let errorType = "Internal Server Error";
+
+    if (message.includes("exceeds max size")) {
+      statusCode = 413;
+      errorType = "Payload Too Large";
+    } else if (message.includes("not allowed")) {
+      statusCode = 415;
+      errorType = "Unsupported Media Type";
+    }
+
+    res.writeHead(statusCode, { "content-type": "application/json" });
 
     // Only expose error details in development
     const responseBody = isDev
-      ? { error: "Internal Server Error", message: error.message }
-      : { error: "Internal Server Error" };
+      ? { error: errorType, message }
+      : { error: errorType };
 
     res.end(JSON.stringify(responseBody));
   }

package/utils/core/parser.js

@@ -54,6 +54,19 @@ function parseMultipart(req, res, media, options, resolve, reject) {
   let bb;
   let fileError = null;
   const streaming = media.streaming === true;
+  let pendingWrites = 0;
+  let busboyFinished = false;
+
+  // Helper to check if we're done
+  const checkComplete = () => {
+    if (busboyFinished && pendingWrites === 0) {
+      if (fileError) {
+        reject(fileError);
+      } else {
+        resolve();
+      }
+    }
+  };
 
   try {
     bb = busboy({
@@ -75,9 +88,15 @@ function parseMultipart(req, res, media, options, resolve, reject) {
     const { filename, mimeType } = info;
     if (!filename) return file.resume();
 
-    // File type validation
+    // File type validation - support wildcards like "image/*"
     if (media.allowedTypes && Array.isArray(media.allowedTypes)) {
-      if (!media.allowedTypes.includes(mimeType)) {
+      const isAllowed = media.allowedTypes.some((allowed) => {
+        if (allowed.endsWith("/*")) {
+          return mimeType.startsWith(allowed.slice(0, -1));
+        }
+        return allowed === mimeType;
+      });
+      if (!isAllowed) {
         fileError = new Error(
           `File type '${mimeType}' not allowed. Allowed: ${media.allowedTypes.join(", ")}`,
         );
@@ -92,6 +111,8 @@ function parseMultipart(req, res, media, options, resolve, reject) {
     }
 
     // BUFFERING MODE: Write to disk
+    pendingWrites++;
+
     const parent = media.public ? options.publicFolder || "" : "";
     const dest = path.resolve(
       path.join(parent, media.dest || (media.public ? "uploads" : "private")),
@@ -103,6 +124,8 @@ function parseMultipart(req, res, media, options, resolve, reject) {
       !dest.startsWith(path.resolve(options.publicFolder || ""))
     ) {
       console.warn("Attempted upload outside public folder, skipping");
+      pendingWrites--;
+      checkComplete();
       return file.resume();
     }
 
@@ -110,6 +133,8 @@ function parseMultipart(req, res, media, options, resolve, reject) {
       if (!fs.existsSync(dest)) fs.mkdirSync(dest, { recursive: true });
     } catch (err) {
       console.error("Failed to create upload folder:", err);
+      pendingWrites--;
+      checkComplete();
       return file.resume();
     }
 
@@ -136,18 +161,28 @@ function parseMultipart(req, res, media, options, resolve, reject) {
       );
       file.unpipe(writeStream);
       writeStream.end();
+      // IMPORTANT: Resume the file stream to drain remaining data
+      // This allows busboy to finish parsing the multipart request
+      file.resume();
       // Clean up partial file
-      fs.unlink(filePath, () => {});
+      fs.unlink(filePath, () => {
+        pendingWrites--;
+        checkComplete();
+      });
     });
 
     file.on("error", (err) => {
       console.error("File stream error:", err);
       writeStream.end();
+      pendingWrites--;
+      checkComplete();
     });
 
     writeStream.on("error", (err) => {
       console.error("Write stream error:", err);
       file.resume();
+      pendingWrites--;
+      checkComplete();
     });
 
     writeStream.on("finish", () => {
@@ -160,6 +195,8 @@ function parseMultipart(req, res, media, options, resolve, reject) {
           size,
         });
       }
+      pendingWrites--;
+      checkComplete();
     });
 
     file.pipe(writeStream);
@@ -172,11 +209,8 @@ function parseMultipart(req, res, media, options, resolve, reject) {
   });
 
   bb.on("finish", () => {
-    if (fileError) {
-      reject(fileError);
-    } else {
-      resolve();
-    }
+    busboyFinished = true;
+    checkComplete();
   });
 
   req.pipe(bb);