vibe-forge 0.8.1 → 0.8.2

package/{bin → src}/lib/daemon/routing.sh

@@ -1,93 +1,93 @@
-#!/usr/bin/env bash
-#
-# bin/lib/daemon/routing.sh
-#
-# Task routing functions - moves tasks between state folders
-#
-# Dependencies: constants.sh, util.sh (log_*), database.sh (db_record_status_history)
-# Globals required: FORGE_ROOT, LOG_FILE, FORGE_DB,
-#                   TASKS_COMPLETED, TASKS_REVIEW, TASKS_APPROVED, TASKS_MERGED
-
-# Prevent double-sourcing
-[[ -n "${_DAEMON_ROUTING_LOADED:-}" ]] && return 0
-_DAEMON_ROUTING_LOADED=1
-
-# Safe file move with symlink protection
-safe_move_task() {
-    local src="$1"
-    local dest_dir="$2"
-
-    # SECURITY: Skip symlinks to prevent symlink attacks
-    if [[ -L "$src" ]]; then
-        echo "[$(date -Iseconds)] WARNING: Skipping symlink: $src" >> "$LOG_FILE"
-        return 1
-    fi
-
-    # SECURITY: Verify source is a regular file
-    if [[ ! -f "$src" ]]; then
-        return 1
-    fi
-
-    # SECURITY: Verify destination is within FORGE_ROOT
-    local real_dest
-    real_dest=$(cd "$dest_dir" 2>/dev/null && pwd)
-    local forge_root_real
-    forge_root_real=$(cd "$FORGE_ROOT" 2>/dev/null && pwd)
-
-    if [[ "$real_dest" != "$forge_root_real"/* ]]; then
-        echo "[$(date -Iseconds)] ERROR: Destination outside FORGE_ROOT: $dest_dir" >> "$LOG_FILE"
-        return 1
-    fi
-
-    local filename
-    filename=$(basename "$src")
-
-    # SECURITY: TOCTOU note - there is a theoretical race between the symlink
-    # check above and this mv. A local attacker with precise timing could swap
-    # the file for a symlink in that window. This risk is accepted because:
-    #   1. Exploiting it requires local filesystem write access (already privileged)
-    #   2. The destination boundary check above limits the blast radius
-    #   3. A fully atomic check+move in bash would require platform-specific tools
-    # Mitigation: the destination is always within FORGE_ROOT (verified above).
-    mv "$src" "$dest_dir/$filename"
-}
-
-route_completed_to_review() {
-    # Move completed tasks to review queue — but ONLY if they have
-    # ready_for_review: true in frontmatter. Tasks that were moved
-    # to completed/ manually (e.g., already reviewed, historical)
-    # should not be re-routed.
-    for task in "$FORGE_ROOT/$TASKS_COMPLETED"/*.md; do
-        if [[ -f "$task" && ! -L "$task" ]]; then
-            # Only route tasks explicitly marked for review
-            local ready_for_review
-            ready_for_review=$(grep -m1 "^ready_for_review:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 10)
-            [[ "$ready_for_review" == "true" ]] || continue
-
-            local filename task_id assigned_to
-            filename=$(basename "$task")
-            task_id=$(grep -m1 "^id:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
-            assigned_to=$(grep -m1 "^assigned_to:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
-            echo "[$(date -Iseconds)] Routing $filename to review" >> "$LOG_FILE"
-            if safe_move_task "$task" "$FORGE_ROOT/$TASKS_REVIEW"; then
-                db_record_status_history "${assigned_to:-unknown}" "review" "${task_id:-$filename}" 2>/dev/null || true
-            fi
-        fi
-    done
-}
-
-route_approved_to_merged() {
-    # Move approved tasks to merged archive
-    for task in "$FORGE_ROOT/$TASKS_APPROVED"/*.md; do
-        if [[ -f "$task" && ! -L "$task" ]]; then
-            local filename task_id assigned_to
-            filename=$(basename "$task")
-            task_id=$(grep -m1 "^id:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
-            assigned_to=$(grep -m1 "^assigned_to:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
-            echo "[$(date -Iseconds)] Archiving $filename to merged" >> "$LOG_FILE"
-            if safe_move_task "$task" "$FORGE_ROOT/$TASKS_MERGED"; then
-                db_record_status_history "${assigned_to:-unknown}" "merged" "${task_id:-$filename}" 2>/dev/null || true
-            fi
-        fi
-    done
-}
+#!/usr/bin/env bash
+#
+# src/lib/daemon/routing.sh
+#
+# Task routing functions - moves tasks between state folders
+#
+# Dependencies: constants.sh, util.sh (log_*), database.sh (db_record_status_history)
+# Globals required: FORGE_ROOT, LOG_FILE, FORGE_DB,
+#                   TASKS_COMPLETED, TASKS_REVIEW, TASKS_APPROVED, TASKS_MERGED
+
+# Prevent double-sourcing
+[[ -n "${_DAEMON_ROUTING_LOADED:-}" ]] && return 0
+_DAEMON_ROUTING_LOADED=1
+
+# Safe file move with symlink protection
+safe_move_task() {
+    local src="$1"
+    local dest_dir="$2"
+
+    # SECURITY: Skip symlinks to prevent symlink attacks
+    if [[ -L "$src" ]]; then
+        echo "[$(date -Iseconds)] WARNING: Skipping symlink: $src" >> "$LOG_FILE"
+        return 1
+    fi
+
+    # SECURITY: Verify source is a regular file
+    if [[ ! -f "$src" ]]; then
+        return 1
+    fi
+
+    # SECURITY: Verify destination is within FORGE_ROOT
+    local real_dest
+    real_dest=$(cd "$dest_dir" 2>/dev/null && pwd)
+    local forge_root_real
+    forge_root_real=$(cd "$FORGE_ROOT" 2>/dev/null && pwd)
+
+    if [[ "$real_dest" != "$forge_root_real"/* ]]; then
+        echo "[$(date -Iseconds)] ERROR: Destination outside FORGE_ROOT: $dest_dir" >> "$LOG_FILE"
+        return 1
+    fi
+
+    local filename
+    filename=$(basename "$src")
+
+    # SECURITY: TOCTOU note - there is a theoretical race between the symlink
+    # check above and this mv. A local attacker with precise timing could swap
+    # the file for a symlink in that window. This risk is accepted because:
+    #   1. Exploiting it requires local filesystem write access (already privileged)
+    #   2. The destination boundary check above limits the blast radius
+    #   3. A fully atomic check+move in bash would require platform-specific tools
+    # Mitigation: the destination is always within FORGE_ROOT (verified above).
+    mv "$src" "$dest_dir/$filename"
+}
+
+route_completed_to_review() {
+    # Move completed tasks to review queue — but ONLY if they have
+    # ready_for_review: true in frontmatter. Tasks that were moved
+    # to completed/ manually (e.g., already reviewed, historical)
+    # should not be re-routed.
+    for task in "$FORGE_ROOT/$TASKS_COMPLETED"/*.md; do
+        if [[ -f "$task" && ! -L "$task" ]]; then
+            # Only route tasks explicitly marked for review
+            local ready_for_review
+            ready_for_review=$(grep -m1 "^ready_for_review:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 10)
+            [[ "$ready_for_review" == "true" ]] || continue
+
+            local filename task_id assigned_to
+            filename=$(basename "$task")
+            task_id=$(grep -m1 "^id:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
+            assigned_to=$(grep -m1 "^assigned_to:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
+            echo "[$(date -Iseconds)] Routing $filename to review" >> "$LOG_FILE"
+            if safe_move_task "$task" "$FORGE_ROOT/$TASKS_REVIEW"; then
+                db_record_status_history "${assigned_to:-unknown}" "review" "${task_id:-$filename}" 2>/dev/null || true
+            fi
+        fi
+    done
+}
+
+route_approved_to_merged() {
+    # Move approved tasks to merged archive
+    for task in "$FORGE_ROOT/$TASKS_APPROVED"/*.md; do
+        if [[ -f "$task" && ! -L "$task" ]]; then
+            local filename task_id assigned_to
+            filename=$(basename "$task")
+            task_id=$(grep -m1 "^id:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
+            assigned_to=$(grep -m1 "^assigned_to:" "$task" 2>/dev/null | cut -d':' -f2 | tr -d " \"'" | head -c 50)
+            echo "[$(date -Iseconds)] Archiving $filename to merged" >> "$LOG_FILE"
+            if safe_move_task "$task" "$FORGE_ROOT/$TASKS_MERGED"; then
+                db_record_status_history "${assigned_to:-unknown}" "merged" "${task_id:-$filename}" 2>/dev/null || true
+            fi
+        fi
+    done
+}

package/{bin → src}/lib/daemon/state.sh

@@ -1,163 +1,163 @@
-#!/usr/bin/env bash
-#
-# bin/lib/daemon/state.sh
-#
-# Daemon state management - forge-state.yaml updates, attention tracking,
-# adaptive polling
-#
-# Dependencies: database.sh, constants.sh
-# Requires: sync.sh (for build_worker_status)
-# Globals required: FORGE_ROOT, STATE_FILE, AGENT_STATUS_DIR,
-#                   TASKS_PENDING, TASKS_IN_PROGRESS, TASKS_COMPLETED,
-#                   TASKS_REVIEW, TASKS_APPROVED, TASKS_NEEDS_CHANGES,
-#                   TASKS_MERGED, TASKS_ATTENTION
-
-# Prevent double-sourcing
-[[ -n "${_DAEMON_STATE_LOADED:-}" ]] && return 0
-_DAEMON_STATE_LOADED=1
-
-# Node.js frontmatter helper (RT-20260405-001 MEDIUM-5: replaces grep/cut YAML parsing)
-FRONTMATTER_JS="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)/frontmatter.js"
-
-# Parse a single frontmatter field from a markdown file.
-# Usage: fm_field <file> <field>
-fm_field() {
-    node "$FRONTMATTER_JS" "$1" "$2" 2>/dev/null | sed -n "s/^${2}=//p"
-}
-
-# Parse a markdown section's first content line.
-# Usage: fm_section <file> <heading>
-fm_section() {
-    node "$FRONTMATTER_JS" --section "$1" "$2" 2>/dev/null
-}
-
-update_state() {
-    # Count tasks in each folder (using find with -maxdepth for safety)
-    local pending in_progress completed review approved needs_changes merged attention
-    pending=$(find "$FORGE_ROOT/$TASKS_PENDING" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    in_progress=$(find "$FORGE_ROOT/$TASKS_IN_PROGRESS" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    completed=$(find "$FORGE_ROOT/$TASKS_COMPLETED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    review=$(find "$FORGE_ROOT/$TASKS_REVIEW" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    approved=$(find "$FORGE_ROOT/$TASKS_APPROVED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    needs_changes=$(find "$FORGE_ROOT/$TASKS_NEEDS_CHANGES" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    merged=$(find "$FORGE_ROOT/$TASKS_MERGED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-    attention=$(find "$FORGE_ROOT/$TASKS_ATTENTION" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-
-    local blocked=${BLOCKED_TASK_COUNT:-0}
-
-    # Build active task details for in-progress tasks
-    local active_tasks_details=""
-    if [[ "$in_progress" -gt 0 ]]; then
-        active_tasks_details=$(build_active_tasks)
-    fi
-
-    # Build attention details if any workers need help
-    local attention_details=""
-    if [[ "$attention" -gt 0 ]]; then
-        attention_details=$(build_attention_details)
-    fi
-
-    # Build blocked task details (T2-H2)
-    local blocked_details=""
-    if [[ "$blocked" -gt 0 ]]; then
-        blocked_details=$(build_blocked_tasks)
-    fi
-
-    # Build worker status from agent-status files
-    local worker_status=""
-    if [[ -d "$FORGE_ROOT/$AGENT_STATUS_DIR" ]]; then
-        worker_status=$(build_worker_status)
-    fi
-
-    # Write state file atomically (write to temp, then move)
-    local temp_state="${STATE_FILE}.tmp.$$"
-    cat > "$temp_state" << EOF
-# Vibe Forge State
-# Auto-updated by forge-daemon
-# Last updated: $(date -Iseconds)
-
-forge:
-  status: active
-  daemon_pid: $$
-
-tasks:
-  pending: $pending
-  in_progress: $in_progress
-  completed: $completed
-  in_review: $review
-  approved: $approved
-  needs_changes: $needs_changes
-  merged: $merged
-  blocked: $blocked
-  attention_needed: $attention
-
-$active_tasks_details
-$attention_details
-$blocked_details
-$worker_status
-last_updated: $(date -Iseconds)
-EOF
-    mv "$temp_state" "$STATE_FILE"
-}
-
-build_attention_details() {
-    echo "attention:"
-    for attention_file in "$FORGE_ROOT/$TASKS_ATTENTION"/*.md; do
-        if [[ -f "$attention_file" && ! -L "$attention_file" ]]; then
-            local agent created issue
-            agent=$(fm_field "$attention_file" "agent")
-            created=$(fm_field "$attention_file" "created")
-            issue=$(fm_section "$attention_file" "Issue")
-            issue="${issue:-Needs attention}"
-
-            printf '  - agent: %s\n' "$agent"
-            printf '    since: %s\n' "$created"
-            printf '    issue: "%s"\n' "$issue"
-        fi
-    done
-}
-
-build_active_tasks() {
-    echo "active_tasks:"
-    for task_file in "$FORGE_ROOT/$TASKS_IN_PROGRESS"/*.md; do
-        if [[ -f "$task_file" && ! -L "$task_file" ]]; then
-            local task_id title assigned_to
-            task_id=$(fm_field "$task_file" "id")
-            title=$(fm_field "$task_file" "title")
-            assigned_to=$(fm_field "$task_file" "assigned_to")
-
-            task_id="${task_id:-$(basename "$task_file" .md)}"
-            title="${title:-Untitled}"
-            assigned_to="${assigned_to:-unassigned}"
-
-            printf '  - id: %s\n' "$task_id"
-            printf '    title: "%s"\n' "$title"
-            printf '    assigned_to: %s\n' "$assigned_to"
-        fi
-    done
-}
-
-# Determine daemon state based on activity (for adaptive polling)
-determine_daemon_state() {
-    # Check if there are in-progress tasks
-    local in_progress_count
-    in_progress_count=$(find "$FORGE_ROOT/$TASKS_IN_PROGRESS" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
-
-    # Check if there are active workers
-    local active_workers
-    active_workers=$(db_count_active_workers 2>/dev/null || echo "0")
-
-    if [[ "$in_progress_count" -gt 0 ]] || [[ "$active_workers" -gt 0 ]]; then
-        echo "active"
-    else
-        echo "idle"
-    fi
-}
-
-# Get current poll interval in seconds (from DB, with fallback)
-get_poll_interval() {
-    local interval_ms
-    interval_ms=$(db_get_poll_interval_ms 2>/dev/null || echo "30000")
-    # Convert ms to seconds (bash integer division)
-    echo $((interval_ms / 1000))
-}
+#!/usr/bin/env bash
+#
+# src/lib/daemon/state.sh
+#
+# Daemon state management - forge-state.yaml updates, attention tracking,
+# adaptive polling
+#
+# Dependencies: database.sh, constants.sh
+# Requires: sync.sh (for build_worker_status)
+# Globals required: FORGE_ROOT, STATE_FILE, AGENT_STATUS_DIR,
+#                   TASKS_PENDING, TASKS_IN_PROGRESS, TASKS_COMPLETED,
+#                   TASKS_REVIEW, TASKS_APPROVED, TASKS_NEEDS_CHANGES,
+#                   TASKS_MERGED, TASKS_ATTENTION
+
+# Prevent double-sourcing
+[[ -n "${_DAEMON_STATE_LOADED:-}" ]] && return 0
+_DAEMON_STATE_LOADED=1
+
+# Node.js frontmatter helper (RT-20260405-001 MEDIUM-5: replaces grep/cut YAML parsing)
+FRONTMATTER_JS="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)/frontmatter.js"
+
+# Parse a single frontmatter field from a markdown file.
+# Usage: fm_field <file> <field>
+fm_field() {
+    node "$FRONTMATTER_JS" "$1" "$2" 2>/dev/null | sed -n "s/^${2}=//p"
+}
+
+# Parse a markdown section's first content line.
+# Usage: fm_section <file> <heading>
+fm_section() {
+    node "$FRONTMATTER_JS" --section "$1" "$2" 2>/dev/null
+}
+
+update_state() {
+    # Count tasks in each folder (using find with -maxdepth for safety)
+    local pending in_progress completed review approved needs_changes merged attention
+    pending=$(find "$FORGE_ROOT/$TASKS_PENDING" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    in_progress=$(find "$FORGE_ROOT/$TASKS_IN_PROGRESS" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    completed=$(find "$FORGE_ROOT/$TASKS_COMPLETED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    review=$(find "$FORGE_ROOT/$TASKS_REVIEW" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    approved=$(find "$FORGE_ROOT/$TASKS_APPROVED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    needs_changes=$(find "$FORGE_ROOT/$TASKS_NEEDS_CHANGES" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    merged=$(find "$FORGE_ROOT/$TASKS_MERGED" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+    attention=$(find "$FORGE_ROOT/$TASKS_ATTENTION" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+
+    local blocked=${BLOCKED_TASK_COUNT:-0}
+
+    # Build active task details for in-progress tasks
+    local active_tasks_details=""
+    if [[ "$in_progress" -gt 0 ]]; then
+        active_tasks_details=$(build_active_tasks)
+    fi
+
+    # Build attention details if any workers need help
+    local attention_details=""
+    if [[ "$attention" -gt 0 ]]; then
+        attention_details=$(build_attention_details)
+    fi
+
+    # Build blocked task details (T2-H2)
+    local blocked_details=""
+    if [[ "$blocked" -gt 0 ]]; then
+        blocked_details=$(build_blocked_tasks)
+    fi
+
+    # Build worker status from agent-status files
+    local worker_status=""
+    if [[ -d "$FORGE_ROOT/$AGENT_STATUS_DIR" ]]; then
+        worker_status=$(build_worker_status)
+    fi
+
+    # Write state file atomically (write to temp, then move)
+    local temp_state="${STATE_FILE}.tmp.$$"
+    cat > "$temp_state" << EOF
+# Vibe Forge State
+# Auto-updated by forge-daemon
+# Last updated: $(date -Iseconds)
+
+forge:
+  status: active
+  daemon_pid: $$
+
+tasks:
+  pending: $pending
+  in_progress: $in_progress
+  completed: $completed
+  in_review: $review
+  approved: $approved
+  needs_changes: $needs_changes
+  merged: $merged
+  blocked: $blocked
+  attention_needed: $attention
+
+$active_tasks_details
+$attention_details
+$blocked_details
+$worker_status
+last_updated: $(date -Iseconds)
+EOF
+    mv "$temp_state" "$STATE_FILE"
+}
+
+build_attention_details() {
+    echo "attention:"
+    for attention_file in "$FORGE_ROOT/$TASKS_ATTENTION"/*.md; do
+        if [[ -f "$attention_file" && ! -L "$attention_file" ]]; then
+            local agent created issue
+            agent=$(fm_field "$attention_file" "agent")
+            created=$(fm_field "$attention_file" "created")
+            issue=$(fm_section "$attention_file" "Issue")
+            issue="${issue:-Needs attention}"
+
+            printf '  - agent: %s\n' "$agent"
+            printf '    since: %s\n' "$created"
+            printf '    issue: "%s"\n' "$issue"
+        fi
+    done
+}
+
+build_active_tasks() {
+    echo "active_tasks:"
+    for task_file in "$FORGE_ROOT/$TASKS_IN_PROGRESS"/*.md; do
+        if [[ -f "$task_file" && ! -L "$task_file" ]]; then
+            local task_id title assigned_to
+            task_id=$(fm_field "$task_file" "id")
+            title=$(fm_field "$task_file" "title")
+            assigned_to=$(fm_field "$task_file" "assigned_to")
+
+            task_id="${task_id:-$(basename "$task_file" .md)}"
+            title="${title:-Untitled}"
+            assigned_to="${assigned_to:-unassigned}"
+
+            printf '  - id: %s\n' "$task_id"
+            printf '    title: "%s"\n' "$title"
+            printf '    assigned_to: %s\n' "$assigned_to"
+        fi
+    done
+}
+
+# Determine daemon state based on activity (for adaptive polling)
+determine_daemon_state() {
+    # Check if there are in-progress tasks
+    local in_progress_count
+    in_progress_count=$(find "$FORGE_ROOT/$TASKS_IN_PROGRESS" -maxdepth 1 -name "*.md" -type f 2>/dev/null | wc -l)
+
+    # Check if there are active workers
+    local active_workers
+    active_workers=$(db_count_active_workers 2>/dev/null || echo "0")
+
+    if [[ "$in_progress_count" -gt 0 ]] || [[ "$active_workers" -gt 0 ]]; then
+        echo "active"
+    else
+        echo "idle"
+    fi
+}
+
+# Get current poll interval in seconds (from DB, with fallback)
+get_poll_interval() {
+    local interval_ms
+    interval_ms=$(db_get_poll_interval_ms 2>/dev/null || echo "30000")
+    # Convert ms to seconds (bash integer division)
+    echo $((interval_ms / 1000))
+}