vibe-forge 0.1.0 → 0.2.1

package/bin/lib/config.sh

@@ -0,0 +1,259 @@
+#!/usr/bin/env bash
+#
+# Vibe Forge - Configuration Management
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/config.sh"
+#
+# SECURITY: This module provides safe JSON parsing without grep/cut vulnerabilities.
+#
+
+# Ensure colors are loaded for error messages
+if ! type log_error &>/dev/null; then
+    echo "Error: colors.sh must be sourced before config.sh" >&2
+    exit 1
+fi
+
+# =============================================================================
+# Agent Configuration Loading
+# =============================================================================
+
+# load_agents_from_json AGENTS_JSON_FILE
+# Loads agent configuration from JSON file into shell variables.
+# Sets: VALID_AGENTS array, AGENT_ALIASES associative array, AGENT_DISPLAY_NAMES
+#
+# SECURITY: Uses safe JSON parsing via Node.js
+load_agents_from_json() {
+    local agents_file="$1"
+
+    if [[ ! -f "$agents_file" ]]; then
+        return 1
+    fi
+
+    if ! command -v node &>/dev/null; then
+        log_error "Node.js required for agent configuration"
+        return 1
+    fi
+
+    # Parse agents JSON and output shell variable assignments
+    # SECURITY: File path passed as argument, not interpolated
+    # NOTE: We output direct assignments (not declare -A) since arrays are pre-declared globally
+    local agent_data
+    agent_data=$(node -e '
+        const fs = require("fs");
+        const file = process.argv[1];
+        try {
+            const data = JSON.parse(fs.readFileSync(file, "utf8"));
+            const agents = data.agents || {};
+
+            // Output VALID_AGENTS array
+            const validAgents = Object.keys(agents);
+            console.log("VALID_AGENTS=(" + validAgents.map(a => `"${a}"`).join(" ") + ")");
+
+            // Output AGENT_ALIASES assignments (array already declared globally)
+            for (const [canonical, info] of Object.entries(agents)) {
+                // Add self-mapping
+                console.log(`AGENT_ALIASES["${canonical}"]="${canonical}"`);
+                // Add aliases
+                if (info.aliases) {
+                    for (const alias of info.aliases) {
+                        console.log(`AGENT_ALIASES["${alias}"]="${canonical}"`);
+                    }
+                }
+            }
+
+            // Output AGENT_DISPLAY_NAMES assignments
+            for (const [canonical, info] of Object.entries(agents)) {
+                const displayName = info.name || canonical;
+                console.log(`AGENT_DISPLAY_NAMES["${canonical}"]="${displayName}"`);
+            }
+
+            // Output AGENT_ROLES assignments
+            for (const [canonical, info] of Object.entries(agents)) {
+                const role = info.role || "";
+                console.log(`AGENT_ROLES["${canonical}"]="${role}"`);
+            }
+
+            // Output AGENT_PERSONALITY_FILES assignments
+            for (const [canonical, info] of Object.entries(agents)) {
+                const pfile = info.personality_file || "";
+                console.log(`AGENT_PERSONALITY_FILES["${canonical}"]="${pfile}"`);
+            }
+
+        } catch (e) {
+            console.error("Error parsing agents.json:", e.message);
+            process.exit(1);
+        }
+    ' -- "$agents_file" 2>/dev/null) || return 1
+
+    # Evaluate the output to set variables
+    eval "$agent_data"
+
+    # Mark as loaded
+    AGENTS_LOADED="true"
+    return 0
+}
+
+# json_get_string FILE KEY
+# Safely extracts a string value from a JSON file.
+# Uses node.js for safe parsing (available since we require Node 16+)
+#
+# SECURITY: This avoids grep/cut vulnerabilities by using proper JSON parsing.
+# SECURITY: File and key are passed as command-line arguments, not interpolated.
+json_get_string() {
+    local file="$1"
+    local key="$2"
+
+    if [[ ! -f "$file" ]]; then
+        return 1
+    fi
+
+    # Use Node.js for safe JSON parsing
+    # SECURITY: Pass file and key as arguments to avoid injection
+    if command -v node &>/dev/null; then
+        node -e '
+            const fs = require("fs");
+            const file = process.argv[1];
+            const key = process.argv[2];
+            try {
+                const data = JSON.parse(fs.readFileSync(file, "utf8"));
+                const value = data[key];
+                if (value !== undefined && value !== null) {
+                    console.log(String(value));
+                }
+            } catch (e) {
+                process.exit(1);
+            }
+        ' -- "$file" "$key" 2>/dev/null
+        return $?
+    fi
+
+    # Fallback: Use Python if available
+    # SECURITY: Pass file and key as arguments to avoid injection
+    if command -v python3 &>/dev/null; then
+        python3 -c '
+import json, sys
+try:
+    file_path = sys.argv[1]
+    key = sys.argv[2]
+    with open(file_path) as f:
+        data = json.load(f)
+    value = data.get(key)
+    if value is not None:
+        print(str(value))
+except:
+    sys.exit(1)
+' "$file" "$key" 2>/dev/null
+        return $?
+    fi
+
+    # No safe parser available - exit with error
+    log_error "No JSON parser available. Install Node.js or Python 3."
+    return 1
+}
+
+# load_forge_config CONFIG_FILE
+# Loads configuration from the forge config file into environment variables.
+# Sets: PLATFORM, GIT_BASH_PATH, TERMINAL_TYPE, FORGE_VALIDATED
+#
+# Returns: 0 on success, 1 on failure
+load_forge_config() {
+    local config_file="$1"
+
+    if [[ ! -f "$config_file" ]]; then
+        log_error "Vibe Forge not initialized."
+        echo "Run 'forge init' first." >&2
+        return 1
+    fi
+
+    # Load config values safely
+    PLATFORM=$(json_get_string "$config_file" "platform") || PLATFORM=""
+    GIT_BASH_PATH=$(json_get_string "$config_file" "git_bash_path") || GIT_BASH_PATH=""
+    TERMINAL_TYPE=$(json_get_string "$config_file" "terminal_type") || TERMINAL_TYPE="manual"
+    FORGE_VALIDATED=$(json_get_string "$config_file" "validated") || FORGE_VALIDATED="false"
+
+    # Validate required fields
+    if [[ -z "$PLATFORM" ]]; then
+        log_error "Invalid config: missing platform"
+        return 1
+    fi
+
+    return 0
+}
+
+# setup_windows_env
+# Sets up Windows-specific environment variables and PATH.
+# Call this after load_forge_config on Windows.
+setup_windows_env() {
+    if [[ "$PLATFORM" != "windows" ]]; then
+        return 0
+    fi
+
+    # Export Git Bash path for Claude Code
+    if [[ -n "$GIT_BASH_PATH" ]]; then
+        # Convert forward slashes to backslashes for Windows
+        local git_bash_win="${GIT_BASH_PATH//\//\\}"
+        export CLAUDE_CODE_GIT_BASH_PATH="$git_bash_win"
+    fi
+
+    # Add npm global path if not already in PATH
+    local npm_path=""
+
+    # Try with USER variable
+    if [[ -n "$USER" ]]; then
+        npm_path="/c/Users/$USER/AppData/Roaming/npm"
+    fi
+
+    # Try with USERPROFILE
+    if [[ -z "$npm_path" || ! -d "$npm_path" ]] && [[ -n "$USERPROFILE" ]]; then
+        npm_path="${USERPROFILE//\\//}/AppData/Roaming/npm"
+    fi
+
+    # Add to PATH if exists and not already there
+    if [[ -n "$npm_path" && -d "$npm_path" && ":$PATH:" != *":$npm_path:"* ]]; then
+        export PATH="$npm_path:$PATH"
+    fi
+}
+
+# require_forge_config FORGE_ROOT
+# Loads config and exits with error if not initialized.
+# Convenience function that combines load + validation.
+require_forge_config() {
+    local forge_root="$1"
+    local config_file="$forge_root/.forge/config.json"
+
+    load_forge_config "$config_file" || exit 1
+    setup_windows_env
+}
+
+# write_json_config FILE KEY VALUE
+# Safely writes/updates a key in a JSON config file.
+# Creates file if it doesn't exist.
+#
+# SECURITY: File, key, and value are passed as command-line arguments, not interpolated.
+write_json_config() {
+    local file="$1"
+    local key="$2"
+    local value="$3"
+
+    # Use Node.js for safe JSON manipulation
+    # SECURITY: Pass all values as arguments to avoid injection
+    if command -v node &>/dev/null; then
+        node -e '
+            const fs = require("fs");
+            const file = process.argv[1];
+            const key = process.argv[2];
+            const value = process.argv[3];
+            let data = {};
+            try {
+                if (fs.existsSync(file)) {
+                    data = JSON.parse(fs.readFileSync(file, "utf8"));
+                }
+            } catch (e) {}
+            data[key] = value;
+            fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
+        ' -- "$file" "$key" "$value" 2>/dev/null
+        return $?
+    fi
+
+    log_error "Node.js required for config writing"
+    return 1
+}

package/bin/lib/constants.sh

@@ -0,0 +1,143 @@
+#!/usr/bin/env bash
+#
+# Vibe Forge - Shared Constants
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/constants.sh"
+#
+# NOTE: Agent configuration should be loaded from config/agents.json via
+# load_agents_from_json() in config.sh. The hardcoded values below are
+# fallback defaults for when JSON loading is not possible (e.g., tests).
+#
+
+# Timing
+POLL_INTERVAL=2              # seconds between daemon task checks
+NOTIFICATION_DEBOUNCE=1      # seconds to avoid notification spam
+
+# Directory structure (relative to FORGE_ROOT)
+CONFIG_DIR=".forge"
+TASKS_DIR="tasks"
+TASKS_PENDING="$TASKS_DIR/pending"
+TASKS_IN_PROGRESS="$TASKS_DIR/in-progress"
+TASKS_COMPLETED="$TASKS_DIR/completed"
+TASKS_REVIEW="$TASKS_DIR/review"
+TASKS_APPROVED="$TASKS_DIR/approved"
+TASKS_NEEDS_CHANGES="$TASKS_DIR/needs-changes"
+TASKS_MERGED="$TASKS_DIR/merged"
+CONTEXT_DIR="context"
+AGENTS_DIR="agents"
+
+# Config files
+AGENTS_CONFIG="config/agents.json"
+
+# =============================================================================
+# Agent Configuration (Fallback Defaults)
+# =============================================================================
+# These values are overwritten when load_agents_from_json() is called.
+# They exist as fallback for contexts where JSON loading isn't available.
+
+# Flag to track if agents were loaded from JSON
+AGENTS_LOADED="${AGENTS_LOADED:-false}"
+
+# Valid agent names (whitelist for security)
+# These are the ONLY valid canonical agent names
+VALID_AGENTS=(
+    "anvil"
+    "furnace"
+    "crucible"
+    "sentinel"
+    "scribe"
+    "herald"
+    "ember"
+    "aegis"
+    "hub"
+)
+
+# Agent aliases map (for resolve_agent)
+# Format: alias=canonical
+declare -A AGENT_ALIASES=(
+    # Anvil aliases
+    ["anvil"]="anvil"
+    ["frontend"]="anvil"
+    ["ui"]="anvil"
+    ["fe"]="anvil"
+    # Furnace aliases
+    ["furnace"]="furnace"
+    ["backend"]="furnace"
+    ["api"]="furnace"
+    ["be"]="furnace"
+    # Crucible aliases
+    ["crucible"]="crucible"
+    ["test"]="crucible"
+    ["testing"]="crucible"
+    ["qa"]="crucible"
+    ["tester"]="crucible"
+    # Sentinel aliases
+    ["sentinel"]="sentinel"
+    ["review"]="sentinel"
+    ["reviewer"]="sentinel"
+    ["cr"]="sentinel"
+    # Scribe aliases
+    ["scribe"]="scribe"
+    ["docs"]="scribe"
+    ["documentation"]="scribe"
+    ["doc"]="scribe"
+    # Herald aliases
+    ["herald"]="herald"
+    ["release"]="herald"
+    ["deploy"]="herald"
+    ["deployment"]="herald"
+    # Ember aliases
+    ["ember"]="ember"
+    ["devops"]="ember"
+    ["ops"]="ember"
+    ["infra"]="ember"
+    ["infrastructure"]="ember"
+    # Aegis aliases
+    ["aegis"]="aegis"
+    ["security"]="aegis"
+    ["sec"]="aegis"
+    ["appsec"]="aegis"
+    # Hub aliases
+    ["hub"]="hub"
+    ["planning"]="hub"
+    ["master"]="hub"
+    ["forge-master"]="hub"
+)
+
+# Agent display names
+declare -A AGENT_DISPLAY_NAMES=(
+    ["anvil"]="Anvil"
+    ["furnace"]="Furnace"
+    ["crucible"]="Crucible"
+    ["sentinel"]="Sentinel"
+    ["scribe"]="Scribe"
+    ["herald"]="Herald"
+    ["ember"]="Ember"
+    ["aegis"]="Aegis"
+    ["hub"]="Planning Hub"
+)
+
+# Agent roles
+declare -A AGENT_ROLES=(
+    ["anvil"]="Frontend Developer"
+    ["furnace"]="Backend Developer"
+    ["crucible"]="Tester / QA"
+    ["sentinel"]="Code Reviewer"
+    ["scribe"]="Documentation"
+    ["herald"]="Release Manager"
+    ["ember"]="DevOps"
+    ["aegis"]="Security"
+    ["hub"]="Planning & Coordination"
+)
+
+# Agent personality files (relative to FORGE_ROOT)
+declare -A AGENT_PERSONALITY_FILES=(
+    ["anvil"]="agents/anvil/personality.md"
+    ["furnace"]="agents/furnace/personality.md"
+    ["crucible"]="agents/crucible/personality.md"
+    ["sentinel"]="agents/sentinel/personality.md"
+    ["scribe"]="agents/scribe/personality.md"
+    ["herald"]="agents/herald/personality.md"
+    ["ember"]="agents/ember/personality.md"
+    ["aegis"]="agents/aegis/personality.md"
+    ["hub"]="agents/planning-hub/personality.md"
+)

package/config/agents.json

@@ -0,0 +1,76 @@
+{
+  "agents": {
+    "anvil": {
+      "name": "Anvil",
+      "icon": "🔨",
+      "role": "Frontend Developer",
+      "aliases": ["frontend", "ui", "fe"],
+      "type": "worker",
+      "personality_file": "agents/anvil/personality.md"
+    },
+    "furnace": {
+      "name": "Furnace",
+      "icon": "🔥",
+      "role": "Backend Developer",
+      "aliases": ["backend", "api", "be"],
+      "type": "worker",
+      "personality_file": "agents/furnace/personality.md"
+    },
+    "crucible": {
+      "name": "Crucible",
+      "icon": "🧪",
+      "role": "Tester / QA",
+      "aliases": ["test", "testing", "qa", "tester"],
+      "type": "worker",
+      "personality_file": "agents/crucible/personality.md"
+    },
+    "sentinel": {
+      "name": "Sentinel",
+      "icon": "🛡️",
+      "role": "Code Reviewer",
+      "aliases": ["review", "reviewer", "cr"],
+      "type": "core",
+      "personality_file": "agents/sentinel/personality.md"
+    },
+    "scribe": {
+      "name": "Scribe",
+      "icon": "📜",
+      "role": "Documentation",
+      "aliases": ["docs", "documentation", "doc"],
+      "type": "worker",
+      "personality_file": "agents/scribe/personality.md"
+    },
+    "herald": {
+      "name": "Herald",
+      "icon": "📯",
+      "role": "Release Manager",
+      "aliases": ["release", "deploy", "deployment"],
+      "type": "worker",
+      "personality_file": "agents/herald/personality.md"
+    },
+    "ember": {
+      "name": "Ember",
+      "icon": "⚙️",
+      "role": "DevOps",
+      "aliases": ["devops", "ops", "infra", "infrastructure"],
+      "type": "specialist",
+      "personality_file": "agents/ember/personality.md"
+    },
+    "aegis": {
+      "name": "Aegis",
+      "icon": "🔒",
+      "role": "Security",
+      "aliases": ["security", "sec", "appsec"],
+      "type": "specialist",
+      "personality_file": "agents/aegis/personality.md"
+    },
+    "hub": {
+      "name": "Planning Hub",
+      "icon": "🔥",
+      "role": "Planning & Coordination",
+      "aliases": ["planning", "master", "forge-master"],
+      "type": "core",
+      "personality_file": "agents/planning-hub/personality.md"
+    }
+  }
+}

package/config/task-template.md

@@ -1,87 +1,87 @@
----
-id: task-{ID}
-title: "{TITLE}"
-type: {TYPE}  # frontend | backend | test | docs | review | release | devops | security
-priority: {PRIORITY}  # critical | high | medium | low
-status: pending
-assigned_to: null
-blocked_by: []
-depends_on: []
-created: {TIMESTAMP}
-updated: {TIMESTAMP}
-estimated_complexity: {COMPLEXITY}  # trivial | low | medium | high | unknown
-epic: {EPIC_ID}
-story: {STORY_ID}  # optional
----
-
-# Context
-
-## Parent Epic
-See: /specs/epics/{EPIC_ID}.md
-
-## Relevant Files
-<!-- List ONLY files the agent needs to read or modify -->
-- /path/to/relevant/file.ts (reason: what to do here)
-- /path/to/reference/file.ts (reference only)
-
-## Dependencies
-<!-- Other tasks that must complete first -->
-- task-{DEP_ID} (status: pending|completed)
-
-## Background
-<!-- Brief context the agent needs - keep minimal, reference docs instead -->
-{BACKGROUND}
-
----
-
-# Acceptance Criteria
-
-<!-- Checkboxes for each requirement - agent marks complete as they work -->
-- [ ] {CRITERION_1}
-- [ ] {CRITERION_2}
-- [ ] {CRITERION_3}
-
----
-
-# Agent Instructions
-
-<!-- Specific instructions for the assigned agent -->
-{AGENT_TYPE}: {SPECIFIC_INSTRUCTIONS}
-
-**Boundaries:**
-- DO modify: {ALLOWED_PATHS}
-- DO NOT modify: {FORBIDDEN_PATHS}
-- If blocked, write blocker to task file and notify Forge Master
-
-**On Completion:**
-1. Ensure all acceptance criteria checked
-2. Run relevant tests
-3. Move this file to `/tasks/completed/`
-4. Include completion summary below
-
----
-
-# Output Expected
-
-- [ ] Files created/modified (list paths in completion)
-- [ ] Tests passing (include count)
-- [ ] No linting errors
-- [ ] Completion summary written
-
----
-
-# Completion Summary
-<!-- Filled by agent on completion -->
-
-```yaml
-completed_by: null
-completed_at: null
-duration_minutes: null
-files_modified: []
-files_created: []
-tests_added: 0
-tests_passing: 0
-notes: ""
-blockers_encountered: []
-ready_for_review: false
-```
+---
+id: task-{ID}
+title: "{TITLE}"
+type: {TYPE}  # frontend | backend | test | docs | review | release | devops | security
+priority: {PRIORITY}  # critical | high | medium | low
+status: pending
+assigned_to: null
+blocked_by: []
+depends_on: []
+created: {TIMESTAMP}
+updated: {TIMESTAMP}
+estimated_complexity: {COMPLEXITY}  # trivial | low | medium | high | unknown
+epic: {EPIC_ID}
+story: {STORY_ID}  # optional
+---
+
+# Context
+
+## Parent Epic
+See: /specs/epics/{EPIC_ID}.md
+
+## Relevant Files
+<!-- List ONLY files the agent needs to read or modify -->
+- /path/to/relevant/file.ts (reason: what to do here)
+- /path/to/reference/file.ts (reference only)
+
+## Dependencies
+<!-- Other tasks that must complete first -->
+- task-{DEP_ID} (status: pending|completed)
+
+## Background
+<!-- Brief context the agent needs - keep minimal, reference docs instead -->
+{BACKGROUND}
+
+---
+
+# Acceptance Criteria
+
+<!-- Checkboxes for each requirement - agent marks complete as they work -->
+- [ ] {CRITERION_1}
+- [ ] {CRITERION_2}
+- [ ] {CRITERION_3}
+
+---
+
+# Agent Instructions
+
+<!-- Specific instructions for the assigned agent -->
+{AGENT_TYPE}: {SPECIFIC_INSTRUCTIONS}
+
+**Boundaries:**
+- DO modify: {ALLOWED_PATHS}
+- DO NOT modify: {FORBIDDEN_PATHS}
+- If blocked, write blocker to task file and notify Forge Master
+
+**On Completion:**
+1. Ensure all acceptance criteria checked
+2. Run relevant tests
+3. Move this file to `/tasks/completed/`
+4. Include completion summary below
+
+---
+
+# Output Expected
+
+- [ ] Files created/modified (list paths in completion)
+- [ ] Tests passing (include count)
+- [ ] No linting errors
+- [ ] Completion summary written
+
+---
+
+# Completion Summary
+<!-- Filled by agent on completion -->
+
+```yaml
+completed_by: null
+completed_at: null
+duration_minutes: null
+files_modified: []
+files_created: []
+tests_added: 0
+tests_passing: 0
+notes: ""
+blockers_encountered: []
+ready_for_review: false
+```