vibe-coding-master 0.7.18 → 0.7.19

package/dist/backend/templates/harness/vcm-long-running-validation-skill.js

@@ -11,7 +11,7 @@ The hard ceiling is 60 minutes per job, enforced by the job worker itself. No ap
 
 ## Protocol
 
-1. Start the command with an explicit ceiling: \`.ai/tools/run-long-check --timeout <duration> -- <command>\`. Pick the ceiling from \`docs/TESTING.md\` guidance or a realistic estimate, never above 60m. The tool prints the job id and creates job state under \`.ai/vcm/jobs/<job-id>/\`.
+1. Start the command with an explicit ceiling: \`.ai/tools/run-long-check --timeout <duration> -- <command>\`. Pass the validation executable and its arguments directly. Do not use a shell command-string wrapper, pipeline its output, or append another command: run-long-check already captures stdout/stderr, and shell wrappers can hide the validation exit code. Pick the ceiling from \`docs/TESTING.md\` guidance or a realistic estimate, never above 60m. The tool prints the job id and creates job state under \`.ai/vcm/jobs/<job-id>/\`.
 2. In the same turn, run \`.ai/tools/watch-job <job-id>\`. The default watch window is 8 minutes.
 3. If watch-job exits 125, the job is still running: run \`.ai/tools/watch-job <job-id>\` again immediately. Do not end the turn between windows.
 4. Repeat until watch-job reports a terminal result.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibe-coding-master",
-  "version": "0.7.18",
+  "version": "0.7.19",
   "description": "Local GUI session cockpit for Claude Code role sessions.",
   "type": "module",
   "files": [

package/scripts/harness-tools/run-long-check

@@ -4,6 +4,9 @@
 Usage:
   .ai/tools/run-long-check [--timeout <duration>] -- <command> [args...]
 
+Pass the validation executable and its arguments directly. Shell command-string
+wrappers are rejected because they can hide the validation command's exit code.
+
 The command runs in a detached worker process group. The worker itself
 enforces the job ceiling (--timeout, max 60m) and a supervision lease: when
 no foreground watcher renews .ai/vcm/jobs/<job-id>/lease, the worker kills
@@ -28,6 +31,7 @@ QUEUED_STALE_SECONDS = 60
 ACTIVE_STATUSES = {"queued", "starting", "running"}
 DEFAULT_LEASE_START_GRACE_SECONDS = 300
 DEFAULT_LEASE_RENEW_GRACE_SECONDS = 120
+SHELL_EXECUTABLES = {"sh", "bash", "zsh", "dash", "ksh", "fish", "csh", "tcsh"}
 
 
 def root_dir() -> Path:
@@ -83,6 +87,25 @@ def job_id() -> str:
     return f"{timestamp}-{uuid.uuid4().hex[:8]}"
 
 
+def shell_command_wrapper(command: list[str]) -> str | None:
+    if not command:
+        return None
+
+    candidates = range(len(command)) if Path(command[0]).name == "env" else range(1)
+    for index in candidates:
+        executable = Path(command[index]).name
+        if executable not in SHELL_EXECUTABLES:
+            continue
+        if any(
+            option.startswith("-")
+            and not option.startswith("--")
+            and "c" in option[1:]
+            for option in command[index + 1:]
+        ):
+            return executable
+    return None
+
+
 def process_exists(pid: int) -> bool:
     try:
         os.kill(pid, 0)
@@ -394,7 +417,23 @@ def main() -> int:
         )
         return 2
 
-    return start_job(argv[index + 1:], timeout_seconds)
+    command = argv[index + 1:]
+    shell_wrapper = shell_command_wrapper(command)
+    if shell_wrapper:
+        print(
+            f"error: {shell_wrapper} command-string wrappers are not allowed; "
+            "pass the validation executable and its arguments directly so its "
+            "exit code remains authoritative",
+            file=sys.stderr,
+        )
+        print(
+            "run-long-check already captures stdout/stderr; do not add pipelines "
+            "or trailing commands to trim output",
+            file=sys.stderr,
+        )
+        return 2
+
+    return start_job(command, timeout_seconds)
 
 
 if __name__ == "__main__":