vibe-coding-master 0.6.14 → 0.6.16

package/dist/backend/services/gate-review-service.js

@@ -28,6 +28,10 @@ const SOURCE_ARTIFACTS = {
         ".ai/vcm/handoffs/final-acceptance.md"
     ]
 };
+const CORE_INPUT_ARTIFACTS = {
+    "architecture-plan": ".ai/vcm/handoffs/architecture-plan.md",
+    "validation-adequacy": ".ai/vcm/handoffs/review-report.md"
+};
 const VALID_SEVERITIES = new Set(["critical", "high", "medium", "low"]);
 export function createGateReviewService(deps) {
     const now = deps.now ?? (() => new Date().toISOString());
@@ -80,6 +84,30 @@ export function createGateReviewService(deps) {
         if (record.status === "running" && !options.force) {
             return { status: "running", gate, record, message: "Gate review is already running." };
         }
+        const coreInput = await readCoreInputArtifact(deps.fs, context.taskRepoRoot, gate);
+        if (coreInput && coreInput.status !== "ready") {
+            index = applyGateState(index, gate, {
+                status: "not_required",
+                decision: undefined,
+                error: undefined,
+                exceptionReason: undefined,
+                requestId: undefined,
+                requestPath: undefined,
+                inputHash: undefined,
+                requestedAt: undefined,
+                startedAt: undefined,
+                completedAt: undefined,
+                callbackStatus: "not_sent",
+                callbackError: undefined
+            }, now(), true);
+            await saveIndex(deps.fs, context.taskRepoRoot, index);
+            return {
+                status: "not_required",
+                gate,
+                record: index.gates[gate],
+                message: `${coreInput.path} is ${coreInput.status}.`
+            };
+        }
         const inputHash = await computeInputHash(deps, context.taskRepoRoot, gate);
         if (!options.force
             && record.status === "completed"
@@ -436,7 +464,7 @@ function normalizeIndex(raw, config, timestamp) {
             : "disabled";
         const existingStatus = normalizeGateStatus(existing?.status);
         const status = config.enabled && required
-            ? (existingStatus === "disabled" || existingStatus === "not_required" ? "pending" : existingStatus ?? fallbackStatus)
+            ? (existingStatus === "disabled" ? "pending" : existingStatus ?? fallbackStatus)
             : fallbackStatus;
         gates[gate] = {
             gate,
@@ -495,6 +523,12 @@ async function saveIndex(fs, taskRepoRoot, index) {
 }
 async function computeInputHash(deps, taskRepoRoot, gate) {
     const digest = createHash("sha256");
+    const coreArtifact = CORE_INPUT_ARTIFACTS[gate];
+    if (coreArtifact) {
+        digest.update(coreArtifact);
+        digest.update(await deps.fs.readText(resolveRepoPath(taskRepoRoot, coreArtifact)));
+        return digest.digest("hex");
+    }
     const common = [
         "CLAUDE.md",
         ".claude/agents/gate-reviewer.md",
@@ -518,6 +552,21 @@ async function computeInputHash(deps, taskRepoRoot, gate) {
     }
     return digest.digest("hex");
 }
+async function readCoreInputArtifact(fs, taskRepoRoot, gate) {
+    const relativePath = CORE_INPUT_ARTIFACTS[gate];
+    if (!relativePath) {
+        return null;
+    }
+    const absolutePath = resolveRepoPath(taskRepoRoot, relativePath);
+    if (!await fs.pathExists(absolutePath)) {
+        return { path: relativePath, status: "missing" };
+    }
+    const content = await fs.readText(absolutePath);
+    if (content.trim().length === 0) {
+        return { path: relativePath, status: "empty" };
+    }
+    return { path: relativePath, status: "ready" };
+}
 async function commandStdout(runner, cwd, args) {
     const result = await runner.run("git", args, { cwd });
     return result.exitCode === 0 ? result.stdout : "";

package/dist/backend/templates/harness/claude-root.js

@@ -6,7 +6,7 @@ export function renderRootClaudeHarnessRules() {
 - Use \`vcm-route-message\` whenever a VCM role hands off work, asks another role a question, reports a result, reports a blocker, or raises a finding. Follow its write-then-stop rule.
 - Use \`vcm-long-running-validation\` for long-running validation. Follow the background job limits below.
 - Use \`vcm-report-harness-issue\` when you notice a reusable VCM harness problem. Record feedback; do not contact Harness Engineer directly.
-- Project-manager runs \`vcm-gate-review\` only at formal delivery Gate Review trigger points: the required handoff artifact exists and PM is about to advance across that delivery boundary. Within such a gate, the request is unconditional and the tool reports the authoritative enable state.
+- Project-manager runs \`vcm-gate-review\` unconditionally at every Gate Review trigger point and on VCM Gate Review callbacks; the tool reports the authoritative enable state.
 
 ## VCM Harness Scope
 

package/dist/backend/templates/harness/gate-review.js

@@ -192,6 +192,10 @@ SOURCE_ARTIFACTS = {
         ".ai/vcm/handoffs/final-acceptance.md",
     ],
 }
+CORE_INPUT_ARTIFACTS = {
+    "architecture-plan": ".ai/vcm/handoffs/architecture-plan.md",
+    "validation-adequacy": ".ai/vcm/handoffs/review-report.md",
+}
 
 
 def root_dir() -> Path:
@@ -282,6 +286,13 @@ def command_output(root: Path, command: list[str]) -> bytes:
 
 def input_hash(root: Path, gate: str) -> str:
     digest = hashlib.sha256()
+    core_artifact = CORE_INPUT_ARTIFACTS.get(gate)
+    if core_artifact:
+        path = root / core_artifact
+        digest.update(core_artifact.encode())
+        digest.update(path.read_bytes())
+        return digest.hexdigest()
+
     common = [
         "CLAUDE.md",
         ".claude/agents/gate-reviewer.md",
@@ -302,6 +313,18 @@ def input_hash(root: Path, gate: str) -> str:
     return digest.hexdigest()
 
 
+def core_input_status(root: Path, gate: str) -> tuple[str, str] | None:
+    core_artifact = CORE_INPUT_ARTIFACTS.get(gate)
+    if not core_artifact:
+        return None
+    path = root / core_artifact
+    if not path.is_file():
+        return (core_artifact, "missing")
+    if not path.read_text().strip():
+        return (core_artifact, "empty")
+    return (core_artifact, "ready")
+
+
 def request_id(gate: str) -> str:
     stamp = datetime.now(timezone.utc).strftime("%Y%m%dT%H%M%SZ")
     return f"{stamp}-{gate}-{uuid.uuid4().hex[:8]}"
@@ -340,6 +363,30 @@ def local_request(gate: str) -> int:
         print_result("not_required", gate=gate)
         return 0
 
+    core_status = core_input_status(root, gate)
+    if core_status and core_status[1] != "ready":
+        gate_record = index["gates"].setdefault(gate, {})
+        gate_record.update({
+            "status": "not_required",
+            "decision": None,
+            "error": None,
+            "exceptionReason": None,
+            "requestId": None,
+            "requestPath": None,
+            "inputHash": None,
+            "requestedAt": None,
+            "startedAt": None,
+            "completedAt": None,
+            "callbackStatus": "not_sent",
+            "callbackError": None,
+            "updatedAt": now_iso(),
+        })
+        if index.get("activeGate") == gate:
+            index["activeGate"] = None
+        write_json(index_path, index)
+        print_result("not_required", gate=gate, message=f"{core_status[0]} is {core_status[1]}.")
+        return 0
+
     current_hash = input_hash(root, gate)
     gate_record = index["gates"].get(gate, {})
     if (

package/dist/backend/templates/harness/project-manager-agent.js

@@ -84,15 +84,10 @@ PM may lightly rewrite the user's words to:
 
 ### Gate Review Gates
 
-- Gate Review is artifact-gated and transition-gated. Request it only when the current formal handoff artifact exists and PM is about to advance across that delivery boundary.
-- Within a confirmed delivery gate, the request is mandatory and unconditional: use the \`vcm-gate-review\` skill to run \`.ai/tools/request-gate-review --gate <gate>\` without judging whether Gate Review is enabled. The tool is the source of truth.
-- Trigger points:
-  - \`architecture-plan\`: current \`.ai/vcm/handoffs/architecture-plan.md\` exists and PM is about to dispatch Coder.
-  - \`validation-adequacy\`: current \`.ai/vcm/handoffs/review-report.md\` exists and PM is about to start docs sync or final acceptance.
-  - \`final-diff\`: current final acceptance evidence exists and PM is about to prepare PR or close the task.
-- Questions, clarifications, role consultations, explanations, status replies, and user-directed role Q&A do not trigger Gate Review.
+- Gate Review requests are mandatory and unconditional. At every trigger point, use the \`vcm-gate-review\` skill to run \`.ai/tools/request-gate-review --gate <gate>\` without first judging whether Gate Review is enabled. The tool (via VCM) is the single source of truth for enable state; never skip the run because you assume Gate Review is off or because the worktree has no gate-review index yet.
 - The tool's first output line decides the next step: \`disabled\`, \`not_required\`, or \`already_approved\` continue the normal VCM flow; \`started\` or \`running\` stop the turn and wait for the VCM callback; \`failed_to_start\` is a hard stop — report it to the user and do not silently proceed past the gate.
-- On a callback, accept only \`approve\` or \`request_changes\`. On \`request_changes\`, route \`architecture-plan\`/\`final-diff\` reports to architect and \`validation-adequacy\` reports to reviewer.
+- Trigger points (run each unconditionally): before coder dispatch run \`architecture-plan\`; before docs sync or final acceptance run \`validation-adequacy\`; before PR preparation run \`final-diff\`.
+- On a callback, accept only \`approve\` or \`request_changes\`. On \`request_changes\`, route \`architecture-plan\`/\`final-diff\` reports to architect (Debug Mode or Replan assessment) and \`validation-adequacy\` reports to reviewer.
 - Do not ask Gate Reviewer to choose owners, fixes, Replan, or user-intervention needs.
 - Record gate decision, report path, and any skip or override reason.