vibe-coding-master 0.4.26 → 0.4.28

package/dist/backend/cli/install-vcm-harness.js

@@ -268,7 +268,6 @@ async function main() {
     const operations = [];
     await assertDirectory(projectRoot, "Project root");
     const manifest = await buildManifest(projectRoot);
-    await installManifest({ projectRoot, manifest, dryRun, operations });
     for (const definition of MANAGED_FILES) {
         await installManagedFile({ projectRoot, definition, dryRun, operations });
     }
@@ -284,6 +283,13 @@ async function main() {
     }
     await removeLegacyFlatSkillFiles({ projectRoot, dryRun, operations });
     await removeLegacyCodexHarnessPaths({ projectRoot, dryRun, operations });
+    await installManifest({
+        projectRoot,
+        manifest,
+        dryRun,
+        operations,
+        forceWrite: hasRealHarnessChange(operations)
+    });
     printReport({ projectRoot, dryRun, operations });
 }
 function parseArgs(argv) {
@@ -449,13 +455,17 @@ function directoryCategory(directory) {
     }
     return "harness-tool-directory";
 }
-async function installManifest({ projectRoot, manifest, dryRun, operations }) {
+async function installManifest({ projectRoot, manifest, dryRun, operations, forceWrite = false }) {
     const targetPath = path.join(projectRoot, MANIFEST_PATH);
     const currentManifest = await readOptionalJson(targetPath);
     if (currentManifest && manifestBodyEqual(currentManifest, manifest)) {
         operations.push(skip(MANIFEST_PATH, "unchanged"));
         return;
     }
+    if (!forceWrite && currentManifest && manifestBodyEqual(currentManifest, manifest, { ignoreHarnessVersion: true })) {
+        operations.push(skip(MANIFEST_PATH, "version-only change ignored"));
+        return;
+    }
     await writeIfChanged({
         targetPath,
         relativePath: MANIFEST_PATH,
@@ -731,15 +741,23 @@ async function pathExists(absolutePath) {
         throw error;
     });
 }
-function manifestBodyEqual(left, right) {
+function manifestBodyEqual(left, right, options = {}) {
     const normalizedLeft = { ...left };
     const normalizedRight = { ...right };
     delete normalizedLeft.installedAt;
     delete normalizedLeft.updatedAt;
     delete normalizedRight.installedAt;
     delete normalizedRight.updatedAt;
+    if (options.ignoreHarnessVersion) {
+        delete normalizedLeft.harnessVersion;
+        delete normalizedRight.harnessVersion;
+    }
     return JSON.stringify(normalizedLeft) === JSON.stringify(normalizedRight);
 }
+function hasRealHarnessChange(operations) {
+    return operations.some((operation) => operation.path !== MANIFEST_PATH &&
+        (operation.status === "done" || operation.status === "plan"));
+}
 function resolveInside(root, relativePath) {
     if (path.isAbsolute(relativePath)) {
         fail(`Path must be relative: ${relativePath}`);

package/dist/backend/services/harness-service.js

@@ -1284,11 +1284,7 @@ async function analyzeHarnessManifest(fs, repoRoot, vcmVersion) {
         };
     }
     if (installedVersion !== vcmVersion) {
-        return {
-            path: MANIFEST_PATH,
-            action: "update",
-            reason: `VCM fixed harness manifest version is ${installedVersion ?? "missing"}; current VCM version is ${vcmVersion}.`
-        };
+        return undefined;
     }
     return undefined;
 }

package/dist/backend/services/session-service.js

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import path from "node:path";
 import { VCM_ROLE_NAMES, isDispatchableRole } from "../../shared/constants.js";
 import { VcmError } from "../errors.js";
@@ -43,10 +42,10 @@ export function createSessionService(deps) {
         const permissionMode = normalizeClaudePermissionMode(input.permissionMode ?? persisted?.permissionMode);
         const model = normalizeClaudeModel(input.model ?? persisted?.model);
         const effort = normalizeClaudeEffort(input.effort ?? persisted?.effort);
-        const claudeSessionId = launchMode === "resume"
+        const resumeClaudeSessionId = launchMode === "resume"
             ? persisted?.claudeSessionId
-            : randomUUID();
-        if (!claudeSessionId) {
+            : undefined;
+        if (launchMode === "resume" && !resumeClaudeSessionId) {
             throw new VcmError({
                 code: "CLAUDE_SESSION_MISSING",
                 message: `${role} does not have a session id to resume.`,
@@ -54,11 +53,14 @@ export function createSessionService(deps) {
                 hint: "Start the role once before using Resume."
             });
         }
+        const claudeSessionId = resumeClaudeSessionId ?? "";
         const transcriptPath = launchMode === "resume" && persisted?.transcriptPath
             ? persisted.transcriptPath
-            : claudeTranscriptPath(taskRepoRoot, claudeSessionId);
+            : resumeClaudeSessionId
+                ? claudeTranscriptPath(taskRepoRoot, resumeClaudeSessionId)
+                : undefined;
         const startCommand = {
-            ...deps.claude.buildRoleStartCommand(role, config.claudeCommand, permissionMode, claudeSessionId, launchMode === "resume", model, effort),
+            ...deps.claude.buildRoleStartCommand(role, config.claudeCommand, permissionMode, resumeClaudeSessionId, launchMode === "resume", model, effort),
             cwd: taskRepoRoot
         };
         const runtimeSession = await deps.runtime.createSession({
@@ -73,7 +75,7 @@ export function createSessionService(deps) {
                 VCM_TASK_REPO_ROOT: taskRepoRoot,
                 VCM_TASK_SLUG: taskSlug,
                 VCM_ROLE: role,
-                VCM_SESSION_ID: claudeSessionId
+                VCM_SESSION_ID: claudeSessionId || undefined
             },
             cols: input.cols,
             rows: input.rows
@@ -120,10 +122,10 @@ export function createSessionService(deps) {
         const permissionMode = normalizeClaudePermissionMode(input.permissionMode ?? persisted?.permissionMode);
         const model = normalizeClaudeModel(input.model ?? persisted?.model);
         const effort = normalizeClaudeEffort(input.effort ?? persisted?.effort ?? "medium");
-        const claudeSessionId = launchMode === "resume"
+        const resumeClaudeSessionId = launchMode === "resume"
             ? persisted?.claudeSessionId
-            : randomUUID();
-        if (!claudeSessionId) {
+            : undefined;
+        if (launchMode === "resume" && !resumeClaudeSessionId) {
             throw new VcmError({
                 code: "TRANSLATOR_SESSION_MISSING",
                 message: "Translator does not have a session id to resume.",
@@ -135,11 +137,14 @@ export function createSessionService(deps) {
         const launchCwd = launchMode === "resume"
             ? persisted?.cwd ?? taskContext.taskRepoRoot
             : taskContext.taskRepoRoot;
+        const claudeSessionId = resumeClaudeSessionId ?? "";
         const transcriptPath = launchMode === "resume" && persisted?.transcriptPath
             ? persisted.transcriptPath
-            : claudeTranscriptPath(launchCwd, claudeSessionId);
+            : resumeClaudeSessionId
+                ? claudeTranscriptPath(launchCwd, resumeClaudeSessionId)
+                : undefined;
         const startCommand = {
-            ...deps.claude.buildRoleStartCommand(TRANSLATOR_ROLE, config.claudeCommand, permissionMode, claudeSessionId, launchMode === "resume", model, effort),
+            ...deps.claude.buildRoleStartCommand(TRANSLATOR_ROLE, config.claudeCommand, permissionMode, resumeClaudeSessionId, launchMode === "resume", model, effort),
             cwd: launchCwd
         };
         const runtimeSession = await deps.runtime.createSession({
@@ -154,7 +159,7 @@ export function createSessionService(deps) {
                 VCM_TASK_REPO_ROOT: taskContext.taskRepoRoot,
                 VCM_TASK_SLUG: taskContext.taskSlug,
                 VCM_ROLE: TRANSLATOR_ROLE,
-                VCM_SESSION_ID: claudeSessionId
+                VCM_SESSION_ID: claudeSessionId || undefined
             },
             cols: input.cols,
             rows: input.rows
@@ -197,10 +202,10 @@ export function createSessionService(deps) {
         const permissionMode = normalizeClaudePermissionMode(input.permissionMode ?? persisted?.permissionMode);
         const model = normalizeClaudeModel(input.model ?? persisted?.model);
         const effort = normalizeClaudeEffort(input.effort ?? persisted?.effort ?? "medium");
-        const claudeSessionId = launchMode === "resume"
+        const resumeClaudeSessionId = launchMode === "resume"
             ? persisted?.claudeSessionId
-            : randomUUID();
-        if (!claudeSessionId) {
+            : undefined;
+        if (launchMode === "resume" && !resumeClaudeSessionId) {
             throw new VcmError({
                 code: "HARNESS_ENGINEER_SESSION_MISSING",
                 message: "Harness Engineer does not have a session id to resume.",
@@ -212,11 +217,14 @@ export function createSessionService(deps) {
         const launchCwd = launchMode === "resume"
             ? persisted?.cwd ?? taskContext.taskRepoRoot
             : taskContext.taskRepoRoot;
+        const claudeSessionId = resumeClaudeSessionId ?? "";
         const transcriptPath = launchMode === "resume" && persisted?.transcriptPath
             ? persisted.transcriptPath
-            : claudeTranscriptPath(launchCwd, claudeSessionId);
+            : resumeClaudeSessionId
+                ? claudeTranscriptPath(launchCwd, resumeClaudeSessionId)
+                : undefined;
         const startCommand = {
-            ...deps.claude.buildRoleStartCommand(HARNESS_ENGINEER_ROLE, config.claudeCommand, permissionMode, claudeSessionId, launchMode === "resume", model, effort),
+            ...deps.claude.buildRoleStartCommand(HARNESS_ENGINEER_ROLE, config.claudeCommand, permissionMode, resumeClaudeSessionId, launchMode === "resume", model, effort),
             cwd: launchCwd
         };
         const runtimeSession = await deps.runtime.createSession({
@@ -231,7 +239,7 @@ export function createSessionService(deps) {
                 VCM_TASK_REPO_ROOT: taskContext.taskRepoRoot,
                 VCM_TASK_SLUG: taskContext.taskSlug,
                 VCM_ROLE: HARNESS_ENGINEER_ROLE,
-                VCM_SESSION_ID: claudeSessionId
+                VCM_SESSION_ID: claudeSessionId || undefined
             },
             cols: input.cols,
             rows: input.rows
@@ -298,7 +306,9 @@ export function createSessionService(deps) {
             ...session,
             cwd: targetCwd,
             previousCwd: session.cwd,
-            transcriptPath: claudeTranscriptPath(targetCwd, session.claudeSessionId),
+            transcriptPath: session.claudeSessionId
+                ? claudeTranscriptPath(targetCwd, session.claudeSessionId)
+                : session.transcriptPath,
             updatedAt: timestamp
         };
         deps.registry.upsert(normalizeProjectScopedRecordForPersistence(updated));
@@ -466,6 +476,7 @@ export function createSessionService(deps) {
                 await deps.runtime.stop(existing.id);
             }
             deps.registry.remove(existing.id);
+            await clearPersistedTranslatorSession(deps.fs, repoRoot);
             return launchProjectTranslatorSession(repoRoot, input, "fresh");
         },
         async getProjectTranslatorSession(repoRoot) {
@@ -509,10 +520,11 @@ export function createSessionService(deps) {
             const timestamp = now();
             const isTurnEnd = isTurnEndHook(input.eventName);
             const isCompact = isCompactHook(input.eventName);
+            const sessionIdentity = nextHookSessionIdentity(current, input);
             const updated = {
                 ...current,
-                claudeSessionId: input.sessionId ?? current.claudeSessionId,
-                transcriptPath: input.transcriptPath ?? current.transcriptPath,
+                claudeSessionId: sessionIdentity.claudeSessionId,
+                transcriptPath: sessionIdentity.transcriptPath,
                 cwd: input.cwd ?? current.cwd,
                 activityStatus: isTurnEnd ? "idle" : isCompact ? current.activityStatus : "running",
                 lastHookEventAt: timestamp,
@@ -590,6 +602,7 @@ export function createSessionService(deps) {
                 await deps.runtime.stop(existing.id);
             }
             deps.registry.remove(existing.id);
+            await clearPersistedHarnessEngineerSession(deps.fs, repoRoot);
             return launchProjectHarnessEngineerSession(repoRoot, input, "fresh");
         },
         async getProjectHarnessEngineerSession(repoRoot) {
@@ -633,10 +646,11 @@ export function createSessionService(deps) {
             const timestamp = now();
             const isTurnEnd = isTurnEndHook(input.eventName);
             const isCompact = isCompactHook(input.eventName);
+            const sessionIdentity = nextHookSessionIdentity(current, input);
             const updated = {
                 ...current,
-                claudeSessionId: input.sessionId ?? current.claudeSessionId,
-                transcriptPath: input.transcriptPath ?? current.transcriptPath,
+                claudeSessionId: sessionIdentity.claudeSessionId,
+                transcriptPath: sessionIdentity.transcriptPath,
                 cwd: input.cwd ?? current.cwd,
                 activityStatus: isTurnEnd ? "idle" : isCompact ? current.activityStatus : "running",
                 lastHookEventAt: timestamp,
@@ -725,6 +739,9 @@ export function createSessionService(deps) {
                 await deps.runtime.stop(existing.id);
             }
             deps.registry.remove(existing.id);
+            const config = await deps.projectService.loadConfig(repoRoot);
+            const task = await deps.taskService.loadTask(repoRoot, taskSlug);
+            await clearPersistedRoleSessionRecord(deps.fs, getTaskRuntimeRepoRoot(task), config.stateRoot, taskSlug, role, now());
             return launchRoleSession(repoRoot, taskSlug, role, input, "fresh");
         },
         async getRoleSession(repoRoot, taskSlug, role) {
@@ -800,10 +817,11 @@ export function createSessionService(deps) {
             const timestamp = now();
             const isTurnEnd = isTurnEndHook(input.eventName);
             const isCompact = isCompactHook(input.eventName);
+            const sessionIdentity = nextHookSessionIdentity(current, input);
             const updated = {
                 ...current,
-                claudeSessionId: input.sessionId ?? current.claudeSessionId,
-                transcriptPath: input.transcriptPath ?? current.transcriptPath,
+                claudeSessionId: sessionIdentity.claudeSessionId,
+                transcriptPath: sessionIdentity.transcriptPath,
                 cwd: input.cwd ?? current.cwd,
                 activityStatus: isTurnEnd ? "idle" : isCompact ? current.activityStatus : "running",
                 lastHookEventAt: timestamp,
@@ -890,6 +908,9 @@ function toRoleSessionRecordView(record, runtime) {
     };
 }
 function matchesRoleHookSession(record, input) {
+    if (!record.claudeSessionId && !record.transcriptPath) {
+        return input.eventName === "UserPromptSubmit";
+    }
     if (input.sessionId && record.claudeSessionId === input.sessionId) {
         return true;
     }
@@ -901,6 +922,20 @@ function matchesRoleHookSession(record, input) {
     }
     return false;
 }
+function nextHookSessionIdentity(current, input) {
+    const canRecordFirstClaudeSessionId = Boolean(!current.claudeSessionId &&
+        input.eventName === "UserPromptSubmit" &&
+        input.sessionId);
+    const hasConfirmedClaudeSessionId = Boolean(current.claudeSessionId || canRecordFirstClaudeSessionId);
+    return {
+        claudeSessionId: canRecordFirstClaudeSessionId
+            ? input.sessionId ?? current.claudeSessionId
+            : current.claudeSessionId,
+        transcriptPath: hasConfirmedClaudeSessionId
+            ? input.transcriptPath ?? current.transcriptPath
+            : current.transcriptPath
+    };
+}
 function isTurnEndHook(eventName) {
     return eventName === "Stop" || eventName === "StopFailure";
 }
@@ -1068,6 +1103,9 @@ function buildHarnessRefreshPrompt(role) {
     ].join("\n");
 }
 async function persistTaskSession(fs, repoRoot, stateRoot, session) {
+    if (!hasConfirmedClaudeSessionId(session)) {
+        return;
+    }
     const sessionPath = getTaskSessionPath(repoRoot, stateRoot, session.taskSlug);
     const empty = createEmptyTaskSessionRecord(session.taskSlug, session.updatedAt);
     const current = await fs.pathExists(sessionPath)
@@ -1092,6 +1130,23 @@ async function persistTaskSession(fs, repoRoot, stateRoot, session) {
         }
     });
 }
+async function clearPersistedRoleSessionRecord(fs, repoRoot, stateRoot, taskSlug, role, updatedAt) {
+    const sessionPath = getTaskSessionPath(repoRoot, stateRoot, taskSlug);
+    const current = await fs.pathExists(sessionPath)
+        ? await fs.readJson(sessionPath)
+        : createEmptyTaskSessionRecord(taskSlug, updatedAt);
+    await fs.writeJsonAtomic(sessionPath, {
+        ...current,
+        updatedAt,
+        roles: {
+            ...current.roles,
+            [role]: {
+                id: null,
+                status: "not_started"
+            }
+        }
+    });
+}
 async function persistRoleSessionRecord(fs, baseRepoRoot, taskRepoRoot, stateRoot, session) {
     if (session.role === TRANSLATOR_ROLE) {
         await persistTranslatorSession(fs, baseRepoRoot, session);
@@ -1104,6 +1159,9 @@ async function persistRoleSessionRecord(fs, baseRepoRoot, taskRepoRoot, stateRoo
     await persistTaskSession(fs, taskRepoRoot, stateRoot, session);
 }
 async function persistTranslatorSession(fs, repoRoot, session) {
+    if (!hasConfirmedClaudeSessionId(session)) {
+        return;
+    }
     await fs.writeJsonAtomic(resolveRepoPath(repoRoot, TRANSLATOR_SESSION_PATH), {
         version: 1,
         role: session.role,
@@ -1114,7 +1172,13 @@ async function persistTranslatorSession(fs, repoRoot, session) {
         }
     });
 }
+async function clearPersistedTranslatorSession(fs, repoRoot) {
+    await removePersistedProjectSessionFile(fs, repoRoot, TRANSLATOR_SESSION_PATH);
+}
 async function persistHarnessEngineerSession(fs, repoRoot, session) {
+    if (!hasConfirmedClaudeSessionId(session)) {
+        return;
+    }
     await fs.writeJsonAtomic(resolveRepoPath(repoRoot, HARNESS_ENGINEER_SESSION_PATH), {
         version: 1,
         role: session.role,
@@ -1125,9 +1189,30 @@ async function persistHarnessEngineerSession(fs, repoRoot, session) {
         }
     });
 }
+async function clearPersistedHarnessEngineerSession(fs, repoRoot) {
+    await removePersistedProjectSessionFile(fs, repoRoot, HARNESS_ENGINEER_SESSION_PATH);
+}
+async function removePersistedProjectSessionFile(fs, repoRoot, relativePath) {
+    const sessionPath = resolveRepoPath(repoRoot, relativePath);
+    if (!(await fs.pathExists(sessionPath))) {
+        return;
+    }
+    if (!fs.removePath) {
+        throw new VcmError({
+            code: "SESSION_CLEAR_UNAVAILABLE",
+            message: "VCM cannot clear the persisted Claude session file in this runtime.",
+            statusCode: 500,
+            hint: `Remove ${relativePath} manually before restarting the role.`
+        });
+    }
+    await fs.removePath(sessionPath, { force: true });
+}
 function isProjectRoleSessionFile(value) {
     return "record" in value && typeof value.record === "object" && value.record !== null;
 }
+function hasConfirmedClaudeSessionId(session) {
+    return session.claudeSessionId.trim().length > 0;
+}
 function createEmptyTaskSessionRecord(taskSlug, updatedAt) {
     return {
         version: 1,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibe-coding-master",
-  "version": "0.4.26",
+  "version": "0.4.28",
   "description": "Local GUI session cockpit for Claude Code role sessions.",
   "type": "module",
   "files": [