vibe-coding-master 0.3.1 → 0.3.3

package/dist/backend/templates/harness/architect-agent.js

@@ -21,24 +21,28 @@ export function renderArchitectHarnessRules() {
 
 ### Architecture Plan
 
-- Before coder work starts, write \`.ai/vcm/handoffs/architecture-plan.md\` and materialize the plan in code scaffolding.
+- Before coder work starts, write \`.ai/vcm/handoffs/architecture-plan.md\`, choose the minimum necessary code scaffolding, and include a Scaffold Manifest for task-specific context and coder guidance.
 
 #### Plan Document
 
 - Define the expected implementation scope: affected modules, changed or created files, each file's responsibility, why it is in scope, and user-visible behavior changes.
 - Define every non-private callable surface intended for use outside its file: visibility, signature shape, responsibility, expected callers, behavior contract, side effects, and error boundaries.
+- Include a \`Scaffold Manifest\` for task-specific file context: file action, why the file is in scope, coder work, allowed implementation freedom, expected \`VCM:CODE\` placeholders, durable code comment needs, proof points, and Replan triggers.
+- Put task context, phase notes, handoff instructions, temporary rationale, and coder guidance in the \`Scaffold Manifest\`, not in source-code comments.
 - Cover architecture docs impact, known risks, and Replan triggers.
 - For docs impact, state whether changes belong in \`docs/ARCHITECTURE.md\`, affected \`<module>/ARCHITECTURE.md\`, \`.ai/generated/public-surface.json\`, or no durable architecture doc.
 
 #### Code Scaffolding
 
-- Create or update module/file scaffolding so file responsibilities, logic boundaries, collaborators, and non-goals are documented in code.
-- When changing an existing file, update only the affected in-code scaffold: responsibility, boundary, collaborators, non-goals, or callable surfaces; do not rewrite unrelated file comments.
+- Create or update only the minimum module/file scaffolding needed to make boundaries, callable surfaces, and placeholders unambiguous.
+- Source-code comments must describe durable behavior, contracts, invariants, error boundaries, or non-obvious logic that should remain useful after the task is complete.
+- Do not put task-specific context, phase notes, handoff instructions, temporary plan rationale, or coder guidance in source-code comments.
+- When changing an existing file, update only affected durable comments or callable surfaces; do not rewrite unrelated file comments.
 - Define every new or changed non-private callable surface directly in code with its signature shape and contract comment.
 - When changing an existing non-private callable surface, update its signature and contract comment in code before coder work starts; leave \`VCM:CODE\` only where implementation must change.
 - Non-private callable surface includes any function, method, type, trait, enum, constant, re-export, or similar symbol that another file can call or depend on.
 - Mark incomplete implementation bodies with \`VCM:CODE\`; coder must implement them and remove the markers before handoff.
-- Architect scaffolding may include modules, files, signatures, type shapes, comments, and placeholder bodies, but not real business implementation beyond minimal scaffold code.
+- Architect scaffolding may include modules, files, signatures, type shapes, durable comments, and placeholder bodies, but not real business implementation beyond minimal scaffold code.
 - Coder may add private implementation helpers, but must not add or change cross-file callable surface without architect replan.
 
 ### Phase Planning

package/dist/backend/templates/harness/claude-root.js

@@ -27,7 +27,7 @@ export function renderRootClaudeHarnessRules() {
 ## VCM Task Flow
 
 - Code changes use the full route: \`project-manager -> architect -> coder -> reviewer -> architect docs sync -> project-manager final acceptance\`.
-- Before code changes, architect must write an architecture plan and code scaffolding that cover file responsibilities, cross-file callable surfaces, user-visible behavior, docs impact, risks, and Replan triggers.
+- Before code changes, architect must write an architecture plan with a Scaffold Manifest and minimum necessary code scaffolding that cover file responsibilities, cross-file callable surfaces, user-visible behavior, docs impact, risks, and Replan triggers.
 - Docs-only changes may use: \`project-manager -> architect -> project-manager final acceptance\`.
 - Test-only or validation-only work may use: \`project-manager -> reviewer -> project-manager final acceptance\`.
 - If a docs/test/validation-only task reveals required code, architecture, public contract, dependency, durable-doc, or test-strategy changes, route back through the full code-change flow.

package/dist/backend/templates/harness/coder-agent.js

@@ -14,7 +14,7 @@ export function renderCoderHarnessRules() {
 - Do not fake completion: no hardcoded success, disabled logic, swallowed errors, test-only shortcuts, or silent fallback that hides failure.
 - Keep the diff inside approved scope: no unrelated rewrites, drive-by refactors, renamed symbols, moved files, or formatting churn.
 - Preserve existing behavior unless the architecture plan explicitly changes it; keep existing call sites and shared code paths working.
-- Maintain code documentation: preserve architect-written comments, add comments for non-obvious implementation logic, remove stale/debug/TODO comments, and keep code and comments consistent.
+- Maintain code documentation: preserve durable architect-written contract comments, do not copy Scaffold Manifest task context into source comments, add comments only for non-obvious durable logic, remove stale/debug/TODO/task-process comments, and keep code and comments consistent.
 
 ### General Coding Standards
 

package/dist/backend/templates/harness/codex-review.js

@@ -31,10 +31,12 @@ Check that the plan:
 - matches the user request and approved scope
 - names affected modules/files, file responsibilities, and user-visible changes
 - defines new or changed non-private callable surfaces: visibility, signature shape, callers, contract, side effects, and error boundaries
+- includes a Scaffold Manifest that carries task-specific context, coder guidance, allowed freedom, expected \`VCM:CODE\`, durable code comment needs, proof points, and Replan triggers
 - preserves dependency direction and avoids unapproved dependencies
 - states docs/generated-context impact or explains why none is needed
 - names risks, proof points, phase boundaries when needed, and Replan triggers
 - uses \`VCM:CODE\` for incomplete implementation and leaves no coder ambiguity
+- keeps task-specific context, phase notes, handoff instructions, and coder guidance out of source-code comments
 - does not take over reviewer-owned validation strategy or test adequacy
 
 ### Validation Adequacy
@@ -56,6 +58,7 @@ Check that the final diff:
 - stays inside the approved plan, phase, and user constraints
 - introduces no unapproved modules, dependencies, public contracts, cross-file callable surfaces, or durable-doc changes
 - removes all \`VCM:CODE\` markers
+- leaves no task-specific process comments in source or test code, such as role handoff notes, phase notes, current-task rationale, or coder instructions
 - contains no fake completion: hardcoded success, disabled logic, swallowed errors, test-only shortcuts, or silent fallback hiding failure
 - preserves existing behavior unless the plan changes it
 - keeps changed functions focused and meaningfully named
@@ -90,15 +93,11 @@ Summary: <one or two sentences>
 - Do not request broader filesystem or network permissions.`;
 }
 export function renderCodexConfigHarnessRules() {
-    return `model = "gpt-5.5"
-model_reasoning_effort = "xhigh"
+    return `# VCM reads this file before launching the Codex Reviewer terminal.
+# Codex CLI project hooks live in .ai/codex/.codex/.
 approval_policy = "never"
 default_permissions = "vcm_codex_reviewer"
 
-[vcm.codex_review]
-enabled = false
-required_gates = []
-
 [permissions.vcm_codex_reviewer.workspace_roots]
 "../.." = true
 
@@ -112,7 +111,7 @@ required_gates = []
 "**/*.env" = "deny"
 
 [permissions.vcm_codex_reviewer.network]
-enabled = false`;
+enabled = true`;
 }
 export function renderCodexCliConfigHarnessRules() {
     return `[features]
@@ -161,6 +160,7 @@ Review whether the architecture plan is ready for coder implementation.
 - \`../../.claude/agents/coder.md\`
 - \`../../.claude/agents/reviewer.md\`
 - \`../../.ai/vcm/handoffs/architecture-plan.md\`
+- current git status and scaffold diff from \`../..\`
 - \`../../.ai/generated/module-index.json\`
 - \`../../.ai/generated/public-surface.json\`
 
@@ -362,11 +362,6 @@ import uuid
 from datetime import datetime, timezone
 from pathlib import Path
 
-try:
-    import tomllib
-except ModuleNotFoundError:
-    tomllib = None
-
 
 GATES = ("architecture-plan", "validation-adequacy", "final-diff")
 REPORTS = {
@@ -464,20 +459,6 @@ def write_json(path: Path, data: dict) -> None:
     tmp.replace(path)
 
 
-def load_config(root: Path) -> dict:
-    path = root / ".ai/codex/config.toml"
-    if not path.is_file() or tomllib is None:
-        return {}
-    return tomllib.loads(path.read_text())
-
-
-def codex_review_config(root: Path) -> dict:
-    config = load_config(root)
-    vcm = config.get("vcm", {})
-    review = vcm.get("codex_review", {}) if isinstance(vcm, dict) else {}
-    return review if isinstance(review, dict) else {}
-
-
 def command_output(root: Path, command: list[str]) -> bytes:
     result = subprocess.run(
         command,
@@ -518,11 +499,11 @@ def request_id(gate: str) -> str:
 
 def local_request(gate: str) -> int:
     root = root_dir()
-    review_config = codex_review_config(root)
-    enabled = bool(review_config.get("enabled", False))
-    required = set(review_config.get("required_gates", []))
     index_path = root / ".ai/vcm/codex-reviews/index.json"
     index = read_json(index_path)
+    enabled = bool(index.get("enabled", False))
+    gate_record = index.get("gates", {}).get(gate, {}) if isinstance(index.get("gates"), dict) else {}
+    required = bool(gate_record.get("required", False)) if isinstance(gate_record, dict) else False
     index.update({"version": 1, "enabled": enabled})
     index.setdefault("gates", {})
 
@@ -532,7 +513,7 @@ def local_request(gate: str) -> int:
         print_result("disabled", gate=gate)
         return 0
 
-    if gate not in required:
+    if not required:
         gate_record = index["gates"].setdefault(gate, {})
         gate_record.update({"required": False, "status": "not_required", "updatedAt": now_iso()})
         write_json(index_path, index)

package/dist/backend/templates/harness/reviewer-agent.js

@@ -23,6 +23,7 @@ export function renderReviewerHarnessRules() {
 - Record failed commands, observed behavior, expected behavior, reproduction steps, skipped checks, and coverage gaps.
 - If validation fails or expected behavior is unclear, report the evidence to project-manager; architect owns diagnosis and next-step routing.
 - Add or modify tests, fixtures, or test helpers needed for validation confidence.
+- If task-specific process comments appear in changed code while reviewing behavior, report them as a maintainability gap; task context belongs in handoff artifacts, not durable code comments.
 - Update \`docs/TESTING.md\` when validation strategy, commands, level mapping, integration/E2E case definitions, selection rules, final-validation cleanup, test gaps, or test expectations change.
 
 ### Testing Documentation

package/dist/shared/types/session.js

@@ -47,7 +47,7 @@ export const CODEX_MODEL_OPTIONS = [
         description: "Codex account default"
     }
 ];
-export const SESSION_EFFORT_OPTIONS = [
+export const CODEX_EFFORT_OPTIONS = [
     {
         value: "default",
         label: "Default",
@@ -79,3 +79,12 @@ export const SESSION_EFFORT_OPTIONS = [
         description: "Maximum reasoning"
     }
 ];
+export const CLAUDE_EFFORT_OPTIONS = [
+    ...CODEX_EFFORT_OPTIONS,
+    {
+        value: "ultracode",
+        label: "Ultracode",
+        description: "Claude Code dynamic workflows with xhigh reasoning"
+    }
+];
+export const SESSION_EFFORT_OPTIONS = CLAUDE_EFFORT_OPTIONS;

package/dist/shared/validation/artifact-check.js

@@ -2,6 +2,7 @@ const REQUIRED_HEADINGS = {
     "architecture-plan": [
         "Context",
         "Architecture Decision",
+        "Scaffold Manifest",
         "Implementation Plan",
         "Risks",
         "Stop Conditions"