vibe-and-thrive 1.6.8 → 1.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vibe-and-thrive",
-  "version": "1.6.8",
+  "version": "1.7.0",
   "description": "Ship quality code faster with AI - RALPH autonomous loop, Claude Code hooks, and pre-commit checks",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/loop.sh

@@ -251,55 +251,59 @@ startup_checklist() {
   fi
 }
 
-# Build the prompt with story context injected
-build_prompt() {
-  local story="$1"
-  local failure_context="${2:-}"
-
-  # Read base PROMPT.md
-  cat "$PROMPT_FILE"
+# Helper: Inject story details into prompt
+_inject_story_context() {
+  local story_json="$1"
 
   echo ""
   echo "---"
   echo ""
   echo "## Current Story"
   echo ""
-
-  # Inject story details
-  local story_json
-  story_json=$(jq --arg id "$story" '.stories[] | select(.id==$id)' "$RALPH_DIR/prd.json")
   echo '```json'
   echo "$story_json"
   echo '```'
+}
+
+# Helper: Inject file guidance into prompt
+_inject_file_guidance() {
+  local story_json="$1"
 
-  # Extract file guidance if present
   local has_files
   has_files=$(echo "$story_json" | jq -r '.files // empty' 2>/dev/null)
-  if [[ -n "$has_files" ]]; then
-    echo ""
-    echo "### File Guidance for This Story"
-    echo ""
-    echo "**Create these files:**"
-    echo "$story_json" | jq -r '.files.create[]? // empty' | sed 's/^/- /'
-    echo ""
-    echo "**Modify these files:**"
-    echo "$story_json" | jq -r '.files.modify[]? // empty' | sed 's/^/- /'
-    echo ""
-    echo "**Reuse/import from:**"
-    echo "$story_json" | jq -r '.files.reuse[]? // empty' | sed 's/^/- /'
-  fi
+  [[ -z "$has_files" ]] && return
+
+  echo ""
+  echo "### File Guidance for This Story"
+  echo ""
+  echo "**Create these files:**"
+  echo "$story_json" | jq -r '.files.create[]? // empty' | sed 's/^/- /'
+  echo ""
+  echo "**Modify these files:**"
+  echo "$story_json" | jq -r '.files.modify[]? // empty' | sed 's/^/- /'
+  echo ""
+  echo "**Reuse/import from:**"
+  echo "$story_json" | jq -r '.files.reuse[]? // empty' | sed 's/^/- /'
+}
+
+# Helper: Inject scalability guidance for story
+_inject_story_scale() {
+  local story_json="$1"
 
-  # Extract scalability guidance if present (for backend stories)
   local has_scale
   has_scale=$(echo "$story_json" | jq -r '.scale // empty' 2>/dev/null)
-  if [[ -n "$has_scale" ]]; then
-    echo ""
-    echo "### Scalability Requirements for This Story"
-    echo ""
-    echo "$story_json" | jq -r '.scale | to_entries[] | "- **\(.key):** \(.value)"' 2>/dev/null
-  fi
+  [[ -z "$has_scale" ]] && return
+
+  echo ""
+  echo "### Scalability Requirements for This Story"
+  echo ""
+  echo "$story_json" | jq -r '.scale | to_entries[] | "- **\(.key):** \(.value)"' 2>/dev/null
+}
+
+# Helper: Inject styleguide reference for frontend stories
+_inject_styleguide() {
+  local story_json="$1"
 
-  # For frontend stories, instruct Claude to read the styleguide first
   local story_type
   story_type=$(echo "$story_json" | jq -r '.type // "frontend"' 2>/dev/null)
   local styleguide_path
@@ -312,74 +316,87 @@ build_prompt() {
     echo "**FIRST:** Read the project styleguide at \`$styleguide_path\` before implementing."
     echo "Use existing components, colors, and patterns from the styleguide."
   fi
+}
 
+# Helper: Inject feature-level context
+_inject_feature_context() {
   echo ""
   echo "## Feature Context"
   echo ""
   echo '```json'
   jq '{feature: .feature, metadata: .metadata}' "$RALPH_DIR/prd.json"
   echo '```'
+}
 
-  # Include scalability if defined
+# Helper: Inject scalability requirements
+_inject_scalability() {
   local has_scalability
   has_scalability=$(jq -r '.scalability // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-  if [[ -n "$has_scalability" ]]; then
-    echo ""
-    echo "## Scalability Requirements"
-    echo ""
-    echo "**IMPORTANT:** Follow these scalability rules."
-    echo ""
-    echo '```json'
-    jq '.scalability' "$RALPH_DIR/prd.json"
-    echo '```'
-    echo ""
-    echo "### Key Rules:"
-    echo "- Always paginate list endpoints (never return unbounded arrays)"
-    echo "- Avoid N+1 queries - eager load relationships"
-    echo "- Add database indexes for frequently queried fields"
-    echo "- Implement caching strategy as specified"
-    echo "- Add rate limiting to public endpoints"
-  fi
+  [[ -z "$has_scalability" ]] && return
+
+  echo ""
+  echo "## Scalability Requirements"
+  echo ""
+  echo "**IMPORTANT:** Follow these scalability rules."
+  echo ""
+  echo '```json'
+  jq '.scalability' "$RALPH_DIR/prd.json"
+  echo '```'
+  echo ""
+  echo "### Key Rules:"
+  echo "- Always paginate list endpoints (never return unbounded arrays)"
+  echo "- Avoid N+1 queries - eager load relationships"
+  echo "- Add database indexes for frequently queried fields"
+  echo "- Implement caching strategy as specified"
+  echo "- Add rate limiting to public endpoints"
+}
 
-  # Include architecture if defined
+# Helper: Inject architecture guidelines
+_inject_architecture() {
   local has_architecture
   has_architecture=$(jq -r '.architecture // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-  if [[ -n "$has_architecture" ]]; then
-    echo ""
-    echo "## Architecture Guidelines"
-    echo ""
-    echo "**IMPORTANT:** Follow these architecture rules strictly."
-    echo ""
-    echo '```json'
-    jq '.architecture' "$RALPH_DIR/prd.json"
-    echo '```'
-    echo ""
-    echo "### Key Rules:"
-    echo "- Put files in the specified directories"
-    echo "- Reuse existing components listed in 'patterns.reuse'"
-    echo "- Do NOT create anything in 'doNotCreate'"
-    echo "- Keep files under $(jq -r '.architecture.principles.maxFileLines // 300' "$RALPH_DIR/prd.json") lines"
-    echo "- Scripts go in scripts/, docs go in docs/"
-  fi
+  [[ -z "$has_architecture" ]] && return
 
-  # Include failure context from previous iteration if available
-  if [[ -n "$failure_context" ]]; then
-    echo ""
-    echo "## Previous Iteration Failed"
-    echo ""
-    echo "**IMPORTANT:** The previous attempt at this story failed verification. Review the errors below and fix them."
-    echo ""
-    echo '```'
-    echo "$failure_context"
-    echo '```'
-    echo ""
-    echo "### What to do:"
-    echo "1. Read the error messages carefully"
-    echo "2. Identify the root cause"
-    echo "3. Fix the issue (do not just retry the same approach)"
-    echo "4. Run verification again"
-  fi
+  echo ""
+  echo "## Architecture Guidelines"
+  echo ""
+  echo "**IMPORTANT:** Follow these architecture rules strictly."
+  echo ""
+  echo '```json'
+  jq '.architecture' "$RALPH_DIR/prd.json"
+  echo '```'
+  echo ""
+  echo "### Key Rules:"
+  echo "- Put files in the specified directories"
+  echo "- Reuse existing components listed in 'patterns.reuse'"
+  echo "- Do NOT create anything in 'doNotCreate'"
+  echo "- Keep files under $(jq -r '.architecture.principles.maxFileLines // 300' "$RALPH_DIR/prd.json") lines"
+  echo "- Scripts go in scripts/, docs go in docs/"
+}
+
+# Helper: Inject failure context from previous iteration
+_inject_failure_context() {
+  local failure_context="$1"
+  [[ -z "$failure_context" ]] && return
+
+  echo ""
+  echo "## Previous Iteration Failed"
+  echo ""
+  echo "**IMPORTANT:** The previous attempt at this story failed verification. Review the errors below and fix them."
+  echo ""
+  echo '```'
+  echo "$failure_context"
+  echo '```'
+  echo ""
+  echo "### What to do:"
+  echo "1. Read the error messages carefully"
+  echo "2. Identify the root cause"
+  echo "3. Fix the issue (do not just retry the same approach)"
+  echo "4. Run verification again"
+}
 
+# Helper: Inject signs (learned patterns)
+_inject_signs() {
   echo ""
   echo "## Signs (Learned Patterns)"
   echo ""
@@ -390,16 +407,43 @@ build_prompt() {
   else
     echo "(none yet)"
   fi
+}
 
-  # Include user's DNA (personal preferences) if it exists
-  if [[ -f "$HOME/.claude/DNA.md" ]]; then
-    echo ""
-    echo "## Developer DNA"
-    echo ""
-    echo "The developer has these working preferences:"
-    echo ""
-    cat "$HOME/.claude/DNA.md"
-  fi
+# Helper: Inject developer DNA
+_inject_developer_dna() {
+  [[ ! -f "$HOME/.claude/DNA.md" ]] && return
+
+  echo ""
+  echo "## Developer DNA"
+  echo ""
+  echo "The developer has these working preferences:"
+  echo ""
+  cat "$HOME/.claude/DNA.md"
+}
+
+# Build the prompt with story context injected
+build_prompt() {
+  local story="$1"
+  local failure_context="${2:-}"
+
+  # Read base PROMPT.md
+  cat "$PROMPT_FILE"
+
+  # Get story JSON once
+  local story_json
+  story_json=$(jq --arg id "$story" '.stories[] | select(.id==$id)' "$RALPH_DIR/prd.json")
+
+  # Inject all sections
+  _inject_story_context "$story_json"
+  _inject_file_guidance "$story_json"
+  _inject_story_scale "$story_json"
+  _inject_styleguide "$story_json"
+  _inject_feature_context
+  _inject_scalability
+  _inject_architecture
+  _inject_failure_context "$failure_context"
+  _inject_signs
+  _inject_developer_dna
 }
 
 # Mark feature as complete (keep PRD for appending new stories)
@@ -418,7 +462,14 @@ archive_feature() {
     if ! git commit -m "feat: complete $feature_name" 2>/dev/null; then
       # Retry after pre-commit auto-fixes
       git add -A
-      git commit -m "feat: complete $feature_name" 2>/dev/null || true
+      if ! git commit -m "feat: complete $feature_name" 2>/dev/null; then
+        # Check if it's "nothing to commit" vs real error
+        if git diff --cached --quiet 2>/dev/null; then
+          echo "    (no changes to commit)"
+        else
+          print_warning "Final commit failed - check git status"
+        fi
+      fi
     fi
   fi
 

package/ralph/utils.sh

@@ -6,9 +6,17 @@ readonly MAX_LOG_LINES=30
 readonly MAX_PROGRESS_LINES=10
 readonly MAX_GIT_STATUS_LINES=10
 readonly MAX_OUTPUT_PREVIEW_LINES=20
+readonly MAX_ERROR_PREVIEW_LINES=40
+readonly MAX_LINT_ERROR_LINES=20
 readonly ITERATION_DELAY_SECONDS=2
 readonly DEFAULT_TIMEOUT_SECONDS=600
 readonly DEFAULT_MAX_ITERATIONS=20
+readonly CODE_REVIEW_TIMEOUT_SECONDS=120
+readonly MAX_PROGRESS_FILE_LINES=1000
+
+# Common project directories (avoid duplication across files)
+readonly FRONTEND_DIRS=("apps/web" "frontend" "client" "web")
+readonly BACKEND_DIRS=("apps/api" "api" "backend" "server")
 
 # Track temp files for safe cleanup
 RALPH_TEMP_FILES=()
@@ -20,6 +28,24 @@ YELLOW='\033[1;33m'
 BLUE='\033[0;34m'
 NC='\033[0m' # No Color
 
+# Get existing frontend directories in this project
+get_frontend_dirs() {
+  local dirs=()
+  for d in "${FRONTEND_DIRS[@]}"; do
+    [[ -d "$d" ]] && dirs+=("$d")
+  done
+  printf '%s\n' "${dirs[@]}"
+}
+
+# Get existing backend directories in this project
+get_backend_dirs() {
+  local dirs=()
+  for d in "${BACKEND_DIRS[@]}"; do
+    [[ -d "$d" ]] && dirs+=("$d")
+  done
+  printf '%s\n' "${dirs[@]}"
+}
+
 # Progress bar for story display
 progress_bar() {
   local current=$1 total=$2 width=${3:-6}
@@ -95,14 +121,26 @@ check_dependencies() {
   fi
 }
 
-# Log progress to progress.txt
+# Log progress to progress.txt (with rotation to prevent unbounded growth)
 log_progress() {
   local story="$1"
   local status="$2"
   local msg="${3:-}"
   local timestamp
+  local progress_file="$RALPH_DIR/progress.txt"
+
   timestamp=$(date -Iseconds 2>/dev/null || date +%Y-%m-%dT%H:%M:%S)
-  echo "[$timestamp] $status $story $msg" >> "$RALPH_DIR/progress.txt"
+  echo "[$timestamp] $status $story $msg" >> "$progress_file"
+
+  # Rotate if file exceeds max lines (keep last half)
+  if [[ -f "$progress_file" ]]; then
+    local line_count
+    line_count=$(wc -l < "$progress_file" 2>/dev/null || echo "0")
+    if [[ "$line_count" -gt "$MAX_PROGRESS_FILE_LINES" ]]; then
+      local keep_lines=$((MAX_PROGRESS_FILE_LINES / 2))
+      tail -"$keep_lines" "$progress_file" > "$progress_file.tmp" && mv "$progress_file.tmp" "$progress_file"
+    fi
+  fi
 }
 
 # Get a value from config.json with a default

package/ralph/verify.sh

@@ -225,8 +225,8 @@ EOF
   echo "    Reviewing changes..."
 
   local result
-  # 2 minute timeout for code review
-  result=$(echo "$prompt" | run_with_timeout 120 claude -p --dangerously-skip-permissions 2>/dev/null) || {
+  # Timeout for code review (defined in utils.sh)
+  result=$(echo "$prompt" | run_with_timeout "$CODE_REVIEW_TIMEOUT_SECONDS" claude -p --dangerously-skip-permissions 2>/dev/null) || {
     print_warning "    Code review skipped (Claude unavailable or timed out)"
     return 0
   }
@@ -345,13 +345,13 @@ run_auto_fix() {
     fi
   fi
 
-  # Check frontend directory too (monorepo support)
-  local fe_dir=""
-  [[ -d "frontend" ]] && fe_dir="frontend"
-  [[ -d "client" ]] && fe_dir="client"
-  [[ -d "web" ]] && fe_dir="web"
+  # Check frontend directories (monorepo support)
+  local fe_dirs
+  fe_dirs=$(get_frontend_dirs)
 
-  if [[ -n "$fe_dir" && -f "$fe_dir/package.json" ]]; then
+  while IFS= read -r fe_dir; do
+    [[ -z "$fe_dir" ]] && continue
+    [[ ! -f "$fe_dir/package.json" ]] && continue
     # ESLint fix
     if grep -q '"eslint"' "$fe_dir/package.json" 2>/dev/null; then
       (cd "$fe_dir" && npx eslint --fix . 2>/dev/null) || true
@@ -366,7 +366,7 @@ run_auto_fix() {
     if grep -q '"prettier"' "$fe_dir/package.json" 2>/dev/null; then
       (cd "$fe_dir" && npx prettier --write . 2>/dev/null) || true
     fi
-  fi
+  done <<< "$fe_dirs"
 
   # Prettier fix (root - for non-monorepo)
   if [[ -f "package.json" ]] && grep -q '"prettier"' package.json 2>/dev/null; then
@@ -387,14 +387,18 @@ verify_lint() {
       print_error "failed"
       echo ""
       echo "    Unfixable lint errors:"
-      ruff check . 2>/dev/null | head -20 | sed 's/^/      /'
+      ruff check . 2>/dev/null | head -"$MAX_LINT_ERROR_LINES" | sed 's/^/      /'
       failed=1
     fi
   fi
 
   # Check for monorepo backend directories
-  for api_dir in "apps/api" "backend" "api"; do
-    if [[ -d "$api_dir" ]] && [[ -f "$api_dir/pyproject.toml" || -f "$api_dir/ruff.toml" ]]; then
+  local api_dirs
+  api_dirs=$(get_backend_dirs)
+
+  while IFS= read -r api_dir; do
+    [[ -z "$api_dir" ]] && continue
+    if [[ -f "$api_dir/pyproject.toml" || -f "$api_dir/ruff.toml" ]]; then
       echo -n "    Ruff lint check ($api_dir)... "
       if (cd "$api_dir" && ruff check . --quiet 2>/dev/null); then
         print_success "passed"
@@ -402,11 +406,11 @@ verify_lint() {
         print_error "failed"
         echo ""
         echo "    Unfixable lint errors in $api_dir:"
-        (cd "$api_dir" && ruff check . 2>/dev/null) | head -20 | sed 's/^/      /'
+        (cd "$api_dir" && ruff check . 2>/dev/null) | head -"$MAX_LINT_ERROR_LINES" | sed 's/^/      /'
         failed=1
       fi
     fi
-  done
+  done <<< "$api_dirs"
 
   return $failed
 }
@@ -418,15 +422,16 @@ run_fastapi_response_check() {
   # Skip if check script doesn't exist
   [[ ! -f "$check_script" ]] && return 0
 
-  # Find FastAPI directories
+  # Find FastAPI directories (check root + backend dirs)
   local fastapi_dirs=()
-  for dir in "." "apps/api" "api" "backend" "server"; do
-    if [[ -d "$dir" ]]; then
-      # Check for FastAPI imports
-      if grep -rq "from fastapi" "$dir"/*.py 2>/dev/null || \
-         grep -rq "from fastapi" "$dir"/**/*.py 2>/dev/null; then
-        fastapi_dirs+=("$dir")
-      fi
+  local all_dirs=("." $(get_backend_dirs))
+
+  for dir in "${all_dirs[@]}"; do
+    [[ ! -d "$dir" ]] && continue
+    # Check for FastAPI imports
+    if grep -rq "from fastapi" "$dir"/*.py 2>/dev/null || \
+       grep -rq "from fastapi" "$dir"/**/*.py 2>/dev/null; then
+      fastapi_dirs+=("$dir")
     fi
   done
 
@@ -445,7 +450,7 @@ run_fastapi_response_check() {
     else
       print_error "failed"
       echo ""
-      echo "$output" | head -40 | sed 's/^/      /'
+      echo "$output" | head -"$MAX_ERROR_PREVIEW_LINES" | sed 's/^/      /'
       # Save for failure context so Claude can fix
       echo "$output" > "$log_file"
       failed=1
@@ -493,7 +498,7 @@ run_configured_checks() {
         print_error "failed"
         echo ""
         echo "    Pre-commit hook errors (after auto-fix):"
-        grep -A 20 "Failed\|error\|Error" "$precommit_log" | head -40 | sed 's/^/      /'
+        grep -A 20 "Failed\|error\|Error" "$precommit_log" | head -"$MAX_ERROR_PREVIEW_LINES" | sed 's/^/      /'
         return 1
       fi
     else
@@ -501,7 +506,7 @@ run_configured_checks() {
       print_error "failed"
       echo ""
       echo "    Pre-commit hook errors:"
-      grep -A 20 "Failed\|error\|Error" "$precommit_log" | head -40 | sed 's/^/      /'
+      grep -A 20 "Failed\|error\|Error" "$precommit_log" | head -"$MAX_ERROR_PREVIEW_LINES" | sed 's/^/      /'
       return 1
     fi
   fi