vgxness 1.17.2 → 1.18.0

package/dist/memory/sqlite/migrations/018_skill_system_v2.sql

@@ -0,0 +1,112 @@
+ALTER TABLE skill_versions ADD COLUMN lifecycle_label TEXT;
+ALTER TABLE skill_versions ADD COLUMN draft_parent_version_id TEXT REFERENCES skill_versions(id) ON DELETE SET NULL;
+ALTER TABLE skill_versions ADD COLUMN draft_revision INTEGER;
+ALTER TABLE skill_versions ADD COLUMN governance_json TEXT;
+ALTER TABLE skill_versions ADD COLUMN published_at TEXT;
+ALTER TABLE skill_versions ADD COLUMN published_by TEXT;
+ALTER TABLE skill_versions ADD COLUMN deprecated_at TEXT;
+ALTER TABLE skill_versions ADD COLUMN archived_at TEXT;
+
+ALTER TABLE skill_usage_records ADD COLUMN workflow TEXT;
+ALTER TABLE skill_usage_records ADD COLUMN phase TEXT;
+ALTER TABLE skill_usage_records ADD COLUMN provider_adapter TEXT;
+ALTER TABLE skill_usage_records ADD COLUMN agent_id TEXT;
+ALTER TABLE skill_usage_records ADD COLUMN intent_json TEXT;
+ALTER TABLE skill_usage_records ADD COLUMN evidence_json TEXT;
+
+ALTER TABLE skill_improvement_proposals ADD COLUMN title TEXT;
+ALTER TABLE skill_improvement_proposals ADD COLUMN problem TEXT;
+ALTER TABLE skill_improvement_proposals ADD COLUMN suggested_change TEXT;
+ALTER TABLE skill_improvement_proposals ADD COLUMN source_run_id TEXT;
+ALTER TABLE skill_improvement_proposals ADD COLUMN source_agent_id TEXT;
+ALTER TABLE skill_improvement_proposals ADD COLUMN evidence_json TEXT;
+
+ALTER TABLE skill_evaluation_results ADD COLUMN request_id TEXT REFERENCES skill_evaluation_requests(id) ON DELETE SET NULL;
+ALTER TABLE skill_evaluation_results ADD COLUMN score REAL;
+ALTER TABLE skill_evaluation_results ADD COLUMN passed INTEGER CHECK (passed IN (0, 1));
+ALTER TABLE skill_evaluation_results ADD COLUMN evidence_json TEXT;
+ALTER TABLE skill_evaluation_results ADD COLUMN risk_json TEXT;
+ALTER TABLE skill_evaluation_results ADD COLUMN preflight_json TEXT;
+
+CREATE TABLE IF NOT EXISTS skill_activation_records (
+  id TEXT PRIMARY KEY,
+  project TEXT NOT NULL,
+  scope TEXT NOT NULL CHECK (scope IN ('project', 'personal')),
+  skill_id TEXT NOT NULL REFERENCES skills(id) ON DELETE CASCADE,
+  version_id TEXT REFERENCES skill_versions(id) ON DELETE SET NULL,
+  run_id TEXT,
+  agent_id TEXT,
+  workflow TEXT,
+  phase TEXT,
+  provider_adapter TEXT,
+  intent_json TEXT,
+  reason TEXT,
+  payload_metadata_json TEXT,
+  created_at TEXT NOT NULL
+);
+
+CREATE TABLE IF NOT EXISTS skill_evaluation_requests (
+  id TEXT PRIMARY KEY,
+  project TEXT NOT NULL,
+  scope TEXT NOT NULL CHECK (scope IN ('project', 'personal')),
+  skill_id TEXT NOT NULL REFERENCES skills(id) ON DELETE CASCADE,
+  version_id TEXT REFERENCES skill_versions(id) ON DELETE SET NULL,
+  scenario_id TEXT REFERENCES skill_evaluation_scenarios(id) ON DELETE SET NULL,
+  proposal_id TEXT REFERENCES skill_improvement_proposals(id) ON DELETE SET NULL,
+  status TEXT NOT NULL CHECK (status IN ('requested', 'planned', 'running', 'completed', 'failed', 'cancelled', 'skipped')),
+  requested_by TEXT NOT NULL,
+  run_id TEXT,
+  agent_id TEXT,
+  workflow TEXT,
+  phase TEXT,
+  provider_adapter TEXT,
+  risk_json TEXT,
+  preflight_json TEXT,
+  created_at TEXT NOT NULL,
+  updated_at TEXT NOT NULL
+);
+
+CREATE TABLE IF NOT EXISTS skill_lifecycle_events (
+  id TEXT PRIMARY KEY,
+  project TEXT NOT NULL,
+  scope TEXT NOT NULL CHECK (scope IN ('project', 'personal')),
+  skill_id TEXT NOT NULL REFERENCES skills(id) ON DELETE CASCADE,
+  version_id TEXT REFERENCES skill_versions(id) ON DELETE SET NULL,
+  event_type TEXT NOT NULL,
+  actor_type TEXT,
+  actor_id TEXT,
+  run_id TEXT,
+  agent_id TEXT,
+  reason TEXT,
+  before_json TEXT,
+  after_json TEXT,
+  evidence_json TEXT,
+  created_at TEXT NOT NULL
+);
+
+CREATE INDEX IF NOT EXISTS skill_versions_status_idx
+  ON skill_versions(status, created_at DESC, id ASC);
+
+CREATE INDEX IF NOT EXISTS skill_versions_lifecycle_label_idx
+  ON skill_versions(lifecycle_label, created_at DESC, id ASC);
+
+CREATE INDEX IF NOT EXISTS skill_activation_records_context_idx
+  ON skill_activation_records(project, scope, skill_id, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_activation_records_run_agent_idx
+  ON skill_activation_records(run_id, agent_id, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_usage_records_v2_context_idx
+  ON skill_usage_records(skill_id, version_id, provider_adapter, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_improvement_proposals_v2_context_idx
+  ON skill_improvement_proposals(skill_id, status, source_run_id, source_agent_id, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_evaluation_requests_context_idx
+  ON skill_evaluation_requests(project, scope, skill_id, status, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_evaluation_requests_run_agent_idx
+  ON skill_evaluation_requests(run_id, agent_id, created_at DESC);
+
+CREATE INDEX IF NOT EXISTS skill_lifecycle_events_context_idx
+  ON skill_lifecycle_events(project, scope, skill_id, version_id, created_at DESC);

package/dist/skills/repositories/skill-evaluation-requests.js

@@ -0,0 +1,190 @@
+import { randomUUID } from 'node:crypto';
+export class SkillEvaluationRequestRepository {
+    db;
+    constructor(db) {
+        this.db = db;
+    }
+    create(input) {
+        const validation = validateCreateInput(input);
+        if (!validation.ok)
+            return validation;
+        const result = this.db.transaction(() => {
+            assertSkillInScope(this.db, input.skillId, input.project, input.scope);
+            if (input.versionId !== undefined)
+                assertVersionBelongsToSkill(this.db, input.versionId, input.skillId);
+            if (input.scenarioId !== undefined)
+                assertScenarioBelongsToSkill(this.db, input.scenarioId, input.skillId);
+            if (input.proposalId !== undefined)
+                assertProposalBelongsToSkill(this.db, input.proposalId, input.skillId);
+            const now = new Date().toISOString();
+            const id = randomUUID();
+            this.db.connection
+                .prepare(`
+          INSERT INTO skill_evaluation_requests(
+            id, project, scope, skill_id, version_id, scenario_id, proposal_id,
+            status, requested_by, run_id, agent_id, workflow, phase, provider_adapter,
+            risk_json, preflight_json, created_at, updated_at
+          ) VALUES (
+            @id, @project, @scope, @skillId, @versionId, @scenarioId, @proposalId,
+            'requested', @requestedBy, @runId, @agentId, @workflow, @phase, @providerAdapter,
+            @riskJson, @preflightJson, @createdAt, @updatedAt
+          )
+        `)
+                .run({
+                id,
+                project: input.project,
+                scope: input.scope,
+                skillId: input.skillId,
+                versionId: input.versionId ?? null,
+                scenarioId: input.scenarioId ?? null,
+                proposalId: input.proposalId ?? null,
+                requestedBy: input.requestedBy.trim(),
+                runId: input.runId ?? null,
+                agentId: input.agentId ?? null,
+                workflow: input.workflow ?? null,
+                phase: input.phase ?? null,
+                providerAdapter: input.providerAdapter ?? null,
+                riskJson: input.risk === undefined ? null : JSON.stringify(input.risk),
+                preflightJson: input.preflight === undefined ? null : JSON.stringify(input.preflight),
+                createdAt: now,
+                updatedAt: now,
+            });
+            const read = this.getById(id);
+            if (!read.ok)
+                throw new Error(read.error.message);
+            return read.value;
+        });
+        if (!result.ok && result.error.cause instanceof SkillEvaluationRequestValidationError)
+            return validationFailure(result.error.cause.message);
+        return result;
+    }
+    list(filters) {
+        try {
+            const where = ['project=@project', 'scope=@scope'];
+            const parameters = { project: filters.project, scope: filters.scope, limit: filters.limit ?? 25 };
+            addOptionalFilter(where, parameters, 'skill_id', 'skillId', filters.skillId);
+            addOptionalFilter(where, parameters, 'version_id', 'versionId', filters.versionId);
+            addOptionalFilter(where, parameters, 'scenario_id', 'scenarioId', filters.scenarioId);
+            addOptionalFilter(where, parameters, 'proposal_id', 'proposalId', filters.proposalId);
+            addOptionalFilter(where, parameters, 'status', 'status', filters.status);
+            addOptionalFilter(where, parameters, 'run_id', 'runId', filters.runId);
+            addOptionalFilter(where, parameters, 'agent_id', 'agentId', filters.agentId);
+            const rows = this.db.connection
+                .prepare(`
+          SELECT * FROM skill_evaluation_requests
+          WHERE ${where.join(' AND ')}
+          ORDER BY created_at DESC, rowid DESC
+          LIMIT @limit
+        `)
+                .all(parameters);
+            return ok(rows.map(mapRequest));
+        }
+        catch (cause) {
+            return fail('Failed to list skill evaluation requests', cause);
+        }
+    }
+    getById(id) {
+        try {
+            const row = this.db.connection.prepare('SELECT * FROM skill_evaluation_requests WHERE id=?').get(id);
+            return row ? ok(mapRequest(row)) : missing(`Skill evaluation request not found: ${id}`);
+        }
+        catch (cause) {
+            return fail('Failed to read skill evaluation request', cause);
+        }
+    }
+}
+function validateCreateInput(input) {
+    if (!input.project.trim())
+        return validationFailure('Project is required');
+    if (input.scope !== 'project' && input.scope !== 'personal')
+        return validationFailure('Scope must be project or personal');
+    if (!input.skillId.trim())
+        return validationFailure('Skill id is required');
+    if (!input.requestedBy.trim())
+        return validationFailure('Skill evaluation requester is required');
+    return ok(undefined);
+}
+function addOptionalFilter(where, parameters, column, key, value) {
+    if (value === undefined)
+        return;
+    where.push(`${column}=@${key}`);
+    parameters[key] = value;
+}
+function assertSkillInScope(db, skillId, project, scope) {
+    const row = db.connection.prepare('SELECT project, scope FROM skills WHERE id=?').get(skillId);
+    if (row === undefined)
+        throw new SkillEvaluationRequestValidationError(`Skill not found: ${skillId}`);
+    if (row.project !== project || row.scope !== scope)
+        throw new SkillEvaluationRequestValidationError('Skill does not belong to the requested project/scope');
+}
+function assertVersionBelongsToSkill(db, versionId, skillId) {
+    const row = db.connection.prepare('SELECT skill_id FROM skill_versions WHERE id=?').get(versionId);
+    if (row === undefined)
+        throw new SkillEvaluationRequestValidationError(`Skill version not found: ${versionId}`);
+    if (row.skill_id !== skillId)
+        throw new SkillEvaluationRequestValidationError('Skill version must belong to the evaluated skill');
+}
+function assertScenarioBelongsToSkill(db, scenarioId, skillId) {
+    const row = db.connection.prepare('SELECT skill_id FROM skill_evaluation_scenarios WHERE id=?').get(scenarioId);
+    if (row === undefined)
+        throw new SkillEvaluationRequestValidationError(`Skill evaluation scenario not found: ${scenarioId}`);
+    if (row.skill_id !== skillId)
+        throw new SkillEvaluationRequestValidationError('Skill evaluation scenario must belong to the evaluated skill');
+}
+function assertProposalBelongsToSkill(db, proposalId, skillId) {
+    const row = db.connection.prepare('SELECT skill_id FROM skill_improvement_proposals WHERE id=?').get(proposalId);
+    if (row === undefined)
+        throw new SkillEvaluationRequestValidationError(`Skill improvement proposal not found: ${proposalId}`);
+    if (row.skill_id !== skillId)
+        throw new SkillEvaluationRequestValidationError('Skill improvement proposal must belong to the evaluated skill');
+}
+function mapRequest(row) {
+    const request = {
+        id: row.id,
+        project: row.project,
+        scope: row.scope,
+        skillId: row.skill_id,
+        status: row.status,
+        requestedBy: row.requested_by,
+        createdAt: row.created_at,
+        updatedAt: row.updated_at,
+    };
+    if (row.version_id !== null)
+        request.versionId = row.version_id;
+    if (row.scenario_id !== null)
+        request.scenarioId = row.scenario_id;
+    if (row.proposal_id !== null)
+        request.proposalId = row.proposal_id;
+    if (row.run_id !== null)
+        request.runId = row.run_id;
+    if (row.agent_id !== null)
+        request.agentId = row.agent_id;
+    if (row.workflow !== null)
+        request.workflow = row.workflow;
+    if (row.phase !== null)
+        request.phase = row.phase;
+    if (row.provider_adapter !== null)
+        request.providerAdapter = row.provider_adapter;
+    if (row.risk_json !== null)
+        request.risk = JSON.parse(row.risk_json);
+    if (row.preflight_json !== null)
+        request.preflight = JSON.parse(row.preflight_json);
+    return request;
+}
+function ok(value) {
+    return { ok: true, value };
+}
+function missing(message) {
+    return { ok: false, error: { code: 'not_found', message } };
+}
+function validationFailure(message) {
+    return { ok: false, error: { code: 'validation_failed', message } };
+}
+function fail(message, cause) {
+    const error = { code: 'validation_failed', message };
+    if (cause !== undefined)
+        error.cause = cause;
+    return { ok: false, error };
+}
+class SkillEvaluationRequestValidationError extends Error {
+}

package/dist/skills/repositories/skill-improvement-proposals.js

@@ -22,11 +22,13 @@ export class SkillImprovementProposalRepository {
           id, skill_id, base_version_id, proposed_version,
           proposed_source_kind, proposed_source_path, proposed_source_url, proposed_source_inline_metadata_json,
           proposed_compatibility_json, rationale, source_signal_json, diff_summary_json,
+          title, problem, suggested_change, source_run_id, source_agent_id, evidence_json,
           status, created_at, updated_at
         ) VALUES (
           @id, @skillId, @baseVersionId, @proposedVersion,
           @sourceKind, @sourcePath, @sourceUrl, @sourceInlineMetadataJson,
           @compatibilityJson, @rationale, @sourceSignalJson, @diffSummaryJson,
+          @title, @problem, @suggestedChange, @sourceRunId, @sourceAgentId, @evidenceJson,
           'draft', @createdAt, @updatedAt
         )
       `)
@@ -43,6 +45,12 @@ export class SkillImprovementProposalRepository {
                 rationale: input.rationale,
                 sourceSignalJson: JSON.stringify(input.sourceSignal ?? {}),
                 diffSummaryJson: JSON.stringify(diffSummary),
+                title: input.title ?? null,
+                problem: input.problem ?? null,
+                suggestedChange: input.suggestedChange ?? null,
+                sourceRunId: input.sourceRunId ?? null,
+                sourceAgentId: input.sourceAgentId ?? null,
+                evidenceJson: input.evidence === undefined ? null : JSON.stringify(input.evidence),
                 createdAt: now,
                 updatedAt: now,
             });
@@ -59,19 +67,44 @@ export class SkillImprovementProposalRepository {
         try {
             const where = [];
             const parameters = {};
+            if (filters.project !== undefined) {
+                where.push('s.project=@project');
+                parameters.project = filters.project;
+            }
+            if (filters.scope !== undefined) {
+                where.push('s.scope=@scope');
+                parameters.scope = filters.scope;
+            }
             if (filters.skillId !== undefined) {
-                where.push('skill_id=@skillId');
+                where.push('p.skill_id=@skillId');
                 parameters.skillId = filters.skillId;
             }
+            if (filters.baseVersionId !== undefined) {
+                where.push('p.base_version_id=@baseVersionId');
+                parameters.baseVersionId = filters.baseVersionId;
+            }
             if (filters.status !== undefined) {
-                where.push('status=@status');
+                where.push('p.status=@status');
                 parameters.status = filters.status;
             }
+            if (filters.runId !== undefined) {
+                where.push('p.source_run_id=@runId');
+                parameters.runId = filters.runId;
+            }
+            if (filters.agentId !== undefined) {
+                where.push('p.source_agent_id=@agentId');
+                parameters.agentId = filters.agentId;
+            }
+            const limitClause = filters.limit === undefined ? '' : 'LIMIT @limit';
+            if (filters.limit !== undefined)
+                parameters.limit = filters.limit;
             const rows = this.db.connection
                 .prepare(`
-        SELECT * FROM skill_improvement_proposals
+        SELECT p.* FROM skill_improvement_proposals p
+        JOIN skills s ON s.id = p.skill_id
         ${where.length ? `WHERE ${where.join(' AND ')}` : ''}
-        ORDER BY created_at DESC, id ASC
+        ORDER BY p.created_at DESC, p.id ASC
+        ${limitClause}
       `)
                 .all(parameters);
             return ok(rows.map(mapProposal));
@@ -211,6 +244,12 @@ function validateCreate(input) {
         return validationFailure('Proposed version is required');
     if (!input.rationale.trim())
         return validationFailure('Proposal rationale is required');
+    if (input.title !== undefined && !input.title.trim())
+        return validationFailure('Proposal title must not be empty');
+    if (input.problem !== undefined && !input.problem.trim())
+        return validationFailure('Proposal problem must not be empty');
+    if (input.suggestedChange !== undefined && !input.suggestedChange.trim())
+        return validationFailure('Proposal suggested change must not be empty');
     if (input.proposedSource.kind === 'path' && !input.proposedSource.path?.trim())
         return validationFailure('Path proposal sources require proposedSource.path');
     if (input.proposedSource.kind === 'url' && !input.proposedSource.url?.trim())
@@ -265,6 +304,18 @@ function mapProposal(row) {
         createdAt: row.created_at,
         updatedAt: row.updated_at,
     };
+    if (row.title !== null && row.title !== undefined)
+        proposal.title = row.title;
+    if (row.problem !== null && row.problem !== undefined)
+        proposal.problem = row.problem;
+    if (row.suggested_change !== null && row.suggested_change !== undefined)
+        proposal.suggestedChange = row.suggested_change;
+    if (row.source_run_id !== null && row.source_run_id !== undefined)
+        proposal.sourceRunId = row.source_run_id;
+    if (row.source_agent_id !== null && row.source_agent_id !== undefined)
+        proposal.sourceAgentId = row.source_agent_id;
+    if (row.evidence_json !== null && row.evidence_json !== undefined)
+        proposal.evidence = JSON.parse(row.evidence_json);
     if (row.submitted_at !== null)
         proposal.submittedAt = row.submitted_at;
     if (row.submitted_by !== null)