vest 5.4.5 → 5.4.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1258,6 +1258,7 @@ function useWithinActiveOmitWhen() {
1258
1258
  return useOmitted();
1259
1259
  }
1260
1260
 
1261
+ // eslint-disable-next-line complexity
1261
1262
  function useVerifyTestRun(testObject, collisionResult = testObject) {
1262
1263
  const testData = VestTest.getData(testObject);
1263
1264
  if (useShouldSkipBasedOnMode(testData)) {
@@ -1685,7 +1686,19 @@ function useRunDoneCallbacks() {
1685
1686
  function useInitVestBus() {
1686
1687
  const VestBus = Bus.useBus();
1687
1688
  on('TEST_COMPLETED', () => { });
1688
- // on("TEST_RUN_STARTED", () => {});
1689
+ on('TEST_RUN_STARTED', () => {
1690
+ // Bringin this back due to https://github.com/ealush/vest/issues/1157
1691
+ // This is a very pecluiar bug in which we're seeing vest behaving differently between
1692
+ // runs when suite.get() is called.
1693
+ // In the bug we experienced that failing tests were skipped in the second run.
1694
+ // The reason: suite.get() built the failures cache. Calling suite.get() before the test run
1695
+ // made Vest think that the field already had failing tests (even though it was the same test!)
1696
+ // and it skipped the test.
1697
+ // A better solution is to be able to identify each failure to its actual position in the suite
1698
+ // but this requires some rearchitecting within Vest.
1699
+ // This is an easy enough solution - we just reset the cache before the test run, let's hope we don't see
1700
+ // any performance issues.
1701
+ });
1689
1702
  VestBus.on(RuntimeEvents.ISOLATE_PENDING, (isolate) => {
1690
1703
  if (VestTest.is(isolate)) {
1691
1704
  VestTest.setPending(isolate);