veryfront 0.1.403 → 0.1.404

package/src/src/server/bootstrap.ts

@@ -33,6 +33,12 @@ import {
   markEnvLoaded,
   supportsEnvFiles,
 } from "../utils/env-loader.js";
+import { getLogBuffer } from "../observability/log-buffer.js";
+import {
+  createFileLogSubscriber,
+  type FileLogConfig,
+  type FileLogSubscriber,
+} from "../observability/file-log-subscriber.js";
 import { ReloadNotifier } from "./reload-notifier.js";
 import { clearDomainCache } from "./utils/domain-lookup.js";
 
@@ -119,15 +125,60 @@ function wireTracingShim(): void {
   }
 }
 
+const DEFAULT_FILE_LOG_PATH = ".veryfront/logs/server.log";
+const DEFAULT_FILE_LOG_MAX_SIZE = "10mb";
+const DEFAULT_FILE_LOG_MAX_FILES = 5;
+const DEFAULT_FILE_LOG_LEVEL = "warn" as const;
+const DEFAULT_FILE_LOG_FORMAT = "json" as const;
+
+interface FileLogHandle {
+  subscriber: FileLogSubscriber;
+  unsubscribe: () => void;
+}
+
+function maybeAttachFileLogSubscriber(config: VeryfrontConfig): FileLogHandle | null {
+  const fileConfig = config.observability?.logging?.file;
+  if (!fileConfig?.enabled) return null;
+
+  const resolved: FileLogConfig = {
+    enabled: true,
+    path: fileConfig.path ?? DEFAULT_FILE_LOG_PATH,
+    maxSize: fileConfig.maxSize ?? DEFAULT_FILE_LOG_MAX_SIZE,
+    maxFiles: fileConfig.maxFiles ?? DEFAULT_FILE_LOG_MAX_FILES,
+    level: fileConfig.level ?? DEFAULT_FILE_LOG_LEVEL,
+    format: fileConfig.format ?? DEFAULT_FILE_LOG_FORMAT,
+  };
+
+  const subscriber = createFileLogSubscriber(resolved);
+  const unsubscribe = getLogBuffer().subscribe(subscriber.getSubscriber());
+  bootstrapLog.debug("[bootstrap] File log subscriber attached", {
+    path: resolved.path,
+    level: resolved.level,
+    format: resolved.format,
+  });
+  return { subscriber, unsubscribe };
+}
+
+async function teardownFileLog(handle: FileLogHandle | null): Promise<void> {
+  if (!handle) return;
+  handle.unsubscribe();
+  await handle.subscriber.close();
+}
+
 function combineDispose(
   extensionLoader: ExtensionLoader,
   fsDispose?: () => void,
+  fileLogHandle?: FileLogHandle | null,
 ): () => Promise<void> {
   return async () => {
     try {
       await extensionLoader.teardownAll();
     } finally {
-      if (fsDispose) fsDispose();
+      try {
+        await teardownFileLog(fileLogHandle ?? null);
+      } finally {
+        if (fsDispose) fsDispose();
+      }
     }
   };
 }
@@ -218,141 +269,155 @@ export async function bootstrap(
   bootstrapLog.debug("Loading config with base adapter");
   let config = await getConfig(projectDir, adapter);
 
-  const fsType = config.fs?.type;
-  const needsFSAdapter = fsType != null && fsType !== "local";
+  let fileLog = maybeAttachFileLogSubscriber(config);
 
-  if (!needsFSAdapter) {
-    bootstrapLog.debug("Using local filesystem (no FSAdapter needed)");
-    const extensionLoader = await orchestrateExtensions({
-      projectDir,
-      config,
-      logger: bootstrapLog,
-      primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
-      builtinExtensions: createBuiltinExtensions(),
-    });
-    wireTracingShim();
-    assertRequiredContracts();
-    return {
-      adapter,
-      config,
-      usingFSAdapter: false,
-      extensionLoader,
-      dispose: combineDispose(extensionLoader),
+  try {
+    const fsType = config.fs?.type;
+    const needsFSAdapter = fsType != null && fsType !== "local";
+
+    if (!needsFSAdapter) {
+      bootstrapLog.debug("Using local filesystem (no FSAdapter needed)");
+      const extensionLoader = await orchestrateExtensions({
+        projectDir,
+        config,
+        logger: bootstrapLog,
+        primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
+        builtinExtensions: createBuiltinExtensions(),
+      });
+      wireTracingShim();
+      assertRequiredContracts();
+      return {
+        adapter,
+        config,
+        usingFSAdapter: false,
+        extensionLoader,
+        dispose: combineDispose(extensionLoader, undefined, fileLog),
+      };
+    }
+
+    bootstrapLog.debug("Initializing FSAdapter", { type: fsType });
+
+    // Inject server-layer callbacks into FS config so the platform layer
+    // doesn't need to import from the server layer
+    const fsWithCallbacks = {
+      ...config.fs,
+      invalidationCallbacks: {
+        triggerReload: (changedPaths?: string[], project?: InvalidationProjectContext) =>
+          ReloadNotifier.triggerReload(changedPaths, project),
+        clearDomainCache,
+      },
     };
-  }
 
-  bootstrapLog.debug("Initializing FSAdapter", { type: fsType });
-
-  // Inject server-layer callbacks into FS config so the platform layer
-  // doesn't need to import from the server layer
-  const fsWithCallbacks = {
-    ...config.fs,
-    invalidationCallbacks: {
-      triggerReload: (changedPaths?: string[], project?: InvalidationProjectContext) =>
-        ReloadNotifier.triggerReload(changedPaths, project),
-      clearDomainCache,
-    },
-  };
+    const enhancedAdapter = await enhanceAdapterWithFS(
+      adapter,
+      { ...config, fs: fsWithCallbacks },
+      projectDir,
+    );
 
-  const enhancedAdapter = await enhanceAdapterWithFS(
-    adapter,
-    { ...config, fs: fsWithCallbacks },
-    projectDir,
-  );
+    if (enhancedAdapter === adapter) {
+      bootstrapLog.debug("Framework initialized successfully", {
+        projectDir,
+        runtime: adapter.id,
+        fsAdapter: "local",
+      });
+
+      const extensionLoader = await orchestrateExtensions({
+        projectDir,
+        config,
+        logger: bootstrapLog,
+        primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
+        builtinExtensions: createBuiltinExtensions(),
+      });
+      wireTracingShim();
+      assertRequiredContracts();
+      return {
+        adapter,
+        config,
+        usingFSAdapter: false,
+        extensionLoader,
+        dispose: combineDispose(extensionLoader, undefined, fileLog),
+      };
+    }
+
+    const isProxyMode = config.fs?.veryfront?.proxyMode === true;
+    const isProductionMode = config.fs?.veryfront?.productionMode === true;
+
+    if (isProxyMode) {
+      bootstrapLog.debug("Skipping config reload in proxy mode (using local config)");
+    } else if (isProductionMode) {
+      bootstrapLog.debug("Skipping config reload in production mode (using local config)");
+    } else {
+      bootstrapLog.debug("Reloading config with FSAdapter");
+      clearConfigCache();
+
+      const originalConfig = config;
+      const reloadedConfig = await getConfig(projectDir, enhancedAdapter);
+
+      const usesDefaultDevConfig = reloadedConfig.dev?.port === 3000 &&
+        reloadedConfig.dev?.host === "localhost" &&
+        !reloadedConfig.dev?.hmr;
+
+      if (usesDefaultDevConfig && originalConfig.dev) {
+        bootstrapLog.debug("Keeping original config (FSAdapter returned defaults)");
+        config = originalConfig;
+      } else {
+        config = reloadedConfig;
+      }
+
+      // Re-attach file log subscriber if config was reloaded with different settings
+      const newFileLog = maybeAttachFileLogSubscriber(config);
+      if (newFileLog) {
+        await teardownFileLog(fileLog);
+        fileLog = newFileLog;
+      }
+    }
 
-  if (enhancedAdapter === adapter) {
     bootstrapLog.debug("Framework initialized successfully", {
       projectDir,
       runtime: adapter.id,
-      fsAdapter: "local",
+      fsAdapter: fsType,
     });
 
-    const extensionLoader = await orchestrateExtensions({
-      projectDir,
-      config,
-      logger: bootstrapLog,
-      primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
-      builtinExtensions: createBuiltinExtensions(),
-    });
+    let fsDispose: (() => void) | undefined;
+    if (isExtendedFSAdapter(enhancedAdapter.fs)) {
+      const underlying = enhancedAdapter.fs.getUnderlyingAdapter();
+      if (
+        "dispose" in underlying &&
+        typeof (underlying as { dispose?: () => void }).dispose === "function"
+      ) {
+        fsDispose = () => (underlying as { dispose: () => void }).dispose();
+      }
+    }
+
+    // If extension orchestration fails after the FS adapter has been wired up,
+    // release the FS resources (WebSocket connections, caches) before
+    // propagating the error — otherwise the adapter would leak.
+    const extensionLoader = await orchestrateOrDisposeFS(
+      () =>
+        orchestrateExtensions({
+          projectDir,
+          config,
+          logger: bootstrapLog,
+          primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
+          builtinExtensions: createBuiltinExtensions(),
+        }),
+      fsDispose,
+    );
     wireTracingShim();
     assertRequiredContracts();
+
     return {
-      adapter,
+      adapter: enhancedAdapter,
       config,
-      usingFSAdapter: false,
+      usingFSAdapter: true,
+      fsAdapterType: fsType,
       extensionLoader,
-      dispose: combineDispose(extensionLoader),
+      dispose: combineDispose(extensionLoader, fsDispose, fileLog),
     };
+  } catch (err) {
+    await teardownFileLog(fileLog);
+    throw err;
   }
-
-  const isProxyMode = config.fs?.veryfront?.proxyMode === true;
-  const isProductionMode = config.fs?.veryfront?.productionMode === true;
-
-  if (isProxyMode) {
-    bootstrapLog.debug("Skipping config reload in proxy mode (using local config)");
-  } else if (isProductionMode) {
-    bootstrapLog.debug("Skipping config reload in production mode (using local config)");
-  } else {
-    bootstrapLog.debug("Reloading config with FSAdapter");
-    clearConfigCache();
-
-    const originalConfig = config;
-    const reloadedConfig = await getConfig(projectDir, enhancedAdapter);
-
-    const usesDefaultDevConfig = reloadedConfig.dev?.port === 3000 &&
-      reloadedConfig.dev?.host === "localhost" &&
-      !reloadedConfig.dev?.hmr;
-
-    if (usesDefaultDevConfig && originalConfig.dev) {
-      bootstrapLog.debug("Keeping original config (FSAdapter returned defaults)");
-      config = originalConfig;
-    } else {
-      config = reloadedConfig;
-    }
-  }
-
-  bootstrapLog.debug("Framework initialized successfully", {
-    projectDir,
-    runtime: adapter.id,
-    fsAdapter: fsType,
-  });
-
-  let fsDispose: (() => void) | undefined;
-  if (isExtendedFSAdapter(enhancedAdapter.fs)) {
-    const underlying = enhancedAdapter.fs.getUnderlyingAdapter();
-    if (
-      "dispose" in underlying &&
-      typeof (underlying as { dispose?: () => void }).dispose === "function"
-    ) {
-      fsDispose = () => (underlying as { dispose: () => void }).dispose();
-    }
-  }
-
-  // If extension orchestration fails after the FS adapter has been wired up,
-  // release the FS resources (WebSocket connections, caches) before
-  // propagating the error — otherwise the adapter would leak.
-  const extensionLoader = await orchestrateOrDisposeFS(
-    () =>
-      orchestrateExtensions({
-        projectDir,
-        config,
-        logger: bootstrapLog,
-        primeContracts: { [AIProviderRegistryName]: createAIProviderRegistry() },
-        builtinExtensions: createBuiltinExtensions(),
-      }),
-    fsDispose,
-  );
-  wireTracingShim();
-  assertRequiredContracts();
-
-  return {
-    adapter: enhancedAdapter,
-    config,
-    usingFSAdapter: true,
-    fsAdapterType: fsType,
-    extensionLoader,
-    dispose: combineDispose(extensionLoader, fsDispose),
-  };
 }
 
 export async function bootstrapDev(

package/src/src/utils/version-constant.ts

@@ -1,3 +1,3 @@
 // Keep in sync with deno.json version.
 // scripts/release.ts updates this constant during releases.
-export const VERSION = "0.1.403";
+export const VERSION = "0.1.404";