veryfront 0.1.112 → 0.1.113

package/src/src/transforms/mdx/esm-module-loader/module-fetcher/framework-validator.ts

@@ -8,6 +8,12 @@
  */
 
 import type { Logger } from "../../../../utils/logger/logger.js";
+import {
+  extractAllFilePaths,
+  extractAllFilePathsRecursive,
+  extractAllHttpBundlePathsRecursive,
+  visitImportedVfModules,
+} from "../../../../modules/react-loader/ssr-module-loader/http-bundle-helpers.js";
 import {
   getCacheBaseDir,
   getHttpBundleCacheDir,
@@ -15,7 +21,6 @@ import {
 } from "../../../../utils/cache-dir.js";
 import { FRAMEWORK_ROOT, LOG_PREFIX_MDX_LOADER } from "../constants.js";
 import { getLocalFs } from "../cache/index.js";
-import { extractHttpBundlePaths } from "../../../../modules/react-loader/ssr-module-loader/http-bundle-helpers.js";
 import { ensureHttpBundlesExist } from "../../../esm/http-cache.js";
 import { ensureMdxModuleDependencies } from "./dependency-recovery.js";
 
@@ -24,48 +29,38 @@ interface MdxRecoveryOptions {
   contentSourceId: string;
 }
 
-/**
- * Check if cached code has file:// paths that are incompatible with this environment.
- * Returns true if the cached code should be invalidated (has paths from a different environment).
- *
- * Checks for:
- * 1. Framework source paths (file:///app/src/...) that don't match FRAMEWORK_ROOT
- * 2. HTTP bundle cache paths (file:///app/.cache/veryfront-http-bundle/...) that don't match local cache dir
- * 3. MDX ESM cache paths (file:///app/.cache/veryfront-mdx-esm/...) that don't match local cache dir
- *
- * IMPORTANT: This function creates a new RegExp on each call to avoid race conditions
- * when multiple modules are processed concurrently. Using a shared global regex with
- * the 'g' flag would cause interleaved exec() calls to skip paths.
- */
-export async function hasIncompatibleFrameworkPaths(code: string, log: Logger): Promise<boolean> {
-  // Check for esm.sh URLs that reference /_vf_modules/ paths - these are invalid
-  // and indicate a cached transform from before the fix was deployed
-  if (/esm\.sh\/_?vf_modules\//.test(code)) {
-    log.debug(`${LOG_PREFIX_MDX_LOADER} Cached code has invalid esm.sh/_vf_modules URL`);
-    return true;
-  }
+const INVALID_VFMOD_ESM_URL_PATTERN = /esm\.sh\/_?vf_modules\//;
 
-  const localHttpCacheDir = getHttpBundleCacheDir();
-  const localMdxCacheDir = getMdxEsmCacheDir();
-  const localCacheBaseDir = getCacheBaseDir();
+async function hasIncompatibleFrameworkPathsInCode(
+  code: string,
+  log: Logger,
+  options: {
+    localHttpCacheDir: string;
+    localMdxCacheDir: string;
+    localCacheBaseDir: string;
+    sourcePath?: string;
+  },
+): Promise<boolean> {
   const localFs = getLocalFs();
+  const sourceContext = options.sourcePath ? { vfModulePath: options.sourcePath } : {};
 
-  // Create a NEW regex for each call to avoid race conditions with concurrent calls.
-  // Global regexes maintain lastIndex state that can interleave between concurrent calls.
-  const allFilePathsPattern = /file:\/\/([^"'\s]+)/gi;
-
-  const allPaths: string[] = [];
-  let match: RegExpExecArray | null;
-  while ((match = allFilePathsPattern.exec(code)) !== null) {
-    if (match[1]) allPaths.push(match[1]);
+  if (INVALID_VFMOD_ESM_URL_PATTERN.test(code)) {
+    log.debug(
+      `${LOG_PREFIX_MDX_LOADER} Cached code has invalid esm.sh/_vf_modules URL`,
+      sourceContext,
+    );
+    return true;
   }
 
+  const allPaths = extractAllFilePaths(code);
+
   for (const path of allPaths) {
     if (path.includes("veryfront-http-bundle")) {
-      if (!path.startsWith(localHttpCacheDir)) {
+      if (!path.startsWith(options.localHttpCacheDir)) {
         log.debug(`${LOG_PREFIX_MDX_LOADER} HTTP bundle path from different environment`, {
           path,
-          expectedDir: localHttpCacheDir,
+          expectedDir: options.localHttpCacheDir,
+          ...sourceContext,
         });
         return true;
       }
@@ -73,10 +68,11 @@ export async function hasIncompatibleFrameworkPaths(code: string, log: Logger):
     }
 
     if (path.includes("veryfront-mdx-esm")) {
-      if (!path.startsWith(localMdxCacheDir)) {
+      if (!path.startsWith(options.localMdxCacheDir)) {
         log.debug(`${LOG_PREFIX_MDX_LOADER} MDX cache path from different environment`, {
           path,
-          expectedDir: localMdxCacheDir,
+          expectedDir: options.localMdxCacheDir,
+          ...sourceContext,
         });
         return true;
       }
@@ -87,10 +83,11 @@ export async function hasIncompatibleFrameworkPaths(code: string, log: Logger):
     // like file:///app/.cache/markdown.tsx. These paths are not portable across pods.
     // Allow local cache-base paths so valid local file:// dependencies under .cache
     // are not evicted on every read.
-    if (path.includes(".cache/") && !path.startsWith(localCacheBaseDir)) {
+    if (path.includes(".cache/") && !path.startsWith(options.localCacheBaseDir)) {
       log.debug(`${LOG_PREFIX_MDX_LOADER} Legacy cache path is not portable`, {
         path,
-        expectedBaseDir: localCacheBaseDir,
+        expectedBaseDir: options.localCacheBaseDir,
+        ...sourceContext,
       });
       return true;
     }
@@ -101,6 +98,7 @@ export async function hasIncompatibleFrameworkPaths(code: string, log: Logger):
       log.debug(`${LOG_PREFIX_MDX_LOADER} Framework path from different environment`, {
         path,
         expectedRoot: FRAMEWORK_ROOT,
+        ...sourceContext,
       });
       return true;
     }
@@ -108,12 +106,18 @@ export async function hasIncompatibleFrameworkPaths(code: string, log: Logger):
     try {
       const stat = await localFs.stat(path);
       if (!stat?.isFile) {
-        log.debug(`${LOG_PREFIX_MDX_LOADER} Framework path does not exist`, { path });
+        log.debug(`${LOG_PREFIX_MDX_LOADER} Framework path does not exist`, {
+          path,
+          ...sourceContext,
+        });
         return true;
       }
     } catch (_) {
       /* expected: framework file may not exist in this environment */
-      log.debug(`${LOG_PREFIX_MDX_LOADER} Framework path not accessible`, { path });
+      log.debug(`${LOG_PREFIX_MDX_LOADER} Framework path not accessible`, {
+        path,
+        ...sourceContext,
+      });
       return true;
     }
   }
@@ -121,6 +125,42 @@ export async function hasIncompatibleFrameworkPaths(code: string, log: Logger):
   return false;
 }
 
+/**
+ * Check if cached code has file:// paths that are incompatible with this environment.
+ * Returns true if the cached code should be invalidated (has paths from a different environment).
+ *
+ * Checks for:
+ * 1. Framework source paths (file:///app/src/...) that don't match FRAMEWORK_ROOT
+ * 2. HTTP bundle cache paths (file:///app/.cache/veryfront-http-bundle/...) that don't match local cache dir
+ * 3. MDX ESM cache paths (file:///app/.cache/veryfront-mdx-esm/...) that don't match local cache dir
+ *
+ * This check also walks transitively imported VF modules so nested stale paths
+ * are rejected before import-time failures.
+ */
+export async function hasIncompatibleFrameworkPaths(code: string, log: Logger): Promise<boolean> {
+  const options = {
+    localHttpCacheDir: getHttpBundleCacheDir(),
+    localMdxCacheDir: getMdxEsmCacheDir(),
+    localCacheBaseDir: getCacheBaseDir(),
+  };
+
+  if (await hasIncompatibleFrameworkPathsInCode(code, log, options)) {
+    return true;
+  }
+
+  let incompatible = false;
+  await visitImportedVfModules(code, async (vfModuleCode, vfModulePath) => {
+    if (incompatible) return;
+
+    incompatible = await hasIncompatibleFrameworkPathsInCode(vfModuleCode, log, {
+      ...options,
+      sourcePath: vfModulePath,
+    });
+  });
+
+  return incompatible;
+}
+
 /**
  * Check if cached code has file:// paths that don't exist locally.
  * Returns list of missing paths, or empty array if all exist.
@@ -133,19 +173,10 @@ export async function findMissingFileDependenciesInCode(
   log: Logger,
 ): Promise<string[]> {
   const localFs = getLocalFs();
-  const pattern = /file:\/\/([^"'\s]+\.(?:mjs|js|tsx|ts|jsx)(?:\?[^"'\s]*)?)/gi;
   const missing: string[] = [];
-  const checked = new Set<string>();
-
-  let match;
-  while ((match = pattern.exec(code)) !== null) {
-    const path = match[1] as string;
-    // Skip query parameters in paths
-    const cleanPath = path.replace(/\?.*$/, "");
-
-    if (checked.has(cleanPath)) continue;
-    checked.add(cleanPath);
+  const allPaths = await extractAllFilePathsRecursive(code);
 
+  for (const cleanPath of allPaths) {
     try {
       const stat = await localFs.stat(cleanPath);
       if (!stat?.isFile) {
@@ -200,7 +231,7 @@ export async function validateCachedModule(
     return false;
   }
 
-  const bundlePaths = extractHttpBundlePaths(cachedCode);
+  const bundlePaths = await extractAllHttpBundlePathsRecursive(cachedCode);
   if (bundlePaths.length > 0) {
     const cacheDir = getHttpBundleCacheDir();
     const failed = await ensureHttpBundlesExist(bundlePaths, cacheDir);

package/src/src/utils/version.ts

@@ -3,7 +3,7 @@ import { getEnv } from "../platform/compat/process.js";
 
 // Keep in sync with deno.json version.
 // scripts/release.ts updates this constant during releases.
-export const VERSION = "0.1.112";
+export const VERSION = "0.1.113";
 
 export function normalizeVeryfrontVersion(version: string | undefined): string | undefined {
   if (!version) return undefined;