verbalcoding 0.2.8 → 0.2.9

package/app-node/cli_install.test.mjs

@@ -82,9 +82,26 @@ test('doctor auto-bootstraps fixable prerequisites by default', () => {
   assert.match(doctor, /--no-fix/);
   assert.match(doctor, /WHISPER_CPP_BIN/);
   assert.match(doctor, /EDGE_TTS_COMMAND/);
+  assert.match(doctor, /installHermesCliIfNeeded/);
+  assert.match(doctor, /NousResearch\/hermes-agent\/main\/scripts\/install\.sh/);
+  assert.match(doctor, /VERBALCODING_DOCTOR_INSTALL_HERMES/);
+  assert.match(doctor, /Discord bot setup:/);
+  assert.match(doctor, /discord\.com\/developers\/applications/);
   assert.match(cli, /doctor\.mjs'\), \.\.\.argv\.slice\(1\)/);
 });
 
+test('setup summary guides Discord app creation and records client id', () => {
+  const installer = fs.readFileSync(path.join(ROOT, 'scripts', 'install.mjs'), 'utf8');
+  const config = fs.readFileSync(path.join(ROOT, 'app-node', 'install_config.mjs'), 'utf8');
+
+  assert.match(installer, /Discord application\/client ID for invite URL/);
+  assert.match(config, /DISCORD_CLIENT_ID/);
+  assert.match(config, /Discord app setup:/);
+  assert.match(config, /https:\/\/discord\.com\/developers\/applications/);
+  assert.match(config, /vc bot invite <client-id>/);
+  assert.match(config, /buildDiscordBotInviteUrl\(\{ clientId: values\.DISCORD_CLIENT_ID \}\)/);
+});
+
 test('Ubuntu Docker smoke script validates clean install without secrets', () => {
   const script = fs.readFileSync(path.join(ROOT, 'scripts', 'docker_ubuntu_smoke.sh'), 'utf8');
 

package/app-node/install_config.mjs

@@ -26,6 +26,7 @@ export function normalizeInstallAnswers(input = {}) {
   const out = {
     AGENT_BACKEND: normalizedHarness,
     DISCORD_BOT_TOKEN: clean(input.discordBotToken || input.DISCORD_BOT_TOKEN),
+    DISCORD_CLIENT_ID: clean(input.discordClientId || input.DISCORD_CLIENT_ID || input.applicationId || input.APPLICATION_ID),
     DISCORD_ALLOWED_USERS: clean(input.allowedUsers || input.DISCORD_ALLOWED_USERS),
     AUTO_JOIN_VOICE_CHANNELS: clean(input.autoJoinVoiceChannels || input.AUTO_JOIN_VOICE_CHANNELS, '일반,General,general'),
     TRANSCRIPT_CHANNEL_ID: clean(input.transcriptChannelId || input.TRANSCRIPT_CHANNEL_ID),
@@ -101,6 +102,7 @@ export function slugifyInstanceName(name) {
 export function buildEnvFile(values = {}) {
   const ordered = [
     'DISCORD_BOT_TOKEN',
+    'DISCORD_CLIENT_ID',
     'DISCORD_ALLOWED_USERS',
     'AUTO_JOIN_VOICE_CHANNELS',
     'TRANSCRIPT_CHANNEL_ID',
@@ -243,9 +245,17 @@ export function parseKeyValueEnv(text) {
 
 export function renderInstallSummary(values = {}) {
   const backend = values.AGENT_BACKEND || 'hermes';
+  const inviteUrl = values.DISCORD_CLIENT_ID ? buildDiscordBotInviteUrl({ clientId: values.DISCORD_CLIENT_ID }) : '';
   return [
     `Configured Discord voice bridge for harness: ${backend}`,
     '',
+    'Discord app setup:',
+    '  1. Create an app: https://discord.com/developers/applications',
+    '  2. Bot tab: Add Bot, enable Message Content Intent, copy/reset the token.',
+    '  3. Put the token in .env as DISCORD_BOT_TOKEN="...".',
+    inviteUrl ? `  4. Invite URL: ${inviteUrl}` : '  4. Invite URL: vc bot invite <client-id>',
+    '  5. Make sure the bot can read/send text and connect/speak in voice.',
+    '',
     'Next commands:',
     '  vc doctor',
     '  vc start',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "verbalcoding",
-  "version": "0.2.8",
+  "version": "0.2.9",
   "description": "Discord voice bridge for CLI coding agents.",
   "license": "MIT",
   "repository": {

package/scripts/doctor.mjs

@@ -61,10 +61,14 @@ function isExecutable(file) {
 }
 
 function commandExists(command) {
+  const extraPath = [
+    path.join(ROOT, '.local', 'bin'),
+    path.join(process.env.HOME || '', '.local', 'bin'),
+  ].filter(Boolean).join(':');
   const result = spawnSync('bash', ['-lc', `command -v ${JSON.stringify(command)}`], {
     cwd: ROOT,
     encoding: 'utf8',
-    env: { ...process.env, PATH: `${path.join(ROOT, '.local', 'bin')}:${process.env.PATH || ''}` },
+    env: { ...process.env, PATH: `${extraPath}:${process.env.PATH || ''}` },
   });
   return result.status === 0 ? result.stdout.trim() : '';
 }
@@ -90,6 +94,7 @@ function note(label, detail = '') {
 
 function fixablePrerequisites(env) {
   const ttsBackend = (env.TTS_BACKEND || 'edge').toLowerCase();
+  const backend = (env.AGENT_BACKEND || 'hermes').toLowerCase();
   const missing = [];
   if (!commandExists('ffmpeg')) missing.push('ffmpeg');
   if (!resolveCommand(env.WHISPER_CPP_BIN || 'whisper-cli', [path.join(ROOT, '.local', 'bin', 'whisper-cli')])) missing.push('whisper-cli');
@@ -99,9 +104,53 @@ function fixablePrerequisites(env) {
     const edgeCommand = env.EDGE_TTS_COMMAND || env.TTS_EDGE_COMMAND || 'edge-tts';
     if (!resolveCommand(edgeCommand, [path.join(ROOT, '.venv-tts', 'bin', 'edge-tts')])) missing.push('edge-tts');
   }
+  if (backend === 'hermes' && !commandExists('hermes')) missing.push('hermes CLI');
   return missing;
 }
 
+function installHermesCliIfNeeded(env) {
+  const backend = (env.AGENT_BACKEND || 'hermes').toLowerCase();
+  if (backend !== 'hermes' || commandExists('hermes')) return false;
+  if (process.platform === 'win32') {
+    console.log('Skipping Hermes CLI auto-install: Windows is not supported by VerbalCoding yet.');
+    return false;
+  }
+  if (['0', 'false', 'no', 'off'].includes(String(process.env.VERBALCODING_DOCTOR_INSTALL_HERMES || '1').toLowerCase())) {
+    console.log('Skipping Hermes CLI auto-install because VERBALCODING_DOCTOR_INSTALL_HERMES is off.');
+    return false;
+  }
+  if (!commandExists('curl')) {
+    console.log('Skipping Hermes CLI auto-install: curl is missing.');
+    return false;
+  }
+  console.log('VerbalCoding doctor: missing hermes CLI; installing Hermes Agent...');
+  const result = spawnSync('bash', ['-lc', 'curl -fsSL https://raw.githubusercontent.com/NousResearch/hermes-agent/main/scripts/install.sh | bash'], {
+    cwd: ROOT,
+    stdio: 'inherit',
+    env: process.env,
+  });
+  if (result.status !== 0) {
+    console.log(`Hermes installer exited with status ${result.status}. Continuing with checks.`);
+  }
+  return true;
+}
+
+function discordSetupGuidance(env) {
+  const clientId = env.DISCORD_CLIENT_ID || env.APPLICATION_ID || '';
+  const lines = [
+    'Discord bot setup:',
+    '  1. Open https://discord.com/developers/applications and create an application.',
+    '  2. Bot tab: Add Bot, enable Message Content Intent, then Reset/Copy Token.',
+    `  3. Save it in ${path.join(ROOT, '.env')} as DISCORD_BOT_TOKEN="...".`,
+    '  4. OAuth2 tab: copy the Application/Client ID.',
+    clientId
+      ? `  5. Invite the bot: vc bot invite ${clientId}`
+      : '  5. Invite the bot: vc bot invite <client-id>',
+    '  6. Give it text channel send/read plus voice connect/speak permissions, then rerun vc doctor.',
+  ];
+  return lines.join('\n');
+}
+
 function persistDiscoveredLocalHelpers(env) {
   const updates = {};
   const localWhisper = path.join(ROOT, '.local', 'bin', 'whisper-cli');
@@ -141,6 +190,13 @@ if (autoFixEnabled && missingBeforeFix.length > 0) {
   console.log('');
   env = mergeEnv();
 }
+if (autoFixEnabled) {
+  const hermesAttempted = installHermesCliIfNeeded(env);
+  if (hermesAttempted) {
+    console.log('');
+    env = mergeEnv();
+  }
+}
 
 const backend = (env.AGENT_BACKEND || 'hermes').toLowerCase();
 const ttsBackend = (env.TTS_BACKEND || 'edge').toLowerCase();
@@ -166,6 +222,9 @@ ok = check('whisper-cli', whisperCommand, whisperCommand || 'missing') && ok;
 const modelPath = path.resolve(ROOT, env.WHISPER_CPP_MODEL || 'models/ggml-small-q5_1.bin');
 ok = check('whisper.cpp model', fs.existsSync(modelPath), path.relative(ROOT, modelPath)) && ok;
 ok = check('Discord bot token configured', Boolean(env.DISCORD_BOT_TOKEN || env.DISCORD_TOKEN), (env.DISCORD_BOT_TOKEN || env.DISCORD_TOKEN) ? '[REDACTED]' : 'missing DISCORD_BOT_TOKEN') && ok;
+if (!(env.DISCORD_BOT_TOKEN || env.DISCORD_TOKEN)) {
+  console.log(discordSetupGuidance(env));
+}
 note('Allowed users configured', env.DISCORD_ALLOWED_USERS ? '[REDACTED]' : 'not set; bot may accept all users depending on config');
 note('Auto-join channels', env.AUTO_JOIN_VOICE_CHANNELS || 'default: 일반,General,general');
 note('Verbose progress default', ['1', 'true', 'yes', 'on'].includes(String(env.AGENT_VERBOSE_PROGRESS || env.VERBALCODING_VERBOSE_PROGRESS || '0').toLowerCase()) ? 'on' : 'off');

package/scripts/install.mjs

@@ -53,6 +53,7 @@ async function main() {
     }
     const existingDiscordBotToken = process.env.DISCORD_BOT_TOKEN || '';
     const discordBotToken = await ask('Discord bot token (DISCORD_BOT_TOKEN)', existingDiscordBotToken, { fallbackLabel: existingDiscordBotToken ? 'keep existing' : '' });
+    const discordClientId = await ask('Discord application/client ID for invite URL', process.env.DISCORD_CLIENT_ID || '');
     const allowedUsers = await ask('Allowed Discord user IDs, comma-separated', process.env.DISCORD_ALLOWED_USERS || '');
     const autoJoinVoiceChannels = await ask('Auto-join voice channel names', process.env.AUTO_JOIN_VOICE_CHANNELS || '일반,General,general');
     const transcriptChannelId = await ask('Transcript text channel/thread ID', process.env.TRANSCRIPT_CHANNEL_ID || '');
@@ -80,6 +81,7 @@ async function main() {
       agentLabel,
       agentCommand,
       discordBotToken,
+      discordClientId,
       allowedUsers,
       autoJoinVoiceChannels,
       transcriptChannelId,