vellum 0.2.8 → 0.2.9

package/src/__tests__/handlers-twilio-config.test.ts

@@ -1,221 +0,0 @@
-import { describe, test, expect, mock, beforeEach } from 'bun:test';
-import { mkdtempSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import * as net from 'node:net';
-
-const testDir = mkdtempSync(join(tmpdir(), 'handlers-twilio-cfg-test-'));
-
-let rawConfigStore: Record<string, unknown> = {};
-const saveRawConfigCalls: Record<string, unknown>[] = [];
-
-mock.module('../config/loader.js', () => ({
-  getConfig: () => ({}),
-  loadConfig: () => ({}),
-  loadRawConfig: () => ({ ...rawConfigStore }),
-  saveRawConfig: (cfg: Record<string, unknown>) => {
-    saveRawConfigCalls.push(cfg);
-    rawConfigStore = { ...cfg };
-  },
-  saveConfig: () => {},
-  invalidateConfigCache: () => {},
-}));
-
-mock.module('../util/platform.js', () => ({
-  getRootDir: () => testDir,
-  getDataDir: () => testDir,
-  getIpcBlobDir: () => join(testDir, 'ipc-blobs'),
-  isMacOS: () => process.platform === 'darwin',
-  isLinux: () => process.platform === 'linux',
-  isWindows: () => process.platform === 'win32',
-  getSocketPath: () => join(testDir, 'test.sock'),
-  getPidPath: () => join(testDir, 'test.pid'),
-  getDbPath: () => join(testDir, 'test.db'),
-  getLogPath: () => join(testDir, 'test.log'),
-  ensureDataDir: () => {},
-}));
-
-mock.module('../util/logger.js', () => ({
-  getLogger: () => ({
-    info: () => {},
-    warn: () => {},
-    error: () => {},
-    debug: () => {},
-    trace: () => {},
-    fatal: () => {},
-    child: () => ({
-      info: () => {},
-      warn: () => {},
-      error: () => {},
-      debug: () => {},
-    }),
-  }),
-}));
-
-mock.module('../memory/app-store.js', () => ({
-  queryAppRecords: () => [],
-  createAppRecord: () => {},
-  updateAppRecord: () => {},
-  deleteAppRecord: () => {},
-  listApps: () => [],
-  getApp: () => undefined,
-  createApp: () => {},
-  updateApp: () => {},
-}));
-
-mock.module('../slack/slack-webhook.js', () => ({
-  postToSlackWebhook: async () => {},
-}));
-
-import { handleMessage, type HandlerContext } from '../daemon/handlers.js';
-import type {
-  TwilioWebhookConfigRequest,
-  ServerMessage,
-} from '../daemon/ipc-contract.js';
-
-function createTestContext(): { ctx: HandlerContext; sent: ServerMessage[] } {
-  const sent: ServerMessage[] = [];
-  const ctx: HandlerContext = {
-    sessions: new Map(),
-    socketToSession: new Map(),
-    cuSessions: new Map(),
-    socketToCuSession: new Map(),
-    cuObservationParseSequence: new Map(),
-    socketSandboxOverride: new Map(),
-    sharedRequestTimestamps: [],
-    debounceTimers: new Map(),
-    suppressConfigReload: false,
-    setSuppressConfigReload: () => {},
-    updateConfigFingerprint: () => {},
-    send: (_socket, msg) => { sent.push(msg); },
-    broadcast: () => {},
-    clearAllSessions: () => 0,
-    getOrCreateSession: () => { throw new Error('not implemented'); },
-    touchSession: () => {},
-  };
-  return { ctx, sent };
-}
-
-describe('Twilio webhook config handler', () => {
-  beforeEach(() => {
-    rawConfigStore = {};
-    saveRawConfigCalls.length = 0;
-  });
-
-  test('get returns empty string when no config set', () => {
-    rawConfigStore = {};
-
-    const msg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'get',
-    };
-
-    const { ctx, sent } = createTestContext();
-    handleMessage(msg, {} as net.Socket, ctx);
-
-    expect(sent).toHaveLength(1);
-    const res = sent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(res.type).toBe('twilio_webhook_config_response');
-    expect(res.success).toBe(true);
-    expect(res.webhookBaseUrl).toBe('');
-  });
-
-  test('set persists value and returns it', () => {
-    rawConfigStore = {};
-
-    const msg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'set',
-      webhookBaseUrl: 'https://example.com/twilio',
-    };
-
-    const { ctx, sent } = createTestContext();
-    handleMessage(msg, {} as net.Socket, ctx);
-
-    expect(sent).toHaveLength(1);
-    const res = sent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(res.type).toBe('twilio_webhook_config_response');
-    expect(res.success).toBe(true);
-    expect(res.webhookBaseUrl).toBe('https://example.com/twilio');
-
-    expect(saveRawConfigCalls).toHaveLength(1);
-    const saved = saveRawConfigCalls[0] as { calls?: { webhookBaseUrl?: string } };
-    expect(saved.calls?.webhookBaseUrl).toBe('https://example.com/twilio');
-  });
-
-  test('set normalizes trailing slashes', () => {
-    rawConfigStore = {};
-
-    const msg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'set',
-      webhookBaseUrl: 'https://example.com/twilio///',
-    };
-
-    const { ctx, sent } = createTestContext();
-    handleMessage(msg, {} as net.Socket, ctx);
-
-    expect(sent).toHaveLength(1);
-    const res = sent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(res.webhookBaseUrl).toBe('https://example.com/twilio');
-
-    const saved = saveRawConfigCalls[0] as { calls?: { webhookBaseUrl?: string } };
-    expect(saved.calls?.webhookBaseUrl).toBe('https://example.com/twilio');
-  });
-
-  test('set treats empty string as unset', () => {
-    rawConfigStore = { calls: { webhookBaseUrl: 'https://example.com/twilio' } };
-    saveRawConfigCalls.length = 0;
-
-    const msg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'set',
-      webhookBaseUrl: '',
-    };
-
-    const { ctx, sent } = createTestContext();
-    handleMessage(msg, {} as net.Socket, ctx);
-
-    expect(sent).toHaveLength(1);
-    const res = sent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(res.success).toBe(true);
-    expect(res.webhookBaseUrl).toBe('');
-
-    const saved = saveRawConfigCalls[0] as { calls?: { webhookBaseUrl?: string } };
-    expect(saved.calls?.webhookBaseUrl).toBeUndefined();
-  });
-
-  test('get after set roundtrip works', () => {
-    rawConfigStore = {};
-
-    // Set
-    const setMsg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'set',
-      webhookBaseUrl: 'https://my-server.ngrok.io',
-    };
-
-    const { ctx: setCtx, sent: setSent } = createTestContext();
-    handleMessage(setMsg, {} as net.Socket, setCtx);
-
-    expect(setSent).toHaveLength(1);
-    const setRes = setSent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(setRes.success).toBe(true);
-    expect(setRes.webhookBaseUrl).toBe('https://my-server.ngrok.io');
-
-    // Get (rawConfigStore was updated by the mock saveRawConfig)
-    const getMsg: TwilioWebhookConfigRequest = {
-      type: 'twilio_webhook_config',
-      action: 'get',
-    };
-
-    const { ctx: getCtx, sent: getSent } = createTestContext();
-    handleMessage(getMsg, {} as net.Socket, getCtx);
-
-    expect(getSent).toHaveLength(1);
-    const getRes = getSent[0] as { type: string; webhookBaseUrl: string; success: boolean };
-    expect(getRes.type).toBe('twilio_webhook_config_response');
-    expect(getRes.success).toBe(true);
-    expect(getRes.webhookBaseUrl).toBe('https://my-server.ngrok.io');
-  });
-});

package/src/calls/__tests__/twilio-webhook-urls.test.ts

@@ -1,162 +0,0 @@
-import { describe, test, expect, beforeEach, afterEach, mock } from 'bun:test';
-
-// ---------------------------------------------------------------------------
-// Mocks — silence logger output during tests
-// ---------------------------------------------------------------------------
-
-function makeLoggerStub(): Record<string, unknown> {
-  const stub: Record<string, unknown> = {};
-  for (const m of ['info', 'warn', 'error', 'debug', 'trace', 'fatal', 'silent', 'child']) {
-    stub[m] = m === 'child' ? () => makeLoggerStub() : () => {};
-  }
-  return stub;
-}
-
-mock.module('../../util/logger.js', () => ({
-  getLogger: () => makeLoggerStub(),
-}));
-
-import {
-  normalizeBaseUrl,
-  buildTwilioVoiceWebhookUrl,
-  buildTwilioStatusCallbackUrl,
-  getWebhookBaseUrl,
-} from '../twilio-webhook-urls.js';
-
-// ---------------------------------------------------------------------------
-// normalizeBaseUrl
-// ---------------------------------------------------------------------------
-
-describe('normalizeBaseUrl', () => {
-  test('returns already-clean URL unchanged', () => {
-    expect(normalizeBaseUrl('https://example.com')).toBe('https://example.com');
-  });
-
-  test('strips trailing slash', () => {
-    expect(normalizeBaseUrl('https://example.com/')).toBe('https://example.com');
-  });
-
-  test('strips multiple trailing slashes', () => {
-    expect(normalizeBaseUrl('https://example.com///')).toBe('https://example.com');
-  });
-
-  test('trims leading and trailing whitespace', () => {
-    expect(normalizeBaseUrl('  https://example.com  ')).toBe('https://example.com');
-  });
-
-  test('trims whitespace and strips trailing slash together', () => {
-    expect(normalizeBaseUrl('  https://example.com/  ')).toBe('https://example.com');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// buildTwilioVoiceWebhookUrl
-// ---------------------------------------------------------------------------
-
-describe('buildTwilioVoiceWebhookUrl', () => {
-  test('returns correct URL with callSessionId', () => {
-    const url = buildTwilioVoiceWebhookUrl('https://example.com', 'session-123');
-    expect(url).toBe('https://example.com/webhooks/twilio/voice?callSessionId=session-123');
-  });
-
-  test('normalizes base URL before composing', () => {
-    const url = buildTwilioVoiceWebhookUrl('https://example.com/', 'abc');
-    expect(url).toBe('https://example.com/webhooks/twilio/voice?callSessionId=abc');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// buildTwilioStatusCallbackUrl
-// ---------------------------------------------------------------------------
-
-describe('buildTwilioStatusCallbackUrl', () => {
-  test('returns correct URL', () => {
-    const url = buildTwilioStatusCallbackUrl('https://example.com');
-    expect(url).toBe('https://example.com/webhooks/twilio/status');
-  });
-
-  test('normalizes base URL before composing', () => {
-    const url = buildTwilioStatusCallbackUrl('https://example.com/');
-    expect(url).toBe('https://example.com/webhooks/twilio/status');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// getWebhookBaseUrl
-// ---------------------------------------------------------------------------
-
-describe('getWebhookBaseUrl', () => {
-  let savedEnv: string | undefined;
-
-  beforeEach(() => {
-    savedEnv = process.env.TWILIO_WEBHOOK_BASE_URL;
-    delete process.env.TWILIO_WEBHOOK_BASE_URL;
-  });
-
-  afterEach(() => {
-    if (savedEnv !== undefined) {
-      process.env.TWILIO_WEBHOOK_BASE_URL = savedEnv;
-    } else {
-      delete process.env.TWILIO_WEBHOOK_BASE_URL;
-    }
-  });
-
-  test('uses config value when set', () => {
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: 'https://config.example.com/' } });
-    expect(result).toBe('https://config.example.com');
-  });
-
-  test('falls back to env var when config value is empty', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com/';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('falls back to env var when config value is undefined', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: {} });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('throws when neither config nor env var is set', () => {
-    expect(() => getWebhookBaseUrl({ calls: { webhookBaseUrl: '' } })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('throws when config is undefined and env var is unset', () => {
-    expect(() => getWebhookBaseUrl({ calls: {} })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('normalizes the returned URL', () => {
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '  https://example.com/  ' } });
-    expect(result).toBe('https://example.com');
-  });
-
-  test('falls through when config value is whitespace-only', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '   ' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('falls through when config value is slash-only', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '///' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('throws when config is whitespace-only and env var is unset', () => {
-    expect(() => getWebhookBaseUrl({ calls: { webhookBaseUrl: '   ' } })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('throws when env var is whitespace-only and config is empty', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = '   ';
-    expect(() => getWebhookBaseUrl({ calls: {} })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-});

package/src/calls/twilio-webhook-urls.ts

@@ -1,47 +0,0 @@
-/**
- * Twilio webhook URL helpers.
- *
- * This module is a thin backward-compat wrapper that delegates to the
- * centralized URL builders in inbound/public-ingress-urls.ts.
- */
-
-import {
-  getPublicBaseUrl,
-  type IngressConfig,
-} from '../inbound/public-ingress-urls.js';
-
-/**
- * Resolve the webhook base URL from config, falling back to the
- * TWILIO_WEBHOOK_BASE_URL environment variable with a deprecation warning.
- * Throws if neither source provides a value.
- *
- * @deprecated Use `getPublicBaseUrl` from `inbound/public-ingress-urls.ts` instead.
- */
-export function getWebhookBaseUrl(config: { calls: { webhookBaseUrl?: string }; ingress?: { publicBaseUrl?: string } }): string {
-  return getPublicBaseUrl(config as IngressConfig);
-}
-
-/**
- * Trim whitespace and strip trailing slash from a URL string.
- */
-export function normalizeBaseUrl(url: string): string {
-  return url.trim().replace(/\/+$/, '');
-}
-
-/**
- * Build the Twilio voice webhook URL for a given call session.
- *
- * @deprecated Use `getTwilioVoiceWebhookUrl` from `inbound/public-ingress-urls.ts` instead.
- */
-export function buildTwilioVoiceWebhookUrl(baseUrl: string, callSessionId: string): string {
-  return `${normalizeBaseUrl(baseUrl)}/webhooks/twilio/voice?callSessionId=${callSessionId}`;
-}
-
-/**
- * Build the Twilio status callback URL.
- *
- * @deprecated Use `getTwilioStatusCallbackUrl` from `inbound/public-ingress-urls.ts` instead.
- */
-export function buildTwilioStatusCallbackUrl(baseUrl: string): string {
-  return `${normalizeBaseUrl(baseUrl)}/webhooks/twilio/status`;
-}